Repository navigation
fix: fall through to interior widget value for null host widgets_values - #14955
claude[bot] wants to merge 4 commits into
Conversation
🎭 Playwright: ✅ 1812 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.85 MB gzip 🟢 -177 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27.7 kB (baseline 27.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.52 MB (baseline 3.52 MB) • 🔴 +80 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • 🔴 +11 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 20 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • 🟢 -268 BBundles that do not match a named category
Status: 68 added / 68 removed / 217 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-16T06:20:14.234Z",
"gitSha": "b53cfde44bd910799a79357bb74624b286393999",
"branch": "fix/fe-14488-null-widgets-values",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2027.2620000000074,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.8439999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.172,
"heapDeltaBytes": 4845728,
"heapUsedBytes": 69396836,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 7.62,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2031.3359999998966,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.076000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.372,
"heapDeltaBytes": 4887020,
"heapUsedBytes": 69364116,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 7.462,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1840.4090000000224,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.501,
"layouts": 12,
"layoutDurationMs": 3.783,
"taskDurationMs": 863.518,
"heapDeltaBytes": -111136,
"heapUsedBytes": 64522216,
"domNodes": 59,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 117.71600000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.2450000000663,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.31700000000001,
"layouts": 12,
"layoutDurationMs": 3.4200000000000004,
"taskDurationMs": 832.9740000000002,
"heapDeltaBytes": -185016,
"heapUsedBytes": 64405356,
"domNodes": 59,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 114.32500000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1748.687000000018,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.33,
"layouts": 6,
"layoutDurationMs": 0.6139999999999999,
"taskDurationMs": 398.82499999999993,
"heapDeltaBytes": 8098548,
"heapUsedBytes": 72588756,
"domNodes": 77,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 9.959,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1762.5110000000177,
"styleRecalcs": 31,
"styleRecalcDurationMs": 21.326000000000004,
"layouts": 6,
"layoutDurationMs": 0.6999999999999998,
"taskDurationMs": 388.681,
"heapDeltaBytes": 8085904,
"heapUsedBytes": 72621864,
"domNodes": 76,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 9.85,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 589.031000000034,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.029,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.344,
"heapDeltaBytes": -11380340,
"heapUsedBytes": 53108100,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 57.373999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 579.8090000000684,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.226,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.676,
"heapDeltaBytes": -11381124,
"heapUsedBytes": 53165000,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 57.51499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.0519999999883,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.861,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.671,
"heapDeltaBytes": 10925816,
"heapUsedBytes": 70906244,
"domNodes": -283,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 14.192000000000004,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2018.5100000001057,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.117000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.457,
"heapDeltaBytes": 10601124,
"heapUsedBytes": 70553728,
"domNodes": -283,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 16.288999999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2224.2970000000355,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1209.6650000000002,
"heapDeltaBytes": 2880496,
"heapUsedBytes": 63362388,
"domNodes": -286,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 331.58700000000005,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2197.569000000044,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.881999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1223.61,
"heapDeltaBytes": 1596216,
"heapUsedBytes": 62925504,
"domNodes": -283,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 343.255,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3230.357999999967,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.717000000000004,
"layouts": 60,
"layoutDurationMs": 7.233,
"taskDurationMs": 1351.5790000000002,
"heapDeltaBytes": 17327676,
"heapUsedBytes": 79199944,
"domNodes": 12,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 374.43699999999995,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3166.606999999999,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.522999999999998,
"layouts": 60,
"layoutDurationMs": 7.092999999999999,
"taskDurationMs": 1324.8549999999998,
"heapDeltaBytes": 16921596,
"heapUsedBytes": 79135932,
"domNodes": 14,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 374.70300000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2013.216,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.051000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.1960000000001,
"heapDeltaBytes": 8904884,
"heapUsedBytes": 69841088,
"domNodes": -285,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 15.603000000000005,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.7819999999592,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.897999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.908,
"heapDeltaBytes": 12337664,
"heapUsedBytes": 73857860,
"domNodes": -283,
"jsHeapTotalBytes": 1671168,
"scriptDurationMs": 14.414000000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.3309999999601,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.083000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.327,
"heapDeltaBytes": -10570572,
"heapUsedBytes": 54117208,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 121.285,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 566.789999999969,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.29800000000006,
"heapDeltaBytes": -10504344,
"heapUsedBytes": 54291452,
"domNodes": 20,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 115.13999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.8169999999927,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.617,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.476,
"heapDeltaBytes": 4965476,
"heapUsedBytes": 69641812,
"domNodes": 22,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 7.104999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.0190000000375,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.336,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.62300000000005,
"heapDeltaBytes": 4978404,
"heapUsedBytes": 69689556,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 6.936000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.1480000000179,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.416000000000004,
"layouts": 16,
"layoutDurationMs": 4.052999999999999,
"taskDurationMs": 778.456,
"heapDeltaBytes": -4100996,
"heapUsedBytes": 60718088,
"domNodes": 66,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 86.159,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.2390000000587,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.775999999999996,
"layouts": 16,
"layoutDurationMs": 4.9270000000000005,
"taskDurationMs": 770.2520000000001,
"heapDeltaBytes": -3995412,
"heapUsedBytes": 60926824,
"domNodes": 63,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 85.887,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.8679999999986,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.343999999999998,
"layouts": 14,
"layoutDurationMs": 12.661999999999999,
"taskDurationMs": 976.3120000000002,
"heapDeltaBytes": 20301992,
"heapUsedBytes": 104810116,
"domNodes": 13673,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 18.042999999999996,
"eventListeners": 2375,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8407.578000000001,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.98,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4225.732000000001,
"heapDeltaBytes": 14072252,
"heapUsedBytes": 74132884,
"domNodes": -283,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 1014.4510000000002,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8393.146999999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.849999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4362.199,
"heapDeltaBytes": 9946876,
"heapUsedBytes": 69633696,
"domNodes": -283,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 1120.476,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17287.409000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16548.76,
"heapDeltaBytes": -39466532,
"heapUsedBytes": 170729040,
"domNodes": -8312,
"jsHeapTotalBytes": -6758400,
"scriptDurationMs": 119.961,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17051.558999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16337.442000000003,
"heapDeltaBytes": -30372232,
"heapUsedBytes": 166763968,
"domNodes": -8316,
"jsHeapTotalBytes": -15372288,
"scriptDurationMs": 116.121,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20364.093000000026,
"styleRecalcs": 170,
"styleRecalcDurationMs": 17.351000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19789.805,
"heapDeltaBytes": -39854388,
"heapUsedBytes": 170251016,
"domNodes": -8312,
"jsHeapTotalBytes": -12070912,
"scriptDurationMs": 426.63800000000003,
"eventListeners": -16383,
"totalBlockingTimeMs": 25,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20746.269999999982,
"styleRecalcs": 174,
"styleRecalcDurationMs": 18.19399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20119.177,
"heapDeltaBytes": -25110632,
"heapUsedBytes": 185066088,
"domNodes": -8312,
"jsHeapTotalBytes": -11546624,
"scriptDurationMs": 401.265,
"eventListeners": -16385,
"totalBlockingTimeMs": 64,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 447.31500000000324,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.095000000000002,
"layouts": 3,
"layoutDurationMs": 0.649,
"taskDurationMs": 107.59700000000001,
"heapDeltaBytes": 4949148,
"heapUsedBytes": 68960804,
"domNodes": 126,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.011,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 486.52000000004136,
"styleRecalcs": 11,
"styleRecalcDurationMs": 26.392,
"layouts": 3,
"layoutDurationMs": 0.647,
"taskDurationMs": 127.64900000000002,
"heapDeltaBytes": 4929756,
"heapUsedBytes": 68519936,
"domNodes": 121,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.734999999999998,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
A null entry in a subgraph host's widgets_values meant "no host override, use the interior widget's value" pre-1.47. After the ADR-0009 widget-store refactor, null was instead written straight into the promoted widget's store entry, so it read back as undefined and legacy workflows (including files following the documented #13601 recovery workaround) opened with dead promoted widgets. Treat null as a no-op write in both places it can reach the store: the positional widgets_values restore path and the promoted widget's value/callback bridge (the latter is also hit by LGraphNode's generic per-widget widgets_values assignment). This restores the pre-1.47 fallthrough semantics without changing behavior for any non-null value. Fixes #14488
8a70dcd to
dd2020a
Compare
RemoteConfig no longer has this field after #14613 retired the team workspace rollout flag, which broke typecheck:browser in CI.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14955 +/- ##
==========================================
- Coverage 78.87% 78.82% -0.05%
==========================================
Files 2211 1881 -330
Lines 112055 117349 +5294
Branches 31675 35437 +3762
==========================================
+ Hits 88380 92506 +4126
- Misses 23219 24270 +1051
- Partials 456 573 +117
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 857 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Heads up — I've extracted the That one line is currently taking down the merge queue for the whole repo. Your litegraph change looks right to me — Whichever of the two lands first, the other's hunk drops out trivially. Nothing |
## The merge queue is down repo-wide `typecheck:browser` fails on `main`: ``` browser_tests/fixtures/data/workspaceAuthFixtures.ts(6,3): error TS2353: Object literal may only specify known properties, and 'team_workspaces_enabled' does not exist in type 'RemoteConfig'. ``` Because the merge queue re-runs **CI: Lint Format** against the queue branch, this fails there too — so PRs are being **added to the queue and then dequeued without merging**, whatever their own CI said. Two of mine were dequeued this way in the last hour (#14691 at 02:59Z, #14669 at 03:05Z), and four unrelated branches hit the sibling `validate-pins` breakage in the same window. Introduced by #12940 (`e544b2ad90`), merged ~4 hours ago. ## Why removing the key is the right fix `team_workspaces_enabled` appears **exactly once in the entire repository** — this line. No `src/` code reads it. Team workspaces are gated on the workspace's own `type` (`'personal' | 'team'`), not on a remote-config flag, and there is no corresponding entry in `useFeatureFlags`. The fixture was enabling nothing, so `{}` is behaviour-identical. The alternative — adding the key to `RemoteConfig` — would invent frontend API surface that nothing consumes. ## Verification Matched control, same machine, same install: | tree | `pnpm run typecheck:browser` | | ---- | --- | | `origin/main` | **exit 2**, the error above | | this branch | **exit 0** | `pnpm run format:check` clean. ## Relationship to #14955 #14955 contains this same one-line fix, but bundled with an unrelated litegraph subgraph-serialization change. That change looks sound to me, but it deserves review on its own merits by someone who owns litegraph — and the queue outage shouldn't wait on it. This PR is the fixture fix alone so it can land immediately. Whichever merges first, the other's hunk drops out trivially. Co-authored-by: t <t@t.t>
# Conflicts: # browser_tests/fixtures/data/workspaceAuthFixtures.ts
|
Context links, so the architecture analysis behind this isn't only in a private doc:
Where this sits: #14495, #14488, #13601 and #11297 are one bug family — the promoted widget's value is stored against the host ( This PR is the ADR-0009-compliant half of the work. It only teaches the load path that One factual overlap for whoever lands these: this PR and #14961 both edit the CI is green on |
|
@DrJKL requesting your review here — you wrote ADR 0009 (#11997, #12197) and I verified the change end to end before pinging you. Summary of what I checked: The Both write paths really are needed, and they're the only two.
I grepped every This is bigger than a legacy-workflow fix. The PR body frames it as back-compat for pre-1.47 files and for people who followed the #13601 null-out workaround. That undersells it. Ordering is right. Axioms. No violation of Theorem 1 (widget identity independence), 6 (value promotion impossibility) or 7 (multi-instance consistency). The change removes a write; it adds no mutation path, no new state, and no cross-instance coordination. The store stays the single ID-addressed source, so multiple host instances converge identically. Two adjacent bridges that do not have the guard — neither is reachable on this load path, so I'd treat them as follow-ups rather than blockers here, but flagging so the asymmetry is a deliberate choice rather than an accident:
One behavioural edge the test doesn't cover. The guard turns CI and mergeability. All four required checks on Test coverage gap, stated plainly: this ships a unit regression test only. There is no e2e pinning a load of a workflow whose host Full architecture dossier: https://claude.ai/code/artifact/ea7a22b5-3c3e-43e9-9354-d41a8f7916dd One scoping note worth making explicit: this is the ADR-0009-compliant half of the promoted-widget work. It fixes the load boundary and adds no mutation path. #14961 addresses a related bug at the runtime-edit boundary and has a design objection outstanding against it. The two are independent — the objection on #14961 does not apply to anything in this diff, and this one shouldn't wait on that thread resolving. |
Requested by Christian Byrne
Summary
A
nullentry in a subgraph host'swidgets_valuesused to mean "no host override — use the interior widget's value" (pre-1.47). After the ADR-0009 widget-store refactor,nullis instead written straight into the promoted widget's store entry, so it reads back asundefined. This silently breaks any pre-refactor workflow whose hostwidgets_valuescontains nulls — including files that followed the documented#13601recovery workaround of nulling those entries out.Changes
nullis now treated as "no override" (a no-op) everywhere it can reach a promoted widget's store entry inSubgraphNode.ts: the positionalwidgets_valuesrestore path (_applyPromotedWidgetValues) and the promoted widget'svalue/callbackbridge used byLGraphNode's generic per-widgetwidgets_valuesassignment duringconfigure(). Both paths needed the guard — the second is a direct store write that bypasses the first.Review Focus
nullis never a legitimate widget value under the existing model (isWidgetValue()already excludes it, and the promoted widget's getter already treated a storednullasundefined), so skipping it is safe for every widget type and doesn't change behavior for any non-null value.Fixes #14488
Generated by Claude Code