Repository navigation
fix: skip control_after_generate slots in promoted widget value restore - #14478
claude[bot] wants to merge 3 commits into
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2007 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.37 MB gzip 🟢 -430 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • 🟢 -1.77 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 592 kB (baseline 592 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.53 MB (baseline 3.53 MB) • 🔴 +571 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 15.1 MB (baseline 15.1 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 220 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-26T01:04:05.309Z",
"gitSha": "81a41fa36bb0a8b526bac4851b1c8d757693d049",
"branch": "fix/subgraph-widget-value-shift-15102",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.7790000000005,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.902000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.90799999999996,
"heapDeltaBytes": -12012792,
"heapUsedBytes": 60275252,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.924,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2051.688000000013,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.208000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.305,
"heapDeltaBytes": -15362392,
"heapUsedBytes": 56192328,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.264000000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2162.1600000000285,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.304,
"layouts": 12,
"layoutDurationMs": 3.394,
"taskDurationMs": 1168.574,
"heapDeltaBytes": -12119472,
"heapUsedBytes": 59476520,
"domNodes": -282,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 135.268,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2107.4069999999665,
"styleRecalcs": 79,
"styleRecalcDurationMs": 36.876,
"layouts": 12,
"layoutDurationMs": 3.392,
"taskDurationMs": 1145.3249999999998,
"heapDeltaBytes": 5622184,
"heapUsedBytes": 78005456,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 135.75799999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.7659999999923,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.706999999999999,
"layouts": 6,
"layoutDurationMs": 0.654,
"taskDurationMs": 345.5489999999999,
"heapDeltaBytes": 4380432,
"heapUsedBytes": 76655856,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.503000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.5670000000791,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.056,
"layouts": 6,
"layoutDurationMs": 0.7129999999999999,
"taskDurationMs": 357.089,
"heapDeltaBytes": 4378000,
"heapUsedBytes": 76323068,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.789,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 913.4050000000116,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.8469999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 676.899,
"heapDeltaBytes": 7194064,
"heapUsedBytes": 79134296,
"domNodes": 16,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 137.126,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 923.8319999999476,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.8839999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 668.9549999999999,
"heapDeltaBytes": 6886844,
"heapUsedBytes": 79299512,
"domNodes": 18,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 134.81199999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.3039999999924,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.7210000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.4239999999999,
"heapDeltaBytes": -2081376,
"heapUsedBytes": 77374404,
"domNodes": -273,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 36.363,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2066.1890000000085,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.9569999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.9900000000001,
"heapDeltaBytes": -1886764,
"heapUsedBytes": 77063248,
"domNodes": -270,
"jsHeapTotalBytes": -2928640,
"scriptDurationMs": 37.791999999999994,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 3107.4499999999716,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.602000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2252.434,
"heapDeltaBytes": 21377472,
"heapUsedBytes": 86377824,
"domNodes": -273,
"jsHeapTotalBytes": 3895296,
"scriptDurationMs": 804.318,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3194.3999999999733,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.704,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2298.9640000000004,
"heapDeltaBytes": 14497072,
"heapUsedBytes": 94588224,
"domNodes": -273,
"jsHeapTotalBytes": 3588096,
"scriptDurationMs": 826.793,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4221.031000000039,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.815,
"layouts": 60,
"layoutDurationMs": 7.663999999999999,
"taskDurationMs": 2351.5810000000006,
"heapDeltaBytes": -2824536,
"heapUsedBytes": 67211732,
"domNodes": 24,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 809.6800000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 4187.938000000031,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.755999999999998,
"layouts": 60,
"layoutDurationMs": 7.914000000000001,
"taskDurationMs": 2297.879,
"heapDeltaBytes": 3679888,
"heapUsedBytes": 74551176,
"domNodes": 24,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 784.966,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 4816.844000000003,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.954,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3542.592,
"heapDeltaBytes": 26334264,
"heapUsedBytes": 94048480,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 968.771,
"eventListeners": 192,
"totalBlockingTimeMs": 6,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 4774.467999999956,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.226999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3434.895,
"heapDeltaBytes": 20395212,
"heapUsedBytes": 90592760,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 935.5680000000001,
"eventListeners": 192,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.2520000000368,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.4199999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.07,
"heapDeltaBytes": 12728236,
"heapUsedBytes": 78078000,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.79399999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.3310000000556,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.516000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.374,
"heapDeltaBytes": -3960704,
"heapUsedBytes": 77400396,
"domNodes": -272,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 38.20900000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 728.9710000000014,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.096,
"heapDeltaBytes": -7623692,
"heapUsedBytes": 65210992,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 141.21900000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 720.1019999999971,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.416999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.07900000000006,
"heapDeltaBytes": -7254820,
"heapUsedBytes": 65285632,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 138.16400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2026.9930000000045,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.296999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.3299999999999,
"heapDeltaBytes": -11567572,
"heapUsedBytes": 61153764,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.677000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.1450000000705,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.332,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.105,
"heapDeltaBytes": 2964516,
"heapUsedBytes": 75137112,
"domNodes": -296,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.290999999999999,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1824.775000000045,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.547000000000004,
"layouts": 16,
"layoutDurationMs": 4.2589999999999995,
"taskDurationMs": 1073.284,
"heapDeltaBytes": -2942756,
"heapUsedBytes": 69801404,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 100.18900000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1836.133000000018,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.604,
"layouts": 16,
"layoutDurationMs": 4.136000000000001,
"taskDurationMs": 1075.083,
"heapDeltaBytes": -1920168,
"heapUsedBytes": 70486508,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 98.19800000000001,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.1609999999491,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.51000000000001,
"layouts": 13,
"layoutDurationMs": 12.814999999999998,
"taskDurationMs": 905.1969999999998,
"heapDeltaBytes": -32916,
"heapUsedBytes": 96620200,
"domNodes": 13671,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.014999999999993,
"eventListeners": 2383,
"totalBlockingTimeMs": 119,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12222.583000000042,
"styleRecalcs": 246,
"styleRecalcDurationMs": 38.696,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7993.3910000000005,
"heapDeltaBytes": -11143272,
"heapUsedBytes": 67803508,
"domNodes": -272,
"jsHeapTotalBytes": 1789952,
"scriptDurationMs": 2706.943,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12295.882000000005,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.452,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8015.206000000001,
"heapDeltaBytes": 1905208,
"heapUsedBytes": 81036560,
"domNodes": -271,
"jsHeapTotalBytes": 3031040,
"scriptDurationMs": 2747.606,
"eventListeners": -159,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17865.944999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17078.643,
"heapDeltaBytes": -31004788,
"heapUsedBytes": 177057932,
"domNodes": -6548,
"jsHeapTotalBytes": -913408,
"scriptDurationMs": 340.002,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17947.369999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17111.965,
"heapDeltaBytes": -45440192,
"heapUsedBytes": 176736984,
"domNodes": -6552,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 367.944,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22014.05600000004,
"styleRecalcs": 175,
"styleRecalcDurationMs": 20.349000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21622.707,
"heapDeltaBytes": -26595632,
"heapUsedBytes": 181075724,
"domNodes": -6548,
"jsHeapTotalBytes": 135168,
"scriptDurationMs": 928.398,
"eventListeners": -7467,
"totalBlockingTimeMs": 125,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21489.6829999999,
"styleRecalcs": 179,
"styleRecalcDurationMs": 19.265000000000033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21193.904000000002,
"heapDeltaBytes": -31120444,
"heapUsedBytes": 177311264,
"domNodes": -6548,
"jsHeapTotalBytes": 249856,
"scriptDurationMs": 913.292,
"eventListeners": -7469,
"totalBlockingTimeMs": 64,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 125.1879999999801,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.685000000000002,
"layouts": 5,
"layoutDurationMs": 1.3909999999999998,
"taskDurationMs": 96.095,
"heapDeltaBytes": 3717888,
"heapUsedBytes": 71993320,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.137000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 145.9100000000717,
"styleRecalcs": 9,
"styleRecalcDurationMs": 19.101,
"layouts": 3,
"layoutDurationMs": 1.7149999999999999,
"taskDurationMs": 112.3,
"heapDeltaBytes": 4049556,
"heapUsedBytes": 72220368,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.586000000000001,
"eventListeners": 56,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14478 +/- ##
==========================================
+ Coverage 80.19% 82.61% +2.42%
==========================================
Files 2272 1939 -333
Lines 116443 111535 -4908
Branches 33203 31572 -1631
==========================================
- Hits 93379 92148 -1231
+ Misses 22559 19048 -3511
+ Partials 505 339 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 396 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Status + context. This PR is genuinely in the promoted-widget-ownership area — State as of today: open since 2026-08-09, Two overlaps worth knowing before this lands:
|
…padding on subgraph configure Legacy/imported subgraph instances can serialize widgets_values with an extra slot for the control_after_generate companion widget (mirroring the underlying node's own widget layout), even though the companion is never itself a promoted input. SubgraphNode._applyPromotedWidgetValues walks widgets_values positionally without accounting for this, so values after the control slot land on the wrong promoted widget. Fixes #15102
SubgraphNode._applyPromotedWidgetValues walked widgets_values positionally, one slot per promoted widget-input, with no allowance for the control_after_generate companion widget some promoted widgets carry. Legacy/imported subgraph instances that still serialize an extra widgets_values slot for that companion (mirroring the underlying node's own widget layout) caused every promoted value after it to land on the wrong widget. Only compensate when widgets_values is longer than the number of promoted inputs, so current-format instances (exactly one value per promoted input) are unaffected. Fixes #15102
024dff7 to
61706a3
Compare
There was a problem hiding this comment.
Length-based format detection can corrupt promoted widget values.
Full context for agent readers
The current payload has no reliable shape marker, so the restore path needs a deterministic migration or named/provenanced representation before this can be approved. Current-main integration is clean; the blocker is isolated to positional interpretation.
| // longer than the promoted-input count, so current-format instances | ||
| // (exactly one value per promoted input, see serialize() below) are | ||
| // unaffected. | ||
| const hasControlAfterGenerateSlots = |
There was a problem hiding this comment.
issue: (blocking) Length alone cannot identify the legacy padded shape. A truncated legacy payload can have the same length as the promoted-input count, assigning control_after_generate to the next widget; an overlong current or stale payload can be misclassified in the opposite direction.
Full context for agent readers
For promoted [seed, steps, sampler], a partial legacy array [seed, "fixed", steps] has length 3, so this flag is false and restoration assigns "fixed" to steps and the old steps value to sampler. The test covers only a complete favorable padded array. Please add payload provenance/versioning, migrate deterministically before restoration, or use named values, with partial-padded and ambiguous-overlong controls. This also preserves the decided full-index contract instead of inferring an old payload layout from current topology.
…alue-shift-15102 # Conflicts: # src/lib/litegraph/src/subgraph/SubgraphNode.ts
Requested by Christian Byrne
Summary
Fixes a subgraph flatten bug where promoted widget values shift into the wrong widget (e.g. seed lands in steps, a number lands in sampler_name) for subgraph instances that carry a legacy/imported
widgets_valuesshape.Changes
SubgraphNode._applyPromotedWidgetValuesrestores promoted widget values from a subgraph instance'swidgets_valuesby walkingthis.inputsand consuming one array slot per promoted widget-input. It never accounted for thecontrol_after_generatecompanion widget that some promoted widgets carry (e.g. seed/noise_seed). Legacy or imported subgraph instances can serializewidgets_valueswith an extra slot for that companion, mirroring the underlying node's own widget layout, even though the companion is never itself a promoted input. Reading the array with a plain per-input counter then shifts every value after the companion's slot onto the wrong widget. The fix only engages the compensation whenwidgets_valuesis longer than the number of promoted inputs (a length mismatch that only legacy-shaped arrays produce), and in that case skips one extra slot for any promoted input whose underlying widget has a linked control-after-generate companion. Current-format instances, which serialize exactly one value per promoted input, are unaffected.Review Focus
The compensation is gated on
widgets_values.length > promotedInputs.lengthspecifically so normal, current-format subgraph instances (which never include a control_after_generate slot) take the exact same code path as before — this is meant to be a no-op for the common case.Added
test: add failing coverage for control_after_generate widgets_values padding on subgraph configureas a separate commit before the fix, so the failing→passing sequence documents the bug.Fixes [backport core/1.49] fix(missing-model): improve gated access accessibility #15102
Related: fix(dialog): treat aria-haspopup triggers as inside non-modal dialogs #13627 (root-caused this exact class of subgraph promotion bug against an older frontend build; tracked but not yet fixed there)
Screenshots (if applicable)
N/A — unit-test-only change to subgraph value restoration logic.