You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Editing a promoted widget in the properties side panel permanently freezes that widget on the subgraph node (stale host widgets_values shadow) #13601
Editing a promoted widget through the properties / parameters side panel while the subgraph host node is selected permanently freezes that widget on the canvas node. After the panel edit:
Dragging the slider (or toggling the boolean) on the subgraph node still updates the interior node's value — execution uses the new value correctly.
But the widget's displayed value never changes again. The UI is pinned to the value that was set in the side panel.
The freeze persists across save/reload, because the pinned value is serialized into the workflow JSON.
Only the widgets that were edited via the side panel freeze; promoted widgets never touched by the panel keep working normally.
Root cause (from inspecting the saved JSON)
The canvas widget edit path routes values through the proxy to the interior node, but the side-panel edit path appears to write the value directly into the host node's widgets_values[i]. Once that entry is non-null, the canvas proxy widget's displayed value is pinned to it.
Evidence from an affected workflow — the subgraph host node has 14 promoted widgets; exactly the two that were edited in the side panel hold concrete values, all others are null:
(index 2 = a promoted BOOLEAN, index 3 = a promoted FLOAT slider — the two panel-edited controls, both frozen; the rest respond normally.)
Workaround that confirms the mechanism: close the workflow tab, hand-edit the JSON to set every entry of the host node's widgets_values back to null, reopen — all widgets respond again. Interior node values are untouched, so nothing is lost.
Steps to Reproduce
Create a subgraph containing a node with a FLOAT widget (e.g. a primitive float/slider) and promote that widget to the subgraph node.
On the parent canvas, verify the promoted slider drags normally.
Select the subgraph node and open the properties/parameters side panel.
Change the promoted widget's value in the side panel.
Try dragging the slider on the subgraph node: the displayed value is frozen at the panel-set value, while queued prompts show the backend receives the dragged value.
Save and reload — still frozen. Inspect the JSON: the host node's widgets_values entry for that widget is now non-null.
How is this affecting you?
Worse than visual-only: the UI displays one value while execution uses another, which silently invalidates generation comparisons until the user notices. Recovering requires hand-editing the workflow JSON.
ComfyUI Frontend Version
1.46.15
Browser
Chrome (the pinned state lives in the serialized workflow JSON, so this does not appear browser-specific)
Additional Context
Possibly related to #10221 (subgraph IO order drift between views, which can additionally misalign this widgets_values snapshot after inputs are reordered), but this issue reproduces without any reordering — a single side-panel edit is sufficient. Distinct from #13046 (nested-subgraph float click behavior).
#12197 - feat(subgraph): Subgraph Link Only Promotion (ADR 0009) + migration/store hygiene [closed] #13322 - ECS: Moving widgets out of the Node data [merged]
🧪 Issue enrichment is currently in open beta.
You can configure auto-planning by selecting labels in the issue_enrichment configuration.
To disable automatic issue enrichment, add the following to your .coderabbit.yaml:
issue_enrichment:
auto_enrich:
enabled: false
💬 Have feedback or questions? Drop into our discord!
The two-sources-of-truth diagnosis looks convincing.
ComfyUI LoRA Pipeline offers a small practical regression fixture for this case. Its Conditioning Pipeline Set Area node exposes x, y, width, height and strength FLOAT widgets.
A test could promote strength into a subgraph and then:
Change it from the canvas widget.
Change it from the properties panel.
Change it again from the canvas.
Save and reload the workflow.
Verify that the displayed, serialized and executed values remain identical.
The host node's widgets_values should not become a second authoritative value that shadows the promoted widget proxy. Either the proxy store must remain the sole source of truth, or the host snapshot must be cleared or synchronized after every edit path.
This was investigated as part of a broader regression sweep across the widget-value handling code.
I was unable to reproduce the described behavior on current main (as of commit e1718dacb, 2026-07-31): editing a promoted widget's value via the properties panel no longer permanently freezes its canvas display or diverges from the executed value. I traced both the canvas-edit and panel-edit write paths and confirmed they now converge on the same widgetValueStore entry (keyed by WidgetId), which appears to have been a result of the ADR-0009 subgraph-promotion rework. I confirmed this across three independent test layers (raw data/store, VueNodes rendering, and the actual SectionWidgets.vue component) and saw no staleness in any of them.
This issue was originally filed against v1.46.15, and it looks like the fix landed as a side effect of the larger widget-value-store refactor rather than as a targeted fix for this specific report.
Could the reporter (or whoever last hit this) re-test on the latest release and confirm whether it still reproduces? If not, this is probably safe to close. If it does still reproduce, a fresh repro workflow/steps would really help — possible remaining edge cases I haven't ruled out are nested (2+ level) subgraph promotion, or loading an older workflow JSON saved before the refactor.
Leaving this open for a maintainer/reporter to make the final call rather than closing it myself.
Confirmed fixed on my side — thanks for chasing it down.
I re-tested on frontend 1.47.11 / ComfyUI core v0.29.2, driving the live UI with Playwright and real mouse input. Two scenarios, both clean:
1. The bug as filed (single-level subgraph, promoted FLOAT):
step
displayed on host
executed (graphToPrompt)
host widgets_values
baseline
12.5
12.5
[12.5]
canvas drag
72.5
72.5
[72.5]
panel edit → 77.5
77.5
77.5
[77.5]
canvas drag again
137.5
137.5
[137.5]
The panel edit now propagates to the canvas display, and the widget keeps responding to drags afterwards. No pinning, no display-vs-execution divergence.
2. Nested (2-level) promotion — the edge case flagged above: same clean progression (12.5 → 72.5 → panel 77.5 → 137.5), with the prompt id 4:3:1 confirming the value resolves two levels down. Does not reproduce either.
So this is good to close as far as the original report goes.
Two notes for anyone else verifying this:
(a) The panel value editor moved. In 1.47.11 the subgraph Parameters panel shows promoted params as read-only rows by default — the editable value control is behind the settings-2 (sliders) icon in the panel header. Before clicking it, the only <input> in the panel is the search box. My first automated run edited the wrong field and produced a false pass; worth knowing so re-tests are actually exercising the panel write path.
(b) null in host widgets_values no longer falls through — and that breaks the workaround this issue recommended. The original report suggested nulling the host's widgets_values entries to recover a frozen widget, which was correct on 1.46.x. On ≥1.47.9 host widgets_values is authoritative (it seeds the display and compiles into the prompt), so a null entry now loads as undefined instead of deferring to the interior widget.
Loading a 1.46-era workflow that had the workaround applied, host node with on-disk widgets_values: [null, null, null, null, null, null, null, 3358], gives 5 of 8 promoted widgets value: undefined on 1.47.11.
Anyone who followed the advice in this thread has a latent breakage. I'll file that separately rather than bury it here — linking it once it's up.
@AI4VFX confirmed on 1.47.11 / ComfyUI core v0.29.2, via Playwright-driven retest, that this is fixed for both the originally-reported single-level subgraph case and the nested (2-level) promotion edge case — panel edits now propagate correctly to the canvas display with no display-vs-execution divergence. As noted in their comment, this landed as a side effect of the ADR-0009 widget-value-store refactor rather than a targeted fix.
Closing per their confirmation ("good to close as far as the original report goes"). The separate null-fallthrough migration issue they flagged has been filed as #14488 and tracked independently.
This issue is closed, but linking it because the analysis names it as the origin of the family and because the null-out workaround documented in this thread is what causes #14488 on >=1.47.
One root cause behind all four: the promoted widget's value lives in widgetValueStore keyed to the host node (graphId:nodeId:name). ADR 0009 makes the host authoritative and the interior widget a schema/default provider that must never be a persistence carrier — but the host-owned value has no durable home. input-disconnected deletes the store entry and _setWidget re-registers it seeded from interiorWidget.value (src/lib/litegraph/src/subgraph/SubgraphNode.ts), so host edits are silently discarded on rebind.
Anyone who applied the workaround here (nulling every host widgets_values entry): those files break differently on >=1.47 — see #14488, fix in flight at #14955.
Activity
coderabbitai commentedon Jul 11, 2026
🔗 Related PRs
#12197 - feat(subgraph): Subgraph Link Only Promotion (ADR 0009) + migration/store hygiene [closed]
#13322 - ECS: Moving widgets out of the Node data [merged]
🧪 Issue enrichment is currently in open beta.
You can configure auto-planning by selecting labels in the issue_enrichment configuration.
To disable automatic issue enrichment, add the following to your
.coderabbit.yaml:💬 Have feedback or questions? Drop into our discord!
andreszs commentedon Jul 31, 2026
The two-sources-of-truth diagnosis looks convincing.
ComfyUI LoRA Pipeline offers a small practical regression fixture for this case. Its Conditioning Pipeline Set Area node exposes
x,y,width,heightandstrengthFLOAT widgets.A test could promote
strengthinto a subgraph and then:The host node's
widgets_valuesshould not become a second authoritative value that shadows the promoted widget proxy. Either the proxy store must remain the sole source of truth, or the host snapshot must be cleared or synchronized after every edit path.ComfyUI LoRA Pipeline
claude commentedon Jul 31, 2026
This was investigated as part of a broader regression sweep across the widget-value handling code.
I was unable to reproduce the described behavior on current
main(as of commite1718dacb, 2026-07-31): editing a promoted widget's value via the properties panel no longer permanently freezes its canvas display or diverges from the executed value. I traced both the canvas-edit and panel-edit write paths and confirmed they now converge on the samewidgetValueStoreentry (keyed byWidgetId), which appears to have been a result of the ADR-0009 subgraph-promotion rework. I confirmed this across three independent test layers (raw data/store, VueNodes rendering, and the actualSectionWidgets.vuecomponent) and saw no staleness in any of them.This issue was originally filed against v1.46.15, and it looks like the fix landed as a side effect of the larger widget-value-store refactor rather than as a targeted fix for this specific report.
Could the reporter (or whoever last hit this) re-test on the latest release and confirm whether it still reproduces? If not, this is probably safe to close. If it does still reproduce, a fresh repro workflow/steps would really help — possible remaining edge cases I haven't ruled out are nested (2+ level) subgraph promotion, or loading an older workflow JSON saved before the refactor.
Leaving this open for a maintainer/reporter to make the final call rather than closing it myself.
Generated by Claude Code
AI4VFX commentedon Jul 31, 2026
Confirmed fixed on my side — thanks for chasing it down.
I re-tested on frontend 1.47.11 / ComfyUI core v0.29.2, driving the live UI with Playwright and real mouse input. Two scenarios, both clean:
1. The bug as filed (single-level subgraph, promoted FLOAT):
graphToPrompt)widgets_values[12.5][72.5][77.5][137.5]The panel edit now propagates to the canvas display, and the widget keeps responding to drags afterwards. No pinning, no display-vs-execution divergence.
2. Nested (2-level) promotion — the edge case flagged above: same clean progression (12.5 → 72.5 → panel 77.5 → 137.5), with the prompt id
4:3:1confirming the value resolves two levels down. Does not reproduce either.So this is good to close as far as the original report goes.
Two notes for anyone else verifying this:
(a) The panel value editor moved. In 1.47.11 the subgraph Parameters panel shows promoted params as read-only rows by default — the editable value control is behind the
settings-2(sliders) icon in the panel header. Before clicking it, the only<input>in the panel is the search box. My first automated run edited the wrong field and produced a false pass; worth knowing so re-tests are actually exercising the panel write path.(b)
nullin hostwidgets_valuesno longer falls through — and that breaks the workaround this issue recommended. The original report suggested nulling the host'swidgets_valuesentries to recover a frozen widget, which was correct on 1.46.x. On ≥1.47.9 hostwidgets_valuesis authoritative (it seeds the display and compiles into the prompt), so anullentry now loads asundefinedinstead of deferring to the interior widget.Loading a 1.46-era workflow that had the workaround applied, host node with on-disk
widgets_values: [null, null, null, null, null, null, null, 3358], gives 5 of 8 promoted widgetsvalue: undefinedon 1.47.11.Anyone who followed the advice in this thread has a latent breakage. I'll file that separately rather than bury it here — linking it once it's up.
AI4VFX commentedon Jul 31, 2026
Filed the null-fallthrough migration break as #14488.
claude commentedon Aug 9, 2026
@AI4VFX confirmed on 1.47.11 / ComfyUI core v0.29.2, via Playwright-driven retest, that this is fixed for both the originally-reported single-level subgraph case and the nested (2-level) promotion edge case — panel edits now propagate correctly to the canvas display with no display-vs-execution divergence. As noted in their comment, this landed as a side effect of the ADR-0009 widget-value-store refactor rather than a targeted fix.
Closing per their confirmation ("good to close as far as the original report goes"). The separate
null-fallthrough migration issue they flagged has been filed as #14488 and tracked independently.Generated by Claude Code
fix: fall through to interior widget value for null host widgets_values
christian-byrne commentedon Aug 19, 2026
RCA of record for this and its siblings (#14495, #14488, #11297): promoted subgraph widget ownership — full dossier.
This issue is closed, but linking it because the analysis names it as the origin of the family and because the
null-out workaround documented in this thread is what causes #14488 on >=1.47.One root cause behind all four: the promoted widget's value lives in
widgetValueStorekeyed to the host node (graphId:nodeId:name). ADR 0009 makes the host authoritative and the interior widget a schema/default provider that must never be a persistence carrier — but the host-owned value has no durable home.input-disconnecteddeletes the store entry and_setWidgetre-registers it seeded frominteriorWidget.value(src/lib/litegraph/src/subgraph/SubgraphNode.ts), so host edits are silently discarded on rebind.Anyone who applied the workaround here (nulling every host
widgets_valuesentry): those files break differently on >=1.47 — see #14488, fix in flight at #14955.