Skip to content

fix: replace lobe-i18n with source-aware in-house locale pipeline - #15062

Merged
benceruleanlu merged 7 commits into
mainfrom
bl/in-house-i18n-pipeline-1b91ce
Aug 13, 2026
Merged

benceruleanlu merged 7 commits into
mainfrom
bl/in-house-i18n-pipeline-1b91ce

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Aug 11, 2026 •

Copy link
Copy Markdown
Member

Summary

Replace the @lobehub/i18n-cli translation step with an in-house pipeline (scripts/i18n/) so changed English source strings are retranslated, removed keys are pruned, and protected syntax survives translation byte-for-byte.

The user-facing and correctness repairs were split into #15137 (merged). This PR is strictly the framework migration.

Changes

  • pnpm locale now runs scripts/i18n/update-locales.ts. It records the English sources of the last successful run as git blob hashes in src/locales/.source-manifest.json, diffs them against the current src/locales/en/*.json to invalidate changed and deleted keys, and rebuilds every output locale from the English structure.
  • Validates interpolation placeholders and protected literals (<Picture N>, 17k+5, quoted match and max), retries corrupted translations, and aborts without writing if corruption persists.
  • pnpm locale:check reports pending work offline.
  • Normalizes English entry files to the committed serialization before hashing so manifest hashes match workflow commits regardless of collect-i18n and formatting order.
  • Removes @lobehub/i18n-cli and .i18nrc.cjs; configuration now lives in scripts/i18n/config.ts.
  • Translation requests go through the official openai SDK (the one new dependency, dev-only with no transitive dependencies), which owns transport retries, timeouts, and typed completion parsing; the pipeline keeps only domain-level retries for truncated or malformed completions.
  • Uses a blobless full-history checkout in the i18n workflows so recorded English source blobs can be fetched on demand.

Review Focus

Manifest advancement only after full validation; rebuild-from-source semantics; translation retry and validation behavior; and source-provenance handling.

Depends on #15137 (merged). Supersedes #15024.

FE-1499

@github-actions

github-actions Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

@github-actions

github-actions Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/13/2026, 02:52:50 AM UTC

Links

🎭 Playwright: ✅ 1801 passed, 0 failed · 5 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1780 / ❌ 0 / ⚠️ 5 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 8.84 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 37.3 MB baseline 37.3 MB — ⚪ 0 B
  • Gzip: 8.84 MB baseline 8.84 MB — ⚪ 0 B
  • Brotli: 6.18 MB baseline 6.18 MB — ⚪ 0 B
  • Bundles: 439 current • 439 baseline

Category Glance
Vendor & Third-Party ⚪ 0 B (16.8 MB) · Other ⚪ 0 B (14.2 MB) · Data & Services ⚪ 0 B (3.51 MB) · Graph Workspace ⚪ 0 B (1.37 MB) · Panels & Settings ⚪ 0 B (565 kB) · Utilities & Hooks ⚪ 0 B (550 kB) · + 5 more

App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 27.2 kB (baseline 27.2 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 B

Reusable component library chunks

Status: 14 unchanged

Data & Services — 3.51 MB (baseline 3.51 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 38 unchanged

Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 286 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 141ms TBT · 69.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 162.1 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 121ms TBT · 163.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap

⚠️ 7 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 376ms 517ms +38% ⚠️ z=3.9
canvas-zoom-sweep: avg frame time 17ms 17ms +0% ⚠️ z=2.2
canvas-zoom-sweep: task duration 295ms 378ms +28% ⚠️ z=2.2
large-graph-idle: task duration 530ms 665ms +25% ⚠️ z=2.3
large-graph-pan: task duration 891ms 1260ms +41% ⚠️ z=4.1
minimap-idle: task duration 537ms 659ms +23% ⚠️ z=2.8
subgraph-idle: task duration 369ms 454ms +23% ⚠️ z=2.7
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.5
canvas-idle: p95 frame time 17ms 17ms +0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 6ms 10ms +65% z=-1.3
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 10 +0% z=-2.1
canvas-idle: task duration 376ms 517ms +38% ⚠️ z=3.9
canvas-idle: script duration 13ms 18ms +36% z=-3.4
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 67.4 MB 67.4 MB +0% —
canvas-idle: DOM nodes 20 20 +0% z=-2.0
canvas-idle: event listeners 6 4 -33% z=-1.6
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 2ms 4ms +52% z=0.2
canvas-mouse-sweep: style recalc duration 23ms 39ms +67% z=-1.3
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 72 74 +3% z=-2.0
canvas-mouse-sweep: task duration 629ms 854ms +36% z=-0.2
canvas-mouse-sweep: script duration 79ms 120ms +53% z=-2.3
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 61.6 MB 54.2 MB -12% —
canvas-mouse-sweep: DOM nodes 57 -113 -298% z=-67.8
canvas-mouse-sweep: event listeners 4 -75 -1963% z=-19.9
canvas-zoom-sweep: avg frame time 17ms 17ms +0% ⚠️ z=2.2
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms +12% z=-1.8
canvas-zoom-sweep: style recalc duration 12ms 17ms +42% z=-1.7
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 30 33 +8% z=2.7
canvas-zoom-sweep: task duration 295ms 378ms +28% ⚠️ z=2.2
canvas-zoom-sweep: script duration 14ms 18ms +31% z=-2.9
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 69.9 MB 70.0 MB +0% —
canvas-zoom-sweep: DOM nodes 78 78 +0% z=-1.6
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.6
dom-widget-clipping: p95 frame time 17ms 17ms -0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 5ms 7ms +35% z=-3.2
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 11 -15% z=-4.2
dom-widget-clipping: task duration 266ms 374ms +41% z=0.6
dom-widget-clipping: script duration 36ms 59ms +65% z=-2.6
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 50.7 MB 51.1 MB +1% —
dom-widget-clipping: DOM nodes 22 18 -18% z=-2.9
dom-widget-clipping: event listeners 2 1 -50% variance too high
large-graph-idle: avg frame time 17ms 17ms -0% z=-1.0
large-graph-idle: p95 frame time 17ms 17ms -0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 6ms 8ms +45% z=-3.7
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 11 9 -18% z=-8.3
large-graph-idle: task duration 530ms 665ms +25% ⚠️ z=2.3
large-graph-idle: script duration 63ms 101ms +61% z=-0.1
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 65.9 MB 63.6 MB -4% —
large-graph-idle: DOM nodes -280 -281 +0% z=-338.2
large-graph-idle: event listeners -147 -148 +1% z=-28.6
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 9ms 14ms +54% z=-4.3
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 69 +1% z=-0.9
large-graph-pan: task duration 891ms 1260ms +41% ⚠️ z=4.1
large-graph-pan: script duration 272ms 421ms +55% z=0.6
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 61.6 MB 59.6 MB -3% —
large-graph-pan: DOM nodes -282 -284 +1% z=-183.7
large-graph-pan: event listeners -149 -148 -1% z=-184.7
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms -0% —
large-graph-zoom: layout duration 5ms 7ms +28% —
large-graph-zoom: style recalc duration 11ms 14ms +30% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 66 65 -2% —
large-graph-zoom: task duration 1101ms 1469ms +33% —
large-graph-zoom: script duration 356ms 522ms +47% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 51.8 MB 72.0 MB +39% —
large-graph-zoom: DOM nodes -284 -138 -51% —
large-graph-zoom: event listeners -153 -73 -53% —
minimap-idle: avg frame time 17ms 17ms -0% z=-0.4
minimap-idle: p95 frame time 17ms 17ms -0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 5ms 6ms +14% z=-4.3
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 9 7 -22% z=-3.8
minimap-idle: task duration 537ms 659ms +23% ⚠️ z=2.8
minimap-idle: script duration 64ms 102ms +59% z=0.4
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 59.7 MB 64.4 MB +8% —
minimap-idle: DOM nodes -282 -287 +2% z=-223.5
minimap-idle: event listeners -179 -149 -17% z=-232.6
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 8ms 10ms +30% z=-3.0
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 48 47 -3% z=-2.5
subgraph-dom-widget-clipping: task duration 295ms 390ms +32% z=0.6
subgraph-dom-widget-clipping: script duration 85ms 120ms +41% z=-1.4
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 51.3 MB 51.7 MB +1% —
subgraph-dom-widget-clipping: DOM nodes 22 19 -14% z=-2.8
subgraph-dom-widget-clipping: event listeners 8 7 -13% z=-1.6
subgraph-idle: avg frame time 17ms 17ms -0% z=-0.2
subgraph-idle: p95 frame time 17ms 17ms -1% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 6ms 9ms +48% z=-1.9
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 11 11 -5% z=-0.6
subgraph-idle: task duration 369ms 454ms +23% ⚠️ z=2.7
subgraph-idle: script duration 11ms 14ms +22% z=-2.4
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 67.5 MB 67.2 MB -0% —
subgraph-idle: DOM nodes 22 21 -5% z=-0.5
subgraph-idle: event listeners 6 4 -33% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.8
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% —
subgraph-mouse-sweep: layout duration 3ms 4ms +15% z=-3.1
subgraph-mouse-sweep: style recalc duration 25ms 34ms +35% z=-2.5
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 75 76 +1% z=-2.4
subgraph-mouse-sweep: task duration 557ms 757ms +36% z=-0.1
subgraph-mouse-sweep: script duration 58ms 89ms +55% z=-1.8
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 58.6 MB 58.6 MB -0% —
subgraph-mouse-sweep: DOM nodes 61 63 +3% z=-1.8
subgraph-mouse-sweep: event listeners 4 4 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms -0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +0% —
subgraph-transition-enter: layout duration 8ms 12ms +48% —
subgraph-transition-enter: style recalc duration 22ms 30ms +33% —
subgraph-transition-enter: layout count 16 14 -13% —
subgraph-transition-enter: style recalc count 20 18 -10% —
subgraph-transition-enter: task duration 680ms 902ms +33% —
subgraph-transition-enter: script duration 19ms 34ms +81% —
subgraph-transition-enter: TBT 96ms 141ms +47% —
subgraph-transition-enter: heap used 94.8 MB 69.6 MB -27% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2373 2375 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 23ms 36ms +61% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 249 250 +0% —
viewport-pan-sweep: task duration 3112ms 4405ms +42% —
viewport-pan-sweep: script duration 868ms 1365ms +57% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 83.8 MB 64.1 MB -24% —
viewport-pan-sweep: DOM nodes -280 -282 +1% —
viewport-pan-sweep: event listeners -161 -133 -17% —
vue-large-graph-idle: avg frame time 17ms 18ms +3% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 10673ms 16690ms +56% —
vue-large-graph-idle: script duration 380ms 584ms +53% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 159.6 MB 162.1 MB +2% —
vue-large-graph-idle: DOM nodes -8312 -8315 +0% —
vue-large-graph-idle: event listeners -16389 -16386 -0% —
vue-large-graph-pan: avg frame time 17ms 18ms +3% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 12ms 15ms +29% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 68 138 +102% —
vue-large-graph-pan: task duration 13360ms 20286ms +52% —
vue-large-graph-pan: script duration 684ms 867ms +27% —
vue-large-graph-pan: TBT 27ms 121ms +348% —
vue-large-graph-pan: heap used 159.6 MB 163.2 MB +2% —
vue-large-graph-pan: DOM nodes -8312 -8312 +0% —
vue-large-graph-pan: event listeners -16387 -16384 -0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms -0% —
workflow-execution: layout duration 0ms 1ms +132% z=-4.6
workflow-execution: style recalc duration 14ms 22ms +61% z=-0.9
workflow-execution: layout count 2 3 +50% z=-3.6
workflow-execution: style recalc count 15 15 +0% z=-1.4
workflow-execution: task duration 87ms 125ms +43% z=0.2
workflow-execution: script duration 7ms 10ms +48% z=-6.4
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 65.7 MB 65.8 MB +0% —
workflow-execution: DOM nodes 128 126 -2% z=-5.0
workflow-execution: event listeners 99 98 -1% z=10.6
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-13T03:04:53.780Z",
  "gitSha": "0542bdf4ce719cbff3bdee16b941a8ae05d913af",
  "branch": "bl/in-house-i18n-pipeline-1b91ce",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2138.8810000000262,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.584999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 581.6600000000001,
      "heapDeltaBytes": 5840016,
      "heapUsedBytes": 70682252,
      "domNodes": 22,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 19.006,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2051.624000000004,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.686000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.48,
      "heapDeltaBytes": 5855052,
      "heapUsedBytes": 70662804,
      "domNodes": 18,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 16.32,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1846.7920000000504,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 37.286,
      "layouts": 12,
      "layoutDurationMs": 3.71,
      "taskDurationMs": 873.371,
      "heapDeltaBytes": -16252088,
      "heapUsedBytes": 48474448,
      "domNodes": -283,
      "jsHeapTotalBytes": 23564288,
      "scriptDurationMs": 120.149,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1841.0420000000158,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 40.01499999999999,
      "layouts": 12,
      "layoutDurationMs": 3.5789999999999997,
      "taskDurationMs": 834.333,
      "heapDeltaBytes": 427416,
      "heapUsedBytes": 65206400,
      "domNodes": 57,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 120.70199999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.7090000000244,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 16.281999999999996,
      "layouts": 6,
      "layoutDurationMs": 0.49700000000000005,
      "taskDurationMs": 379.21000000000004,
      "heapDeltaBytes": 8746708,
      "heapUsedBytes": 73613112,
      "domNodes": 78,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 18.177,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.055999999944,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.869000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.6280000000000001,
      "taskDurationMs": 377.21099999999996,
      "heapDeltaBytes": 8558756,
      "heapUsedBytes": 73290968,
      "domNodes": 78,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 18.474,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 578.9439999999786,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.401,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.128,
      "heapDeltaBytes": -11296540,
      "heapUsedBytes": 53491352,
      "domNodes": 18,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 59.120999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 576.3500000000477,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.2219999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 377.563,
      "heapDeltaBytes": -11382380,
      "heapUsedBytes": 53657828,
      "domNodes": 18,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 59.538999999999994,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.5059999999644,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.128,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 660.898,
      "heapDeltaBytes": 6710180,
      "heapUsedBytes": 66652028,
      "domNodes": -282,
      "jsHeapTotalBytes": 3768320,
      "scriptDurationMs": 100.08,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.868999999906,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.530000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 669.542,
      "heapDeltaBytes": 6999216,
      "heapUsedBytes": 66755976,
      "domNodes": -280,
      "jsHeapTotalBytes": 2719744,
      "scriptDurationMs": 101.841,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2158.976999999993,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.355999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1265.623,
      "heapDeltaBytes": 1984220,
      "heapUsedBytes": 62996688,
      "domNodes": -283,
      "jsHeapTotalBytes": 3174400,
      "scriptDurationMs": 424.20199999999994,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2163.6989999999514,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.437999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1254.4719999999998,
      "heapDeltaBytes": 1174304,
      "heapUsedBytes": 62077736,
      "domNodes": -285,
      "jsHeapTotalBytes": 3960832,
      "scriptDurationMs": 417.561,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3278.377999999975,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 15.469,
      "layouts": 60,
      "layoutDurationMs": 6.968999999999999,
      "taskDurationMs": 1521.8709999999999,
      "heapDeltaBytes": 1568196,
      "heapUsedBytes": 63809816,
      "domNodes": -286,
      "jsHeapTotalBytes": 5865472,
      "scriptDurationMs": 531.999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3147.5090000000137,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.479999999999999,
      "layouts": 60,
      "layoutDurationMs": 7.025,
      "taskDurationMs": 1416.4399999999998,
      "heapDeltaBytes": 23940224,
      "heapUsedBytes": 87163892,
      "domNodes": 10,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 511.49199999999996,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2016.8790000000172,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.989000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 658.4689999999999,
      "heapDeltaBytes": 6354484,
      "heapUsedBytes": 67172736,
      "domNodes": -287,
      "jsHeapTotalBytes": 4030464,
      "scriptDurationMs": 101.493,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.739000000026,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.075,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 658.563,
      "heapDeltaBytes": 6919144,
      "heapUsedBytes": 67897144,
      "domNodes": -286,
      "jsHeapTotalBytes": 4554752,
      "scriptDurationMs": 102.045,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 595.5539999999928,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.099000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 387.066,
      "heapDeltaBytes": -10289280,
      "heapUsedBytes": 54478644,
      "domNodes": 16,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 120.26200000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 589.2949999999928,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 10.723,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 391.992,
      "heapDeltaBytes": -11015760,
      "heapUsedBytes": 53930732,
      "domNodes": 22,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 118.763,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2028.0680000000189,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.612000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 461.0690000000001,
      "heapDeltaBytes": 5902476,
      "heapUsedBytes": 70498548,
      "domNodes": 22,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 13.434000000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.213000000026,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.225,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.398,
      "heapDeltaBytes": 5889236,
      "heapUsedBytes": 70504232,
      "domNodes": 20,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 14.003,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.9180000000065,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 33.724,
      "layouts": 16,
      "layoutDurationMs": 3.7830000000000004,
      "taskDurationMs": 763.875,
      "heapDeltaBytes": -3261620,
      "heapUsedBytes": 61436380,
      "domNodes": 62,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 88.98599999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1711.1830000000054,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.660000000000004,
      "layouts": 16,
      "layoutDurationMs": 3.6,
      "taskDurationMs": 749.465,
      "heapDeltaBytes": -3462116,
      "heapUsedBytes": 61447860,
      "domNodes": 64,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 89.377,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.096999999997,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.73200000000001,
      "layouts": 14,
      "layoutDurationMs": 12.464000000000002,
      "taskDurationMs": 901.6139999999999,
      "heapDeltaBytes": 1436228,
      "heapUsedBytes": 73024636,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15204352,
      "scriptDurationMs": 33.87800000000001,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8301.328000000012,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 36.164,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4402.585,
      "heapDeltaBytes": 5778580,
      "heapUsedBytes": 65729212,
      "domNodes": -282,
      "jsHeapTotalBytes": 5533696,
      "scriptDurationMs": 1369.932,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8194.856000000073,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 36.769999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4408.19,
      "heapDeltaBytes": 9410156,
      "heapUsedBytes": 68672760,
      "domNodes": -281,
      "jsHeapTotalBytes": 5795840,
      "scriptDurationMs": 1359.146,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16832.524000000034,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16801.476000000002,
      "heapDeltaBytes": -50758404,
      "heapUsedBytes": 166201708,
      "domNodes": -8312,
      "jsHeapTotalBytes": -12263424,
      "scriptDurationMs": 585.416,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16633.995999999912,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16578.704,
      "heapDeltaBytes": -44534896,
      "heapUsedBytes": 173680220,
      "domNodes": -8317,
      "jsHeapTotalBytes": -8855552,
      "scriptDurationMs": 581.597,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20326.04200000003,
      "styleRecalcs": 137,
      "styleRecalcDurationMs": 15.106999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20302.506999999998,
      "heapDeltaBytes": -40763240,
      "heapUsedBytes": 165177848,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9637888,
      "scriptDurationMs": 863.4289999999999,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 95,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20304.161999999906,
      "styleRecalcs": 138,
      "styleRecalcDurationMs": 15.682000000000029,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20268.516,
      "heapDeltaBytes": -49119300,
      "heapUsedBytes": 177094352,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9449472,
      "scriptDurationMs": 870.617,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 147,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 481.2339999999722,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 20.344,
      "layouts": 3,
      "layoutDurationMs": 1.153,
      "taskDurationMs": 129.72299999999998,
      "heapDeltaBytes": 5074420,
      "heapUsedBytes": 69016916,
      "domNodes": 126,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.562,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 509.2499999999518,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 24.122000000000003,
      "layouts": 3,
      "layoutDurationMs": 0.6229999999999999,
      "taskDurationMs": 119.867,
      "heapDeltaBytes": 5067260,
      "heapUsedBytes": 69030956,
      "domNodes": 125,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.658000000000001,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@coderabbitai

coderabbitai Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR replaces the external i18n CLI with a Git-aware TypeScript locale pipeline. It adds locale parsing, translation, validation, rebuilding, manifest tracking, offline checks, CI integration, and blobless full-history checkout support.

Changes

Locale pipeline

Layer / File(s) Summary
Locale models and protected-token validation
scripts/i18n/config.ts, scripts/i18n/locale-tree.ts, scripts/i18n/protected-tokens.ts
Adds pipeline configuration, locale tree operations, source diffing, deterministic rebuilding, protected-token checks, and locale validation.
Translation batching and recovery
scripts/i18n/translate.ts
Adds structured translation requests, batching, bounded concurrency, timeouts, retries, response filtering, and multi-round recovery.
Manifest-driven locale updates
scripts/i18n/update-locales.ts, scripts/i18n/update-locales.test.ts, src/locales/.source-manifest.json
Adds Git source-manifest loading, pending-entry detection, translation assembly, pruning safeguards, locale writes, failure handling, and tests.
Workflow wiring and validation
.github/workflows/*, .github/actions/lint-format-verify/action.yml, package.json, pnpm-workspace.yaml, eslint.config.ts, .oxlintrc.json, .oxfmtrc.json, src/locales/CONTRIBUTING.md, vitest.setup.ts
Switches scripts to the local updater, adds locale:check, updates CI checkout and validation, removes obsolete CLI references, and documents the new workflow.

Estimated code review effort: 4 (Complex) | ~60 minutes

Mergeability Score: 🟠 High · up to 0bf15

The new locale pipeline can currently delete translations when an English entry file is missing, mishandle manually dispatched workflow branch selection, and accept translations that lose repeated protected tokens. These create concrete data-loss, workflow, and localization-correctness risks, so the PR is not merge-ready until the deletion guard, branch handling, and token-count validation are addressed.

Sequence Diagram(s)

sequenceDiagram
  participant GitHubActions
  participant updateLocales
  participant Git
  participant OpenAI
  participant LocaleFiles
  GitHubActions->>updateLocales: run locale update or check
  updateLocales->>Git: load source-manifest blobs and history
  updateLocales->>OpenAI: send batched pending translations
  OpenAI-->>updateLocales: return JSON translations
  updateLocales->>LocaleFiles: validate and write rebuilt locales
  LocaleFiles-->>GitHubActions: provide locale integrity status
Loading

Possibly related PRs

Suggested reviewers: christian-byrne


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The changed-file list is available, but the PR title and actual commit subjects are not; the required bug-fix signal cannot be verified from the allowed metadata. Provide the PR title and commit subjects, then reassess whether the explicit bug-fix condition applies.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes replacing the existing i18n CLI with an in-house, source-aware locale pipeline.
Description check ✅ Passed The description covers the summary, core changes, dependencies, review focus, issue reference, and migration scope required by the template.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed No changed file is under src/lib/litegraph/, src/ecs/, or related to graph entities, so the ADR compliance check does not apply.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bl/in-house-i18n-pipeline-1b91ce

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/i18n/translate.ts`:
- Around line 130-140: Update the fetchFn call in the translation request flow
to include signal: AbortSignal.timeout(120000) in its request options, ensuring
slow OpenAI requests are aborted after two minutes while preserving the existing
catch-based TimeoutError retry behavior.

In `@scripts/i18n/update-locales.test.ts`:
- Around line 208-226: Add a promise-gated Vitest case in the locale translation
tests that passes multiple chunks to translateLocaleItems with
requestConcurrency greater than one, tracks active TranslateBatch calls, and
asserts the maximum active count never exceeds the configured limit while all
translations complete. Keep the test focused on concurrent batch dispatch and
use the existing translation fixtures and helpers.

In `@scripts/i18n/update-locales.ts`:
- Around line 188-199: Update the recorded-source loader around execFileSync and
parseLocale so the try/catch covers only git blob retrieval; parse the returned
content after the try succeeds. Preserve the missing-blob error for retrieval
failures, and attach the caught original error as the Error cause.
- Around line 202-224: The writeManifest flow must hash the same formatted
English locale bytes that are committed. Ensure formatting runs before locale
collection/manifest generation (prefer ordering pnpm format before pnpm locale),
or otherwise format the content before calculating hashes in writeManifest;
preserve manifest serialization and conditional writing behavior.

In `@src/locales/fr/nodeDefs.json`:
- Around line 9147-9148: Update the description value for the latent AV split
node in nodeDefs.json to state “any compatible AV model,” preserving the
existing French wording and display_name unchanged.

In `@src/locales/ko/nodeDefs.json`:
- Line 5985: Update the description string in the relevant node definition to
replace “참조 이미지의 안내에 따라” with wording that means generating the video based on
the reference image, such as “참조 이미지를 기반으로,” while preserving the optional
preset voice-reference behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 054178fb-5657-4eb9-852c-d4b10ca4abe3

📥 Commits

Reviewing files that changed from the base of the PR and between 2ab67a6 and 4350fea.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (41)
  • .github/workflows/i18n-update-core.yaml
  • .github/workflows/i18n-update-custom-nodes.yaml
  • .github/workflows/i18n-update-nodes.yaml
  • .i18nrc.cjs
  • .oxlintrc.json
  • eslint.config.ts
  • package.json
  • pnpm-workspace.yaml
  • scripts/i18n/config.ts
  • scripts/i18n/locale-tree.ts
  • scripts/i18n/protected-tokens.ts
  • scripts/i18n/translate.ts
  • scripts/i18n/update-locales.test.ts
  • scripts/i18n/update-locales.ts
  • src/locales/.source-manifest.json
  • src/locales/CONTRIBUTING.md
  • src/locales/ar/main.json
  • src/locales/ar/nodeDefs.json
  • src/locales/es/main.json
  • src/locales/es/nodeDefs.json
  • src/locales/fa/main.json
  • src/locales/fa/nodeDefs.json
  • src/locales/fr/main.json
  • src/locales/fr/nodeDefs.json
  • src/locales/he/main.json
  • src/locales/he/nodeDefs.json
  • src/locales/it/main.json
  • src/locales/ja/main.json
  • src/locales/ja/nodeDefs.json
  • src/locales/ko/main.json
  • src/locales/ko/nodeDefs.json
  • src/locales/pt-BR/main.json
  • src/locales/pt-BR/nodeDefs.json
  • src/locales/ru/main.json
  • src/locales/ru/nodeDefs.json
  • src/locales/tr/main.json
  • src/locales/tr/nodeDefs.json
  • src/locales/zh-TW/main.json
  • src/locales/zh-TW/nodeDefs.json
  • src/locales/zh/main.json
  • src/locales/zh/nodeDefs.json
💤 Files with no reviewable changes (4)
  • .oxlintrc.json
  • pnpm-workspace.yaml
  • .i18nrc.cjs
  • eslint.config.ts

Comment thread scripts/i18n/translate.ts Resolved
Comment thread scripts/i18n/update-locales.test.ts Resolved
Comment thread scripts/i18n/update-locales.ts Resolved
Comment thread scripts/i18n/update-locales.ts Resolved
Comment on lines +9147 to +9148
"description": "Sépare un latent AV conjoint en ses latents vidéo et audio (tout modèle AV, par ex. LTXV ou MiniMax H3).",
"display_name": "Séparer le latent AV",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Preserve the compatibility constraint in the description.

The text tout modèle AV means “any AV model.” The intended meaning is “any compatible AV model.” Add compatible so users do not infer that every AV model accepts this latent format.

Proposed wording
-    "description": "Sépare un latent AV conjoint en ses latents vidéo et audio (tout modèle AV, par ex. LTXV ou MiniMax H3).",
+    "description": "Sépare un latent AV conjoint en ses latents vidéo et audio (tout modèle AV compatible, par ex. LTXV ou MiniMax H3).",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"description": "Sépare un latent AV conjoint en ses latents vidéo et audio (tout modèle AV, par ex. LTXV ou MiniMax H3).",
"display_name": "Séparer le latent AV",
"description": "Sépare un latent AV conjoint en ses latents vidéo et audio (tout modèle AV compatible, par ex. LTXV ou MiniMax H3).",
"display_name": "Séparer le latent AV",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/fr/nodeDefs.json` around lines 9147 - 9148, Update the
description value for the latent AV split node in nodeDefs.json to state “any
compatible AV model,” preserving the existing French wording and display_name
unchanged.

},
"GrokVideoReferenceNode": {
"description": "참조 이미지를 스타일 및 콘텐츠 참조로 사용하여 비디오를 생성합니다.",
"description": "참조 이미지의 안내에 따라 비디오를 생성하며, 사전 설정된 음성 참조를 선택적으로 사용할 수 있습니다.",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Use wording that describes visual guidance.

참조 이미지의 안내에 따라 implies that the reference image contains instructions. Use wording such as 참조 이미지를 기반으로 to preserve the intended meaning.

Proposed fix
-    "description": "참조 이미지의 안내에 따라 비디오를 생성하며, 사전 설정된 음성 참조를 선택적으로 사용할 수 있습니다.",
+    "description": "참조 이미지를 기반으로 비디오를 생성하며, 사전 설정된 음성 참조를 선택적으로 사용할 수 있습니다.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"description": "참조 이미지의 안내에 따라 비디오를 생성하며, 사전 설정된 음성 참조를 선택적으로 사용할 수 있습니다.",
"description": "참조 이미지를 기반으로 비디오를 생성하며, 사전 설정된 음성 참조를 선택적으로 사용할 수 있습니다.",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/ko/nodeDefs.json` at line 5985, Update the description string in
the relevant node definition to replace “참조 이미지의 안내에 따라” with wording that means
generating the video based on the reference image, such as “참조 이미지를 기반으로,” while
preserving the optional preset voice-reference behavior.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
scripts/i18n/update-locales.test.ts (1)

145-230: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Add coverage for concurrent batch dispatch.

The visible tests only exercise sequential, single-chunk-at-a-time response scenarios. None of them pass multiple chunks with requestConcurrency > 1 to translateLocaleItems. A regression that exceeds the configured request limit would still pass these tests.

Add a promise-gated test. Track active TranslateBatch calls. Assert the maximum active count never exceeds the configured requestConcurrency. Assert all translations still complete.

As per path instructions, review the colocated Vitest coverage for locale pipeline behavior, especially batching and retries.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/i18n/update-locales.test.ts` around lines 145 - 230, Add a Vitest
case in the translateLocaleItems suite that supplies enough items for multiple
chunks and configures requestConcurrency above one. Use promise-gated
TranslateBatch calls to track active requests and record the maximum concurrent
count, then release them and assert all translations complete while the maximum
never exceeds translationConfig.requestConcurrency. Ensure the test covers
concurrent batch dispatch without altering existing retry behavior.

Source: Path instructions

♻️ Duplicate comments (1)
src/locales/fr/nodeDefs.json (1)

9142-9144: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Add "compatible" to the LTXVSeparateAVLatent description.

The text still reads "tout modèle AV" ("any AV model"). A previous review on this exact line range asked to change this to "tout modèle AV compatible" ("any compatible AV model"), because the node supports specific AV models rather than every AV model. That change is not present in the current text.

🐛 Proposed wording
-    "description": "Sépare un latent AV conjoint en ses latents vidéo et audio (tout modèle AV, par ex. LTXV ou MiniMax H3).",
+    "description": "Sépare un latent AV conjoint en ses latents vidéo et audio (tout modèle AV compatible, par ex. LTXV ou MiniMax H3).",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/fr/nodeDefs.json` around lines 9142 - 9144, Update the
description for LTXVSeparateAVLatent to say “tout modèle AV compatible” instead
of “tout modèle AV”, preserving the rest of the French text unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/locales/es/nodeDefs.json`:
- Around line 5966-5968: Restore the missing resolution.tooltip translation
under GrokVideoNode.inputs.resolution in src/locales/es/nodeDefs.json
(5966-5968), src/locales/ar/nodeDefs.json (5966-5968),
src/locales/fa/nodeDefs.json (5966-5968), and src/locales/fr/nodeDefs.json
(5966-5968), using the corresponding translated tooltip defined by the English
locale.

---

Outside diff comments:
In `@scripts/i18n/update-locales.test.ts`:
- Around line 145-230: Add a Vitest case in the translateLocaleItems suite that
supplies enough items for multiple chunks and configures requestConcurrency
above one. Use promise-gated TranslateBatch calls to track active requests and
record the maximum concurrent count, then release them and assert all
translations complete while the maximum never exceeds
translationConfig.requestConcurrency. Ensure the test covers concurrent batch
dispatch without altering existing retry behavior.

---

Duplicate comments:
In `@src/locales/fr/nodeDefs.json`:
- Around line 9142-9144: Update the description for LTXVSeparateAVLatent to say
“tout modèle AV compatible” instead of “tout modèle AV”, preserving the rest of
the French text unchanged.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 102ad7f7-95c8-473b-89cc-276b164a81a6

📥 Commits

Reviewing files that changed from the base of the PR and between 4350fea and 014afd2.

📒 Files selected for processing (17)
  • .github/workflows/i18n-update-custom-nodes.yaml
  • scripts/i18n/translate.ts
  • scripts/i18n/update-locales.test.ts
  • scripts/i18n/update-locales.ts
  • src/locales/ar/nodeDefs.json
  • src/locales/es/nodeDefs.json
  • src/locales/fa/nodeDefs.json
  • src/locales/fr/nodeDefs.json
  • src/locales/he/nodeDefs.json
  • src/locales/it/nodeDefs.json
  • src/locales/ja/nodeDefs.json
  • src/locales/ko/nodeDefs.json
  • src/locales/pt-BR/nodeDefs.json
  • src/locales/ru/nodeDefs.json
  • src/locales/tr/nodeDefs.json
  • src/locales/zh-TW/nodeDefs.json
  • src/locales/zh/nodeDefs.json

Comment thread src/locales/es/nodeDefs.json Resolved
@codecov

codecov Bot commented Aug 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #15062      +/-   ##
==========================================
+ Coverage   80.90%   81.12%   +0.22%     
==========================================
  Files        1882     1882              
  Lines      111804   123862   +12058     
  Branches    31718    39031    +7313     
==========================================
+ Hits        90453   100484   +10031     
- Misses      20977    22821    +1844     
- Partials      374      557     +183     
Flag Coverage Δ
unit 72.54% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 373 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benceruleanlu
benceruleanlu marked this pull request as ready for review August 12, 2026 00:01
@benceruleanlu
benceruleanlu requested a review from a team August 12, 2026 00:01
@dosubot dosubot Bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Aug 12, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
scripts/i18n/translate.ts (1)

103-115: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Preserve a closed type at the translator boundary.

OpenAiTranslatorOptions.reasoningEffort widens the configuration union to string. Arbitrary values can then reach reasoning_effort without compile-time protection. Reuse one shared reasoning-effort type. Validate model-specific values before fetchFn if the factory supports multiple models.

As per path instructions: docs/guidance/typescript.md requires precise types and stable helper contracts.

Proposed type fix
 interface OpenAiTranslatorOptions {
   apiKey: string
   model: string
-  reasoningEffort: string
+  reasoningEffort: ReasoningEffort
   glossary: string
 }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/i18n/translate.ts` around lines 103 - 115, Update
OpenAiTranslatorOptions.reasoningEffort and the createOpenAiTranslator request
path to use the shared closed reasoning-effort type instead of string,
preserving compile-time rejection of arbitrary values. If the factory supports
multiple models, validate that the selected effort is supported for the
configured model before invoking fetchFn.

Source: Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/i18n/config.ts`:
- Line 11: Define and export a single ReasoningEffort type aligned with the
selected model’s API contract, then reuse it for
OpenAiTranslatorOptions.reasoningEffort in scripts/i18n/config.ts:11 and the
corresponding reasoning-effort declaration in scripts/i18n/translate.ts:103-115.
Preserve the supported 'max' value and ensure the API boundary no longer widens
the configured literal union to string.

---

Outside diff comments:
In `@scripts/i18n/translate.ts`:
- Around line 103-115: Update OpenAiTranslatorOptions.reasoningEffort and the
createOpenAiTranslator request path to use the shared closed reasoning-effort
type instead of string, preserving compile-time rejection of arbitrary values.
If the factory supports multiple models, validate that the selected effort is
supported for the configured model before invoking fetchFn.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2365ae98-4c0e-4f5a-aee2-82361351f0c8

📥 Commits

Reviewing files that changed from the base of the PR and between ca0aa0d and d8a4c2f.

📒 Files selected for processing (3)
  • scripts/i18n/config.ts
  • scripts/i18n/translate.ts
  • scripts/i18n/update-locales.ts

Comment thread scripts/i18n/config.ts Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 832c12d3eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/i18n/update-locales.ts Outdated
for (const leaf of collectLeaves(state.plan.source).values()) {
if (typeof leaf.value !== 'string') continue
if (pendingKeys.has(pathKey(leaf.path))) continue
if (protectedTokens(leaf.value, false).length === 0) continue

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Audit placeholders in unchanged locale entries

When the manifest is seeded with existing translations, this false excludes interpolation placeholders from the audit, so corrupted stable entries are permanently treated as valid. This is already observable in pt-BR/main.json: manager.changingVersion replaced {to} with the literal pt-BR, while g.itemsSelected uses {selectedCount} although its callers pass count; nevertheless locale:check reports no violation and normal runs retain both strings. Include interpolation tokens when auditing unchanged leaves so these entries are surfaced or regenerated.

Useful? React with 👍 / 👎.

Comment thread scripts/i18n/protected-tokens.ts Outdated
/\b\d+k\+\d+\b/g,
/(?<=['"“”「」])(?:match|max)(?=['"“”「」])/g
]
const interpolationPattern = /(?<!\\)\{[A-Za-z][A-Za-z0-9_.-]*\}/g

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Recognize numeric list-interpolation placeholders

When a message using Vue I18n list interpolation is regenerated, this pattern does not match placeholders such as {0}, {1}, and {2}. The current English resources use them in linearMode.error.mobileFixable and linearMode.error.getHelp, where <i18n-t> supplies linked components; if a translation drops or renumbers one, it is absent from preserve and tokenErrors accepts the broken result. Extend the recognized interpolation syntax to cover numeric placeholders.

Useful? React with 👍 / 👎.

Comment thread scripts/i18n/translate.ts
- Respond with a JSON object that maps every item "id" to its translated string — every id, no other keys, no commentary.
- Every substring listed in an item's "preserve" array must appear in the translation exactly as written, byte for byte. Never translate, transliterate, or renumber them.
- Interpolation placeholders such as {name} stay exactly as written.
- The | character separates plural forms. Keep the same number of forms and translate each form.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve locale-specific plural variant counts

When a pluralized source string is added or modified, forcing every locale to keep the English number of forms produces incorrect locale data: the existing Russian catalog deliberately uses three variants for many two-form English messages, while Chinese and Japanese commonly use one. The generated Russian message can therefore select the wrong grammar for some counts; instruct the translator to follow the target locale's Vue I18n plural forms instead of mirroring English.

AGENTS.md reference: AGENTS.md:L163-L163

Useful? React with 👍 / 👎.

Comment on lines +4 to +8
const protectedLiteralPatterns = [
/<(?:Picture|Video|Audio) [A-Za-z0-9]>/g,
/\b\d+k\+\d+\b/g,
/(?<=['"“”「」])(?:match|max)(?=['"“”「」])/g
]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Protect exact XML prompt tags

When affected node-definition tooltips are regenerated, the protected-token list ignores exact prompt syntax already present in English, notably <bbox>...</bbox> and <img>...</img>. Those strings explicitly tell users to type these tags, but a model may translate or alter them and validation will accept the result, leaving localized instructions that generate invalid prompts. Add these opening and closing tags to the protected literals.

Useful? React with 👍 / 👎.

@DrJKL DrJKL added the claude-review Add to trigger a PR code review from Claude Code label Aug 12, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/i18n/protected-tokens.ts`:
- Around line 115-121: Update auditProtectedLiterals in
scripts/i18n/protected-tokens.ts at lines 115-121 to traverse array elements and
compare protected tokens for every string element, including unchanged source
arrays, while preserving existing skip-key behavior. Add a
placeholder/protected-literal validation test in
scripts/i18n/update-locales.test.ts at lines 271-288 covering an unchanged array
whose target corrupts a <Picture 10> or 17k+5 token.

In `@src/locales/it/main.json`:
- Line 4625: Update the Italian seekVideo translation from “Sposta video” to a
seek-specific label such as “Scorri il video”, preserving the meaning of moving
the playback position rather than moving the video itself.

In `@src/locales/zh-TW/main.json`:
- Line 4625: Update the seekVideo localization value to use a
seek-within-current-video label, such as `定位影片`, instead of wording that means
searching for a video.

In `@src/locales/zh/nodeDefs.json`:
- Around line 892-893: Update the Seedance 2.5 tooltip wording at
src/locales/zh/nodeDefs.json lines 892-893, 933-934, and 986-987, and
src/locales/zh-TW/nodeDefs.json lines 892-893, 933-934, and 986-987. Replace the
opening clause stating it uses or suits the latest model with wording that
clearly says Seedance 2.5 is the latest model, while preserving the existing
duration and output-format details.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a7849e85-6a14-41a5-90ce-4c3df36dc63c

📥 Commits

Reviewing files that changed from the base of the PR and between ca0aa0d and 67716c9.

📒 Files selected for processing (32)
  • scripts/i18n/config.ts
  • scripts/i18n/locale-tree.ts
  • scripts/i18n/protected-tokens.ts
  • scripts/i18n/translate.ts
  • scripts/i18n/update-locales.test.ts
  • scripts/i18n/update-locales.ts
  • src/locales/ar/main.json
  • src/locales/ar/nodeDefs.json
  • src/locales/es/main.json
  • src/locales/es/nodeDefs.json
  • src/locales/fa/main.json
  • src/locales/fa/nodeDefs.json
  • src/locales/fr/main.json
  • src/locales/fr/nodeDefs.json
  • src/locales/he/main.json
  • src/locales/he/nodeDefs.json
  • src/locales/it/main.json
  • src/locales/it/nodeDefs.json
  • src/locales/ja/main.json
  • src/locales/ja/nodeDefs.json
  • src/locales/ko/main.json
  • src/locales/ko/nodeDefs.json
  • src/locales/pt-BR/main.json
  • src/locales/pt-BR/nodeDefs.json
  • src/locales/ru/main.json
  • src/locales/ru/nodeDefs.json
  • src/locales/tr/main.json
  • src/locales/tr/nodeDefs.json
  • src/locales/zh-TW/main.json
  • src/locales/zh-TW/nodeDefs.json
  • src/locales/zh/main.json
  • src/locales/zh/nodeDefs.json

Comment thread scripts/i18n/protected-tokens.ts Resolved
Comment thread src/locales/it/main.json
"play": "Riproduci",
"resolution": "{width} × {height}",
"retry": "Riprova",
"seekVideo": "Sposta video",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Translate seekVideo as a seek action.

"Sposta video" means “move video”. It does not describe moving the playback position. Use a seek-specific Italian label, such as "Scorri il video".

Proposed fix
-    "seekVideo": "Sposta video",
+    "seekVideo": "Scorri il video",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"seekVideo": "Sposta video",
"seekVideo": "Scorri il video",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/it/main.json` at line 4625, Update the Italian seekVideo
translation from “Sposta video” to a seek-specific label such as “Scorri il
video”, preserving the meaning of moving the playback position rather than
moving the video itself.

"play": "播放",
"resolution": "{width} × {height}",
"retry": "重試",
"seekVideo": "搜尋影片",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Use a seek label, not a video-search label.

搜尋影片 means “search for a video”. This control moves within the current video. Use wording such as 定位影片.

Proposed fix
-    "seekVideo": "搜尋影片",
+    "seekVideo": "定位影片",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"seekVideo": "搜尋影片",
"seekVideo": "定位影片",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/zh-TW/main.json` at line 4625, Update the seekVideo localization
value to use a seek-within-current-video label, such as `定位影片`, instead of
wording that means searching for a video.

Comment thread src/locales/zh/nodeDefs.json Resolved

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid replacement for lobe-i18n overall — rebuild-from-source, atomic validate-then-write, and the manifest-based invalidation are the right shape, and the tests cover the interesting paths. One finding I think should be addressed before this lands, plus a few smaller ones.

Main issue: the pipeline's headline claim ("validates that interpolation placeholders … survive translation") only holds for keys the manifest marks as added/modified. Seeding the manifest to the current English sources means every pre-existing placeholder corruption is grandfathered permanently and is invisible to pnpm locale:check. I scanned this branch's committed locales against en/: 148 keys across 12 locales have a placeholder set that differs from the English source. Details inline on protected-tokens.ts. it/main.json changingVersion — hand-fixed in this PR — is one instance of exactly that class; the other 148 were not found because nothing looks for them.

The fix is small and belongs here, while the baseline is being established.

Comment thread scripts/i18n/protected-tokens.ts Outdated
for (const [key, leaf] of collectLeaves(source)) {
if (typeof leaf.value !== 'string') continue
if (skipKeys.has(key)) continue
if (protectedTokens(leaf.value, false).length === 0) continue

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[correctness] high — the standing audit is placeholder-blind, so 148 already-broken strings are grandfathered by the new manifest baseline.

auditProtectedLiterals is the only check that runs over unchanged keys, and it passes includeInterpolation: false, so it only looks at <Picture N> / 17k+5 / quoted match|max. Interpolation placeholders are validated in exactly two places, both of which skip pre-existing translations:

  • validateLocale's first loop — only changes.added + changes.modified
  • translateLocaleItems — only strings actually sent to the model

Because the seeded manifest equals the current en/*.json, nothing is added/modified on the next run, and collectPendingLeaves sees string vs string so nothing is pending either. Net effect: pnpm locale:check reports "fully converged" while these remain, forever.

Scanning this branch's committed locales against en/ with the same interpolationPattern used here: 148 mismatches — zh 18, ja 16, zh-TW 15, ko 15, ru 14, fr 14, es 14, ar 14, pt-BR 10, tr 9, fa 8, he 1. These are live UI bugs, not cosmetic:

zh g.searchPlaceholder      EN "Search {subject}..."                    TR "搜索占位符"   (literally "search placeholder")
zh g.enabling               EN "Enabling {id}"                          TR "启用中"
zh workspacePanel.inviteLimitReached
                            EN "You've reached the maximum of {count} members"
                            TR "您已达到最多 50 名成员的上限"          (count hardcoded to 50)
zh workspacePanel.members.membersCount
                            EN "{count} of {maxSeats} members"          TR "{count}/50 名成员"
zh g.itemsSelected          EN "... | {count} item selected | ..."      TR "已选择 {selectedCount} 项"  (placeholder that is never passed → renders empty)
zh manager.failed           EN "Failed"                                 TR "失败 ({count})"           (extra placeholder → renders empty)
zh assetBrowser.uploadModelDescription2
                            EN "Only links from {link} are supported at the moment"
                            TR "目前仅支持 <a href=…>https://civitai.com</a> 链接。"  (raw HTML baked in where the source now uses a placeholder)

Suggested fix — make the placeholder check part of the standing audit and let it drive re-translation:

  1. Add a placeholder-parity check over all string leaves (source vs existing) in both reportCheck and collectPendingLeaves.
  2. Treat a mismatch the same as invalidated, so pnpm locale repairs them on the next run instead of preserving them.

That is one predicate reused in two places, and it turns FE-1499's "stale strings stay stale" guarantee into something the pipeline actually enforces. Without it, merging this permanently enshrines the 148.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concrete proof this is load-bearing, from the current head:

manager.changingVersion — EN "Changing version from {from} to {to}"

ok      it: "Cambio versione da {from} a {to}"        <- hand-fixed in this PR
BROKEN  pt-BR: "Alterando versão de {from} para pt-BR"

Same key, same failure mode (the locale code substituted for {to}). it was found by eye and repaired here; pt-BR is untouched at head and pnpm locale:check reports the tree fully converged. That is the blind spot in one line — and it is the whole point of FE-1499.

For what it's worth, the Codex bot flagged the same thing independently ("Audit placeholders in unchanged locale entries", P2) and landed on the same pt-BR/manager.changingVersion example. Its sibling finding about {0} list interpolation is already fixed by 67716c9; this one is not.

Comment thread scripts/i18n/locale-tree.ts Outdated
if (!isTranslatableLeaf(leaf.value)) continue
if (
invalidated.has(key) ||
!leafShapeMatches(leaf.value, getLeaf(existing, leaf.path))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[correctness] high — companion to the protected-tokens.ts comment.

leafShapeMatches for two strings is typeof target === 'string', so a translation that dropped every {placeholder} still "matches shape" and is never marked pending. This is the second half of why the 148 corrupted strings are invisible: nothing invalidates them, so rebuildLocale copies them straight through.

A placeholder-set comparison here (source vs existing) would make them pending and get them repaired automatically.

})
return parseLocale(content, `${filename}@${hash}`)
} catch {
throw new Error(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[reliability] medium — this is an unrecoverable hard failure in a release-blocking workflow.

If git cat-file blob <hash> fails for any reason — a shallow/non-promisor clone, an object GC'd before it was ever reachable from a pushed commit, a rewritten branch, a transient failure of the lazy blob fetch — pnpm locale aborts entirely and there is no path forward except hand-editing .source-manifest.json. The catch {} also swallows a JSON parse failure of a perfectly readable blob and reports it as a history problem, which will send whoever hits it down the wrong trail.

Suggest degrading instead of aborting: warn, treat the baseline as "unknown" for that file (previous = source, i.e. no invalidation — backfill missing keys only), and let the run proceed. That keeps the failure mode no worse than today's lobe-i18n behavior rather than blocking the release. At minimum, distinguish the parse error from the fetch error.

// must match what gets committed: normalize to the same serialization
// serializeLocale produces (collect-i18n omits the newline oxfmt adds)
const canonical = serializeLocale(source)
if (!check && raw !== canonical) writeFileSync(entryFile, canonical)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[reliability] medium — the manifest's correctness depends on an unenforced coupling between serializeLocale and oxfmt.

writeManifest hashes these files at the end of the run, but i18n-update-core.yaml runs pnpm locale && pnpm format — so oxfmt gets the last word on the bytes that are committed. I verified today they agree (JSON.stringify(…, null, 2) + '\n' is byte-identical to oxfmt's output for all four en/*.json, and the manifest hashes in this PR do match the committed blobs). But nothing enforces it. If oxfmt's JSON formatting ever changes, the recorded hash points at a blob that is written locally by hash-object -w and never pushed — and the next CI run hard-fails at readManifestSource with a misleading "run from a clone with full history" message.

Cheapest guard: add src/locales/**/*.json to .oxfmtrc.json ignorePatterns so this pipeline is the sole writer of those bytes. Alternatively re-read and re-verify after pnpm format, or drop && pnpm format from the workflow step.

Comment thread scripts/i18n/translate.ts
.map((item) => ` ${item.context}`)
.slice(0, 20)
.join('\n')
throw new Error(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[reliability] low SHOULD-FIX — one chunk that stays corrupted after 3 rounds throws, mapWithConcurrency's Promise.all rejects, run() aborts, and nothing is written. Every other locale's completed translation work is discarded and paid for again on the retry. With 13 locales × 4 files this is a real cost/wall-clock hazard on a large backfill.

Also worth checking choices[0].finish_reason === 'length' explicitly: with maxItemsPerRequest: 40 and no max_completion_tokens, a truncated response surfaces as a JSON parse error and burns all four attempts before anyone sees why.

Comment thread package.json
"lint:desktop": "pnpm --filter @comfyorg/desktop-ui run lint",
"locale": "lobe-i18n locale",
"locale": "tsx scripts/i18n/update-locales.ts",
"locale:check": "tsx scripts/i18n/update-locales.ts --check",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[quality] low SHOULD-FIX — locale:check is offline and cheap but isn't wired into any CI job, so drift is only caught during a release run where OPENAI_API_KEY is present and a failure blocks the release. Consider adding it to the standard PR checks; that is also where the placeholder audit from the protected-tokens.ts comment would earn its keep.

@benceruleanlu
benceruleanlu force-pushed the bl/in-house-i18n-pipeline-1b91ce branch from 67716c9 to 440d24a Compare August 12, 2026 07:43
@benceruleanlu
benceruleanlu changed the base branch from main to bl/fix-i18n-locale-data August 12, 2026 07:43
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 13

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/i18n-update-custom-nodes.yaml:
- Line 84: Update the copy command in the i18n update workflow to copy from
temp/diff/. instead of using the unmatched * glob, so an empty diff directory
becomes a successful no-op while existing locale files are still copied.

In `@scripts/i18n/translate.ts`:
- Around line 141-148: Update the retry handling in the OpenAI request flow to
honor a valid Retry-After response header for 429 statuses by waiting at least
the specified duration before continuing. Fall back to the existing fixed retry
delay when the header is absent or invalid, while preserving current behavior
for other retryable statuses.

In `@scripts/i18n/update-locales.test.ts`:
- Around line 178-186: Extend the tests for translateLocaleItems with an
empty-translation retry case: use a translator that returns whitespace on the
first attempt and a valid translation afterward, then assert the final
translated value and the retry note text indicating “empty translation.” Keep
the existing corrupted-token test unchanged and place the new case alongside the
retry/error coverage.

In `@scripts/i18n/update-locales.ts`:
- Around line 167-181: Extract the inline manifest validation into an
isSourceManifest(value: unknown): value is SourceManifest type guard, placed in
the appropriate lightweight leaf module. Update the surrounding logic to call
this predicate and return manifest directly after successful narrowing, removing
the trailing manifest as SourceManifest assertion while preserving all existing
validation checks.
- Around line 332-333: Validate manifest hashes before they reach
readManifestSource and git, accepting only hexadecimal object IDs of the
expected length; reject invalid entries such as option-like strings. Apply this
in the hash handling near loadManifest or before the readManifestSource call,
while preserving valid hash processing.

In `@src/locales/CONTRIBUTING.md`:
- Around line 53-59: Document the git-history prerequisite beside the OpenAI API
key prerequisite in the locale contributor instructions, noting that local runs
require a non-shallow clone. Update protected-token validation to compare
interpolation tokens for unchanged translations and traverse array elements
rather than skipping non-string leaves; update leafShapeMatches so
collectPendingLeaves reprocesses mismatched translations. Export the named
ReasoningEffort union from config and use it for
OpenAiTranslatorOptions.reasoningEffort in translate instead of string.

In `@src/locales/es/main.json`:
- Line 4909: Update the matchedModelCount translation so the singular form
“coincidencia” appears before the plural form “coincidencias,” preserving the
existing placeholders and separator.

In `@src/locales/fr/main.json`:
- Around line 3439-3440: Update the French translation for
openHuggingFaceRepoDesktop to make the new-tab fallback explicit by placing
“peut s’ouvrir dans un nouvel onglet” in parentheses, or remove that fragment if
it represents a separate action already covered by openHuggingFaceRepoNewTab.
- Around line 4897-4902: Update the French count labels in the locale entries
around disableAllCount, disableMatchingCount, enableAllCount, and
enableMatchingCount so singular and plural variants consistently appear in
singular-then-plural order, with {count} placed before the noun rather than
after it. Apply the same correction to the matchedModelCount entry noted in the
review.

In `@src/locales/it/main.json`:
- Around line 4900-4902: Update the Italian disableMatchingCount and
enableMatchingCount labels so the count appears before provider: use the
singular form for count 1 and the plural form for other counts, preserving the
existing disable/enable wording and plural agreement.

In `@src/locales/ko/main.json`:
- Line 4908: Update the loading translation value in the Korean locale to use
the object particle, changing it to “파트너 노드 접근을 불러오는 중” while leaving the
surrounding locale entries unchanged.
- Around line 3439-3440: Update the Korean labels openHuggingFaceRepoDesktop and
openHuggingFaceRepoNewTab to use 저장소 instead of 리포지토리, matching the existing
terminology for Hugging Face repositories.

In `@src/locales/pt-BR/main.json`:
- Around line 4897-4902: Update the Portuguese pluralized labels
disableAllCount, disableMatchingCount, enableAllCount, and enableMatchingCount
so {count} is expressed as a quantity of providers, using count-first phrasing
for both singular and plural variants; preserve the existing translation
meaning.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3d429f5b-3469-45d4-ab39-711dff595ebf

📥 Commits

Reviewing files that changed from the base of the PR and between 2026348 and 440d24a.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (42)
  • .github/workflows/i18n-update-core.yaml
  • .github/workflows/i18n-update-custom-nodes.yaml
  • .github/workflows/i18n-update-nodes.yaml
  • .i18nrc.cjs
  • .oxlintrc.json
  • eslint.config.ts
  • package.json
  • pnpm-workspace.yaml
  • scripts/i18n/config.ts
  • scripts/i18n/locale-tree.ts
  • scripts/i18n/protected-tokens.ts
  • scripts/i18n/translate.ts
  • scripts/i18n/update-locales.test.ts
  • scripts/i18n/update-locales.ts
  • src/locales/.source-manifest.json
  • src/locales/CONTRIBUTING.md
  • src/locales/ar/main.json
  • src/locales/ar/nodeDefs.json
  • src/locales/es/main.json
  • src/locales/es/nodeDefs.json
  • src/locales/fa/main.json
  • src/locales/fa/nodeDefs.json
  • src/locales/fr/main.json
  • src/locales/fr/nodeDefs.json
  • src/locales/he/main.json
  • src/locales/he/nodeDefs.json
  • src/locales/it/main.json
  • src/locales/it/nodeDefs.json
  • src/locales/ja/main.json
  • src/locales/ja/nodeDefs.json
  • src/locales/ko/main.json
  • src/locales/ko/nodeDefs.json
  • src/locales/pt-BR/main.json
  • src/locales/pt-BR/nodeDefs.json
  • src/locales/ru/main.json
  • src/locales/ru/nodeDefs.json
  • src/locales/tr/main.json
  • src/locales/tr/nodeDefs.json
  • src/locales/zh-TW/main.json
  • src/locales/zh-TW/nodeDefs.json
  • src/locales/zh/main.json
  • src/locales/zh/nodeDefs.json
💤 Files with no reviewable changes (4)
  • pnpm-workspace.yaml
  • .i18nrc.cjs
  • .oxlintrc.json
  • eslint.config.ts

Comment thread scripts/i18n/translate.ts Resolved
Comment thread scripts/i18n/update-locales.test.ts Resolved
Comment on lines +167 to +181
if (
!manifest ||
typeof manifest !== 'object' ||
!('version' in manifest) ||
manifest.version !== 1 ||
!('files' in manifest) ||
!manifest.files ||
typeof manifest.files !== 'object' ||
Array.isArray(manifest.files) ||
!Object.values(manifest.files).every((hash) => typeof hash === 'string')
) {
throw new Error(`${filename} has an invalid source manifest`)
}
return manifest as SourceManifest
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Replace the trailing assertion with a type guard.

Line 180 asserts manifest as SourceManifest after the inline checks. Extract the checks into an isSourceManifest(value: unknown): value is SourceManifest predicate so the narrowing is carried by the type system.

As per path instructions, docs/guidance/typescript.md requires: "use precise types throughout: avoid any, as any, unnecessary assertions, and @ts-expect-error; narrow unknown values with type guards. Place reusable type guards in lightweight leaf modules to prevent circular dependencies."

🧰 Tools
🪛 ast-grep (0.45.1)

[warning] Importing child_process exposes a command-execution surface; ensure any command/argument built from input is validated, and prefer execFile/spawn with an argument array over exec.
Context: import { execFileSync } from 'node:child_process'
Note: [CWE-78] Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection').

(detect-child-process-typescript)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/i18n/update-locales.ts` around lines 167 - 181, Extract the inline
manifest validation into an isSourceManifest(value: unknown): value is
SourceManifest type guard, placed in the appropriate lightweight leaf module.
Update the surrounding logic to call this predicate and return manifest directly
after successful narrowing, removing the trailing manifest as SourceManifest
assertion while preserving all existing validation checks.

Source: Path instructions

Comment thread scripts/i18n/update-locales.ts Resolved
Comment thread src/locales/CONTRIBUTING.md Resolved
@benceruleanlu
benceruleanlu force-pushed the bl/fix-i18n-locale-data branch from 6d6a6fa to 6045f54 Compare August 12, 2026 07:51
@benceruleanlu
benceruleanlu force-pushed the bl/in-house-i18n-pipeline-1b91ce branch from 440d24a to c40e2c6 Compare August 12, 2026 07:51

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.

Actionable comments posted: 13

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/i18n-update-custom-nodes.yaml:
- Line 84: Update the copy command in the i18n update workflow to copy from
temp/diff/. instead of using the unmatched * glob, so an empty diff directory
becomes a successful no-op while existing locale files are still copied.

In `@scripts/i18n/translate.ts`:
- Around line 141-148: Update the retry handling in the OpenAI request flow to
honor a valid Retry-After response header for 429 statuses by waiting at least
the specified duration before continuing. Fall back to the existing fixed retry
delay when the header is absent or invalid, while preserving current behavior
for other retryable statuses.

In `@scripts/i18n/update-locales.test.ts`:
- Around line 178-186: Extend the tests for translateLocaleItems with an
empty-translation retry case: use a translator that returns whitespace on the
first attempt and a valid translation afterward, then assert the final
translated value and the retry note text indicating “empty translation.” Keep
the existing corrupted-token test unchanged and place the new case alongside the
retry/error coverage.

In `@scripts/i18n/update-locales.ts`:
- Around line 167-181: Extract the inline manifest validation into an
isSourceManifest(value: unknown): value is SourceManifest type guard, placed in
the appropriate lightweight leaf module. Update the surrounding logic to call
this predicate and return manifest directly after successful narrowing, removing
the trailing manifest as SourceManifest assertion while preserving all existing
validation checks.
- Around line 332-333: Validate manifest hashes before they reach
readManifestSource and git, accepting only hexadecimal object IDs of the
expected length; reject invalid entries such as option-like strings. Apply this
in the hash handling near loadManifest or before the readManifestSource call,
while preserving valid hash processing.

In `@src/locales/CONTRIBUTING.md`:
- Around line 53-59: Document the git-history prerequisite beside the OpenAI API
key prerequisite in the locale contributor instructions, noting that local runs
require a non-shallow clone. Update protected-token validation to compare
interpolation tokens for unchanged translations and traverse array elements
rather than skipping non-string leaves; update leafShapeMatches so
collectPendingLeaves reprocesses mismatched translations. Export the named
ReasoningEffort union from config and use it for
OpenAiTranslatorOptions.reasoningEffort in translate instead of string.

In `@src/locales/es/main.json`:
- Line 4909: Update the matchedModelCount translation so the singular form
“coincidencia” appears before the plural form “coincidencias,” preserving the
existing placeholders and separator.

In `@src/locales/fr/main.json`:
- Around line 3439-3440: Update the French translation for
openHuggingFaceRepoDesktop to make the new-tab fallback explicit by placing
“peut s’ouvrir dans un nouvel onglet” in parentheses, or remove that fragment if
it represents a separate action already covered by openHuggingFaceRepoNewTab.
- Around line 4897-4902: Update the French count labels in the locale entries
around disableAllCount, disableMatchingCount, enableAllCount, and
enableMatchingCount so singular and plural variants consistently appear in
singular-then-plural order, with {count} placed before the noun rather than
after it. Apply the same correction to the matchedModelCount entry noted in the
review.

In `@src/locales/it/main.json`:
- Around line 4900-4902: Update the Italian disableMatchingCount and
enableMatchingCount labels so the count appears before provider: use the
singular form for count 1 and the plural form for other counts, preserving the
existing disable/enable wording and plural agreement.

In `@src/locales/ko/main.json`:
- Line 4908: Update the loading translation value in the Korean locale to use
the object particle, changing it to “파트너 노드 접근을 불러오는 중” while leaving the
surrounding locale entries unchanged.
- Around line 3439-3440: Update the Korean labels openHuggingFaceRepoDesktop and
openHuggingFaceRepoNewTab to use 저장소 instead of 리포지토리, matching the existing
terminology for Hugging Face repositories.

In `@src/locales/pt-BR/main.json`:
- Around line 4897-4902: Update the Portuguese pluralized labels
disableAllCount, disableMatchingCount, enableAllCount, and enableMatchingCount
so {count} is expressed as a quantity of providers, using count-first phrasing
for both singular and plural variants; preserve the existing translation
meaning.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3d429f5b-3469-45d4-ab39-711dff595ebf

📥 Commits

Reviewing files that changed from the base of the PR and between 2026348 and 440d24a.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (42)
  • .github/workflows/i18n-update-core.yaml
  • .github/workflows/i18n-update-custom-nodes.yaml
  • .github/workflows/i18n-update-nodes.yaml
  • .i18nrc.cjs
  • .oxlintrc.json
  • eslint.config.ts
  • package.json
  • pnpm-workspace.yaml
  • scripts/i18n/config.ts
  • scripts/i18n/locale-tree.ts
  • scripts/i18n/protected-tokens.ts
  • scripts/i18n/translate.ts
  • scripts/i18n/update-locales.test.ts
  • scripts/i18n/update-locales.ts
  • src/locales/.source-manifest.json
  • src/locales/CONTRIBUTING.md
  • src/locales/ar/main.json
  • src/locales/ar/nodeDefs.json
  • src/locales/es/main.json
  • src/locales/es/nodeDefs.json
  • src/locales/fa/main.json
  • src/locales/fa/nodeDefs.json
  • src/locales/fr/main.json
  • src/locales/fr/nodeDefs.json
  • src/locales/he/main.json
  • src/locales/he/nodeDefs.json
  • src/locales/it/main.json
  • src/locales/it/nodeDefs.json
  • src/locales/ja/main.json
  • src/locales/ja/nodeDefs.json
  • src/locales/ko/main.json
  • src/locales/ko/nodeDefs.json
  • src/locales/pt-BR/main.json
  • src/locales/pt-BR/nodeDefs.json
  • src/locales/ru/main.json
  • src/locales/ru/nodeDefs.json
  • src/locales/tr/main.json
  • src/locales/tr/nodeDefs.json
  • src/locales/zh-TW/main.json
  • src/locales/zh-TW/nodeDefs.json
  • src/locales/zh/main.json
  • src/locales/zh/nodeDefs.json
💤 Files with no reviewable changes (4)
  • pnpm-workspace.yaml
  • .i18nrc.cjs
  • .oxlintrc.json
  • eslint.config.ts
🛑 Comments failed to post (8)
.github/workflows/i18n-update-custom-nodes.yaml (1)

84-84: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Handle an empty diff directory before copying.

At Line 84, the * glob has no match when no locale additions exist. The shell passes the literal path to cp, so a valid no-op run fails.

Use temp/diff/. or an explicit empty-directory guard.

Proposed fix
-          cp -rf temp/diff/* "$LOCALE_DIR"
+          cp -rf temp/diff/. "$LOCALE_DIR"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

          cp -rf temp/diff/. "$LOCALE_DIR"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/i18n-update-custom-nodes.yaml at line 84, Update the copy
command in the i18n update workflow to copy from temp/diff/. instead of using
the unmatched * glob, so an empty diff directory becomes a successful no-op
while existing locale files are still copied.
src/locales/es/main.json (1)

4909-4909: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Put the singular form first.

Line 4909 uses coincidencias | coincidencia. The singular and plural forms are reversed. Use "{matched} de {total} coincidencia | {matched} de {total} coincidencias" so the count renders the correct noun form.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/es/main.json` at line 4909, Update the matchedModelCount
translation so the singular form “coincidencia” appears before the plural form
“coincidencias,” preserving the existing placeholders and separator.
src/locales/fr/main.json (2)

3439-3440: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the desktop fallback explicit.

openHuggingFaceRepoDesktop joins an action label with the fragment peut s’ouvrir dans un nouvel onglet. If the new-tab behavior is a fallback, use parentheses. If it is a separate action, remove it because openHuggingFaceRepoNewTab already covers that action.

Proposed wording
-      "openHuggingFaceRepoDesktop": "Ouvrir le dépôt Hugging Face de {model} dans l’application de bureau ; peut s’ouvrir dans un nouvel onglet",
+      "openHuggingFaceRepoDesktop": "Ouvrir le dépôt Hugging Face de {model} dans l’application de bureau (peut s’ouvrir dans un nouvel onglet)",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

      "openHuggingFaceRepoDesktop": "Ouvrir le dépôt Hugging Face de {model} dans l’application de bureau (peut s’ouvrir dans un nouvel onglet)",
      "openHuggingFaceRepoNewTab": "Ouvrir le dépôt Hugging Face de {model} dans un nouvel onglet",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/fr/main.json` around lines 3439 - 3440, Update the French
translation for openHuggingFaceRepoDesktop to make the new-tab fallback explicit
by placing “peut s’ouvrir dans un nouvel onglet” in parentheses, or remove that
fragment if it represents a separate action already covered by
openHuggingFaceRepoNewTab.

4897-4902: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Fix the French count and plural forms.

The singular count labels place {count} after the noun, which reads as an identifier. matchedModelCount also reverses the singular and plural variants. Put the count before the noun and keep the singular form before the plural form.

Proposed wording
-      "disableAllCount": "Désactiver le fournisseur {count} | Désactiver les {count} fournisseurs",
+      "disableAllCount": "Désactiver {count} fournisseur | Désactiver {count} fournisseurs",
-      "disableMatchingCount": "Désactiver le fournisseur correspondant {count} | Désactiver les fournisseurs correspondants {count}",
+      "disableMatchingCount": "Désactiver {count} fournisseur correspondant | Désactiver {count} fournisseurs correspondants",
-      "enableAllCount": "Activer le fournisseur {count} | Activer les {count} fournisseurs",
+      "enableAllCount": "Activer {count} fournisseur | Activer {count} fournisseurs",
-      "enableMatchingCount": "Activer le fournisseur correspondant {count} | Activer les fournisseurs correspondants {count}",
+      "enableMatchingCount": "Activer {count} fournisseur correspondant | Activer {count} fournisseurs correspondants",
-      "matchedModelCount": "{matched} correspondances sur {total} | {matched} correspondance sur {total}",
+      "matchedModelCount": "{matched} correspondance sur {total} | {matched} correspondances sur {total}",

Also applies to: 4909-4909

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/fr/main.json` around lines 4897 - 4902, Update the French count
labels in the locale entries around disableAllCount, disableMatchingCount,
enableAllCount, and enableMatchingCount so singular and plural variants
consistently appear in singular-then-plural order, with {count} placed before
the noun rather than after it. Apply the same correction to the
matchedModelCount entry noted in the review.
src/locales/it/main.json (1)

4900-4902: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Move {count} before provider in the Italian matching-count labels.

When {count} is 1, the current strings render Disabilita il provider corrispondente 1 and Abilita il provider corrispondente 1. Use the singular and plural forms below.

Proposed fix
-      "disableMatchingCount": "Disabilita il provider corrispondente {count} | Disabilita i {count} provider corrispondenti",
+      "disableMatchingCount": "Disabilita {count} provider corrispondente | Disabilita {count} provider corrispondenti",
-      "enableMatchingCount": "Abilita il provider corrispondente {count} | Abilita i {count} provider corrispondenti",
+      "enableMatchingCount": "Abilita {count} provider corrispondente | Abilita {count} provider corrispondenti",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

      "disableMatchingCount": "Disabilita {count} provider corrispondente | Disabilita {count} provider corrispondenti",
      "enableAllCount": "Abilita tutti i {count} provider | Abilita tutti i {count} provider",
      "enableMatchingCount": "Abilita {count} provider corrispondente | Abilita {count} provider corrispondenti",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/it/main.json` around lines 4900 - 4902, Update the Italian
disableMatchingCount and enableMatchingCount labels so the count appears before
provider: use the singular form for count 1 and the plural form for other
counts, preserving the existing disable/enable wording and plural agreement.
src/locales/ko/main.json (2)

3439-3440: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Use one Korean term for the Hugging Face repository.

Line 3438 uses 저장소, but these new labels use 리포지토리 for the same concept. Use 저장소 in both new labels to keep the missing-model actions consistent.

Proposed wording
-      "openHuggingFaceRepoDesktop": "데스크톱 앱에서 {model}의 Hugging Face 리포지토리 열기(새 탭에서 열릴 수 있음)",
-      "openHuggingFaceRepoNewTab": "새 탭에서 {model}의 Hugging Face 리포지토리 열기",
+      "openHuggingFaceRepoDesktop": "데스크톱 앱에서 {model}의 Hugging Face 저장소 열기(새 탭에서 열릴 수 있음)",
+      "openHuggingFaceRepoNewTab": "새 탭에서 {model}의 Hugging Face 저장소 열기",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

      "openHuggingFaceRepoDesktop": "데스크톱 앱에서 {model}의 Hugging Face 저장소 열기(새 탭에서 열릴 수 있음)",
      "openHuggingFaceRepoNewTab": "새 탭에서 {model}의 Hugging Face 저장소 열기",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/ko/main.json` around lines 3439 - 3440, Update the Korean labels
openHuggingFaceRepoDesktop and openHuggingFaceRepoNewTab to use 저장소 instead of
리포지토리, matching the existing terminology for Hugging Face repositories.

4908-4908: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add the object particle to the loading label.

loadError uses 파트너 노드 접근을, but loading omits 을. Use 파트너 노드 접근을 불러오는 중 for natural Korean.

Proposed wording
-      "loading": "파트너 노드 접근 불러오는 중",
+      "loading": "파트너 노드 접근을 불러오는 중",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

      "loading": "파트너 노드 접근을 불러오는 중",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/ko/main.json` at line 4908, Update the loading translation value
in the Korean locale to use the object particle, changing it to “파트너 노드 접근을 불러오는
중” while leaving the surrounding locale entries unchanged.
src/locales/pt-BR/main.json (1)

4897-4902: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Render {count} as a quantity, not a provider identifier.

These labels can render text such as Desativar o provedor 3. The keys describe bulk provider counts, so the text must describe three providers.

Use count-first Portuguese phrasing for the disable and enable variants.

Proposed fix
-      "disableAllCount": "Desativar o provedor {count} | Desativar todos os {count} provedores",
+      "disableAllCount": "Desativar {count} provedor | Desativar todos os {count} provedores",
-      "disableMatchingCount": "Desativar o provedor correspondente {count} | Desativar os {count} provedores correspondentes",
+      "disableMatchingCount": "Desativar {count} provedor correspondente | Desativar {count} provedores correspondentes",
-      "enableAllCount": "Ativar o provedor {count} | Ativar todos os {count} provedores",
+      "enableAllCount": "Ativar {count} provedor | Ativar todos os {count} provedores",
-      "enableMatchingCount": "Ativar o provedor correspondente {count} | Ativar os {count} provedores correspondentes",
+      "enableMatchingCount": "Ativar {count} provedor correspondente | Ativar {count} provedores correspondentes",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

      "disableAllCount": "Desativar {count} provedor | Desativar todos os {count} provedores",
      "disableAllMessage": "Todos os provedores serão desativados. Os nós de parceiros ficarão indisponíveis enquanto o acesso estiver restrito.",
      "disableAllTitle": "Desabilitar todos os provedores?",
      "disableMatchingCount": "Desativar {count} provedor correspondente | Desativar {count} provedores correspondentes",
      "enableAllCount": "Ativar {count} provedor | Ativar todos os {count} provedores",
      "enableMatchingCount": "Ativar {count} provedor correspondente | Ativar {count} provedores correspondentes",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/pt-BR/main.json` around lines 4897 - 4902, Update the Portuguese
pluralized labels disableAllCount, disableMatchingCount, enableAllCount, and
enableMatchingCount so {count} is expressed as a quantity of providers, using
count-first phrasing for both singular and plural variants; preserve the
existing translation meaning.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at c40e2c67. No pipeline code changed — all six files under scripts/i18n/ are byte-identical to 67716c9e, so all six findings from my previous review stand unaddressed. What changed is structural: the branch was squashed and rebased onto newer main, and the base was retargeted to bl/fix-i18n-locale-data (#15137).

The split is a good call — the pipeline is much easier to review without 26 locale JSON files in the diff. Two things to flag though.

1. #15137 does not repair this class of corruption. I re-ran the placeholder audit across both heads. #15137 fixed zero of the 148 mismatches I reported. pt-BR/manager.changingVersion is still "Alterando versao de {from} para pt-BR" at this head — the same key the author hand-fixed for it, in a PR titled "repair stale and malformed locale data." If #15137 is meant to be the data-repair half of this work, this class is its most obvious gap.

2. The count went up during review — 148 to 161. Every locale gained one, including it, which was previously clean. Details inline. That the number moved in the wrong direction while the PR sat in review, by exactly the mechanism the pipeline is supposed to prevent, is the argument for fixing the audit here rather than in a follow-up.

Manifest integrity re-verified at this head: all four recorded hashes still match the committed en/*.json blobs.

Comment thread scripts/i18n/protected-tokens.ts Outdated
for (const [key, leaf] of collectLeaves(source)) {
if (typeof leaf.value !== 'string') continue
if (skipKeys.has(key)) continue
if (protectedTokens(leaf.value, false).length === 0) continue

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[correctness] high — still unaddressed, and the drift got worse during review: 148 to 161 placeholder mismatches.

The rebase pulled in a newly-broken key, corrupted in all 13 locales at once:

EN  rightSidePanel.missingModels.gatedModelsHint
    "{count} model is gated. To download it, sign in to Hugging Face and accept
     its license agreement. | {count} models are gated. To download them, ..."

it  "Alcuni modelli sono protetti. Per scaricarli, accedi a Hugging Face e ..."
fr  "Certains modeles sont restreints. Pour les telecharger, connectez-vous ..."
zh  "部分模型为受限模型。要下载这些模型,请登录 Hugging Face 并同意模型许可协议。"
ja  "一部のモデルは制限されています。ダウンロードするには..."

The English was changed to a two-form plural carrying {count}; every translation is a single form with no {count} at all, so none of them can render the number. This is precisely the FE-1499 failure mode — English changed, translations stayed stale.

Why this PR will not catch it: the manifest at this head records the current en/main.json (b417a114), which already contains the {count} version. So on the next run gatedModelsHint is neither added nor modified, so it is not invalidated; leafShapeMatches sees string vs string, so it is not pending; and this line's includeInterpolation: false means the standing audit never looks at {count}. pnpm locale:check will report the tree fully converged.

Note what happened here: the corruption landed on main while this PR was in review, and merging as-is freezes it into the baseline permanently. That is the case for fixing the audit in this PR rather than deferring — every day the baseline is seeded later, it grandfathers more. Same suggested fix as before: compare placeholder sets over all string leaves and treat a mismatch as invalidated so pnpm locale repairs them.

(Also worth deciding deliberately: 161 of these repaired at once is a meaningful translation spend. Gating the repair behind a flag, or landing it as a one-time backfill, are both reasonable — but silently grandfathering them is not.)

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the whole pipeline end to end, plus the history of what it replaces. Recording the conclusion up front: I think this should land.

I came into this worried that replacing @lobehub/i18n-cli trades a working, quietly-maintained dependency for a maintenance burden. I dug into whether that is true and it mostly is not, so I want the reasoning on the record rather than sitting in my head:

  • The bug is structural, not a regression. lobe computes just-diff(target, entry) and keeps only the add and remove ops; the replace op is computed and discarded. A key-structure equality check upstream of that means a value-only edit skips the file entirely — no request, no write, no log line. The same filter is in 1.20.1, the version adopted in #1751 in Dec 2024. It has never worked.
  • Replaying the git history of the English locale files: 644 English strings have been edited in place and never retranslated — 351 in nodeDefs.json, 293 in main.json, earliest 2024-12. Still live on main today: the SamplerER_SDE eta tooltip describes a limitation that was deleted from the English, in all 13 locales.
  • lobe is 5,800 LOC but the path pnpm locale executes is ~815 of them; markdown translation, the TUI, the config wizard and the lint command are dead weight for us. Upstream shipped three releases in the last fourteen months. And its package exports exactly one symbol, defineConfig — the diff, chunker and translator are bundled into the CLI and unreachable — so "keep the engine, own the invalidation" is only possible by mutating files on disk and shelling out. That constraint is why #15024 was 600–700 lines, and it is the strongest argument for this PR.
  • Splitting the data repairs into #15137 and landing them first was the right call. Seeding the manifest before the repairs would have declared all 644 stale strings fresh and frozen them permanently. Worth saying out loud.

Everything below is diff-level. Nothing here is architectural and nothing suggests restarting — I would like to iterate on this branch rather than reopen the approach.

Blocking

  1. translate.ts L143 — the finish_reason: "length" retry replays a byte-identical request four times, then fails the run.
  2. update-locales.ts L369 + the CI workflows — pnpm locale:check silently skips changed-string detection whenever the recorded blob is unreachable, and the two ci-lint-format* workflows check out at depth 1. The gate goes quiet in precisely the case it exists to catch.
  3. protected-tokens.ts L30 — plural-form counts are never validated; 39 strings in main.json are exposed to a silently dropped form.
  4. protected-tokens.ts L68 — hand-authored translations are silently regenerated on placeholder drift even when English never changed, with no per-leaf record of why.
  5. config.ts L49 — please pin gpt-4.1 here and swap the model in a separate PR.
  6. translate.ts L150 — use the openai SDK rather than hand-rolled retry/backoff/timeout.

Two things not anchored to a line in this diff

  • .github/workflows/ci-lint-format.yaml and ci-lint-format-queue.yaml need fetch-depth: 0 + filter: blob:none, matching what this PR already did to the three i18n workflows. Without it, finding 2 stands regardless of what changes in update-locales.ts.
  • Please run i18n-update-custom-nodes.yaml once end to end against a real node pack before merging. Its copy path was wrong until #15137 fixed it, which means it has been failing quietly for some time, and this PR also changes its checkout. That workflow opens PRs against other people's repositories, so it is the one place a mistake here is visible outside our own.

Worth considering, not blocking

  • Port rename detection (locale-tree.ts L101). A deleted leaf and an added leaf with identical source content are the same string moved; carrying the translation over is ~15 lines and node renames in nodeDefs.json are routine.
  • We are giving up lobe-i18n lint's ELD language detection. We never wired it up, so it is an unclaimed option rather than a working feature — but it catches exactly the "zh-TW file contains Simplified characters" class we have already shipped once. eld is a standalone package if we want it back later.
  • For the record on due diligence: lingo.dev (Apache-2.0, actively maintained, BYO key) solves this problem with a lockfile of per-key source hashes — the same design this PR arrived at independently, which I take as a good sign. I am not suggesting we switch; its migration cost is not lower than finishing this, and our escaping contract is ours either way. But it is the question that comes back in six months if nobody can say we looked.

Comment thread scripts/i18n/translate.ts Outdated

let lastError = new Error('translation request was not attempted')
let serverRetryDelayMs = 0
for (let attempt = 0; attempt <= retryDelaysMs.length; attempt++) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking — the truncation retry replays the identical request.

body is built once at L128, outside this loop. When finish_reason === "length" (L183) the handler sets lastError and continues, which re-POSTs the same model, the same chunk and the same params. Nothing between attempts changes the input, so a chunk that overflows the output window overflows it again on all four attempts, and the run then dies with an error telling a human to lower maxItemsPerRequest.

Truncation is the one failure in this loop that is a property of the request rather than of the server, so it needs different handling from the 429/5xx path: split the chunk in half and translate the halves, or drop maxItemsPerRequest for the retry.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I have this fixed in the pending follow-up diff: finish_reason: "length" now bisects a multi-item batch and translates the two halves, recursively if needed, instead of replaying the identical request. A focused test verifies that both follow-up request bodies are smaller and that their responses are combined. A truncated single-item batch fails immediately because it cannot be split further. This is local and validated, but not pushed yet.

Comment thread scripts/i18n/translate.ts Outdated
: undefined
if (finishReason === 'length') {
lastError = new Error(
'OpenAI response was truncated (finish_reason "length"); lower maxItemsPerRequest or maxSourceCharsPerRequest'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message asks a human to change maxItemsPerRequest / maxSourceCharsPerRequest, but nothing in the code path does that automatically and the retry that follows does not change the request at all. Once the split-on-truncation fix is in, this should become an internal detail that never reaches an operator.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled by the same pending split-on-truncation change. Multi-item truncation is now recovered internally and no longer reaches this operator message. The message remains only for an irreducible single-item batch, where lowering the configured source/request bound is still the available recovery. Local and validated, not pushed yet.

Comment thread scripts/i18n/translate.ts Outdated
const fetchFn = options.fetchFn ?? fetch
const timeoutMs = options.requestTimeoutMs ?? defaultRequestTimeoutMs
return async (locale, items) => {
const body = JSON.stringify({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No max_completion_tokens is set, so the output bound is whatever the model defaults to — and output truncation is precisely the failure this loop is trying to survive. Worth setting it explicitly so the chunk-size math has a number to be derived from instead of an implicit one.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am leaving max_completion_tokens unset for now. An arbitrary explicit cap would introduce another source of truncation without making the character heuristic token-aware; the recursive split now provides the actual safety net. If we add a cap later, it should come from a measured token/cost policy rather than a guessed constant.

Comment thread scripts/i18n/translate.ts Outdated
return async (locale, items) => {
const body = JSON.stringify({
model: options.model,
reasoning_effort: options.reasoningEffort,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReasoningEffort in config.ts admits 'none' | 'xhigh' | 'max', which the Chat Completions API does not accept. The type is wider than the wire contract, so a config typo becomes a 400 at minute 30 of a 13-locale run rather than a compile error. Narrow the union to the values the endpoint actually takes.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the local ReasoningEffort union in the pending follow-up diff. TranslationPipelineConfig.reasoningEffort is now derived as NonNullable<OpenAI.ChatCompletionCreateParams['reasoning_effort']>, so the request configuration tracks the SDK wire type directly. The current SDK and configured GPT-5.6 Terra model support the values this PR uses. Local and validated, not pushed yet.

Comment thread scripts/i18n/translate.ts Outdated
}
try {
const response = await fetchFn(
'https://api.openai.com/v1/chat/completions',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the openai SDK instead of hand-rolled transport.

Between here and L207 the PR owns: retry policy, backoff schedule, Retry-After parsing and clamping, request timeout, HTTP error classification, and response-shape narrowing. That is roughly 100 lines of code whose only job is to be the same as the SDK, and it is the part of this PR that will rot on someone else's schedule rather than ours.

This is the single largest reduction available in what we newly own, and it does not touch any of the design that makes this PR worth landing.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed on the current PR head by fbde245: the transport now uses the official openai SDK, which owns network retry policy, backoff and Retry-After handling, timeout behavior, HTTP classification, and response typing. The pipeline retains only domain-level handling for truncated or malformed translation content.

return parseLocale(readFileSync(filename, 'utf8'), filename)
}

export function serializeLocale(locale: LocaleObject): string {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that .oxfmtrc.json excludes src/locales/**/*.json, this function is the only thing defining the on-disk format, and nothing enforces it on a hand-edited file. A contributor who reformats a locale file in an editor produces a diff the pipeline will silently rewrite on its next run. Worth a line in CONTRIBUTING.md.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 45d9f9d. src/locales/CONTRIBUTING.md now documents the canonical locale JSON format (recursively sorted keys, two-space indentation, and a trailing newline), explains that oxfmt intentionally ignores these files, and warns that a successful locale run normalizes formatting while preserving unchanged translation values.

Comment thread scripts/i18n/config.ts
export const translationPipelineConfig: TranslationPipelineConfig = {
entry: 'src/locales/en',
output: 'src/locales',
model: 'gpt-5.6-terra',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pin gpt-4.1 in this PR and swap the model separately.

This changes the translation engine and the framework in one commit. If output quality moves — across 13 locales, including four with hand-written guidance we cannot easily spot-check — there is no way to attribute it, and the natural response would be to distrust the migration.

The follow-up is a one-line diff whose review is about translation quality, which is a completely different conversation from this one and deserves its own.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping gpt-5.6-terra by author decision. I agree that model changes affect output attribution, but the model selection is intentional and already landed with #15062; reverting it in this follow-up would add another behavior change and unwind the reasoning-aware request configuration. No change here.

Comment thread scripts/i18n/config.ts
output: 'src/locales',
model: 'gpt-5.6-terra',
reasoningEffort: 'high',
maxItemsPerRequest: 40,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two numbers are the entire chunking policy and they are currently unexplained constants. Once the truncation path re-chunks (see translate.ts L143), say in a comment that they are a starting heuristic with a safety net rather than a measured bound — otherwise the next person to see a truncation will tune these instead of trusting the split.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9f04e9b. chunkItems now states that character count is only the initial batching heuristic and that truncated responses are recursively split before the run fails, so the constants are not presented as measured bounds.

Comment thread scripts/i18n/config.ts
'latent' is the short form of 'latent space'.
'mask' is in the context of image processing.`

const chineseSimplifiedGuidance = `Use ONLY Simplified Chinese characters (简体中文). Common examples: 节点 (not 節點), 画布 (not 畫布), 图像 (not 圖像), 选择 (not 選擇), 减小 (not 減小). NEVER mix Simplified and Traditional Chinese characters.`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carrying over the .i18nrc.cjs reference prompt verbatim is the right call and I checked it line by line — glossary terms, Simplified/Traditional rules, Persian numerals, Hebrew RTL and term glossary all survive.

One thing lost in the move: the old prompt framed the target as "BCP 47" and this one passes an English language name. That is probably better for the model, but zh vs zh-TW now depends entirely on the name string and the guidance text rather than on a tag the model can reason about. Worth a test that the two Chinese locales stay disjoint in script — it is the failure mode we have already shipped once (#5013).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 45d9f9d. The model prompt now identifies the targets as zh-Hans and zh-Hant-TW in addition to their English names. The pipeline also rejects the known Simplified/Traditional cross-script terms from #5013 before persisting output, with focused tests for both locales; the full committed locale corpus passes the new audit.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On further review, I think the dedicated script validator is excessive and I no longer think this comment warrants a production guard. The old pipeline already carried explicit Simplified/Traditional instructions; the migration materially improves reliability by moving from gpt-4.1 to gpt-5.6-terra with high reasoning, naming the active target as Simplified Chinese or Traditional Chinese (Taiwan), and attaching only that locale-specific guidance instead of putting both Chinese variants into one global reference block. Given those changes, a hardcoded vocabulary list adds maintenance cost and incomplete/false-positive validation without meaningfully reducing practical risk. Treating this as no-fix.

Comment thread src/locales/CONTRIBUTING.md Outdated
protected literals (e.g. `<Picture N>`, `17k+5`) survive translation exactly.
Existing translations whose placeholders no longer match the English source are
re-queued for translation, so corrupted strings heal on the next run. Runs that
would delete an implausibly large share of a file's keys abort without writing

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the pipeline is the sole writer of those bytes" sits in the same document that invites contributors to open manual translation PRs, and the two statements are in tension.

What the code actually does is worth stating here explicitly, because it is good news and nobody will discover it by reading rebuildLocale: a hand-authored translation is preserved verbatim unless the English source changed, the value shape changed, or its placeholders drifted from the English. That is a stronger guarantee than lobe gave, where hand edits survived only as a side effect of key-diffing.

The third condition is the one to warn people about — see the note on protected-tokens.ts L68.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 45d9f9d. The contributor guide now says that unchanged hand-authored translation values are preserved and distinguishes that from canonical JSON formatting. It also reflects the hardened behavior added in this follow-up: placeholder or protected-literal drift on an unchanged source blocks checks and generation with the affected path instead of silently overwriting the manual translation.

@socket-security

socket-security Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​openai@​7.4.078100100100100

View full report

- Widen quoted match/max protection to locale-typical quote styles
- Drop the backslash lookbehind that exempted real placeholders; flag
  introduced plural separators and linked messages; audit arrays, type
  changes, and blank translations
- Preserve keys named __proto__ in rebuilt locales
- Persist completed entry files and advance their manifest entries when
  another file fails; stop dispatching translation requests after a
  fatal error
- Prune locale files whose English source file was removed
- Fail locale:check on protected-token violations beyond the manifest's
  transitional knownViolations baseline, which the first successful
  locale run heals and drops
- Give locale:check callers blobless full history so changed-string
  detection works on PRs; plumb an allow_prune dispatch input; move
  prune thresholds into config
coderabbitai[bot]
coderabbitai Bot previously requested changes Aug 13, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/i18n-update-core.yaml:
- Around line 58-63: Separate the translation and formatting commands in the
workflow so their outcomes are tracked independently. Update the final
failure-reporting step to distinguish a failed pnpm locale command from a failed
pnpm format command, while preserving continue-on-error behavior for committing
completed translation files.
- Around line 7-11: Update the workflow’s manual-dispatch branch handling to use
`${{ github.head_ref || github.ref_name }}` for fetch, checkout, and push
operations. Add validation that rejects tag refs before any push occurs, while
preserving the existing branch behavior for pull-request runs.

In `@scripts/i18n/update-locales.ts`:
- Line 449: Require the --allow-prune option before deleting files identified by
orphanedOutputFiles in the pruning flows around the orphanedOutputFiles call and
its corresponding deletion path. Ensure orphaned locale files are never removed
without explicit permission, including entries absent from src/locales/en, and
add coverage for a missing English entry file.

In `@src/locales/CONTRIBUTING.md`:
- Around line 122-125: The documentation wording should reflect run-level
behavior: replace “abort that file without writing” with language stating that
an unsafe prune aborts the entire generation run before any locale files are
written. Keep the existing guidance about using --allow-prune only after
verifying complete English sources.

Apply the same fix in `@src/locales/CONTRIBUTING.md` around lines 131 - 133.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ad9f41d6-d745-47fa-86ce-3a752477f50f

📥 Commits

Reviewing files that changed from the base of the PR and between fbde245 and 0bf1590.

📒 Files selected for processing (11)
  • .github/workflows/ci-lint-format-queue.yaml
  • .github/workflows/ci-lint-format.yaml
  • .github/workflows/i18n-update-core.yaml
  • scripts/i18n/config.ts
  • scripts/i18n/locale-tree.ts
  • scripts/i18n/protected-tokens.ts
  • scripts/i18n/translate.ts
  • scripts/i18n/update-locales.test.ts
  • scripts/i18n/update-locales.ts
  • src/locales/.source-manifest.json
  • src/locales/CONTRIBUTING.md

Comment on lines +7 to +11
inputs:
allow_prune:
description: 'Confirm deletions larger than the prune threshold'
type: boolean
default: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

file=.github/workflows/i18n-update-core.yaml
rg -n -C2 \
  'workflow_dispatch|allow_prune|github\.head_ref|github\.ref_name|git (fetch|checkout|push)' \
  "$file"

if rg -n 'git (fetch|checkout|push).*github\.head_ref' "$file"; then
  echo "Manual dispatch still uses the pull-request-only head_ref." >&2
  exit 1
fi

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 1937


🏁 Script executed:

sed -n '1,120p' .github/workflows/i18n-update-core.yaml

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 3706


🌐 Web query:

GitHub Actions workflow_dispatch github.head_ref github.ref_name manual dispatch branch tag documentation

💡 Result:

When manually triggering a workflow via the workflow_dispatch event, you can specify a target branch or tag using the GitHub UI, GitHub CLI, or REST API [1][2]. The following clarifies the behavior of relevant GitHub context properties in this context: 1. github.ref_name: This context property correctly identifies the branch or tag name that was selected when the workflow was manually triggered [3][4]. It is the recommended property to use for referencing the current branch or tag in workflow_dispatch runs [4]. 2. github.head_ref: This property is only defined for pull_request and pull_request_target events [5][6][7]. It will be empty (undefined) for workflow_dispatch runs [4]. If you write a workflow that handles both pull_request and workflow_dispatch events, you should avoid relying on github.head_ref without providing a fallback (e.g., using ${{ github.head_ref || github.ref_name }}) to prevent errors [8]. In summary, for manual dispatches, github.ref_name provides the desired branch/tag context, while github.head_ref is not applicable [4][7].

Citations:


🏁 Script executed:

python3 - <<'PY'
from pathlib import Path
import re

p = Path(".github/workflows/i18n-update-core.yaml")
text = p.read_text()

manual_job = "github.event_name == 'workflow_dispatch'" in text
head_ref_commands = re.findall(r"git\s+(?:fetch|checkout|push)[^\n]*github\.head_ref", text)
ref_name_present = "github.ref_name" in text

print({
    "manual_dispatch_enables_job": manual_job,
    "commit_commands_using_head_ref": head_ref_commands,
    "ref_name_present": ref_name_present,
})
PY

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 418


Use the selected branch for manual dispatches.

Manual runs leave github.head_ref empty, so the fetch, checkout, and push commands do not target a branch. Use ${{ github.head_ref || github.ref_name }} and reject tag refs before pushing.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/i18n-update-core.yaml around lines 7 - 11, Update the
workflow’s manual-dispatch branch handling to use `${{ github.head_ref ||
github.ref_name }}` for fetch, checkout, and push operations. Add validation
that rejects tag refs before any push occurs, while preserving the existing
branch behavior for pull-request runs.

Source: MCP tools

Comment on lines +58 to +63
id: translate
# continue-on-error so completed entry files (written and recorded in
# the manifest even when another file fails) still get committed; the
# final step re-surfaces the failure
continue-on-error: true
run: pnpm locale ${{ inputs.allow_prune == true && '--allow-prune' || '' }} && pnpm format

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

file=.github/workflows/i18n-update-core.yaml
rg -n -C2 \
  'id: translate|continue-on-error|pnpm locale|pnpm format|steps\.translate\.outcome' \
  "$file"

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 1026


🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

file=.github/workflows/i18n-update-core.yaml
sed -n '1,100p' "$file"
printf '\n--- package scripts ---\n'
rg -n -C2 '"(locale|format)"|locale|format' package.json pnpm-workspace.yaml 2>/dev/null || true

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 4582


🏁 Script executed:

#!/usr/bin/env bash
set -u

run_case() {
  local locale_status="$1"
  local format_status="$2"
  local outcome=success

  if (( locale_status == 0 )); then
    (( format_status == 0 )) || outcome=failure
  else
    outcome=failure
  fi

  printf 'pnpm locale=%s, pnpm format=%s -> steps.translate.outcome=%s\n' \
    "$locale_status" "$format_status" "$outcome"
}

run_case 0 0
run_case 0 1
run_case 1 0

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 356


Separate translation and formatting status

If pnpm locale succeeds but pnpm format fails, steps.translate.outcome is failure, so the final step incorrectly reports pnpm locale failed. Track formatting separately or record separate outcomes.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/i18n-update-core.yaml around lines 58 - 63, Separate the
translation and formatting commands in the workflow so their outcomes are
tracked independently. Update the final failure-reporting step to distinguish a
failed pnpm locale command from a failed pnpm format command, while preserving
continue-on-error behavior for committing completed translation files.

Source: MCP tools

}

const states = loadLocaleFileStates(config, outputDir, plans)
const orphans = orphanedOutputFiles(outputDir, config, filenames)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Require --allow-prune before deleting orphaned locale files.

oversizedPrunes only evaluates files still present in src/locales/en. If collection omits an entire entry file, it has no SourcePlan. Lines 449 and 581 then delete that file for every output locale without a threshold check or --allow-prune.

Gate orphan deletion behind --allow-prune, or calculate its recorded leaf count and apply the same threshold. Add coverage for a missing English entry file.

Proposed fix
 const orphans = orphanedOutputFiles(outputDir, config, filenames)
+if (orphans.length > 0 && !check && !argv.includes('--allow-prune')) {
+  throw new Error(
+    `Refusing to delete ${orphans.length} orphaned locale files. ` +
+      'Verify the English sources, or rerun with --allow-prune.'
+  )
+}
 
 if (check) {

Also applies to: 581-581

🧰 Tools
🪛 ast-grep (0.45.1)

[warning] Importing child_process exposes a command-execution surface; ensure any command/argument built from input is validated, and prefer execFile/spawn with an argument array over exec.
Context: import { execFileSync } from 'node:child_process'
Note: [CWE-78] Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection').

(detect-child-process-typescript)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/i18n/update-locales.ts` at line 449, Require the --allow-prune option
before deleting files identified by orphanedOutputFiles in the pruning flows
around the orphanedOutputFiles call and its corresponding deletion path. Ensure
orphaned locale files are never removed without explicit permission, including
entries absent from src/locales/en, and add coverage for a missing English entry
file.

Comment on lines +122 to +125
would delete an implausibly large share of a file's keys abort that file
without writing — that usually means `collect-i18n` observed a partial app;
rerun with `--allow-prune` (or the `allow_prune` input on the manual workflow
dispatch) only after confirming the English sources are complete.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Describe unsafe-prune handling as a run-level abort.

scripts/i18n/update-locales.ts collects oversized prune plans and throws before loading locale states or writing outputs when --allow-prune is absent. Therefore, the generation run stops before any locale file is written. The phrase “abort that file” implies that other files continue.

Change the wording to “abort the run before writing” or change the implementation to provide true per-file continuation.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/CONTRIBUTING.md` around lines 122 - 125, The documentation
wording should reflect run-level behavior: replace “abort that file without
writing” with language stating that an unsafe prune aborts the entire generation
run before any locale files are written. Keep the existing guidance about using
--allow-prune only after verifying complete English sources.

Apply the same fix in `@src/locales/CONTRIBUTING.md` around lines 131 - 133.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. I re-verified the fixes by executing the pipeline code against the real locale data rather than reading the diff.

Blocker (#7, mass prune) — closed. My original repro is now refused:

BLOCKED  main.json  full `manager` subtree lost (repro)  129/4117 (3.1%)
BLOCKED  nodeDefs   half the file lost                  4541/9082 (50%)
ALLOWED  commands   legit cleanup of 10                   10/124  (8.1%)

Per-file rather than aggregate is a sharper design than what I suggested — a halved commands.json can't hide under a corpus-wide threshold.

Placeholder audit (#1, #2) — closed. Running collectPendingLeaves + auditProtectedLiterals as reportCheck now calls them, against real en/zh main.json: pending 21 -> 39, audit errors 0 -> 19. g.searchPlaceholder, gatedModelsHint, and workspacePanel.members.membersCount all re-queue for repair. The knownViolations baseline being per-file and self-clearing on revalidation is a good call — it makes the backlog explicit and auditable instead of invisible, which is what I was actually after.

On #3 — you were right and I was wrong. My suggested fallback (previous = source on an unreadable blob) would have advanced the manifest past an unread baseline and permanently skipped those retranslations. Splitting the error types and degrading only --check is the correct call.

On #4 — you found more than I did. I had verified oxfmt and serializeLocale currently agree and filed it as latent fragility. The ci-lint-format.yaml auto-commit path makes it a live second writer. Good catch.

Also noted: the prototype-pollution hardening in rebuildObject, manifest hash validation before git argv, and mapWithConcurrency halting dispatch on first failure — none of which were asked for.

Two non-blocking items:

  1. PR description is stale. It still says "No new dependencies — the OpenAI API is called directly," but this now depends on the openai SDK. The declaration is correct (devDependency, catalog:, lockfile updated) so nothing ships to users — the description just needs a line.
  2. Residual prune window. Deletions under 2% still pass silently: roughly 180 nodeDefs keys, about 2,300 strings across 13 locales. Inherent to any threshold and a fine tradeoff, just worth knowing the floor isn't zero.

CI is green across the board. Nice work on the turnaround.

@benjcooley
benjcooley dismissed their stale review August 13, 2026 03:36

Superseded — all findings addressed and verified in 03e07b1 + 2f9041f; approved separately.

@benceruleanlu
benceruleanlu added this pull request to the merge queue Aug 13, 2026
@benceruleanlu

Copy link
Copy Markdown
Member Author

Smuggling in now and fixing rest of Christian's concerns in a followup, since diff is growing and things are generally nonblocking

pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Aug 13, 2026
## Summary

Split the existing user-facing and correctness repairs out of Comfy-Org#15062 so
the framework migration can be reviewed independently.

## Changes

- Applies the locale-data repairs already present in Comfy-Org#15062 onto current
`main`, preserving translations that were independently updated on
`main` in the meantime.
- Repairs the stale, corrupted, missing, and leftover locale values
already included in Comfy-Org#15062.
- Fixes the custom-node locale workflow copy path (`temp/diff`, not
`ComfyUI_frontend/temp/diff`).
- Contains no i18n framework or dependency migration and no newly
authored translations.

## Validation

- Semantic three-way comparison against Comfy-Org#15062 original repair patch for
all 26 affected locale files.
- JSON parse and format validation passed.
- Pre-commit checks, including `knip`, passed.

Extracted mechanically from Comfy-Org#15062; no repair content was reauthored.
Merged via the queue into main with commit 1a0bfcc Aug 13, 2026
80 checks passed
@benceruleanlu
benceruleanlu deleted the bl/in-house-i18n-pipeline-1b91ce branch August 13, 2026 04:30
github-merge-queue Bot pushed a commit that referenced this pull request Aug 14, 2026
## Summary

Wire the previously dormant `scripts/tsconfig.json` into a runnable
check (`pnpm typecheck:scripts`) and run it in the lint-format-verify CI
action, so type errors in `scripts/` no longer land silently.

## Changes

- **What**: `scripts/tsconfig.json` gains the
`node`/`vitest`/`vite/client` types and the repo's ambient declaration
includes (mirroring `browser_tests/tsconfig.json`), runs via `vue-tsc`
because scripts transitively import `.vue` modules, and disables
incremental state so repeat runs cannot report stale results. New
`typecheck:scripts` script + CI step.
- `scripts/vite-define-shim.ts` drops its `declare global` block —
`global.d.ts` and `src/platform/distribution/types.ts` already declare
those constants ambiently, and duplicate declarations are a compile
error once they share a program.
- Pre-existing strictness errors in `collect-i18n-general.ts`,
`collect-i18n-node-defs.ts`, `nodeDefLocaleSerializer.test.ts`, and
`perf-report.ts` are suppressed with `@ts-expect-error` for now rather
than fixed.
- `collect-i18n-general.ts` imports `formatUtil` via the package's
exports map instead of a cross-package relative path (latent
`import-x/no-relative-packages` error surfaced by lint-staged on first
touch).

## Review Focus

Whether suppressing the pre-existing errors is acceptable versus fixing
them here; and the shim's deleted `declare global` block (its only
importer is `collect-i18n-general.ts`, and no other tsconfig checks the
shim).

Stacked on #15062.

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-review Add to trigger a PR code review from Claude Code risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants