Repository navigation
fix: repair stale and malformed locale data - #15137
Conversation
🎭 Playwright: ✅ 1802 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.72 MB gzip 🔴 +4 kBDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.51 MB (baseline 3.51 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 17 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14.2 MB (baseline 14.1 MB) • 🔴 +16.5 kBBundles that do not match a named category
Status: 96 added / 96 removed / 189 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-12T08:14:05.584Z",
"gitSha": "2d9f35b16bbfa3e5352d42a56a9977d63397cfa4",
"branch": "bl/fix-i18n-locale-data",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.0729999999971,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.276000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.819,
"heapDeltaBytes": 5810096,
"heapUsedBytes": 70260064,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 16.46,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2005.045999999993,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.082,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.71599999999995,
"heapDeltaBytes": 5765000,
"heapUsedBytes": 70302256,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 15.766000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1908.0359999999814,
"styleRecalcs": 77,
"styleRecalcDurationMs": 46.101,
"layouts": 12,
"layoutDurationMs": 4.029000000000001,
"taskDurationMs": 958.615,
"heapDeltaBytes": -12796012,
"heapUsedBytes": 51776776,
"domNodes": -282,
"jsHeapTotalBytes": 23306240,
"scriptDurationMs": 126.247,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1850.7880000000796,
"styleRecalcs": 72,
"styleRecalcDurationMs": 32.748,
"layouts": 12,
"layoutDurationMs": 3.3859999999999997,
"taskDurationMs": 870.3989999999999,
"heapDeltaBytes": -15010504,
"heapUsedBytes": 49550696,
"domNodes": -281,
"jsHeapTotalBytes": 23306240,
"scriptDurationMs": 107.83400000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.2339999999813,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.188,
"layouts": 6,
"layoutDurationMs": 0.5820000000000001,
"taskDurationMs": 400.569,
"heapDeltaBytes": 8782416,
"heapUsedBytes": 73244004,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 22.305,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.7140000000254,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.488999999999999,
"layouts": 6,
"layoutDurationMs": 0.636,
"taskDurationMs": 365.913,
"heapDeltaBytes": 8827696,
"heapUsedBytes": 73211728,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 18.154,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 599.2400000000089,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.1030000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.077,
"heapDeltaBytes": -11271520,
"heapUsedBytes": 53202832,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 57.895,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 578.6390000000665,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.24899999999997,
"heapDeltaBytes": -11197952,
"heapUsedBytes": 53120580,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 55.673,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2036.5170000000035,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.082000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 739.4000000000001,
"heapDeltaBytes": 7369284,
"heapUsedBytes": 67323660,
"domNodes": -280,
"jsHeapTotalBytes": 4296704,
"scriptDurationMs": 111.97200000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.9529999999922,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.851000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 669.933,
"heapDeltaBytes": 6931984,
"heapUsedBytes": 66379492,
"domNodes": -281,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 92.79499999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2274.0549999999757,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.860999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1367.029,
"heapDeltaBytes": -6176500,
"heapUsedBytes": 55187136,
"domNodes": -284,
"jsHeapTotalBytes": 4558848,
"scriptDurationMs": 435.068,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2169.5210000000316,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.777,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1244.932,
"heapDeltaBytes": 5250460,
"heapUsedBytes": 65754752,
"domNodes": -285,
"jsHeapTotalBytes": 3178496,
"scriptDurationMs": 405.696,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3298.535999999956,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.383999999999999,
"layouts": 60,
"layoutDurationMs": 8.797999999999998,
"taskDurationMs": 1581.862,
"heapDeltaBytes": 24842712,
"heapUsedBytes": 86995056,
"domNodes": 10,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 554.3929999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3215.330999999992,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.154,
"layouts": 60,
"layoutDurationMs": 8.217,
"taskDurationMs": 1549.193,
"heapDeltaBytes": -1961600,
"heapUsedBytes": 60318092,
"domNodes": -287,
"jsHeapTotalBytes": 6131712,
"scriptDurationMs": 536.212,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2039.6169999999643,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.033999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 763.845,
"heapDeltaBytes": 6767296,
"heapUsedBytes": 68225808,
"domNodes": -284,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 117.955,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.6769999999642,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.473,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.515,
"heapDeltaBytes": 7086312,
"heapUsedBytes": 68305440,
"domNodes": -284,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 93.30199999999999,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 587.6289999999926,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.96,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.12500000000006,
"heapDeltaBytes": -10591696,
"heapUsedBytes": 53947964,
"domNodes": 18,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 121.583,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.5929999999744,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.036000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.004,
"heapDeltaBytes": -10789812,
"heapUsedBytes": 53947128,
"domNodes": 22,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 121.45599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.3990000000117,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.572,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.044,
"heapDeltaBytes": 5824364,
"heapUsedBytes": 70503416,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 15.132000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2047.2530000000688,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.473000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.53399999999993,
"heapDeltaBytes": -18316920,
"heapUsedBytes": 46192420,
"domNodes": -282,
"jsHeapTotalBytes": 22519808,
"scriptDurationMs": 14.15,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1771.7569999999796,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.146,
"layouts": 16,
"layoutDurationMs": 4.9399999999999995,
"taskDurationMs": 850.9010000000001,
"heapDeltaBytes": -15684280,
"heapUsedBytes": 48713088,
"domNodes": -283,
"jsHeapTotalBytes": 23044096,
"scriptDurationMs": 96.76799999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.890000000044,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.637,
"layouts": 16,
"layoutDurationMs": 4.4830000000000005,
"taskDurationMs": 787.574,
"heapDeltaBytes": -17046724,
"heapUsedBytes": 47353684,
"domNodes": -281,
"jsHeapTotalBytes": 22257664,
"scriptDurationMs": 86.376,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.4349999999395,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.45600000000001,
"layouts": 15,
"layoutDurationMs": 11.289,
"taskDurationMs": 894.8739999999999,
"heapDeltaBytes": 31018708,
"heapUsedBytes": 101031272,
"domNodes": 13673,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 40.328999999999986,
"eventListeners": 2375,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8468.55099999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 48.14399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4719.581,
"heapDeltaBytes": 14721904,
"heapUsedBytes": 74912144,
"domNodes": -284,
"jsHeapTotalBytes": 5537792,
"scriptDurationMs": 1408.9370000000001,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8245.147000000088,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.663000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4369.715,
"heapDeltaBytes": 12170688,
"heapUsedBytes": 72346660,
"domNodes": -283,
"jsHeapTotalBytes": 6062080,
"scriptDurationMs": 1364.247,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18041.51999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17982.789,
"heapDeltaBytes": -33990552,
"heapUsedBytes": 183350888,
"domNodes": -8312,
"jsHeapTotalBytes": -9117696,
"scriptDurationMs": 590.6210000000001,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17936.786999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17913.945,
"heapDeltaBytes": -36471488,
"heapUsedBytes": 167323724,
"domNodes": -8312,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 569.2230000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22836.116000000005,
"styleRecalcs": 174,
"styleRecalcDurationMs": 27.542999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22809.342,
"heapDeltaBytes": -63630168,
"heapUsedBytes": 153965528,
"domNodes": -8312,
"jsHeapTotalBytes": -10162176,
"scriptDurationMs": 929.622,
"eventListeners": -16381,
"totalBlockingTimeMs": 789,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22259.470000000078,
"styleRecalcs": 159,
"styleRecalcDurationMs": 23.094000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22213.433,
"heapDeltaBytes": -40225776,
"heapUsedBytes": 166405488,
"domNodes": -8341,
"jsHeapTotalBytes": -10428416,
"scriptDurationMs": 910.047,
"eventListeners": -16383,
"totalBlockingTimeMs": 411,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 476.1980000000676,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.817,
"layouts": 3,
"layoutDurationMs": 0.647,
"taskDurationMs": 116.41600000000001,
"heapDeltaBytes": 5064216,
"heapUsedBytes": 68754056,
"domNodes": 126,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.317000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 459.1460000000325,
"styleRecalcs": 12,
"styleRecalcDurationMs": 17.144,
"layouts": 3,
"layoutDurationMs": 0.6300000000000001,
"taskDurationMs": 104.759,
"heapDeltaBytes": 5036276,
"heapUsedBytes": 68676400,
"domNodes": 121,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.828000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
📝 WalkthroughWalkthroughThis change updates the locale-copy workflow, adds structured media-asset and partner-node translations, corrects an Italian interpolation placeholder, and refreshes translated node descriptions for Seedance, Grok, LTXV, MiniMax H3, Load3D, and PreviewAny. ChangesLocalization and workflow updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/locales/he/nodeDefs.json`:
- Line 893: Update the repeated tooltip entries in nodeDefs.json to state
grammatically that Seedance 2.5 is the newest model, and normalize the
output-format casing to MP4/MOV and 4K in all three occurrences. Keep the
remaining Seedance descriptions unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 889b3753-8c6e-4a4b-ba78-14e4bcf38a00
📒 Files selected for processing (23)
.github/workflows/i18n-update-custom-nodes.yamlsrc/locales/ar/main.jsonsrc/locales/ar/nodeDefs.jsonsrc/locales/es/main.jsonsrc/locales/es/nodeDefs.jsonsrc/locales/fa/nodeDefs.jsonsrc/locales/fr/main.jsonsrc/locales/fr/nodeDefs.jsonsrc/locales/he/nodeDefs.jsonsrc/locales/it/main.jsonsrc/locales/it/nodeDefs.jsonsrc/locales/ja/main.jsonsrc/locales/ja/nodeDefs.jsonsrc/locales/ko/main.jsonsrc/locales/ko/nodeDefs.jsonsrc/locales/pt-BR/nodeDefs.jsonsrc/locales/ru/main.jsonsrc/locales/ru/nodeDefs.jsonsrc/locales/tr/main.jsonsrc/locales/tr/nodeDefs.jsonsrc/locales/zh-TW/main.jsonsrc/locales/zh-TW/nodeDefs.jsonsrc/locales/zh/nodeDefs.json
| "model": { | ||
| "name": "model", | ||
| "tooltip": "Seedance 2.0 לאיכות מרבית; Fast לאופטימיזציית מהירות; Mini לדור מהיר וזול במיוחד." | ||
| "tooltip": "Seedance 2.5 עבור הדגם החדש ביותר, סרטונים באורך של עד 30 שניות ופלט mp4/mov; Seedance 2.0 לאיכות מרבית ול־1080p/4k; Fast למיטוב מהירות; Mini ליצירה המהירה ביותר ובעלות הנמוכה ביותר." |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Fix the repeated Seedance tooltip wording.
Seedance 2.5 עבור הדגם החדש ביותר is grammatically incomplete and does not state that Seedance 2.5 is the newest model. Use consistent product casing for MP4/MOV and 4K in all three entries.
Proposed fix
-Seedance 2.5 עבור הדגם החדש ביותר, סרטונים באורך של עד 30 שניות ופלט mp4/mov; Seedance 2.0 לאיכות מרבית ול־1080p/4k; Fast למיטוב מהירות; Mini ליצירה המהירה ביותר ובעלות הנמוכה ביותר.
+Seedance 2.5 הוא הדגם החדש ביותר, ליצירת סרטונים באורך של עד 30 שניות ובפלט MP4/MOV; Seedance 2.0 לאיכות מרבית ול־1080p/4K; Fast למיטוב מהירות; Mini ליצירה המהירה ביותר ובעלות הנמוכה ביותר.Also applies to: 934-934, 987-987
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/locales/he/nodeDefs.json` at line 893, Update the repeated tooltip
entries in nodeDefs.json to state grammatically that Seedance 2.5 is the newest
model, and normalize the output-format casing to MP4/MOV and 4K in all three
occurrences. Keep the remaining Seedance descriptions unchanged.
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/locales/ar/main.json`:
- Line 4909: Update the matchedModelCount entries to use singular-first ordering
in src/locales/ar/main.json:4909-4909, src/locales/es/main.json:4909-4909,
src/locales/he/main.json:4909-4909, and src/locales/fr/main.json:4909-4909;
place each singular translation before its plural alternative while preserving
the existing placeholders and separator.
In `@src/locales/fr/main.json`:
- Around line 4897-4902: Update the four provider-count translation values in
the locale entries disableAllCount, disableMatchingCount, enableAllCount, and
enableMatchingCount so {count} appears before the French noun, preserving the
singular/plural variants and intended “N providers” meaning.
In `@src/locales/it/main.json`:
- Around line 4900-4902: The singular alternatives in src/locales/it/main.json
lines 4900-4902 for disableMatchingCount and enableMatchingCount must place
{count} before provider or omit it. Apply the same correction in
src/locales/pt-BR/main.json lines 4897-4902 for disableAllCount,
disableMatchingCount, enableAllCount, and enableMatchingCount; leave plural
alternatives unchanged.
- Line 4909: Reverse the variant order for matchedModelCount so the singular
form precedes the plural form, matching Vue I18n’s selection behavior. Apply
this change in src/locales/it/main.json at lines 4909-4909 and
src/locales/pt-BR/main.json at lines 4909-4909; no other translations or symbols
require changes.
- Line 4888: Update allowedSummary in src/locales/it/main.json:4888-4888 and
src/locales/pt-BR/main.json:4888-4888 with singular/plural forms using the count
placeholder. In the component that displays allowedSummaryAll, pass count as the
i18n-t plural choice rather than only as a slot value.
In `@src/locales/ru/main.json`:
- Around line 4897-4902: Add a Russian pluralization rule under the existing
pluralRules configuration in i18n.ts, using forms for 1, 2–4, and 5+ counts.
Update the six locale labels disableAllCount, disableMatchingCount,
enableAllCount, enableMatchingCount, and their corresponding matchedModelCount
entries to provide all three Russian forms, and reverse matchedModelCount
ordering so count 1 selects the singular form.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8e798ff6-732d-4bf9-8716-1de487e00f34
📒 Files selected for processing (15)
src/locales/ar/main.jsonsrc/locales/ar/nodeDefs.jsonsrc/locales/es/main.jsonsrc/locales/fa/main.jsonsrc/locales/fa/nodeDefs.jsonsrc/locales/fr/main.jsonsrc/locales/he/main.jsonsrc/locales/it/main.jsonsrc/locales/ja/main.jsonsrc/locales/ko/main.jsonsrc/locales/pt-BR/main.jsonsrc/locales/ru/main.jsonsrc/locales/tr/main.jsonsrc/locales/zh-TW/main.jsonsrc/locales/zh/main.json
| "gatedHint": "تقييد نماذج الشركاء ميزة ضمن خطة Enterprise.", | ||
| "loadError": "تعذر تحميل وصول عقد الشركاء.", | ||
| "loading": "جارٍ تحميل وصول عقد الشركاء", | ||
| "matchedModelCount": "{matched} من أصل {total} مطابقات | {matched} من أصل {total} مطابقة", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use singular-first ordering for matchedModelCount.
The affected locales place the plural alternative before the singular alternative. This reverses the rendered form for one match.
src/locales/ar/main.json#L4909-L4909: placeمطابقةbeforeمطابقات.src/locales/es/main.json#L4909-L4909: placecoincidenciabeforecoincidencias.src/locales/he/main.json#L4909-L4909: placeהתאמהbeforeהתאמות.src/locales/fr/main.json#L4909-L4909: placecorrespondancebeforecorrespondances.
📍 Affects 4 files
src/locales/ar/main.json#L4909-L4909(this comment)src/locales/es/main.json#L4909-L4909src/locales/he/main.json#L4909-L4909src/locales/fr/main.json#L4909-L4909
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/locales/ar/main.json` at line 4909, Update the matchedModelCount entries
to use singular-first ordering in src/locales/ar/main.json:4909-4909,
src/locales/es/main.json:4909-4909, src/locales/he/main.json:4909-4909, and
src/locales/fr/main.json:4909-4909; place each singular translation before its
plural alternative while preserving the existing placeholders and separator.
| "disableAllCount": "Désactiver le fournisseur {count} | Désactiver les {count} fournisseurs", | ||
| "disableAllMessage": "Tous les fournisseurs seront désactivés. Les nœuds partenaires ne seront pas disponibles tant que l'accès est restreint.", | ||
| "disableAllTitle": "Désactiver tous les fournisseurs ?", | ||
| "enableAll": "Tout activer", | ||
| "disableMatchingCount": "Désactiver le fournisseur correspondant {count} | Désactiver les fournisseurs correspondants {count}", | ||
| "enableAllCount": "Activer le fournisseur {count} | Activer les {count} fournisseurs", | ||
| "enableMatchingCount": "Activer le fournisseur correspondant {count} | Activer les fournisseurs correspondants {count}", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Put {count} before the French noun.
Strings such as Désactiver le fournisseur {count} render a provider named by the number. They do not express “disable N providers.” Apply the correction to all four provider-count keys.
Proposed fix
- "disableAllCount": "Désactiver le fournisseur {count} | Désactiver les {count} fournisseurs",
+ "disableAllCount": "Désactiver {count} fournisseur | Désactiver {count} fournisseurs",
- "disableMatchingCount": "Désactiver le fournisseur correspondant {count} | Désactiver les fournisseurs correspondants {count}",
+ "disableMatchingCount": "Désactiver {count} fournisseur correspondant | Désactiver {count} fournisseurs correspondants",
- "enableAllCount": "Activer le fournisseur {count} | Activer les {count} fournisseurs",
+ "enableAllCount": "Activer {count} fournisseur | Activer {count} fournisseurs",
- "enableMatchingCount": "Activer le fournisseur correspondant {count} | Activer les fournisseurs correspondants {count}",
+ "enableMatchingCount": "Activer {count} fournisseur correspondant | Activer {count} fournisseurs correspondants",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "disableAllCount": "Désactiver le fournisseur {count} | Désactiver les {count} fournisseurs", | |
| "disableAllMessage": "Tous les fournisseurs seront désactivés. Les nœuds partenaires ne seront pas disponibles tant que l'accès est restreint.", | |
| "disableAllTitle": "Désactiver tous les fournisseurs ?", | |
| "enableAll": "Tout activer", | |
| "disableMatchingCount": "Désactiver le fournisseur correspondant {count} | Désactiver les fournisseurs correspondants {count}", | |
| "enableAllCount": "Activer le fournisseur {count} | Activer les {count} fournisseurs", | |
| "enableMatchingCount": "Activer le fournisseur correspondant {count} | Activer les fournisseurs correspondants {count}", | |
| "disableAllCount": "Désactiver {count} fournisseur | Désactiver {count} fournisseurs", | |
| "disableAllMessage": "Tous les fournisseurs seront désactivés. Les nœuds partenaires ne seront pas disponibles tant que l'accès est restreint.", | |
| "disableAllTitle": "Désactiver tous les fournisseurs ?", | |
| "disableMatchingCount": "Désactiver {count} fournisseur correspondant | Désactiver {count} fournisseurs correspondants", | |
| "enableAllCount": "Activer {count} fournisseur | Activer {count} fournisseurs", | |
| "enableMatchingCount": "Activer {count} fournisseur correspondant | Activer {count} fournisseurs correspondants", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/locales/fr/main.json` around lines 4897 - 4902, Update the four
provider-count translation values in the locale entries disableAllCount,
disableMatchingCount, enableAllCount, and enableMatchingCount so {count} appears
before the French noun, preserving the singular/plural variants and intended “N
providers” meaning.
| "allowAllAccessTitle": "Consentire l'accesso a tutti i partner node?", | ||
| "allowAllOffHint": "Gli utenti possono eseguire solo i modelli consentiti di seguito. I nuovi modelli sono disabilitati per impostazione predefinita.", | ||
| "allowAllOnHint": "Disattiva per scegliere quali modelli partner gli utenti possono eseguire.", | ||
| "allowedSummary": "{count} modelli partner consentiti", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- target locale entries ---'
for f in src/locales/it/main.json src/locales/pt-BR/main.json; do
printf '\n%s\n' "$f"
sed -n '4868,4900p' "$f"
done
printf '%s\n' '--- allowedSummary references and locale structure ---'
rg -n -C 3 '"allowedSummary"|allowedSummary' src | head -240
printf '%s\n' '--- locale files containing the same key ---'
rg -l '"allowedSummary"' src/locales | sortRepository: Comfy-Org/ComfyUI_frontend
Length of output: 16170
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- component usage ---'
sed -n '320,360p' src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue
printf '%s\n' '--- Vue I18n setup and pluralization configuration ---'
rg -n -C 4 'createI18n|pluralization|pluralRules|locale|fallbackLocale|i18n-t|`@intlify`|vue-i18n' src package.json pnpm-lock.yaml | head -320
printf '%s\n' '--- locale messages with count plural variants ---'
rg -n -C 1 '"[^"]*": "[^"]*\{count\}[^"]*\|[^"]*\{count\}' src/locales/en/main.json src/locales/it/main.json src/locales/pt-BR/main.json | head -180
printf '%s\n' '--- relevant package versions ---'
rg -n '"(vue-i18n|vue|`@intlify`)[^"]*"' package.jsonRepository: Comfy-Org/ComfyUI_frontend
Length of output: 38256
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- locked Vue I18n version ---'
rg -n -C 3 '(^|/)(vue-i18n|`@intlify/core-base`)@|vue-i18n:' pnpm-lock.yaml | head -100
printf '%s\n' '--- i18n-t usages with plural-related props ---'
rg -n -C 4 '<i18n-t|plural=|:plural=' src --glob '*.vue' | head -320
printf '%s\n' '--- dependency availability ---'
if [ -d node_modules/vue-i18n ]; then
printf '%s\n' 'node_modules/vue-i18n is available'
node -p "require('./node_modules/vue-i18n/package.json').version"
else
printf '%s\n' 'node_modules/vue-i18n is not available'
fi
printf '%s\n' '--- target component context and count source ---'
rg -n -C 5 'enabledModelCount|isRestricted|allowedSummary' \
src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 27649
🌐 Web query:
Vue I18n v11 i18n-t component plural prop named slots pluralization pipe syntax
💡 Result:
In Vue I18n v11, pluralization, component interpolation, and slot management have been streamlined, with older legacy functions like $tc removed [1]. Pluralization via Pipe Syntax Vue I18n uses a pipe (|) character to separate plural forms [2][1]. To use this in v11, you use the standard t translation function with a count parameter, rather than the legacy $tc function [1]. - Syntax: "no items | {n} item | {n} items" [3][2] - Usage: t('key', { n: count }, count) [1] - Note: Always ensure there is a space before and after the pipe character; otherwise, the string will not be split correctly [2]. i18n-t Component and Plural Prop The i18n-t component supports the plural prop to specify the count for pluralization [4][5]. - Component Usage: <i18n-t keypath="message.plural":plural="count"> <template #n> {{ count }} - The plural prop accepts a number or string value, which determines the plural form chosen from the message [4][6]. Named Slots in i18n-t The i18n-t component uses named slots to inject content into translated messages [6][5]. When a keypath contains named placeholders (e.g., {n} or {name}), you provide the content by defining a template with a matching slot name [6][5]. - Recent updates (v11/mid-2026) have refactored the translation component to correctly pass component children as slots, improving stability and ensuring that interpolated VNodes are rendered correctly within custom tags or components [7]. Migration Note The legacy $tc function has been removed in v11 [1]. For all pluralization needs, use the t function or the i18n-t component with the plural prop [5][1]. For complex pluralization requirements (e.g., languages with more than 3 forms), it is recommended to use the ICU message format [1].
Citations:
- 1: https://simplelocalize.io/blog/posts/vue-i18n-localization/
- 2: https://localepack.app/guides/vue-i18n-locale-files-json-yaml-plurals
- 3: https://vue-i18n.intlify.dev/guide/essentials/pluralization
- 4: https://vue-i18n.intlify.dev/api/component
- 5: https://vue-i18n.intlify.dev/guide/migration/features
- 6: https://vue-i18n.intlify.dev/guide/advanced/component
- 7: fix(i18n-t): pass component children as slots intlify/vue-i18n#2475
🏁 Script executed:
#!/bin/bash
set -eu
python3 - <<'PY'
import json
import re
from pathlib import Path
def get_path(obj, path):
for part in path.split("."):
obj = obj[part]
return obj
key = "workspacePanel.partnerNodes.allowedSummary"
for name in ("it", "pt-BR"):
path = Path("src/locales") / name / "main.json"
value = get_path(json.loads(path.read_text()), key)
print(f"{path}: {value!r}")
print(f" forms separated by '|': {len(value.split('|'))}")
print(f" singular noun present: {bool(re.search(r'\\b(modello|modelo)\\b', value))}")
print(f" plural noun present: {bool(re.search(r'\\b(modelli|modelos)\\b', value))}")
component = Path(
"src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue"
).read_text()
match = re.search(
r"<i18n-t\b(?P<body>.*?)</i18n-t>",
component,
re.DOTALL,
)
if not match:
raise SystemExit("allowedSummary i18n-t not found")
body = match.group("body")
print("\nallowedSummary i18n-t:")
print(f" plural prop supplied: {bool(re.search(r'(?::plural|plural)\\s*=', body))}")
print(f" count slot supplied: {bool(re.search(r'<template\\s+#count>', body))}")
PYRepository: Comfy-Org/ComfyUI_frontend
Length of output: 437
🏁 Script executed:
#!/bin/bash
set -eu
python3 - <<'PY'
import json
import re
from pathlib import Path
def get_path(obj, path):
for part in path.split("."):
obj = obj[part]
return obj
key = "workspacePanel.partnerNodes.allowedSummary"
singular_re = re.compile(r"\b(modello|modelo)\b")
plural_re = re.compile(r"\b(modelli|modelos)\b")
for name in ("it", "pt-BR"):
path = Path("src/locales") / name / "main.json"
value = get_path(json.loads(path.read_text()), key)
singular = bool(singular_re.search(value))
plural = bool(plural_re.search(value))
print(f"{path}: {value!r}")
print(f" forms separated by '|': {len(value.split('|'))}")
print(f" singular noun present: {singular}")
print(f" plural noun present: {plural}")
component = Path(
"src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue"
).read_text()
match = re.search(r"<i18n-t\b(?P<body>.*?)</i18n-t>", component, re.DOTALL)
if not match:
raise SystemExit("allowedSummary i18n-t not found")
body = match.group("body")
plural_prop = bool(re.search(r"(?::plural|plural)\s*=", body))
count_slot = bool(re.search(r"<template\s+#count>", body))
print("\nallowedSummary i18n-t:")
print(f" plural prop supplied: {plural_prop}")
print(f" count slot supplied: {count_slot}")
PYRepository: Comfy-Org/ComfyUI_frontend
Length of output: 551
Add singular/plural forms and pass a plural choice to i18n-t. Add {count} modello ... | {count} modelli ... and {count} modelo ... | {count} modelos .... The component currently provides count only as a slot, so Vue I18n cannot select the singular form. Select the plural form when displaying allowedSummaryAll.
📍 Affects 2 files
src/locales/it/main.json#L4888-L4888(this comment)src/locales/pt-BR/main.json#L4888-L4888
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/locales/it/main.json` at line 4888, Update allowedSummary in
src/locales/it/main.json:4888-4888 and src/locales/pt-BR/main.json:4888-4888
with singular/plural forms using the count placeholder. In the component that
displays allowedSummaryAll, pass count as the i18n-t plural choice rather than
only as a slot value.
| "disableMatchingCount": "Disabilita il provider corrispondente {count} | Disabilita i {count} provider corrispondenti", | ||
| "enableAllCount": "Abilita tutti i {count} provider | Abilita tutti i {count} provider", | ||
| "enableMatchingCount": "Abilita il provider corrispondente {count} | Abilita i {count} provider corrispondenti", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- Italian locale context ---'
sed -n '4888,4908p' src/locales/it/main.json
printf '%s\n' '--- Brazilian Portuguese locale context ---'
sed -n '4888,4908p' src/locales/pt-BR/main.json
printf '%s\n' '--- Related count translations across locales ---'
rg -n -C 2 '"(disableAllCount|disableMatchingCount|enableAllCount|enableMatchingCount)"' src/locales
printf '%s\n' '--- Locale metadata and pluralization references ---'
rg -n -C 2 'disableMatchingCount|enableMatchingCount|disableAllCount|enableAllCount|plural' src --glob '!locales/*/main.json' | head -200Repository: Comfy-Org/ComfyUI_frontend
Length of output: 37311
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- Translation call site ---'
sed -n '450,505p' src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue
printf '%s\n' '--- i18n dependencies and configuration ---'
rg -n -C 2 '"vue-i18n"|createI18n|fallbackLocale|locale:' package.json pnpm-lock.yaml src --glob '!src/locales/*/main.json' | head -240
printf '%s\n' '--- Italian count-placement conventions ---'
rg -n -C 1 '\{count\}[^"|]*provider|provider[^"|]*\{count\}|\{count\}[^"|]*modelli|modelli[^"|]*\{count\}' src/locales/it/main.json | head -160
printf '%s\n' '--- Brazilian Portuguese count-placement conventions ---'
rg -n -C 1 '\{count\}[^"|]*provedor|provedor[^"|]*\{count\}|\{count\}[^"|]*modelos|modelos[^"|]*\{count\}' src/locales/pt-BR/main.json | head -160
printf '%s\n' '--- Parse the affected locale entries ---'
python3 - <<'PY'
import json
for path in ('src/locales/it/main.json', 'src/locales/pt-BR/main.json'):
with open(path, encoding='utf-8') as f:
data = json.load(f)
node = data['workspacePanel']['partnerNodes']
print(path)
for key in ('disableAllCount', 'disableMatchingCount', 'enableAllCount', 'enableMatchingCount'):
print(f' {key}: {node[key]!r}')
PYRepository: Comfy-Org/ComfyUI_frontend
Length of output: 25372
Fix singular provider-action count placement.
When count is 1, the affected singular alternatives render provider {count} or provedor {count}. Move {count} before the noun, or omit it from the singular alternative.
- Italian:
disableMatchingCountandenableMatchingCount - Brazilian Portuguese:
disableAllCount,disableMatchingCount,enableAllCount, andenableMatchingCount
📍 Affects 2 files
src/locales/it/main.json#L4900-L4902(this comment)src/locales/pt-BR/main.json#L4897-L4902
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/locales/it/main.json` around lines 4900 - 4902, The singular alternatives
in src/locales/it/main.json lines 4900-4902 for disableMatchingCount and
enableMatchingCount must place {count} before provider or omit it. Apply the
same correction in src/locales/pt-BR/main.json lines 4897-4902 for
disableAllCount, disableMatchingCount, enableAllCount, and enableMatchingCount;
leave plural alternatives unchanged.
| "gatedHint": "La limitazione dei modelli partner è una funzionalità del piano Enterprise.", | ||
| "loadError": "Impossibile caricare l'accesso ai partner node.", | ||
| "loading": "Caricamento accesso partner node", | ||
| "matchedModelCount": "{matched} di {total} corrispondenze | {matched} di {total} corrispondenza", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- locale entries ---'
rg -n -C 2 '"matchedModelCount"' src/locales/it/main.json src/locales/pt-BR/main.json
printf '%s\n' '--- usages and locale conventions ---'
rg -n -C 3 'matchedModelCount|matched.*total|correspondenza|correspondência' src --glob '!**/node_modules/**' | head -240
printf '%s\n' '--- nearby locale variants ---'
python3 - <<'PY'
import json
from pathlib import Path
for path in sorted(Path("src/locales").glob("*/main.json")):
try:
data = json.loads(path.read_text())
except Exception:
continue
def find(obj, prefix=""):
if isinstance(obj, dict):
for k, v in obj.items():
p = f"{prefix}.{k}" if prefix else k
if k == "matchedModelCount":
print(f"{path}: {p} = {v!r}")
find(v, p)
elif isinstance(obj, list):
for i, v in enumerate(obj):
find(v, f"{prefix}[{i}]")
find(data)
PYRepository: Comfy-Org/ComfyUI_frontend
Length of output: 14112
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- locale entries ---'
rg -n -C 2 '"matchedModelCount"' src/locales/it/main.json src/locales/pt-BR/main.json
printf '%s\n' '--- usages and locale conventions ---'
rg -n -C 3 'matchedModelCount|matched.*total|corrispondenza|correspondência' src --glob '!**/node_modules/**' | head -240
printf '%s\n' '--- nearby locale variants ---'
python3 - <<'PY'
import json
from pathlib import Path
for path in sorted(Path("src/locales").glob("*/main.json")):
try:
data = json.loads(path.read_text())
except Exception:
continue
def find(obj, prefix=""):
if isinstance(obj, dict):
for key, value in obj.items():
current = f"{prefix}.{key}" if prefix else key
if key == "matchedModelCount":
print(f"{path}: {current} = {value!r}")
find(value, current)
elif isinstance(obj, list):
for index, value in enumerate(obj):
find(value, f"{prefix}[{index}]")
find(data)
PYRepository: Comfy-Org/ComfyUI_frontend
Length of output: 15690
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- i18n dependencies and configuration ---'
rg -n -C 3 '"vue-i18n"|createI18n|pluralization|pluralRules|localeMessage|fallbackLocale' package.json pnpm-lock.yaml src --glob '!**/node_modules/**' | head -260
printf '%s\n' '--- translation call context ---'
sed -n '250,295p' src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue
rg -n -C 3 '\$t\([^)]*matchedModelCount|matchedModelCount' . --glob '!**/node_modules/**' --glob '!**/dist/**' --glob '!**/build/**'
printf '%s\n' '--- pluralized locale key patterns ---'
python3 - <<'PY'
import json
from pathlib import Path
for path in [Path("src/locales/en/main.json"), Path("src/locales/it/main.json"), Path("src/locales/pt-BR/main.json")]:
data = json.loads(path.read_text())
hits = []
def walk(obj, key=""):
if isinstance(obj, dict):
for k, v in obj.items():
p = f"{key}.{k}" if key else k
if isinstance(v, str) and "|" in v:
hits.append((p, v))
walk(v, p)
elif isinstance(obj, list):
for i, v in enumerate(obj):
walk(v, f"{key}[{i}]")
walk(data)
print(f"{path}: {len(hits)} pipe-separated messages")
for p, v in hits[:30]:
print(f" {p} = {v}")
PYRepository: Comfy-Org/ComfyUI_frontend
Length of output: 45090
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- i18n dependencies and configuration ---'
rg -n -C 3 '"vue-i18n"|createI18n|pluralization|pluralRules|localeMessage|fallbackLocale' package.json pnpm-lock.yaml src --glob '!**/node_modules/**' | head -260
printf '%s\n' '--- translation call context ---'
sed -n '250,295p' src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue
rg -n -C 3 '\$t\([^)]*matchedModelCount|matchedModelCount' . --glob '!**/node_modules/**' --glob '!**/dist/**' --glob '!**/build/**'
printf '%s\n' '--- pluralized locale key patterns ---'
python3 - <<'PY'
import json
from pathlib import Path
for path in [Path("src/locales/en/main.json"), Path("src/locales/it/main.json"), Path("src/locales/pt-BR/main.json")]:
data = json.loads(path.read_text())
hits = []
def walk(obj, key=""):
if isinstance(obj, dict):
for k, v in obj.items():
current = f"{key}.{k}" if key else k
if isinstance(v, str) and "|" in v:
hits.append((current, v))
walk(v, current)
elif isinstance(obj, list):
for i, v in enumerate(obj):
walk(v, f"{key}[{i}]")
walk(data)
print(f"{path}: {len(hits)} pipe-separated messages")
for p, v in hits[:30]:
print(f" {p} = {v}")
PYRepository: Comfy-Org/ComfyUI_frontend
Length of output: 39471
🏁 Script executed:
#!/bin/bash
set -eu
python3 - <<'PY'
import json
import re
from pathlib import Path
component = Path("src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue").read_text()
assert "provider.nodes.length" in component
assert re.search(
r"matchedModelCount[\s\S]{0,500}provider\.nodes\.length",
component,
), "The matched count is not passed to the translation call."
for locale, singular, plural in [
("it", "corrispondenza", "corrispondenze"),
("pt-BR", "correspondência", "correspondências"),
]:
path = Path(f"src/locales/{locale}/main.json")
message = json.loads(path.read_text())["workspacePanel"]["partnerNodes"]["matchedModelCount"]
variants = [part.strip() for part in message.split("|")]
assert len(variants) == 2, (locale, variants)
assert singular in variants[1], (locale, "singular is not second", variants)
assert plural in variants[0], (locale, "plural is not first", variants)
print(f"{locale}: first={variants[0]!r}; second={variants[1]!r}; order is plural|singular")
print("The component supplies provider.nodes.length as the plural choice.")
print("Under the project's two-variant Vue I18n convention, the required order is singular|plural.")
PYRepository: Comfy-Org/ComfyUI_frontend
Length of output: 569
Put the singular variant first in matchedModelCount.
PartnerNodeAccessPanel.vue passes provider.nodes.length as the plural choice. For one matched model, Vue I18n selects the first variant, but both locales place the plural form first. Use singular|plural order in src/locales/it/main.json and src/locales/pt-BR/main.json.
📍 Affects 2 files
src/locales/it/main.json#L4909-L4909(this comment)src/locales/pt-BR/main.json#L4909-L4909
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/locales/it/main.json` at line 4909, Reverse the variant order for
matchedModelCount so the singular form precedes the plural form, matching Vue
I18n’s selection behavior. Apply this change in src/locales/it/main.json at
lines 4909-4909 and src/locales/pt-BR/main.json at lines 4909-4909; no other
translations or symbols require changes.
| "disableAllCount": "Отключить всех: {count} провайдера | Отключить всех: {count} провайдеров", | ||
| "disableAllMessage": "Все провайдеры будут отключены. Партнёрские узлы будут недоступны при ограниченном доступе.", | ||
| "disableAllTitle": "Отключить всех провайдеров?", | ||
| "enableAll": "Включить все", | ||
| "disableMatchingCount": "Отключить {count} соответствующего провайдера | Отключить {count} соответствующих провайдеров", | ||
| "enableAllCount": "Включить всех: {count} провайдера | Включить всех: {count} провайдеров", | ||
| "enableMatchingCount": "Включить {count} соответствующего провайдера | Включить {count} соответствующих провайдеров", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -e
printf '%s\n' '--- target locale excerpt ---'
sed -n '4875,4920p' src/locales/ru/main.json
printf '%s\n' '--- related locale keys ---'
rg -n '"(disableAllCount|disableMatchingCount|enableAllCount|enableMatchingCount|matchedModelCount|modelCount)"' src/locales
printf '%s\n' '--- locale/pluralization configuration references ---'
rg -n 'plural|pluralization|createI18n|localeMessages|main\.json' src --glob '*.{ts,tsx,js,json}' | head -200Repository: Comfy-Org/ComfyUI_frontend
Length of output: 34737
🏁 Script executed:
#!/bin/bash
set -e
printf '%s\n' '--- i18n setup ---'
sed -n '235,275p' src/i18n.ts
printf '%s\n' '--- dependency versions ---'
rg -n '"vue-i18n"|vue-i18n@' package.json pnpm-lock.yaml
printf '%s\n' '--- count-key usages ---'
rg -n 'partnerNodes\.(disableAllCount|disableMatchingCount|enableAllCount|enableMatchingCount|matchedModelCount|modelCount)|disableAllCount|disableMatchingCount|enableAllCount|enableMatchingCount|matchedModelCount|modelCount' src --glob '*.{ts,tsx,vue,js}'
printf '%s\n' '--- Russian plural strings elsewhere ---'
rg -n '"[^"]+"\s*:\s*"[^"]+\s*\|\s*[^"]+\s*\|\s*[^"]+"' src/locales/ru/main.json | head -80Repository: Comfy-Org/ComfyUI_frontend
Length of output: 5307
🏁 Script executed:
#!/bin/bash
set -e
printf '%s\n' '--- PartnerNodeAccessPanel count rendering ---'
sed -n '250,300p' src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue
printf '%s\n' '--- PartnerNodeAccessPanel action labels ---'
sed -n '455,500p' src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue
printf '%s\n' '--- vue-i18n package metadata ---'
sed -n '9385,9400p' pnpm-lock.yaml
sed -n '19020,19040p' pnpm-lock.yaml
printf '%s\n' '--- locale builder and plural configuration ---'
rg -n 'pluralRules|pluralizationRules|buildLocale|SUPPORTED_LOCALES|SupportedLocale' src/i18n.ts src/locales --glob '*.{ts,js}'Repository: Comfy-Org/ComfyUI_frontend
Length of output: 6838
🌐 Web query:
Vue I18n 11.4.8 Russian pluralization pipe choice index locale ru
💡 Result:
In Vue I18n 11.4.8, the default pluralization logic is language-agnostic and does not natively support the specific pluralization requirements of Slavic languages like Russian [1]. If you do not provide custom rules, Vue I18n will apply a default behavior that is insufficient for the three distinct plural categories (one, few, many) required for Russian [1]. To correctly handle Russian pluralization using the pipe | character, you must implement a custom pluralization function and pass it via the pluralRules option (or pluralizationRules for the legacy Options API) when initializing your I18n instance [2][3][4]. The custom rule should map a given count (n) to the index of the corresponding plural form [2][5]. For Russian, a standard implementation follows these logic rules [1]: const i18n = createI18n({ locale: 'ru', pluralRules: { ru: (choice) => { if (choice === 0) return 0; const teen = choice > 10 && choice < 20; const endsWithOne = choice % 10 === 1; if (!teen && endsWithOne) return 1; // "один" (e.g., 1, 21, 31) if (!teen && choice % 10 >= 2 && choice % 10 <= 4) return 2; // "несколько" (e.g., 2, 3, 4, 22) return 3; // "много" (e.g., 5, 10, 11, 20) } }, messages: { ru: { // Index 0: 0, Index 1: 1, Index 2: 2-4, Index 3: 5+ car: '0 машин | {n} машина | {n} машины | {n} машин' } } }); When using this setup, you can access the translation in your template using $t with a count argument or the legacy $tc method: {{ $t('car', 1) }} or {{ $tc('car', 1) }} [2][4][6]. Ensure you include spaces around the pipe | separators, as they are required for correct splitting [6].
Citations:
- 1: Default $tc plurialization in different language intlify/vue-i18n#1006
- 2: https://vue-i18n.intlify.dev/guide/essentials/pluralization
- 3: Custom pluralization rule is not working intlify/vue-i18n#882
- 4: https://kazupon.github.io/vue-i18n/guide/pluralization.html
- 5: https://kazupon.github.io/vue-i18n/ru/guide/pluralization.html
- 6: https://localepack.app/guides/vue-i18n-locale-files-json-yaml-plurals
🌐 Web query:
site:github.com/intlify/vue-i18n v11 pluralRules getPluralIndex default locale ru core-base
💡 Result:
In vue-i18n v11, the pluralRules option (used in the Composition API) determines how plural indices are calculated for different locales [1]. Regarding the Russian (ru) locale and core-base runtime: 1. Limitation in v11: The core-base runtime in v11 uses a simplified default pluralization function (pluralDefault) that is language-agnostic [2]. For Russian, which requires three distinct plural categories (one, few, many) plus "other," this default rule incorrectly caps indices at 2, meaning it never selects the "many" form [2]. 2. Workaround: To support Russian correctly in v11, you must provide an explicit custom pluralRules definition [2]: javascript pluralRules: { ru: (n) => { if (n === 0) return 0 const lt = n % 100, ld = n % 10, teen = lt >= 11 && lt <= 19 if (!teen && ld === 1) return 1 if (!teen && ld >= 2 && ld <= 4) return 2 return 3 } } 3. Future Resolution: Automatic support for CLDR-compliant pluralization using Intl.PluralRules was implemented in subsequent versions (starting with PR #2400) [3], replacing the need for manual Slavic-language rules [2]. If you are working within a v11 environment, the explicit rule above remains the standard solution [2]. For technical context regarding getPluralIndex, recent refactors in packages/core-base/src/runtime.ts have standardized how this function computes indices, ensuring that explicit pluralIndex arguments are prioritized correctly over named parameters (like n or count) [4][5][6].
Citations:
- 1: Custom pluralization rule is not working intlify/vue-i18n#882
- 2: Default $tc plurialization in different language intlify/vue-i18n#1006
- 3: feat!: Support automatic pluralization with
Intl.PluralRulesintlify/vue-i18n#2400 - 4: refactor: reduce variable assignments and function calls intlify/vue-i18n#2392
- 5: fix: Numeric named parameter overwrites plural parameter in pluralization intlify/vue-i18n#2413
- 6: Numeric named parameter overwrites plural parameter in pluralization intlify/vue-i18n#2120
🏁 Script executed:
#!/bin/bash
set -e
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
curl -fsSL https://raw.githubusercontent.com/intlify/vue-i18n/v11.4.8/packages/core-base/src/runtime.ts \
-o "$tmpdir/runtime.ts"
printf '%s\n' '--- pluralization implementation ---'
rg -n -A45 -B10 'pluralDefault|getPluralIndex|pluralRules' "$tmpdir/runtime.ts"
printf '%s\n' '--- i18n 11.4.8 createI18n pluralRules wiring ---'
curl -fsSL https://raw.githubusercontent.com/intlify/vue-i18n/v11.4.8/packages/vue-i18n-core/src/composer.ts \
| rg -n -A12 -B8 'pluralRules|pluralIndex'Repository: Comfy-Org/ComfyUI_frontend
Length of output: 9321
🏁 Script executed:
#!/bin/bash
set -e
python3 - <<'PY'
import json
from pathlib import Path
data = json.loads(Path("src/locales/ru/main.json").read_text())
keys = [
"disableAllCount",
"disableMatchingCount",
"enableAllCount",
"enableMatchingCount",
"matchedModelCount",
"modelCount",
]
messages = data["workspacePanel"]["partnerNodes"]
def vue_i18n_11_default_index(count, choices):
count = abs(count)
if len(choices) == 2:
return 0 if count == 1 else 1
return min(count, 2)
for key in keys:
choices = [part.strip() for part in messages[key].split("|")]
print(key, "forms=", len(choices))
for count in (0, 1, 2, 4, 5, 21, 22):
index = vue_i18n_11_default_index(count, choices)
print(f" count={count}: form[{index}]={choices[index]}")
PYRepository: Comfy-Org/ComfyUI_frontend
Length of output: 2596
Add Russian pluralization support.
vue-i18n 11.4.8 has no built-in Russian rule. Without pluralRules.ru, the current labels use the plural form for every count except 1, so counts 2–4 are incorrect. Add a Russian plural rule in src/i18n.ts, then provide 1 | 2–4 | 5+ forms for all six labels. Reverse matchedModelCount so count 1 uses the singular form.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/locales/ru/main.json` around lines 4897 - 4902, Add a Russian
pluralization rule under the existing pluralRules configuration in i18n.ts,
using forms for 1, 2–4, and 5+ counts. Update the six locale labels
disableAllCount, disableMatchingCount, enableAllCount, enableMatchingCount, and
their corresponding matchedModelCount entries to provide all three Russian
forms, and reverse matchedModelCount ordering so count 1 selects the singular
form.
6d6a6fa to
6045f54
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15137 +/- ##
========================================
Coverage 81.12% 81.13%
========================================
Files 1882 1882
Lines 124447 123731 -716
Branches 39618 39445 -173
========================================
- Hits 100960 100384 -576
+ Misses 22931 22801 -130
+ Partials 556 546 -10 see 20 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…mfy-Org#15062) ## Summary Replace the `@lobehub/i18n-cli` translation step with an in-house pipeline (`scripts/i18n/`) so changed English source strings are retranslated, removed keys are pruned, and protected syntax survives translation byte-for-byte. The user-facing and correctness repairs were split into Comfy-Org#15137 (merged). This PR is strictly the framework migration. ## Changes - `pnpm locale` now runs `scripts/i18n/update-locales.ts`. It records the English sources of the last successful run as git blob hashes in `src/locales/.source-manifest.json`, diffs them against the current `src/locales/en/*.json` to invalidate changed and deleted keys, and rebuilds every output locale from the English structure. - Validates interpolation placeholders and protected literals (`<Picture N>`, `17k+5`, quoted `match` and `max`), retries corrupted translations, and aborts without writing if corruption persists. - `pnpm locale:check` reports pending work offline. - Normalizes English entry files to the committed serialization before hashing so manifest hashes match workflow commits regardless of `collect-i18n` and formatting order. - Removes `@lobehub/i18n-cli` and `.i18nrc.cjs`; configuration now lives in `scripts/i18n/config.ts`. - Translation requests go through the official `openai` SDK (the one new dependency, dev-only with no transitive dependencies), which owns transport retries, timeouts, and typed completion parsing; the pipeline keeps only domain-level retries for truncated or malformed completions. - Uses a blobless full-history checkout in the i18n workflows so recorded English source blobs can be fetched on demand. ## Review Focus Manifest advancement only after full validation; rebuild-from-source semantics; translation retry and validation behavior; and source-provenance handling. Depends on Comfy-Org#15137 (merged). Supersedes Comfy-Org#15024. [FE-1499](https://linear.app/comfyorg/issue/FE-1499/fix-i18n-release-workflow-changed-source-strings-stay-stale-and)
Summary
Split the existing user-facing and correctness repairs out of #15062 so the framework migration can be reviewed independently.
Changes
main, preserving translations that were independently updated onmainin the meantime.temp/diff, notComfyUI_frontend/temp/diff).Validation
knip, passed.Extracted mechanically from #15062; no repair content was reauthored.