Skip to content

[backport cloud/1.51] fix: resolve widget labels, output names and tooltips from the backend - #15482

Merged
comfy-pr-bot merged 1 commit into
cloud/1.51from
backport-14797-to-cloud-1.51
Aug 20, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.51from
backport-14797-to-cloud-1.51

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #14797 to cloud/1.51

Automatically created by backport workflow.

#14797)

#14541 made English
`display_name` and `description` come from the backend. Widget labels,
output names and tooltips were still read from the stale bundled
snapshot, so a renamed node showed a new title beside old labels.

Adds `resolveNodeDefInputText` / `resolveNodeDefOutputText` and extracts
`resolveNodeDefPath`, so the per-locale precedence table now lives in
exactly one place and `resolveNodeDefText` delegates to it. Applied in
`litegraphService` (widget labels, socket and output `localized_name`),
`NodeTooltip.vue`, and `useNodeTooltips.ts`. Also fixes
`getNodeDescription`, which wrapped an already-resolved value in `st()`
and let the stale bundle win.

## Review focus

**Tooltips must never be escaped or compiled.** They are read through
`stRaw`/`tm()`, which returns the message uncompiled, so a literal
`{'@'}` would render to the user. One function decides it:

```ts
return field === 'tooltip' ? stRaw : st
```

Backend values short-circuit before any reader runs, so a tooltip
reaches the compiler by no path. No runtime escaping added;
`escapeI18nMessage` stays build-time-only.

Coverage was verified by mutation rather than inspection, which matters
here: `st()` swallows a vue-i18n `SyntaxError` and returns the raw
stored message, so a fixture containing a throwing character passes
whether or not the code is correct. The raw/compiled fixture (`50{'%'}
{'@'}`) compiles cleanly so that escape hatch cannot mask a defect.
Forcing the reader to always-`st` or always-`stRaw` each fails the
suite.

## Migration guidance (`node.widgets`)

`widget.label` now resolves through the node-def text pipeline
(custom-node translations, then the live backend value, then the bundled
snapshot) instead of taking the node definition's `display_name`
verbatim. The resolved string therefore varies by active locale and by
what `/object_info` sends.

Extensions must use `widget.name` for widget identity. `widget.label` is
display text and was never stable across locales. No type or API shape
changed.

Fixes #14631

---
Previously merged without review and backed out by
#14791. Re-submitting
for normal review. Rebased onto post-revert `main`; content unchanged.

---------

Co-authored-by: Connor Byrne <c.byrne@comfy.org>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: DrJKL <DrJKL0424@gmail.com>
@comfy-pr-bot
comfy-pr-bot requested a review from a team as a code owner August 20, 2026 06:21
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 20, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 20, 2026 06:21
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1818 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1797 / ❌ 0 / ⚠️ 4 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/20/2026, 06:23:34 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 89ms TBT · 75.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
vue-large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 165.2 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 5ms TBT · 160.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 328ms
canvas-idle: script duration 6ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.4 MB
canvas-idle: DOM nodes 22
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 23ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 558ms
canvas-mouse-sweep: script duration 67ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.5 MB
canvas-mouse-sweep: DOM nodes 57
canvas-mouse-sweep: event listeners 5
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 11ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 261ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.2 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 264ms
dom-widget-clipping: script duration 36ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 51.1 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 434ms
large-graph-idle: script duration 13ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 65.1 MB
large-graph-idle: DOM nodes -281
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 824ms
large-graph-pan: script duration 225ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 60.4 MB
large-graph-pan: DOM nodes -282
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 966ms
large-graph-zoom: script duration 273ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 76.4 MB
large-graph-zoom: DOM nodes 15
large-graph-zoom: event listeners 8
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 10
minimap-idle: task duration 438ms
minimap-idle: script duration 13ms
minimap-idle: TBT 0ms
minimap-idle: heap used 71.6 MB
minimap-idle: DOM nodes -282
minimap-idle: event listeners -162
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 49
subgraph-dom-widget-clipping: task duration 278ms
subgraph-dom-widget-clipping: script duration 78ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 53.0 MB
subgraph-dom-widget-clipping: DOM nodes 23
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 323ms
subgraph-idle: script duration 5ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.8 MB
subgraph-idle: DOM nodes 22
subgraph-idle: event listeners 6
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 25ms
subgraph-mouse-sweep: layout count 17
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 541ms
subgraph-mouse-sweep: script duration 57ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 59.1 MB
subgraph-mouse-sweep: DOM nodes 63
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 8ms
subgraph-transition-enter: style recalc duration 21ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 592ms
subgraph-transition-enter: script duration 11ms
subgraph-transition-enter: TBT 89ms
subgraph-transition-enter: heap used 75.9 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 2913ms
viewport-pan-sweep: script duration 751ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 71.1 MB
viewport-pan-sweep: DOM nodes -282
viewport-pan-sweep: event listeners -133
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 10983ms
vue-large-graph-idle: script duration 78ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 165.2 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16393
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 68
vue-large-graph-pan: task duration 13393ms
vue-large-graph-pan: script duration 386ms
vue-large-graph-pan: TBT 5ms
vue-large-graph-pan: heap used 160.1 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16387
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 0ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 2
workflow-execution: style recalc count 16
workflow-execution: task duration 79ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.4 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 99
Raw data
{
  "timestamp": "2026-08-20T06:32:18.584Z",
  "gitSha": "491996c1b5b0fc9b725abacebeb2f900d869a6bc",
  "branch": "backport-14797-to-cloud-1.51",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2017.5090000000182,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.606,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 345.991,
      "heapDeltaBytes": 5074360,
      "heapUsedBytes": 70637456,
      "domNodes": 20,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 5.835,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2004.1220000000521,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.231999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 310.38999999999993,
      "heapDeltaBytes": 4973456,
      "heapUsedBytes": 70614952,
      "domNodes": 24,
      "jsHeapTotalBytes": 23855104,
      "scriptDurationMs": 5.264000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1707.6779999999872,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 22.504999999999995,
      "layouts": 12,
      "layoutDurationMs": 2.69,
      "taskDurationMs": 559.254,
      "heapDeltaBytes": 130004,
      "heapUsedBytes": 65486332,
      "domNodes": 56,
      "jsHeapTotalBytes": 25694208,
      "scriptDurationMs": 67.04199999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1686.4140000000134,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 23.147999999999996,
      "layouts": 12,
      "layoutDurationMs": 2.484,
      "taskDurationMs": 557.644,
      "heapDeltaBytes": 93904,
      "heapUsedBytes": 65516188,
      "domNodes": 57,
      "jsHeapTotalBytes": 25432064,
      "scriptDurationMs": 67.70599999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1670.2619999999797,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 11.142999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.49799999999999994,
      "taskDurationMs": 265.745,
      "heapDeltaBytes": 8399212,
      "heapUsedBytes": 73725552,
      "domNodes": 79,
      "jsHeapTotalBytes": 23855104,
      "scriptDurationMs": 8.301,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.826000000021,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 11.498000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.6309999999999999,
      "taskDurationMs": 256.56,
      "heapDeltaBytes": 7944280,
      "heapUsedBytes": 73429200,
      "domNodes": 78,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 7.693999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 437.0930000000044,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 5.851,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 266.397,
      "heapDeltaBytes": -11902456,
      "heapUsedBytes": 53594500,
      "domNodes": 22,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 35.226,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 425.83300000001145,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.442000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 261.857,
      "heapDeltaBytes": -11846252,
      "heapUsedBytes": 53612428,
      "domNodes": 20,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 36.276999999999994,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 1994.2810000000009,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.252000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 436.99000000000007,
      "heapDeltaBytes": 4283660,
      "heapUsedBytes": 65008936,
      "domNodes": -281,
      "jsHeapTotalBytes": 2195456,
      "scriptDurationMs": 14.191000000000003,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2021.1690000001,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.3660000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.795,
      "heapDeltaBytes": 11321568,
      "heapUsedBytes": 71563488,
      "domNodes": -280,
      "jsHeapTotalBytes": 2719744,
      "scriptDurationMs": 10.937,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2057.8080000000227,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.306,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 846.064,
      "heapDeltaBytes": 7315104,
      "heapUsedBytes": 67947404,
      "domNodes": -282,
      "jsHeapTotalBytes": 3960832,
      "scriptDurationMs": 236.3,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2073.1100000000424,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 11.133000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 802.2109999999999,
      "heapDeltaBytes": -2895692,
      "heapUsedBytes": 58706388,
      "domNodes": -282,
      "jsHeapTotalBytes": 3698688,
      "scriptDurationMs": 214.274,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3069.7440000000142,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 14.146,
      "layouts": 60,
      "layoutDurationMs": 7.759,
      "taskDurationMs": 1010.578,
      "heapDeltaBytes": 18332696,
      "heapUsedBytes": 80886732,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 296.229,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3071.9870000000356,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.936,
      "layouts": 60,
      "layoutDurationMs": 7.379,
      "taskDurationMs": 921.9259999999999,
      "heapDeltaBytes": 16164024,
      "heapUsedBytes": 79306012,
      "domNodes": 14,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 250.231,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.075000000058,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.964000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.24100000000004,
      "heapDeltaBytes": 13168312,
      "heapUsedBytes": 74638040,
      "domNodes": -282,
      "jsHeapTotalBytes": 2981888,
      "scriptDurationMs": 13.325999999999997,
      "eventListeners": -177,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2005.1479999999628,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.800000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.897,
      "heapDeltaBytes": 12541808,
      "heapUsedBytes": 75482388,
      "domNodes": -281,
      "jsHeapTotalBytes": 3244032,
      "scriptDurationMs": 12.593999999999998,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 492.20500000001266,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 7.7920000000000025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 295.16900000000004,
      "heapDeltaBytes": -9909080,
      "heapUsedBytes": 55605692,
      "domNodes": 22,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 82.399,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 426.5240000001995,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 7.921999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 261.753,
      "heapDeltaBytes": -9962784,
      "heapUsedBytes": 55591716,
      "domNodes": 24,
      "jsHeapTotalBytes": 23855104,
      "scriptDurationMs": 73.215,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.316999999991,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.035,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 329.063,
      "heapDeltaBytes": 5628544,
      "heapUsedBytes": 71190988,
      "domNodes": 22,
      "jsHeapTotalBytes": 23855104,
      "scriptDurationMs": 5.681,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2003.5139999999956,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.548000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 316.894,
      "heapDeltaBytes": 5346692,
      "heapUsedBytes": 71093676,
      "domNodes": 22,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 5.297,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1672.2279999999046,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 26.119999999999997,
      "layouts": 17,
      "layoutDurationMs": 3.698,
      "taskDurationMs": 556.5360000000001,
      "heapDeltaBytes": -3611192,
      "heapUsedBytes": 61886384,
      "domNodes": 63,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 59.57,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1673.2690000001185,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 24.616999999999997,
      "layouts": 16,
      "layoutDurationMs": 3.202,
      "taskDurationMs": 525.056,
      "heapDeltaBytes": -3727012,
      "heapUsedBytes": 61953084,
      "domNodes": 63,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 53.528999999999996,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 816.2020000000894,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 20.929999999999996,
      "layouts": 16,
      "layoutDurationMs": 7.576999999999999,
      "taskDurationMs": 592.4119999999999,
      "heapDeltaBytes": -5987844,
      "heapUsedBytes": 79587780,
      "domNodes": 13673,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 10.577000000000004,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 89,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8091.686999999979,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 36.486000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3049.0620000000004,
      "heapDeltaBytes": 15943240,
      "heapUsedBytes": 76244380,
      "domNodes": -282,
      "jsHeapTotalBytes": 3960832,
      "scriptDurationMs": 820.5010000000001,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8087.187999999969,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 32.278,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2777.06,
      "heapDeltaBytes": 12726740,
      "heapUsedBytes": 72837172,
      "domNodes": -282,
      "jsHeapTotalBytes": 4485120,
      "scriptDurationMs": 682.4820000000001,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11905.814000000079,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11243.771999999999,
      "heapDeltaBytes": -34016720,
      "heapUsedBytes": 177869412,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9900032,
      "scriptDurationMs": 77.96700000000001,
      "eventListeners": -16395,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11798.00699999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10721.351999999999,
      "heapDeltaBytes": -42245528,
      "heapUsedBytes": 168653388,
      "domNodes": -8312,
      "jsHeapTotalBytes": -12259328,
      "scriptDurationMs": 77.327,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14214.275000000043,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.539999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13592.389000000001,
      "heapDeltaBytes": -46620088,
      "heapUsedBytes": 164885872,
      "domNodes": -8312,
      "jsHeapTotalBytes": -16420864,
      "scriptDurationMs": 387.969,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13966.204999999945,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 14.093999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13193.777999999998,
      "heapDeltaBytes": -39998388,
      "heapUsedBytes": 170845328,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14688256,
      "scriptDurationMs": 384.869,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 9,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 440.49699999993663,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 12.526,
      "layouts": 2,
      "layoutDurationMs": 0.33399999999999996,
      "taskDurationMs": 75.961,
      "heapDeltaBytes": 4996944,
      "heapUsedBytes": 69609864,
      "domNodes": 128,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 5.507000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 433.74100000005456,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 13.498,
      "layouts": 2,
      "layoutDurationMs": 0.5040000000000001,
      "taskDurationMs": 82.38799999999999,
      "heapDeltaBytes": 4971284,
      "heapUsedBytes": 69566388,
      "domNodes": 127,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 5.800000000000002,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 20, 2026
@github-actions
github-actions Bot requested a review from AustinMroz August 20, 2026 06:22
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/services/litegraphService.ts 77.77% 1 Missing and 1 partial ⚠️
@@              Coverage Diff              @@
##             cloud/1.51   #15482   +/-   ##
=============================================
  Coverage              ?   81.49%           
=============================================
  Files                 ?     1883           
  Lines                 ?   117533           
  Branches              ?    36702           
=============================================
  Hits                  ?    95787           
  Misses                ?    21274           
  Partials              ?      472           
Flag Coverage Δ
unit 73.05% <96.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/graph/NodeTooltip.vue 94.33% <100.00%> (ø)
src/i18n.ts 97.47% <100.00%> (ø)
...derer/extensions/vueNodes/components/InputSlot.vue 90.69% <100.00%> (ø)
...extensions/vueNodes/composables/useNodeTooltips.ts 98.24% <100.00%> (ø)
src/services/litegraphService.ts 70.33% <77.77%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit bfe8485 into cloud/1.51 Aug 20, 2026
88 of 90 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-14797-to-cloud-1.51 branch August 20, 2026 06:49
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants