Repository navigation
[backport cloud/1.51] fix: resolve widget labels, output names and tooltips from the backend - #15482
Conversation
#14797) #14541 made English `display_name` and `description` come from the backend. Widget labels, output names and tooltips were still read from the stale bundled snapshot, so a renamed node showed a new title beside old labels. Adds `resolveNodeDefInputText` / `resolveNodeDefOutputText` and extracts `resolveNodeDefPath`, so the per-locale precedence table now lives in exactly one place and `resolveNodeDefText` delegates to it. Applied in `litegraphService` (widget labels, socket and output `localized_name`), `NodeTooltip.vue`, and `useNodeTooltips.ts`. Also fixes `getNodeDescription`, which wrapped an already-resolved value in `st()` and let the stale bundle win. ## Review focus **Tooltips must never be escaped or compiled.** They are read through `stRaw`/`tm()`, which returns the message uncompiled, so a literal `{'@'}` would render to the user. One function decides it: ```ts return field === 'tooltip' ? stRaw : st ``` Backend values short-circuit before any reader runs, so a tooltip reaches the compiler by no path. No runtime escaping added; `escapeI18nMessage` stays build-time-only. Coverage was verified by mutation rather than inspection, which matters here: `st()` swallows a vue-i18n `SyntaxError` and returns the raw stored message, so a fixture containing a throwing character passes whether or not the code is correct. The raw/compiled fixture (`50{'%'} {'@'}`) compiles cleanly so that escape hatch cannot mask a defect. Forcing the reader to always-`st` or always-`stRaw` each fails the suite. ## Migration guidance (`node.widgets`) `widget.label` now resolves through the node-def text pipeline (custom-node translations, then the live backend value, then the bundled snapshot) instead of taking the node definition's `display_name` verbatim. The resolved string therefore varies by active locale and by what `/object_info` sends. Extensions must use `widget.name` for widget identity. `widget.label` is display text and was never stable across locales. No type or API shape changed. Fixes #14631 --- Previously merged without review and backed out by #14791. Re-submitting for normal review. Rebased onto post-revert `main`; content unchanged. --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: DrJKL <DrJKL0424@gmail.com>
🎭 Playwright: ✅ 1818 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-20T06:32:18.584Z",
"gitSha": "491996c1b5b0fc9b725abacebeb2f900d869a6bc",
"branch": "backport-14797-to-cloud-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.5090000000182,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.606,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.991,
"heapDeltaBytes": 5074360,
"heapUsedBytes": 70637456,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 5.835,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2004.1220000000521,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.231999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.38999999999993,
"heapDeltaBytes": 4973456,
"heapUsedBytes": 70614952,
"domNodes": 24,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 5.264000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.6779999999872,
"styleRecalcs": 72,
"styleRecalcDurationMs": 22.504999999999995,
"layouts": 12,
"layoutDurationMs": 2.69,
"taskDurationMs": 559.254,
"heapDeltaBytes": 130004,
"heapUsedBytes": 65486332,
"domNodes": 56,
"jsHeapTotalBytes": 25694208,
"scriptDurationMs": 67.04199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1686.4140000000134,
"styleRecalcs": 73,
"styleRecalcDurationMs": 23.147999999999996,
"layouts": 12,
"layoutDurationMs": 2.484,
"taskDurationMs": 557.644,
"heapDeltaBytes": 93904,
"heapUsedBytes": 65516188,
"domNodes": 57,
"jsHeapTotalBytes": 25432064,
"scriptDurationMs": 67.70599999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.2619999999797,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.142999999999999,
"layouts": 6,
"layoutDurationMs": 0.49799999999999994,
"taskDurationMs": 265.745,
"heapDeltaBytes": 8399212,
"heapUsedBytes": 73725552,
"domNodes": 79,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 8.301,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.826000000021,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.498000000000001,
"layouts": 6,
"layoutDurationMs": 0.6309999999999999,
"taskDurationMs": 256.56,
"heapDeltaBytes": 7944280,
"heapUsedBytes": 73429200,
"domNodes": 78,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 7.693999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 437.0930000000044,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.851,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 266.397,
"heapDeltaBytes": -11902456,
"heapUsedBytes": 53594500,
"domNodes": 22,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 35.226,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 425.83300000001145,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.442000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 261.857,
"heapDeltaBytes": -11846252,
"heapUsedBytes": 53612428,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 36.276999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 1994.2810000000009,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.252000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.99000000000007,
"heapDeltaBytes": 4283660,
"heapUsedBytes": 65008936,
"domNodes": -281,
"jsHeapTotalBytes": 2195456,
"scriptDurationMs": 14.191000000000003,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.1690000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.3660000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.795,
"heapDeltaBytes": 11321568,
"heapUsedBytes": 71563488,
"domNodes": -280,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 10.937,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2057.8080000000227,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.306,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 846.064,
"heapDeltaBytes": 7315104,
"heapUsedBytes": 67947404,
"domNodes": -282,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 236.3,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2073.1100000000424,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.133000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 802.2109999999999,
"heapDeltaBytes": -2895692,
"heapUsedBytes": 58706388,
"domNodes": -282,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 214.274,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3069.7440000000142,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.146,
"layouts": 60,
"layoutDurationMs": 7.759,
"taskDurationMs": 1010.578,
"heapDeltaBytes": 18332696,
"heapUsedBytes": 80886732,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 296.229,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3071.9870000000356,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.936,
"layouts": 60,
"layoutDurationMs": 7.379,
"taskDurationMs": 921.9259999999999,
"heapDeltaBytes": 16164024,
"heapUsedBytes": 79306012,
"domNodes": 14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 250.231,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.075000000058,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.964000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.24100000000004,
"heapDeltaBytes": 13168312,
"heapUsedBytes": 74638040,
"domNodes": -282,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 13.325999999999997,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.1479999999628,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.800000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.897,
"heapDeltaBytes": 12541808,
"heapUsedBytes": 75482388,
"domNodes": -281,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 12.593999999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 492.20500000001266,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.7920000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.16900000000004,
"heapDeltaBytes": -9909080,
"heapUsedBytes": 55605692,
"domNodes": 22,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 82.399,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 426.5240000001995,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.921999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 261.753,
"heapDeltaBytes": -9962784,
"heapUsedBytes": 55591716,
"domNodes": 24,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 73.215,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.316999999991,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.063,
"heapDeltaBytes": 5628544,
"heapUsedBytes": 71190988,
"domNodes": 22,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 5.681,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2003.5139999999956,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.548000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.894,
"heapDeltaBytes": 5346692,
"heapUsedBytes": 71093676,
"domNodes": 22,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 5.297,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1672.2279999999046,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.119999999999997,
"layouts": 17,
"layoutDurationMs": 3.698,
"taskDurationMs": 556.5360000000001,
"heapDeltaBytes": -3611192,
"heapUsedBytes": 61886384,
"domNodes": 63,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 59.57,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.2690000001185,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.616999999999997,
"layouts": 16,
"layoutDurationMs": 3.202,
"taskDurationMs": 525.056,
"heapDeltaBytes": -3727012,
"heapUsedBytes": 61953084,
"domNodes": 63,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 53.528999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 816.2020000000894,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.929999999999996,
"layouts": 16,
"layoutDurationMs": 7.576999999999999,
"taskDurationMs": 592.4119999999999,
"heapDeltaBytes": -5987844,
"heapUsedBytes": 79587780,
"domNodes": 13673,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 10.577000000000004,
"eventListeners": 2373,
"totalBlockingTimeMs": 89,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8091.686999999979,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.486000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3049.0620000000004,
"heapDeltaBytes": 15943240,
"heapUsedBytes": 76244380,
"domNodes": -282,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 820.5010000000001,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8087.187999999969,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.278,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2777.06,
"heapDeltaBytes": 12726740,
"heapUsedBytes": 72837172,
"domNodes": -282,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 682.4820000000001,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11905.814000000079,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11243.771999999999,
"heapDeltaBytes": -34016720,
"heapUsedBytes": 177869412,
"domNodes": -8312,
"jsHeapTotalBytes": -9900032,
"scriptDurationMs": 77.96700000000001,
"eventListeners": -16395,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11798.00699999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10721.351999999999,
"heapDeltaBytes": -42245528,
"heapUsedBytes": 168653388,
"domNodes": -8312,
"jsHeapTotalBytes": -12259328,
"scriptDurationMs": 77.327,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14214.275000000043,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.539999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13592.389000000001,
"heapDeltaBytes": -46620088,
"heapUsedBytes": 164885872,
"domNodes": -8312,
"jsHeapTotalBytes": -16420864,
"scriptDurationMs": 387.969,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13966.204999999945,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.093999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13193.777999999998,
"heapDeltaBytes": -39998388,
"heapUsedBytes": 170845328,
"domNodes": -8312,
"jsHeapTotalBytes": -14688256,
"scriptDurationMs": 384.869,
"eventListeners": -16387,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 440.49699999993663,
"styleRecalcs": 16,
"styleRecalcDurationMs": 12.526,
"layouts": 2,
"layoutDurationMs": 0.33399999999999996,
"taskDurationMs": 75.961,
"heapDeltaBytes": 4996944,
"heapUsedBytes": 69609864,
"domNodes": 128,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 5.507000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 433.74100000005456,
"styleRecalcs": 15,
"styleRecalcDurationMs": 13.498,
"layouts": 2,
"layoutDurationMs": 0.5040000000000001,
"taskDurationMs": 82.38799999999999,
"heapDeltaBytes": 4971284,
"heapUsedBytes": 69566388,
"domNodes": 127,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 5.800000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.51 #15482 +/- ##
=============================================
Coverage ? 81.49%
=============================================
Files ? 1883
Lines ? 117533
Branches ? 36702
=============================================
Hits ? 95787
Misses ? 21274
Partials ? 472
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14797 to
cloud/1.51Automatically created by backport workflow.