Repository navigation
[backport core/1.51] fix: resolve widget labels, output names and tooltips from the backend - #15480
Conversation
#14797) #14541 made English `display_name` and `description` come from the backend. Widget labels, output names and tooltips were still read from the stale bundled snapshot, so a renamed node showed a new title beside old labels. Adds `resolveNodeDefInputText` / `resolveNodeDefOutputText` and extracts `resolveNodeDefPath`, so the per-locale precedence table now lives in exactly one place and `resolveNodeDefText` delegates to it. Applied in `litegraphService` (widget labels, socket and output `localized_name`), `NodeTooltip.vue`, and `useNodeTooltips.ts`. Also fixes `getNodeDescription`, which wrapped an already-resolved value in `st()` and let the stale bundle win. ## Review focus **Tooltips must never be escaped or compiled.** They are read through `stRaw`/`tm()`, which returns the message uncompiled, so a literal `{'@'}` would render to the user. One function decides it: ```ts return field === 'tooltip' ? stRaw : st ``` Backend values short-circuit before any reader runs, so a tooltip reaches the compiler by no path. No runtime escaping added; `escapeI18nMessage` stays build-time-only. Coverage was verified by mutation rather than inspection, which matters here: `st()` swallows a vue-i18n `SyntaxError` and returns the raw stored message, so a fixture containing a throwing character passes whether or not the code is correct. The raw/compiled fixture (`50{'%'} {'@'}`) compiles cleanly so that escape hatch cannot mask a defect. Forcing the reader to always-`st` or always-`stRaw` each fails the suite. ## Migration guidance (`node.widgets`) `widget.label` now resolves through the node-def text pipeline (custom-node translations, then the live backend value, then the bundled snapshot) instead of taking the node definition's `display_name` verbatim. The resolved string therefore varies by active locale and by what `/object_info` sends. Extensions must use `widget.name` for widget identity. `widget.label` is display text and was never stable across locales. No type or API shape changed. Fixes #14631 --- Previously merged without review and backed out by #14791. Re-submitting for normal review. Rebased onto post-revert `main`; content unchanged. --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: DrJKL <DrJKL0424@gmail.com>
🎭 Playwright: ✅ 1822 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-20T06:32:46.256Z",
"gitSha": "1a632d1d83e94d1c9afc336eb1649bf2426d73ef",
"branch": "backport-14797-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2002.523999999994,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.971,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.876,
"heapDeltaBytes": 5061848,
"heapUsedBytes": 70492024,
"domNodes": 22,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 5.576,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2001.9399999999905,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.056,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.45099999999996,
"heapDeltaBytes": 5032920,
"heapUsedBytes": 70523776,
"domNodes": 22,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 4.783,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1696.5400000000272,
"styleRecalcs": 71,
"styleRecalcDurationMs": 19.160000000000004,
"layouts": 12,
"layoutDurationMs": 1.9619999999999997,
"taskDurationMs": 523.26,
"heapDeltaBytes": -189632,
"heapUsedBytes": 65199088,
"domNodes": 54,
"jsHeapTotalBytes": 24645632,
"scriptDurationMs": 57.409000000000006,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1671.043999999938,
"styleRecalcs": 72,
"styleRecalcDurationMs": 19.602,
"layouts": 12,
"layoutDurationMs": 1.77,
"taskDurationMs": 533.959,
"heapDeltaBytes": -305116,
"heapUsedBytes": 65249936,
"domNodes": 56,
"jsHeapTotalBytes": 24383488,
"scriptDurationMs": 62.45799999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.8590000000117,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.03,
"layouts": 6,
"layoutDurationMs": 0.40499999999999997,
"taskDurationMs": 238.56299999999996,
"heapDeltaBytes": 7831988,
"heapUsedBytes": 73213528,
"domNodes": 79,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 5.783,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.6279999999888,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.99,
"layouts": 6,
"layoutDurationMs": 0.541,
"taskDurationMs": 249.382,
"heapDeltaBytes": 8285808,
"heapUsedBytes": 73707784,
"domNodes": 78,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.879,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 417.12000000001126,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.658999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 241.91899999999995,
"heapDeltaBytes": -12804220,
"heapUsedBytes": 52394648,
"domNodes": 22,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 32.262,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 424.72300000008545,
"styleRecalcs": 14,
"styleRecalcDurationMs": 5.365,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 260.197,
"heapDeltaBytes": -10696388,
"heapUsedBytes": 54842892,
"domNodes": 24,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 33.00899999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 1993.7110000000189,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.727000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.76900000000006,
"heapDeltaBytes": 11157424,
"heapUsedBytes": 71834336,
"domNodes": -282,
"jsHeapTotalBytes": 1933312,
"scriptDurationMs": 7.317,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 1993.7479999999823,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.793000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.968,
"heapDeltaBytes": 12809036,
"heapUsedBytes": 73109220,
"domNodes": -280,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 8.743,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2036.3699999999767,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.244,
"heapDeltaBytes": 10003816,
"heapUsedBytes": 73242036,
"domNodes": -283,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 185.695,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2091.9099999999844,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.389000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 770.335,
"heapDeltaBytes": -2234132,
"heapUsedBytes": 59373900,
"domNodes": -284,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 204.152,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3121.25199999997,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.862,
"layouts": 60,
"layoutDurationMs": 4.688000000000001,
"taskDurationMs": 851.702,
"heapDeltaBytes": -7354784,
"heapUsedBytes": 54851360,
"domNodes": -282,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 213.905,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3056.367000000023,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.85,
"layouts": 60,
"layoutDurationMs": 5.396,
"taskDurationMs": 845.7150000000001,
"heapDeltaBytes": 16526016,
"heapUsedBytes": 79436516,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 230.08800000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1991.8739999999957,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.368999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.28800000000007,
"heapDeltaBytes": 13139696,
"heapUsedBytes": 74672824,
"domNodes": -281,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 8.728,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1993.208999999979,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.272000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.227,
"heapDeltaBytes": 12832844,
"heapUsedBytes": 75999888,
"domNodes": -279,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 12.704999999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 425.56200000001354,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.853,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 248.521,
"heapDeltaBytes": -10065704,
"heapUsedBytes": 55587344,
"domNodes": 24,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 66.079,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 393.39000000006763,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.841,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 253.81500000000003,
"heapDeltaBytes": -11444936,
"heapUsedBytes": 54207484,
"domNodes": 22,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 67.501,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1989.0889999999786,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.9319999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.376,
"heapDeltaBytes": 5351316,
"heapUsedBytes": 70829556,
"domNodes": 24,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 4.533,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.4619999999559,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.296,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 302.44499999999994,
"heapDeltaBytes": 5560728,
"heapUsedBytes": 71140264,
"domNodes": 22,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 4.828,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.9399999999982,
"styleRecalcs": 78,
"styleRecalcDurationMs": 24.886,
"layouts": 16,
"layoutDurationMs": 2.575,
"taskDurationMs": 490.662,
"heapDeltaBytes": -3840864,
"heapUsedBytes": 61756268,
"domNodes": 64,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 45.260000000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.8470000000234,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.787999999999997,
"layouts": 16,
"layoutDurationMs": 3.05,
"taskDurationMs": 500.754,
"heapDeltaBytes": -3794452,
"heapUsedBytes": 61926512,
"domNodes": 63,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 48.489,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 816.1379999999667,
"styleRecalcs": 22,
"styleRecalcDurationMs": 20.377999999999993,
"layouts": 17,
"layoutDurationMs": 7.458999999999999,
"taskDurationMs": 594.803,
"heapDeltaBytes": -5899096,
"heapUsedBytes": 77118040,
"domNodes": 13673,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 10.672,
"eventListeners": 2373,
"totalBlockingTimeMs": 87,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8075.05500000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 20.669,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2475.405,
"heapDeltaBytes": 10666688,
"heapUsedBytes": 72835084,
"domNodes": -281,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 569.39,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8066.511999999989,
"styleRecalcs": 249,
"styleRecalcDurationMs": 26.462,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2627.4040000000005,
"heapDeltaBytes": 13195796,
"heapUsedBytes": 73463260,
"domNodes": -280,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 631.3199999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11004.655000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10170.709,
"heapDeltaBytes": -38828164,
"heapUsedBytes": 174154544,
"domNodes": -8312,
"jsHeapTotalBytes": -13832192,
"scriptDurationMs": 65.69600000000001,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10520.92099999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9572.431,
"heapDeltaBytes": -23891172,
"heapUsedBytes": 174711500,
"domNodes": -8312,
"jsHeapTotalBytes": -5443584,
"scriptDurationMs": 69.86599999999999,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 12637.963999999954,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.614999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11946.12,
"heapDeltaBytes": -8072732,
"heapUsedBytes": 190477272,
"domNodes": -8312,
"jsHeapTotalBytes": -6561792,
"scriptDurationMs": 318.139,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12651.872999999909,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.742999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11847.851,
"heapDeltaBytes": -34301456,
"heapUsedBytes": 177311432,
"domNodes": -8312,
"jsHeapTotalBytes": -6037504,
"scriptDurationMs": 315.478,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 420.22600000001376,
"styleRecalcs": 14,
"styleRecalcDurationMs": 11.215,
"layouts": 3,
"layoutDurationMs": 0.495,
"taskDurationMs": 69.61899999999999,
"heapDeltaBytes": 4943372,
"heapUsedBytes": 69619560,
"domNodes": 128,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 4.993999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 429.6000000000504,
"styleRecalcs": 15,
"styleRecalcDurationMs": 12.176,
"layouts": 2,
"layoutDurationMs": 0.31900000000000006,
"taskDurationMs": 73.88900000000001,
"heapDeltaBytes": 4972636,
"heapUsedBytes": 69512852,
"domNodes": 125,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5.5200000000000005,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.51 #15480 +/- ##
=============================================
+ Coverage 81.48% 81.49% +0.01%
=============================================
Files 1883 1883
Lines 117534 117533 -1
Branches 36717 37173 +456
=============================================
+ Hits 95769 95787 +18
+ Misses 21289 21274 -15
+ Partials 476 472 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #14797 to
core/1.51Automatically created by backport workflow.