Repository navigation
refactor(litegraph): prune dead surfaces (AUDIT-LG implementation, draft) - #12228
Conversation
Delete the LGraph stepping hook fields and their dispatch sites: onAfterStep, onBeforeStep, onPlayEvent, onStopEvent, onAfterExecute, onExecuteStep. These hooks fire from LGraph.start() / LGraph.stop() / LGraph.runStep() — the native LiteGraph runtime executor that ComfyUI never uses (we execute server-side via WebSocket). The host methods are already @deprecated 'Will be removed in 0.9'. Per AUDIT-LG.7 each hook has zero internal callers and zero external repos touching it (touch-points DB + rg over src/, browser_tests/, packages/ excluding lib/litegraph/). This is the safest first deletion in a series — see follow-up commits for the full executor cluster, the trigger/action subsystem (#12223), the 27 LGraphNode dead hooks (#12224), and the ON_EVENT deprecation cycle (#12225). Refs: AUDIT-LG.7 master verdict table + AUDIT-LG.9 sweep results in research/architecture/audit-litegraph-pruning.md (cross-repo ecs-vue-hoisted-client-state-hook-api workspace). Closes part of: #12224
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR removes six optional callback method declarations from the ChangesExecution Lifecycle Callback Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1598 passed, 0 failed · 1 flaky📊 Browser Reports
|
📦 Bundle: 5.35 MB gzip 🔴 +50 BDetailsSummary
Category Glance App Entry Points — 31.8 kB (baseline 31.8 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 82.6 kB (baseline 82.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 526 kB (baseline 526 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 14 unchanged User & Accounts — 17.7 kB (baseline 17.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 57.9 kB (baseline 57.9 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3.16 MB (baseline 3.16 MB) • 🟢 -277 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 369 kB (baseline 369 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 19 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 9.13 MB (baseline 9.13 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 85 unchanged ⚡ Performance Report
No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-13T21:20:44.155Z",
"gitSha": "d501da664acaf7b6142c5f070b698d9c99e13604",
"branch": "litegraph/prune-dead-surfaces",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.5569999999966,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.820999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.192,
"heapDeltaBytes": 20288552,
"heapUsedBytes": 69329704,
"domNodes": -268,
"jsHeapTotalBytes": 18477056,
"scriptDurationMs": 16.945,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2047.0679999999675,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.788,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.78099999999995,
"heapDeltaBytes": 6603796,
"heapUsedBytes": 56503336,
"domNodes": -260,
"jsHeapTotalBytes": 16994304,
"scriptDurationMs": 23.858000000000004,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1928.1440000000316,
"styleRecalcs": 75,
"styleRecalcDurationMs": 40.144,
"layouts": 12,
"layoutDurationMs": 3.497,
"taskDurationMs": 897.4839999999999,
"heapDeltaBytes": -863464,
"heapUsedBytes": 48131940,
"domNodes": -266,
"jsHeapTotalBytes": 16904192,
"scriptDurationMs": 134.018,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.9169999999613,
"styleRecalcs": 72,
"styleRecalcDurationMs": 34.355999999999995,
"layouts": 12,
"layoutDurationMs": 3.279,
"taskDurationMs": 771.081,
"heapDeltaBytes": 12916256,
"heapUsedBytes": 63006084,
"domNodes": -262,
"jsHeapTotalBytes": 22237184,
"scriptDurationMs": 121.454,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.6570000000174,
"styleRecalcs": 33,
"styleRecalcDurationMs": 19.331999999999997,
"layouts": 6,
"layoutDurationMs": 0.655,
"taskDurationMs": 324.72299999999996,
"heapDeltaBytes": 23439056,
"heapUsedBytes": 73281620,
"domNodes": 79,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 24.412000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.3010000000686,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.206,
"layouts": 6,
"layoutDurationMs": 0.585,
"taskDurationMs": 312.95300000000003,
"heapDeltaBytes": 17044704,
"heapUsedBytes": 66004608,
"domNodes": -184,
"jsHeapTotalBytes": 10350592,
"scriptDurationMs": 19.084999999999997,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 567.9640000000177,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.077,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.04800000000006,
"heapDeltaBytes": 1291124,
"heapUsedBytes": 50025436,
"domNodes": -265,
"jsHeapTotalBytes": 17166336,
"scriptDurationMs": 58.13400000000001,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 535.7979999999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.126000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.743,
"heapDeltaBytes": 8506136,
"heapUsedBytes": 57467488,
"domNodes": 16,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 60.199000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2020.6009999999992,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.378,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.761,
"heapDeltaBytes": 38715608,
"heapUsedBytes": 98130468,
"domNodes": -265,
"jsHeapTotalBytes": 33579008,
"scriptDurationMs": 97.33500000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2071.1469999999963,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.146,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.3480000000001,
"heapDeltaBytes": 3177300,
"heapUsedBytes": 62095780,
"domNodes": -263,
"jsHeapTotalBytes": 5005312,
"scriptDurationMs": 107.172,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2200.706000000025,
"styleRecalcs": 69,
"styleRecalcDurationMs": 18.081000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1142.247,
"heapDeltaBytes": 43460008,
"heapUsedBytes": 104786520,
"domNodes": -262,
"jsHeapTotalBytes": 36696064,
"scriptDurationMs": 389.66,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2170.91999999991,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.423,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1140.2379999999998,
"heapDeltaBytes": -703044,
"heapUsedBytes": 59034844,
"domNodes": -264,
"jsHeapTotalBytes": 1540096,
"scriptDurationMs": 430.686,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3246.851000000049,
"styleRecalcs": 66,
"styleRecalcDurationMs": 19.139,
"layouts": 60,
"layoutDurationMs": 7.242,
"taskDurationMs": 1398.6609999999998,
"heapDeltaBytes": 46503020,
"heapUsedBytes": 109388280,
"domNodes": -267,
"jsHeapTotalBytes": 33898496,
"scriptDurationMs": 498.264,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3181.067999999982,
"styleRecalcs": 65,
"styleRecalcDurationMs": 18.020999999999997,
"layouts": 60,
"layoutDurationMs": 7.256,
"taskDurationMs": 1399.3410000000001,
"heapDeltaBytes": 9893252,
"heapUsedBytes": 71026100,
"domNodes": -270,
"jsHeapTotalBytes": 4481024,
"scriptDurationMs": 529.7510000000001,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2024.2110000000366,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.466,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.228,
"heapDeltaBytes": 34441300,
"heapUsedBytes": 95299648,
"domNodes": -265,
"jsHeapTotalBytes": 32268288,
"scriptDurationMs": 93.00900000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2001.8370000000232,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.688000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.413,
"heapDeltaBytes": 46701876,
"heapUsedBytes": 113256508,
"domNodes": 20,
"jsHeapTotalBytes": 48640000,
"scriptDurationMs": 100.36599999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 556.4360000000192,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.754,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.032,
"heapDeltaBytes": 15431872,
"heapUsedBytes": 64702044,
"domNodes": 16,
"jsHeapTotalBytes": 16777216,
"scriptDurationMs": 119.275,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 540.5609999999115,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.434,
"heapDeltaBytes": 9237284,
"heapUsedBytes": 59128904,
"domNodes": 18,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 112.851,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2049.3040000000065,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.596,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.24300000000005,
"heapDeltaBytes": 36915112,
"heapUsedBytes": 86211440,
"domNodes": -242,
"jsHeapTotalBytes": 34467840,
"scriptDurationMs": 15.827,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1996.556000000055,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.928,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.086,
"heapDeltaBytes": 22981000,
"heapUsedBytes": 72267800,
"domNodes": 18,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 12.597999999999992,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.5379999999864,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.931,
"layouts": 16,
"layoutDurationMs": 4.572,
"taskDurationMs": 722.22,
"heapDeltaBytes": 24923328,
"heapUsedBytes": 77878560,
"domNodes": 64,
"jsHeapTotalBytes": 45875200,
"scriptDurationMs": 93.24,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.9340000000057,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.88099999999999,
"layouts": 16,
"layoutDurationMs": 4.2170000000000005,
"taskDurationMs": 723.684,
"heapDeltaBytes": 11610420,
"heapUsedBytes": 60676688,
"domNodes": -263,
"jsHeapTotalBytes": 21884928,
"scriptDurationMs": 89.89400000000002,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 932.9199999999673,
"styleRecalcs": 16,
"styleRecalcDurationMs": 26.785999999999998,
"layouts": 5,
"layoutDurationMs": 11.872,
"taskDurationMs": 714.4319999999999,
"heapDeltaBytes": 30257908,
"heapUsedBytes": 96639976,
"domNodes": 13513,
"jsHeapTotalBytes": 17563648,
"scriptDurationMs": 26.722999999999995,
"eventListeners": 2529,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8320.613000000038,
"styleRecalcs": 248,
"styleRecalcDurationMs": 49.838,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3753.2430000000004,
"heapDeltaBytes": 20250528,
"heapUsedBytes": 80028220,
"domNodes": -267,
"jsHeapTotalBytes": 4976640,
"scriptDurationMs": 1261.854,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8365.409999999996,
"styleRecalcs": 250,
"styleRecalcDurationMs": 51.596000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3967.7110000000002,
"heapDeltaBytes": 80172380,
"heapUsedBytes": 137752820,
"domNodes": -261,
"jsHeapTotalBytes": 68124672,
"scriptDurationMs": 1238.99,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12332.09199999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12314.707999999999,
"heapDeltaBytes": -40828404,
"heapUsedBytes": 172493148,
"domNodes": -8331,
"jsHeapTotalBytes": 26800128,
"scriptDurationMs": 622.81,
"eventListeners": -16463,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12250.32299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12216.262999999999,
"heapDeltaBytes": -41858812,
"heapUsedBytes": 171881600,
"domNodes": -8331,
"jsHeapTotalBytes": 16576512,
"scriptDurationMs": 615.73,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14324.982000000035,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.23000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14290.773000000001,
"heapDeltaBytes": -53370868,
"heapUsedBytes": 169132092,
"domNodes": -8331,
"jsHeapTotalBytes": -2711552,
"scriptDurationMs": 879.818,
"eventListeners": -16492,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17124.769000000015,
"styleRecalcs": 108,
"styleRecalcDurationMs": 18.92499999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17098.073,
"heapDeltaBytes": 30440332,
"heapUsedBytes": 291878860,
"domNodes": -8331,
"jsHeapTotalBytes": 34140160,
"scriptDurationMs": 1021.868,
"eventListeners": -16488,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 447.1720000000232,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.028,
"layouts": 6,
"layoutDurationMs": 1.675,
"taskDurationMs": 129.40999999999997,
"heapDeltaBytes": 5361452,
"heapUsedBytes": 55200856,
"domNodes": 170,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 24.715,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 474.6979999999894,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.983000000000004,
"layouts": 5,
"layoutDurationMs": 1.2339999999999998,
"taskDurationMs": 127.95100000000004,
"heapDeltaBytes": 5043972,
"heapUsedBytes": 55261896,
"domNodes": 154,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 23.921999999999997,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #12228 +/- ##
===========================================
- Coverage 74.27% 59.41% -14.86%
===========================================
Files 1520 1410 -110
Lines 89781 71815 -17966
Branches 24872 19935 -4937
===========================================
- Hits 66684 42669 -24015
- Misses 22262 28670 +6408
+ Partials 835 476 -359
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Custom node ecosystem search — breaking change validationSearched the ComfyUI custom node ecosystem (codesearch index over public custom nodes + downstream forks) for each of the 6 deleted
ConclusionAcross the indexed custom-node ecosystem there are zero custom nodes that consume any of the 6 hooks being removed. All non-frontend hits are either:
The only borderline case is This is consistent with the AUDIT-LG.9 per-symbol attribution: 0 external functional callers. — evidence gathered via the comfy-codesearch index; raw queries: |
…reChange Delete two remaining LGraph instance hook fields confirmed dead by AUDIT-LG.9: - LGraph.onGetNodeMenuOptions field + dispatcher in LGraphCanvas.ts (context-menu construction). - LGraph.onBeforeChange field + dispatcher in LGraph.ts:1374. LGraphCanvas.onBeforeChange is a SEPARATE field and is preserved. Stacks on #12228. Closes the LGraph-side portion of #12224.
Delete LGraph.start(), .stop(), .runStep(), .sendEventToAllNodes(), the runtime state fields they own (iteration, globaltime, runningtime, fixedtime, fixedtime_lapse, elapsed_time, last_update_time, starttime, catch_errors, execution_timer_id, errors_in_execution, execution_time, status), and the LGraph.STATUS_RUNNING/STATUS_STOPPED constants. The host methods were already `@deprecated 'Will be removed in 0.9'`. AUDIT-LG.9 confirmed zero internal and zero external callers across src/, browser_tests/, packages/. Stacks on top of #12228 which deleted the 6 stepping hooks fired from these methods. Transitive cleanup folded in: - LGraph.getTime/getFixedTime/getElapsedTime accessors (read deleted fields, zero callers) - LGraphNode.doExecute now drops 'this.exec_version = this.graph.iteration' - LGraphCanvas.renderInfo drops the T:/I: debug overlay lines - useCoreCommands.test.ts subgraph mock drops start/stop/runStep stubs - Unused LGraphEventMode import in LGraph.ts Preserves nodes_executing/nodes_actioning/nodes_executedAction - those pair with the trigger cluster being removed separately.
…reChange Delete two remaining LGraph instance hook fields confirmed dead by AUDIT-LG.9: - LGraph.onGetNodeMenuOptions field + dispatcher in LGraphCanvas.ts (context-menu construction). - LGraph.onBeforeChange field + dispatcher in LGraph.ts:1374. LGraphCanvas.onBeforeChange is a SEPARATE field and is preserved. Stacks on #12228. Closes the LGraph-side portion of #12224.
…foreChange (#12230) Stacks on #12228. Part of the LGraph dead-hook cleanup per AUDIT-LG.9. ## What - `LGraph.onGetNodeMenuOptions` — **deleted** (field + dispatcher in `LGraphCanvas.getNodeMenuOptions`). Zero ecosystem consumers. - `LGraph.onBeforeChange` — **deprecated, not deleted**. The field and the dispatch in `LGraph.beforeChange()` are kept, but assigning a handler now emits a one-time `warnDeprecated` nudging migration to `LGraphCanvas.onBeforeChange`. ## Why onBeforeChange is preserved The W2F-1 re-audit found `bmad4ever/ComfyUI-Bmad-DirtyUndoRedo` assigns `app.graph.onBeforeChange = fn` (the listener-assignment pattern). Deleting the field outright would silently turn those handlers into no-ops. Keeping it as a deprecated shim preserves backward compatibility during a grace period while signaling the intended replacement. `onAfterChange` is untouched (so `BennyKok/comfyui-deploy`'s `onAfterChange` wrapper keeps working). `LGraphCanvas.onBeforeChange` remains a separate field, and the canvas dispatch chain `this.canvasAction((c) => c.onBeforeChange?.(this))` is unchanged. ## Tests `LGraph.test.ts` covers the shim: the assigned listener is still invoked, the deprecation warning fires when used, and no warning fires when no listener is assigned. ## Sequencing - Stacks on #12228 - Sequences behind Alex's Phase B (#11939, #11811) --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
…foreChange (#12230) Stacks on #12228. Part of the LGraph dead-hook cleanup per AUDIT-LG.9. ## What - `LGraph.onGetNodeMenuOptions` — **deleted** (field + dispatcher in `LGraphCanvas.getNodeMenuOptions`). Zero ecosystem consumers. - `LGraph.onBeforeChange` — **deprecated, not deleted**. The field and the dispatch in `LGraph.beforeChange()` are kept, but assigning a handler now emits a one-time `warnDeprecated` nudging migration to `LGraphCanvas.onBeforeChange`. ## Why onBeforeChange is preserved The W2F-1 re-audit found `bmad4ever/ComfyUI-Bmad-DirtyUndoRedo` assigns `app.graph.onBeforeChange = fn` (the listener-assignment pattern). Deleting the field outright would silently turn those handlers into no-ops. Keeping it as a deprecated shim preserves backward compatibility during a grace period while signaling the intended replacement. `onAfterChange` is untouched (so `BennyKok/comfyui-deploy`'s `onAfterChange` wrapper keeps working). `LGraphCanvas.onBeforeChange` remains a separate field, and the canvas dispatch chain `this.canvasAction((c) => c.onBeforeChange?.(this))` is unchanged. ## Tests `LGraph.test.ts` covers the shim: the assigned listener is still invoked, the deprecation warning fires when used, and no warning fires when no listener is assigned. ## Sequencing - Stacks on #12228 - Sequences behind Alex's Phase B (#11939, #11811) --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
…aft) (#12228) Implements the AUDIT-LG verdicts (#12223, #12224, #12225) as a single deletion PR off main. > **DRAFT — sequencing.** Per the AUDIT-LG framing doc, deletions land **after Phase B ECS migration** (Alex's #11939 + #11811). Open early to capture the diff and let CI cascade-flag any unused-export fallout. Flip to ready-for-review post-Alex-rebase. ## Status | commit | scope | status | |---|---|---| | 1 | Delete 6 LGraph stepping hooks (`onAfterStep`, `onBeforeStep`, `onPlayEvent`, `onStopEvent`, `onAfterExecute`, `onExecuteStep`) + their dispatch sites in `start()`/`stop()`/`runStep()` | ✅ landed (this commit) | | 2 | Delete the rest of the dead executor cluster (`start()`/`stop()`/`runStep()`/`sendEventToAllNodes()` + state fields + `STATUS_*` constants) | follow-up | | 3 | Delete `LGraphNode` dead event hooks (~22 fields per #12224) | follow-up | | 4 | Delete trigger/action subsystem (~22 symbols, #12223) | follow-up | | 5 | `ON_EVENT` deprecation cycle, release N (#12225) | follow-up | ## Verification (commit 1) ``` $ pnpm lint && pnpm format:check && pnpm knip ✓ format: All matched files use the correct format ✓ lint: pre-existing icon-name warnings only ✓ knip: no new unused exports flagged ``` ## Verdicts the deletion is grounded in - AUDIT-LG.7 master verdict table (146 surfaces classified DELETE-NOW / DEPRECATE / KEEP) - AUDIT-LG.9 per-symbol attribution sweep (confirmed zero functional callers for the trigger cluster + the dead hooks) For each surface in this PR: - **`internal_count` from rg over `src/`, `browser_tests/`, `packages/` excluding `lib/litegraph/`:** 0 - **External use from touch-points DB:** 0 (per AUDIT-LG.3 + AUDIT-LG.9 per-symbol attribution) - **Host methods (`start()`/`stop()`/`runStep()`):** `@deprecated 'Will be removed in 0.9'` already The dispatch sites (`this.onAfterStep?.()` etc.) are inside the deprecated host methods — removing the dispatchers does not change observable behaviour because no listener is attached to begin with. ## Why batched, why draft Per AUDIT-LG framing, the deletion sequences behind Alex's PR #11939 (ECS world-combo). Opening as draft lets CI run early and flags any unused-export cascades the audit script missed. Each follow-up commit will be its own atomic deletion (one feature per commit) so any single one can be reverted in isolation if needed. cc @DrJKL @christian-byrne ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12228-refactor-litegraph-prune-dead-surfaces-AUDIT-LG-implementation-draft-35f6d73d365081e0b72cd292228e2ca6) by [Unito](https://www.unito.io) Co-authored-by: Connor Byrne <c.byrne@comfy.org>
…foreChange (#12230) Stacks on #12228. Part of the LGraph dead-hook cleanup per AUDIT-LG.9. ## What - `LGraph.onGetNodeMenuOptions` — **deleted** (field + dispatcher in `LGraphCanvas.getNodeMenuOptions`). Zero ecosystem consumers. - `LGraph.onBeforeChange` — **deprecated, not deleted**. The field and the dispatch in `LGraph.beforeChange()` are kept, but assigning a handler now emits a one-time `warnDeprecated` nudging migration to `LGraphCanvas.onBeforeChange`. ## Why onBeforeChange is preserved The W2F-1 re-audit found `bmad4ever/ComfyUI-Bmad-DirtyUndoRedo` assigns `app.graph.onBeforeChange = fn` (the listener-assignment pattern). Deleting the field outright would silently turn those handlers into no-ops. Keeping it as a deprecated shim preserves backward compatibility during a grace period while signaling the intended replacement. `onAfterChange` is untouched (so `BennyKok/comfyui-deploy`'s `onAfterChange` wrapper keeps working). `LGraphCanvas.onBeforeChange` remains a separate field, and the canvas dispatch chain `this.canvasAction((c) => c.onBeforeChange?.(this))` is unchanged. ## Tests `LGraph.test.ts` covers the shim: the assigned listener is still invoked, the deprecation warning fires when used, and no warning fires when no listener is assigned. ## Sequencing - Stacks on #12228 - Sequences behind Alex's Phase B (#11939, #11811) --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
…aft) (#12228) Implements the AUDIT-LG verdicts (#12223, #12224, #12225) as a single deletion PR off main. > **DRAFT — sequencing.** Per the AUDIT-LG framing doc, deletions land **after Phase B ECS migration** (Alex's #11939 + #11811). Open early to capture the diff and let CI cascade-flag any unused-export fallout. Flip to ready-for-review post-Alex-rebase. ## Status | commit | scope | status | |---|---|---| | 1 | Delete 6 LGraph stepping hooks (`onAfterStep`, `onBeforeStep`, `onPlayEvent`, `onStopEvent`, `onAfterExecute`, `onExecuteStep`) + their dispatch sites in `start()`/`stop()`/`runStep()` | ✅ landed (this commit) | | 2 | Delete the rest of the dead executor cluster (`start()`/`stop()`/`runStep()`/`sendEventToAllNodes()` + state fields + `STATUS_*` constants) | follow-up | | 3 | Delete `LGraphNode` dead event hooks (~22 fields per #12224) | follow-up | | 4 | Delete trigger/action subsystem (~22 symbols, #12223) | follow-up | | 5 | `ON_EVENT` deprecation cycle, release N (#12225) | follow-up | ## Verification (commit 1) ``` $ pnpm lint && pnpm format:check && pnpm knip ✓ format: All matched files use the correct format ✓ lint: pre-existing icon-name warnings only ✓ knip: no new unused exports flagged ``` ## Verdicts the deletion is grounded in - AUDIT-LG.7 master verdict table (146 surfaces classified DELETE-NOW / DEPRECATE / KEEP) - AUDIT-LG.9 per-symbol attribution sweep (confirmed zero functional callers for the trigger cluster + the dead hooks) For each surface in this PR: - **`internal_count` from rg over `src/`, `browser_tests/`, `packages/` excluding `lib/litegraph/`:** 0 - **External use from touch-points DB:** 0 (per AUDIT-LG.3 + AUDIT-LG.9 per-symbol attribution) - **Host methods (`start()`/`stop()`/`runStep()`):** `@deprecated 'Will be removed in 0.9'` already The dispatch sites (`this.onAfterStep?.()` etc.) are inside the deprecated host methods — removing the dispatchers does not change observable behaviour because no listener is attached to begin with. ## Why batched, why draft Per AUDIT-LG framing, the deletion sequences behind Alex's PR #11939 (ECS world-combo). Opening as draft lets CI run early and flags any unused-export cascades the audit script missed. Each follow-up commit will be its own atomic deletion (one feature per commit) so any single one can be reverted in isolation if needed. cc @DrJKL @christian-byrne ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12228-refactor-litegraph-prune-dead-surfaces-AUDIT-LG-implementation-draft-35f6d73d365081e0b72cd292228e2ca6) by [Unito](https://www.unito.io) Co-authored-by: Connor Byrne <c.byrne@comfy.org>
…foreChange (#12230) Stacks on #12228. Part of the LGraph dead-hook cleanup per AUDIT-LG.9. ## What - `LGraph.onGetNodeMenuOptions` — **deleted** (field + dispatcher in `LGraphCanvas.getNodeMenuOptions`). Zero ecosystem consumers. - `LGraph.onBeforeChange` — **deprecated, not deleted**. The field and the dispatch in `LGraph.beforeChange()` are kept, but assigning a handler now emits a one-time `warnDeprecated` nudging migration to `LGraphCanvas.onBeforeChange`. ## Why onBeforeChange is preserved The W2F-1 re-audit found `bmad4ever/ComfyUI-Bmad-DirtyUndoRedo` assigns `app.graph.onBeforeChange = fn` (the listener-assignment pattern). Deleting the field outright would silently turn those handlers into no-ops. Keeping it as a deprecated shim preserves backward compatibility during a grace period while signaling the intended replacement. `onAfterChange` is untouched (so `BennyKok/comfyui-deploy`'s `onAfterChange` wrapper keeps working). `LGraphCanvas.onBeforeChange` remains a separate field, and the canvas dispatch chain `this.canvasAction((c) => c.onBeforeChange?.(this))` is unchanged. ## Tests `LGraph.test.ts` covers the shim: the assigned listener is still invoked, the deprecation warning fires when used, and no warning fires when no listener is assigned. ## Sequencing - Stacks on #12228 - Sequences behind Alex's Phase B (#11939, #11811) --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
Delete LGraph.start(), .stop(), .runStep(), .sendEventToAllNodes(), the runtime state fields they own (iteration, globaltime, runningtime, fixedtime, fixedtime_lapse, elapsed_time, last_update_time, starttime, catch_errors, execution_timer_id, errors_in_execution, execution_time, status), and the LGraph.STATUS_RUNNING/STATUS_STOPPED constants. The host methods were already `@deprecated 'Will be removed in 0.9'`. AUDIT-LG.9 confirmed zero internal and zero external callers across src/, browser_tests/, packages/. Stacks on top of #12228 which deleted the 6 stepping hooks fired from these methods. Transitive cleanup folded in: - LGraph.getTime/getFixedTime/getElapsedTime accessors (read deleted fields, zero callers) - LGraphNode.doExecute now drops 'this.exec_version = this.graph.iteration' - LGraphCanvas.renderInfo drops the T:/I: debug overlay lines - useCoreCommands.test.ts subgraph mock drops start/stop/runStep stubs - Unused LGraphEventMode import in LGraph.ts Preserves nodes_executing/nodes_actioning/nodes_executedAction - those pair with the trigger cluster being removed separately.
Delete LGraph.start(), .stop(), .runStep(), .sendEventToAllNodes(), the runtime state fields they own (iteration, globaltime, runningtime, fixedtime, fixedtime_lapse, elapsed_time, last_update_time, starttime, catch_errors, execution_timer_id, errors_in_execution, execution_time, status), and the LGraph.STATUS_RUNNING/STATUS_STOPPED constants. The host methods were already `@deprecated 'Will be removed in 0.9'`. AUDIT-LG.9 confirmed zero internal and zero external callers across src/, browser_tests/, packages/. Stacks on top of #12228 which deleted the 6 stepping hooks fired from these methods. Transitive cleanup folded in: - LGraph.getTime/getFixedTime/getElapsedTime accessors (read deleted fields, zero callers) - LGraphNode.doExecute now drops 'this.exec_version = this.graph.iteration' - LGraphCanvas.renderInfo drops the T:/I: debug overlay lines - useCoreCommands.test.ts subgraph mock drops start/stop/runStep stubs - Unused LGraphEventMode import in LGraph.ts Preserves nodes_executing/nodes_actioning/nodes_executedAction - those pair with the trigger cluster being removed separately.
Delete LGraph.start(), .stop(), .runStep(), .sendEventToAllNodes(), the runtime state fields they own (iteration, globaltime, runningtime, fixedtime, fixedtime_lapse, elapsed_time, last_update_time, starttime, catch_errors, execution_timer_id, errors_in_execution, execution_time, status), and the LGraph.STATUS_RUNNING/STATUS_STOPPED constants. The host methods were already `@deprecated 'Will be removed in 0.9'`. AUDIT-LG.9 confirmed zero internal and zero external callers across src/, browser_tests/, packages/. Stacks on top of #12228 which deleted the 6 stepping hooks fired from these methods. Transitive cleanup folded in: - LGraph.getTime/getFixedTime/getElapsedTime accessors (read deleted fields, zero callers) - LGraphNode.doExecute now drops 'this.exec_version = this.graph.iteration' - LGraphCanvas.renderInfo drops the T:/I: debug overlay lines - useCoreCommands.test.ts subgraph mock drops start/stop/runStep stubs - Unused LGraphEventMode import in LGraph.ts Preserves nodes_executing/nodes_actioning/nodes_executedAction - those pair with the trigger cluster being removed separately.
Implements the AUDIT-LG verdicts (#12223, #12224, #12225) as a single deletion PR off main.
Status
onAfterStep,onBeforeStep,onPlayEvent,onStopEvent,onAfterExecute,onExecuteStep) + their dispatch sites instart()/stop()/runStep()start()/stop()/runStep()/sendEventToAllNodes()+ state fields +STATUS_*constants)LGraphNodedead event hooks (~22 fields per #12224)ON_EVENTdeprecation cycle, release N (#12225)Verification (commit 1)
Verdicts the deletion is grounded in
For each surface in this PR:
internal_countfrom rg oversrc/,browser_tests/,packages/excludinglib/litegraph/: 0start()/stop()/runStep()):@deprecated 'Will be removed in 0.9'alreadyThe dispatch sites (
this.onAfterStep?.()etc.) are inside the deprecated host methods — removing the dispatchers does not change observable behaviour because no listener is attached to begin with.Why batched, why draft
Per AUDIT-LG framing, the deletion sequences behind Alex's PR #11939 (ECS world-combo). Opening as draft lets CI run early and flags any unused-export cascades the audit script missed. Each follow-up commit will be its own atomic deletion (one feature per commit) so any single one can be reverted in isolation if needed.
cc @DrJKL @christian-byrne
┆Issue is synchronized with this Notion page by Unito