Repository navigation
refactor(litegraph): delete dead LGraph executor cluster - #12233
christian-byrne wants to merge 10 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR removes LGraph’s deprecated execution-loop/timing surface (status constants/field, timing fields, start/stop/runStep, timing getters, sendEventToAllNodes), updates clear(), adjusts class docs/imports, and updates canvas/node/test snippets referencing start/runStep. ChangesDeprecation and runtime surface removal
Sequence DiagramsequenceDiagram
participant App as ComfyApp
participant Graph as LGraph
participant Node as LGraphNode
participant Canvas as LGraphCanvas
App->>Graph: setup (no start)
Note right of Graph: start/stop/runStep removed\ntiming fields removed
Graph->>Node: execute node (doExecute)
Note right of Node: no exec_version = graph.iteration assignment
Graph->>Canvas: renderInfo
Note right of Canvas: shows N / V / FPS (T/I removed)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/lib/litegraph/src/LGraph.ts (2)
175-180:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winUpdate the class summary after removing the executor.
The opening JSDoc still says
LGraphcan "run the execution loop", which is no longer true after this cleanup and will mislead downstream readers of the public API.✏️ Suggested doc update
- * LGraph is the class that contain a full graph. We instantiate one and add nodes to it, and then we can run the execution loop. + * LGraph contains a full graph. Instantiate it, add nodes/groups, and use it for editing, traversal, and serialisation.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/litegraph/src/LGraph.ts` around lines 175 - 180, The class JSDoc for LGraph is outdated—remove the statement that it "can run the execution loop" (executor was removed) and update the summary to accurately describe current responsibilities (manages nodes, connections and graph metadata; supports callbacks like onNodeAdded/onNodeRemoved) by editing the comment block above the LGraph class declaration in LGraph.ts to reflect that it no longer executes the graph and only provides graph management and callback hooks.
352-412:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd a compatibility buffer for the removed executor lifecycle.
clear()now tears the graph down without anystop()path, and this PR also removes the old stepping/play callbacks from the publicLGraphsurface. Please either keep deprecated no-op shims for one release or add explicit migration guidance before merge so extensions do not discover this as a runtime break. As per coding guidelines "Maintain extension ecosystem compatibility (ADR 0008): Changes to extension-facing callbacks ... require migration guidance in the PR description. These affect 40+ custom node repositories."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/litegraph/src/LGraph.ts` around lines 352 - 412, clear() now removes the executor lifecycle and public stepping/play callbacks which will break extensions; restore backward compatibility by reintroducing deprecated no-op shims on the LGraph public surface (e.g. stop(), start()/play()/pause(), step(), and any removed event hooks like onPlay/onStop or executor-related methods referenced by extensions) that simply warn once about deprecation and no-op their old behavior, and add a single-line migration message in each shim recommending the new API; alternatively, if you prefer documentation-only, add a clear migration note to the PR and release notes listing the removed symbols (clear(), executor lifecycle methods) and the replacement behavior so consumers can update before the next release.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/lib/litegraph/src/LGraph.ts`:
- Around line 175-180: The class JSDoc for LGraph is outdated—remove the
statement that it "can run the execution loop" (executor was removed) and update
the summary to accurately describe current responsibilities (manages nodes,
connections and graph metadata; supports callbacks like
onNodeAdded/onNodeRemoved) by editing the comment block above the LGraph class
declaration in LGraph.ts to reflect that it no longer executes the graph and
only provides graph management and callback hooks.
- Around line 352-412: clear() now removes the executor lifecycle and public
stepping/play callbacks which will break extensions; restore backward
compatibility by reintroducing deprecated no-op shims on the LGraph public
surface (e.g. stop(), start()/play()/pause(), step(), and any removed event
hooks like onPlay/onStop or executor-related methods referenced by extensions)
that simply warn once about deprecation and no-op their old behavior, and add a
single-line migration message in each shim recommending the new API;
alternatively, if you prefer documentation-only, add a clear migration note to
the PR and release notes listing the removed symbols (clear(), executor
lifecycle methods) and the replacement behavior so consumers can update before
the next release.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cce83bec-a818-477e-8c16-3dee876308b7
📒 Files selected for processing (4)
src/composables/useCoreCommands.test.tssrc/lib/litegraph/src/LGraph.tssrc/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LGraphNode.ts
💤 Files with no reviewable changes (3)
- src/composables/useCoreCommands.test.ts
- src/lib/litegraph/src/LGraphCanvas.ts
- src/lib/litegraph/src/LGraphNode.ts
414945d to
2dadcde
Compare
📦 Bundle: 5.38 MB gzip 🟢 -1.29 kBDetailsSummary
Category Glance App Entry Points — 26.1 kB (baseline 26.1 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 82.9 kB (baseline 82.9 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 527 kB (baseline 527 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 14 unchanged User & Accounts — 17.8 kB (baseline 17.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 58 kB (baseline 58 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3.16 MB (baseline 3.16 MB) • 🟢 -5.16 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 367 kB (baseline 367 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 18 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 9.23 MB (baseline 9.23 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 86 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-18T21:55:21.516Z",
"gitSha": "8c34780c685c3aa5dc510ee9db9e49082c5829bb",
"branch": "litegraph/prune-executor-cluster",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.339999999971,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.0859999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 273.071,
"heapDeltaBytes": 23350572,
"heapUsedBytes": 72077784,
"domNodes": 22,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 15.229,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1991.6039999999953,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.431000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.62300000000005,
"heapDeltaBytes": 857748,
"heapUsedBytes": 51148024,
"domNodes": -259,
"jsHeapTotalBytes": 20926464,
"scriptDurationMs": 19.497,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1735.4390000000421,
"styleRecalcs": 71,
"styleRecalcDurationMs": 29.607999999999997,
"layouts": 12,
"layoutDurationMs": 3.3899999999999997,
"taskDurationMs": 684.956,
"heapDeltaBytes": 1001828,
"heapUsedBytes": 49649428,
"domNodes": -262,
"jsHeapTotalBytes": 14807040,
"scriptDurationMs": 97.82100000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1690.889000000027,
"styleRecalcs": 72,
"styleRecalcDurationMs": 26.838,
"layouts": 12,
"layoutDurationMs": 2.979,
"taskDurationMs": 623.7860000000001,
"heapDeltaBytes": 16945516,
"heapUsedBytes": 66009488,
"domNodes": -259,
"jsHeapTotalBytes": 19001344,
"scriptDurationMs": 93.20200000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.4279999999935,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.271,
"layouts": 6,
"layoutDurationMs": 0.5429999999999998,
"taskDurationMs": 231.017,
"heapDeltaBytes": 502656,
"heapUsedBytes": 49398380,
"domNodes": 78,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 14.900999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1715.5799999999886,
"styleRecalcs": 33,
"styleRecalcDurationMs": 12.753,
"layouts": 6,
"layoutDurationMs": 0.4850000000000001,
"taskDurationMs": 227.299,
"heapDeltaBytes": 664172,
"heapUsedBytes": 49113268,
"domNodes": 79,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 15.988000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 424.2479999999773,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.954999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.82800000000003,
"heapDeltaBytes": -4317860,
"heapUsedBytes": 61896940,
"domNodes": 18,
"jsHeapTotalBytes": 22896640,
"scriptDurationMs": 42.732,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 434.4059999999672,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.675000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.094,
"heapDeltaBytes": 14979592,
"heapUsedBytes": 63982680,
"domNodes": 22,
"jsHeapTotalBytes": 16777216,
"scriptDurationMs": 43.166999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2006.2470000000303,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.752999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.074,
"heapDeltaBytes": 44490288,
"heapUsedBytes": 101094796,
"domNodes": -259,
"jsHeapTotalBytes": 33579008,
"scriptDurationMs": 77.404,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2019.348999999977,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.413,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.69399999999996,
"heapDeltaBytes": 44165136,
"heapUsedBytes": 101080640,
"domNodes": -258,
"jsHeapTotalBytes": 32792576,
"scriptDurationMs": 69.458,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2146.69600000002,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.640999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 922.9450000000002,
"heapDeltaBytes": 38822796,
"heapUsedBytes": 105281268,
"domNodes": -263,
"jsHeapTotalBytes": 26296320,
"scriptDurationMs": 320.553,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2161.914999999965,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.669,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 917.2009999999999,
"heapDeltaBytes": 45921108,
"heapUsedBytes": 107153200,
"domNodes": -261,
"jsHeapTotalBytes": 39055360,
"scriptDurationMs": 311.847,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3088.7910000000147,
"styleRecalcs": 67,
"styleRecalcDurationMs": 17.910999999999998,
"layouts": 60,
"layoutDurationMs": 6.937,
"taskDurationMs": 1045.279,
"heapDeltaBytes": 11853036,
"heapUsedBytes": 72426476,
"domNodes": -260,
"jsHeapTotalBytes": 286720,
"scriptDurationMs": 378.454,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3088.2819999999924,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.616,
"layouts": 60,
"layoutDurationMs": 6.822000000000001,
"taskDurationMs": 1022.4340000000001,
"heapDeltaBytes": 8739852,
"heapUsedBytes": 69482112,
"domNodes": -264,
"jsHeapTotalBytes": 4218880,
"scriptDurationMs": 373.596,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.5150000000363,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.215999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.516,
"heapDeltaBytes": 2850364,
"heapUsedBytes": 63357948,
"domNodes": -259,
"jsHeapTotalBytes": 5529600,
"scriptDurationMs": 64.697,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2008.1919999999513,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.247000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.03499999999997,
"heapDeltaBytes": 7248248,
"heapUsedBytes": 67348868,
"domNodes": -263,
"jsHeapTotalBytes": 1073152,
"scriptDurationMs": 61.711,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 449.6050000000196,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.822,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.865,
"heapDeltaBytes": 8982116,
"heapUsedBytes": 57571948,
"domNodes": 19,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 93.942,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 429.28399999999556,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.939999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.862,
"heapDeltaBytes": 11579564,
"heapUsedBytes": 60952168,
"domNodes": 20,
"jsHeapTotalBytes": 17301504,
"scriptDurationMs": 93.727,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2058.8689999999588,
"styleRecalcs": 22,
"styleRecalcDurationMs": 16.839,
"layouts": 4,
"layoutDurationMs": 1.048,
"taskDurationMs": 345.62000000000006,
"heapDeltaBytes": 4747424,
"heapUsedBytes": 70420244,
"domNodes": 192,
"jsHeapTotalBytes": 21848064,
"scriptDurationMs": 20.075000000000003,
"eventListeners": 102,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.0170000000094,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.596000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.678,
"heapDeltaBytes": 23085156,
"heapUsedBytes": 71698664,
"domNodes": 20,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 17.437,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.175999999999,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.031,
"layouts": 16,
"layoutDurationMs": 3.8529999999999998,
"taskDurationMs": 585.201,
"heapDeltaBytes": 12483496,
"heapUsedBytes": 61476852,
"domNodes": -256,
"jsHeapTotalBytes": 18739200,
"scriptDurationMs": 72.8,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.6980000000112,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.63,
"layouts": 16,
"layoutDurationMs": 3.764,
"taskDurationMs": 559.066,
"heapDeltaBytes": -1391776,
"heapUsedBytes": 47271668,
"domNodes": -259,
"jsHeapTotalBytes": 14544896,
"scriptDurationMs": 73.38300000000001,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 900.066000000038,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.29099999999999,
"layouts": 7,
"layoutDurationMs": 8.984,
"taskDurationMs": 645.8960000000001,
"heapDeltaBytes": 81999040,
"heapUsedBytes": 224337372,
"domNodes": 13513,
"jsHeapTotalBytes": 80216064,
"scriptDurationMs": 20.664999999999996,
"eventListeners": 2527,
"totalBlockingTimeMs": 99,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8360.31799999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 50.544000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3262.848,
"heapDeltaBytes": 77695860,
"heapUsedBytes": 136550392,
"domNodes": -260,
"jsHeapTotalBytes": 72318976,
"scriptDurationMs": 985.811,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8094.274999999981,
"styleRecalcs": 250,
"styleRecalcDurationMs": 46.336999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2825.131,
"heapDeltaBytes": 11683208,
"heapUsedBytes": 68260980,
"domNodes": -258,
"jsHeapTotalBytes": 6782976,
"scriptDurationMs": 917.311,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11349.910000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11306.364,
"heapDeltaBytes": -58908936,
"heapUsedBytes": 161686000,
"domNodes": -8331,
"jsHeapTotalBytes": 24702976,
"scriptDurationMs": 486.061,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 10194.741999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10186.426000000001,
"heapDeltaBytes": -14392680,
"heapUsedBytes": 190768432,
"domNodes": -8331,
"jsHeapTotalBytes": 25489408,
"scriptDurationMs": 441.28000000000003,
"eventListeners": -16468,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 13322.370999999976,
"styleRecalcs": 67,
"styleRecalcDurationMs": 19.489000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13295.443,
"heapDeltaBytes": -49601264,
"heapUsedBytes": 154814628,
"domNodes": -8331,
"jsHeapTotalBytes": -4395008,
"scriptDurationMs": 723.422,
"eventListeners": -16488,
"totalBlockingTimeMs": 46,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12704.45600000005,
"styleRecalcs": 64,
"styleRecalcDurationMs": 18.00399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12689.585000000001,
"heapDeltaBytes": -44452580,
"heapUsedBytes": 173417912,
"domNodes": -8331,
"jsHeapTotalBytes": 27066368,
"scriptDurationMs": 708.309,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 444.2990000000009,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.951,
"layouts": 4,
"layoutDurationMs": 1.0629999999999997,
"taskDurationMs": 105.25999999999999,
"heapDeltaBytes": 5406240,
"heapUsedBytes": 55573708,
"domNodes": 170,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 22.465,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 442.61100000005626,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.262,
"layouts": 5,
"layoutDurationMs": 1.2159999999999997,
"taskDurationMs": 94.94800000000001,
"heapDeltaBytes": 5068368,
"heapUsedBytes": 56865512,
"domNodes": 157,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 18.651,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🎨 Storybook: ❌ FailedDetails⏰ Completed at: 09/02/2026, 05:32:42 PM UTC Links
🎭 Playwright: ❌ 1899 passed, 1 failed · 1 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle: 9.68 MB gzip 🟢 -1.36 kBDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • 🟢 -5.16 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 223 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T17:45:49.651Z",
"gitSha": "d467a54b48f66b89bf2aa06c49ae1d25404468b0",
"branch": "litegraph/prune-executor-cluster",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2101.25800000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.859000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.383,
"heapDeltaBytes": 7454248,
"heapUsedBytes": 77387796,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.755000000000003,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2055.097000000046,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.953999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.339,
"heapDeltaBytes": -3379784,
"heapUsedBytes": 66533880,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.206000000000001,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1892.2670000000608,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.512,
"layouts": 14,
"layoutDurationMs": 4.726999999999999,
"taskDurationMs": 930.08,
"heapDeltaBytes": -6159048,
"heapUsedBytes": 64292532,
"domNodes": -280,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 168.45200000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1863.5100000000193,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.888999999999996,
"layouts": 14,
"layoutDurationMs": 4.6899999999999995,
"taskDurationMs": 972.5729999999999,
"heapDeltaBytes": -11950736,
"heapUsedBytes": 58290116,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 170.957,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.0339999999842,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.654,
"layouts": 6,
"layoutDurationMs": 1.2200000000000002,
"taskDurationMs": 383.963,
"heapDeltaBytes": 5135000,
"heapUsedBytes": 75528288,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.805999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.3369999999777,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.479,
"layouts": 6,
"layoutDurationMs": 1.268,
"taskDurationMs": 376.6120000000001,
"heapDeltaBytes": 5075532,
"heapUsedBytes": 75891832,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.966000000000005,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 693.271999999979,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.724000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.8019999999999,
"heapDeltaBytes": 18791888,
"heapUsedBytes": 88134220,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 163.47500000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 740.2069999999412,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.568999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.04100000000005,
"heapDeltaBytes": 18226056,
"heapUsedBytes": 88339136,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 169.62,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2015.7350000000633,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.506000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.1919999999999,
"heapDeltaBytes": 22336192,
"heapUsedBytes": 87409080,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.274,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2048.390999999924,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.982999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.6379999999999,
"heapDeltaBytes": 10799248,
"heapUsedBytes": 85990996,
"domNodes": -272,
"jsHeapTotalBytes": -1409024,
"scriptDurationMs": 38.96899999999999,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2987.7669999999625,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.612999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1924.4879999999998,
"heapDeltaBytes": -6748676,
"heapUsedBytes": 95709380,
"domNodes": -274,
"jsHeapTotalBytes": 425984,
"scriptDurationMs": 983.524,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2768.1330000000344,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.377,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1797.2079999999999,
"heapDeltaBytes": 27623244,
"heapUsedBytes": 93215084,
"domNodes": -277,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 876.5849999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3646.150000000034,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.149999999999999,
"layouts": 60,
"layoutDurationMs": 12.403999999999998,
"taskDurationMs": 1740.1480000000001,
"heapDeltaBytes": 8790092,
"heapUsedBytes": 75558344,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 783.198,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3769.9420000000146,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.623000000000001,
"layouts": 60,
"layoutDurationMs": 13.026000000000002,
"taskDurationMs": 1811.1139999999998,
"heapDeltaBytes": 8483648,
"heapUsedBytes": 76230620,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 804.904,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3116.192000000069,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.325999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1989.3000000000002,
"heapDeltaBytes": 21938192,
"heapUsedBytes": 89721448,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 960.795,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3197.650000000067,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.394000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2026.697,
"heapDeltaBytes": 22781572,
"heapUsedBytes": 89402700,
"domNodes": -282,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 998.898,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2001.510000000053,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.910999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.326,
"heapDeltaBytes": 21930380,
"heapUsedBytes": 87290972,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.832,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 1998.2049999998708,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.8599999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.5349999999999,
"heapDeltaBytes": 22236948,
"heapUsedBytes": 88312416,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.81300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 637.593000000038,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.962,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.515,
"heapDeltaBytes": 15122760,
"heapUsedBytes": 88061500,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.517,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 637.7430000000004,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.130999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.298,
"heapDeltaBytes": 14812992,
"heapUsedBytes": 87461780,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 148.89000000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2040.2990000000045,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.788999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.539,
"heapDeltaBytes": -8254120,
"heapUsedBytes": 64429692,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.8469999999999995,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.9399999999723,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.838000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.703,
"heapDeltaBytes": -7828480,
"heapUsedBytes": 64429996,
"domNodes": -296,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.255,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.7950000000192,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.742,
"layouts": 18,
"layoutDurationMs": 5.287,
"taskDurationMs": 865.21,
"heapDeltaBytes": 2590316,
"heapUsedBytes": 75396476,
"domNodes": -293,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 114.88400000000001,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1789.2989999999145,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.644,
"layouts": 18,
"layoutDurationMs": 6.118,
"taskDurationMs": 943.835,
"heapDeltaBytes": 245680,
"heapUsedBytes": 73303904,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 127.218,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.7419999999602,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.347,
"layouts": 16,
"layoutDurationMs": 15.349000000000002,
"taskDurationMs": 939.5960000000003,
"heapDeltaBytes": 21044600,
"heapUsedBytes": 108656760,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.058999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9014.21300000004,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.157999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6129.249000000001,
"heapDeltaBytes": -11832100,
"heapUsedBytes": 88739236,
"domNodes": -269,
"jsHeapTotalBytes": -917504,
"scriptDurationMs": 2741.295,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9837.37700000006,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.544,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6410.501,
"heapDeltaBytes": -7264604,
"heapUsedBytes": 93250964,
"domNodes": -263,
"jsHeapTotalBytes": -655360,
"scriptDurationMs": 2854.017,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17921.65,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17265.988,
"heapDeltaBytes": -32782844,
"heapUsedBytes": 175878532,
"domNodes": -6548,
"jsHeapTotalBytes": -4485120,
"scriptDurationMs": 323.551,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18365.831999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17605.828,
"heapDeltaBytes": -17814072,
"heapUsedBytes": 175654368,
"domNodes": -6548,
"jsHeapTotalBytes": -1855488,
"scriptDurationMs": 322.253,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22137.177000000065,
"styleRecalcs": 173,
"styleRecalcDurationMs": 21.872000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21878.067000000003,
"heapDeltaBytes": -19932048,
"heapUsedBytes": 190517400,
"domNodes": -6548,
"jsHeapTotalBytes": -3801088,
"scriptDurationMs": 939.8219999999999,
"eventListeners": -7467,
"totalBlockingTimeMs": 71,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22421.92,
"styleRecalcs": 175,
"styleRecalcDurationMs": 23.635000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22163.769,
"heapDeltaBytes": -28126324,
"heapUsedBytes": 176315532,
"domNodes": -6548,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 1018.4089999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 185,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6521.021000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.60099999999998,
"layouts": 20,
"layoutDurationMs": 25.386000000000006,
"taskDurationMs": 6426.2300000000005,
"heapDeltaBytes": -21078556,
"heapUsedBytes": 181219780,
"domNodes": -6548,
"jsHeapTotalBytes": 18329600,
"scriptDurationMs": 129.616,
"eventListeners": -7469,
"totalBlockingTimeMs": 437,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6677.650000000085,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.22099999999999,
"layouts": 20,
"layoutDurationMs": 25.646000000000015,
"taskDurationMs": 6583.4890000000005,
"heapDeltaBytes": -35876940,
"heapUsedBytes": 173412496,
"domNodes": -6548,
"jsHeapTotalBytes": 11911168,
"scriptDurationMs": 127.05699999999997,
"eventListeners": -7471,
"totalBlockingTimeMs": 491,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 123.90599999991991,
"styleRecalcs": 9,
"styleRecalcDurationMs": 18.113,
"layouts": 3,
"layoutDurationMs": 1.7670000000000001,
"taskDurationMs": 91.757,
"heapDeltaBytes": 3093316,
"heapUsedBytes": 71603112,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.134000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 494.513999999981,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.114999999999995,
"layouts": 4,
"layoutDurationMs": 2.409,
"taskDurationMs": 140.095,
"heapDeltaBytes": 4902540,
"heapUsedBytes": 72547304,
"domNodes": 144,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.129000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #12233 +/- ##
==========================================
+ Coverage 80.81% 82.43% +1.62%
==========================================
Files 2444 2032 -412
Lines 124797 117407 -7390
Branches 31212 31270 +58
==========================================
- Hits 100849 96787 -4062
+ Misses 23445 20442 -3003
+ Partials 503 178 -325
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 423 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Custom node ecosystem search — breaking change validation
Searched the ComfyUI custom node ecosystem (GitHub code search + comfy-codesearch) for each deleted surface in this PR:
Hit triage
Confirmed real consumers
ConclusionThis is a partial breaking change for the ecosystem. No one is hitting the timing/status fields, but
— evidence gathered via |
Supplemental validation — ComfyUI custom node ecosystem searchThe earlier comment leaned mostly on
These are all real custom-node JS modules invoking Caveat: the comfy codesearch backend was intermittent during this run; queries that failed are not represented here, so the real consumer count may be slightly higher. |
699824f
Addresses review feedback: #12233 (review) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
CodeRabbit feedback addressedComment 1 (LGraph.ts:175-180 JSDoc update): Fixed in b0947ee - updated class summary to reflect executor removal. Comment 2 (LGraph.ts:352-412 compatibility shims): Skipped. The methods in question ( |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/litegraph/src/LGraph.ts`:
- Around line 176-179: The removal of LGraph.runStep() and
LGraph.sendEventToAllNodes() breaks third-party extensions; restore one-release
compatibility shims in the LGraph class by reintroducing deprecated stub methods
named runStep and sendEventToAllNodes that call the new APIs (or the internal
replacement methods) so behavior is preserved, emit a clear deprecation warning
(e.g., console.warn or processLogger) when each stub is invoked, and keep their
TypeScript signatures exported so TS consumers continue to type-check for one
release; ensure the stubs delegate to the current implementations and include a
TODO/TICKET reference for removal in the next major release.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 78fae435-0a95-467a-a5e1-54c91d999fd9
⛔ Files ignored due to path filters (1)
browser_tests/tests/canvasSettings.spec.ts-snapshots/canvas-info-hud-on-chromium-linux.pngis excluded by!**/*.png
📒 Files selected for processing (1)
src/lib/litegraph/src/LGraph.ts
Re-analyzing the actual needs (replacement API brainstorm)Based on the ecosystem audit above, here's what these extensions are actually trying to accomplish: 1.
|
| Method | Real want | Why current API doesn't work | Replacement |
|---|---|---|---|
runStep() |
Force refresh after client-side change | Backend-driven execution model | graph.trigger('node:output:changed') or setDirtyCanvas() |
sendEventToAllNodes() |
Broadcast custom events | No custom event support in graph.trigger() |
Extend graph.trigger() or add graph.broadcast() |
Recommendation:
- Before deleting
runStep(), provide clear migration guidance — most callers probably just needsetDirtyCanvas(true, true)or to rethink their approach - Before deleting
sendEventToAllNodes(), either:- Extend
graph.trigger()to support custom event types - Or add
graph.broadcast(eventName, payload)as a typed replacement
- Extend
- Open issues against the 6+ affected repos with migration instructions
|
Investigation (W15.F): PR currently |
DrJKL
left a comment
There was a problem hiding this comment.
Approving — pure dead-code removal, type system is doing the safety work here (the LGraphEventMode import drop is a nice tell that no callers remain).
One small follow-up while you're in LGraphNode.ts: the class-level JSDoc still advertises onStart / onStop as supported callbacks (lines 191–192). With sendEventToAllNodes() deleted, nothing dispatches those anymore, so the docstring should drop them:
+ onAdded: when added to graph (warning: this is called BEFORE the node is configured when loading)
+ onRemoved: when removed from graph
- + onStart: when the graph starts playing
- + onStop: when the graph stops playing
+ onDrawForeground: render the inside widgets inside the nodeNot a blocker — happy for it to land in a follow-up if you'd rather keep this PR scoped.
Addresses review feedback: #12233 (comment)
|
@coderabbitai review |
|
Addresses review feedback: #12233 (review) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Addresses review feedback: #12233 (comment)
1dd2e32 to
c6f23c3
Compare
|
Rebased onto current Full context for agent readersResolved the Verification on rebased head |
Addresses review feedback: #12233 (review)
c6f23c3 to
9fb7c6e
Compare
Addresses review feedback: #12233 (comment)
|
Rebased on current Full context for agent readersForce-pushed Evidence:
An earlier overbroad Vitest invocation ran the full suite and reported 15 failures in 9 unrelated test files; neither focused affected file failed, and the correctly scoped rerun above passed. |
Delete LGraph.start(), .stop(), .runStep(), .sendEventToAllNodes(), the runtime state fields they own (iteration, globaltime, runningtime, fixedtime, fixedtime_lapse, elapsed_time, last_update_time, starttime, catch_errors, execution_timer_id, errors_in_execution, execution_time, status), and the LGraph.STATUS_RUNNING/STATUS_STOPPED constants. The host methods were already `@deprecated 'Will be removed in 0.9'`. AUDIT-LG.9 confirmed zero internal and zero external callers across src/, browser_tests/, packages/. Stacks on top of #12228 which deleted the 6 stepping hooks fired from these methods. Transitive cleanup folded in: - LGraph.getTime/getFixedTime/getElapsedTime accessors (read deleted fields, zero callers) - LGraphNode.doExecute now drops 'this.exec_version = this.graph.iteration' - LGraphCanvas.renderInfo drops the T:/I: debug overlay lines - useCoreCommands.test.ts subgraph mock drops start/stop/runStep stubs - Unused LGraphEventMode import in LGraph.ts Preserves nodes_executing/nodes_actioning/nodes_executedAction - those pair with the trigger cluster being removed separately.
Missed in initial deletion - also clean README example.
Reverts incorrect local snapshots; fixes lineCount from 5 to 3 to match the actual number of lines displayed (N, V, FPS).
The HUD now shows N/V/FPS without the removed T:/I: lines.
Addresses review feedback: #12233 (review)
The HUD displays dynamic FPS values that change between runs, causing ~300 pixel variance in the 180×160 clip region (~1%).
Addresses review feedback: #12233 (comment)
9fb7c6e to
8e5d33d
Compare
|
Rebased onto current Full context for agent readersForce-pushed Evidence:
|
Stacks on #12228. Deletes the rest of the dead LGraph executor cluster per AUDIT-LG.9.
What
LGraph.start(),.stop(),.runStep(),.sendEventToAllNodes()methodsiteration,globaltime,runningtime,fixedtime,fixedtime_lapse,elapsed_time,last_update_time,starttime,catch_errors,execution_timer_id,errors_in_execution,execution_time,statusLGraph.STATUS_RUNNING/STATUS_STOPPED(live on the LGraph class itself, not LiteGraph global)clear()resets for those fieldsTransitive cleanup folded in (caught by manual review, not knip)
LGraph.getTime()/getFixedTime()/getElapsedTime()— read the deleted timing fields, zero callers anywhereLGraphNode.doExecute— dropthis.exec_version = this.graph.iteration(only writer;exec_versionitself has no readers but is left alone sincedoExecuteis part of the trigger cluster being removed separately)LGraphCanvas.renderInfo— drop theT:(globaltime) andI:(iteration) lines from the debug overlay;N:/V:/FPS:remainuseCoreCommands.test.ts— dropstart/stop/runStepfrom the subgraph mock objectLGraphEventModeimport inLGraph.tsWhy
The host methods were already
@deprecated 'Will be removed in 0.9'.AUDIT-LG.9 confirmed zero internal AND zero external callers across
src/, browser_tests/, and packages/. ComfyUI's executor runs on the
Python backend; the LiteGraph in-browser stepping loop is unused.
Verification
Sequencing
do NOT block forward motion until rebased onto the ECS branch.
┆Issue is synchronized with this Notion page by Unito
Re-audit context (W2F-1, 2026-05-13)
Re-audit context: no listener-variant consumer impact found in W2F-1 sweep across 138 indexed extension repos. The W2F-1 sweep targeted the 21 EXTENSION-CONSUMER surfaces enumerated in
research/touch-points/database.yaml(S2.N*, S3.C1, S6.A1, S11.G3); the symbols deleted in this PR are LITEGRAPH-INTERNAL and not in that surfaced set. Seeresearch/meta/sourcegraph-mcp-coverage-investigation.md§Step E (AUDIT-LG.10 verdict-table impact: zero flips required).