Repository navigation
refactor(litegraph): delete dead onGetNodeMenuOptions, deprecate onBeforeChange - #12230
Conversation
📝 WalkthroughWalkthroughRemoved two graph-level optional callbacks and an import from LGraph; beforeChange now dispatches to canvas-level onBeforeChange; LGraphCanvas.getNodeMenuOptions no longer calls the graph-level onGetNodeMenuOptions hook. ChangesLifecycle callback cleanup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
📦 Bundle: 5.38 MB gzip 🔴 +34 BDetailsSummary
Category Glance App Entry Points — 26.1 kB (baseline 26.1 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 82.9 kB (baseline 82.9 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 527 kB (baseline 527 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 14 unchanged User & Accounts — 17.8 kB (baseline 17.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 58 kB (baseline 58 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3.16 MB (baseline 3.16 MB) • 🟢 -89 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 367 kB (baseline 367 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 18 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 9.23 MB (baseline 9.23 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 86 unchanged ⚡ Performance Report
No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-18T22:46:16.688Z",
"gitSha": "d5e4f95cfff1005f28795254a59cab3a5153a4f0",
"branch": "litegraph/prune-lgraph-misc-hooks",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.425000000018,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.65,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.69300000000004,
"heapDeltaBytes": -3380860,
"heapUsedBytes": 46225552,
"domNodes": -265,
"jsHeapTotalBytes": 13324288,
"scriptDurationMs": 14.852,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2013.877999999977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.1229999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.55300000000005,
"heapDeltaBytes": 6367952,
"heapUsedBytes": 56544664,
"domNodes": -264,
"jsHeapTotalBytes": 18042880,
"scriptDurationMs": 15.335999999999999,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.693999999989,
"styleRecalcs": 73,
"styleRecalcDurationMs": 37.172999999999995,
"layouts": 12,
"layoutDurationMs": 3.4779999999999998,
"taskDurationMs": 812.578,
"heapDeltaBytes": -5492204,
"heapUsedBytes": 60225640,
"domNodes": -260,
"jsHeapTotalBytes": 29577216,
"scriptDurationMs": 127.271,
"eventListeners": -161,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1831.6820000000007,
"styleRecalcs": 74,
"styleRecalcDurationMs": 33.015,
"layouts": 12,
"layoutDurationMs": 3.2349999999999994,
"taskDurationMs": 783.441,
"heapDeltaBytes": 27804008,
"heapUsedBytes": 77900640,
"domNodes": -200,
"jsHeapTotalBytes": 29577216,
"scriptDurationMs": 115.74099999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1748.784999999998,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.300999999999998,
"layouts": 6,
"layoutDurationMs": 0.588,
"taskDurationMs": 284.386,
"heapDeltaBytes": 511764,
"heapUsedBytes": 49181776,
"domNodes": 76,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 17.281000000000006,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.5170000000103,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.266000000000002,
"layouts": 6,
"layoutDurationMs": 0.591,
"taskDurationMs": 294.757,
"heapDeltaBytes": 860580,
"heapUsedBytes": 50222100,
"domNodes": 78,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 22.671000000000003,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 585.8340000000055,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.367,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.77899999999994,
"heapDeltaBytes": -4233080,
"heapUsedBytes": 64525292,
"domNodes": 18,
"jsHeapTotalBytes": 20185088,
"scriptDurationMs": 58.44,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 532.4739999999792,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.078999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.322,
"heapDeltaBytes": 10079048,
"heapUsedBytes": 59332884,
"domNodes": 22,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 61.147999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2060.212000000007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.589000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.075,
"heapDeltaBytes": 38953096,
"heapUsedBytes": 96474612,
"domNodes": -261,
"jsHeapTotalBytes": 32792576,
"scriptDurationMs": 96.29999999999998,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2034.050000000036,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.243000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.2230000000001,
"heapDeltaBytes": 41328772,
"heapUsedBytes": 100293792,
"domNodes": -264,
"jsHeapTotalBytes": 33054720,
"scriptDurationMs": 86.422,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2097.7509999999884,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.567,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1022.603,
"heapDeltaBytes": 6585252,
"heapUsedBytes": 66226360,
"domNodes": -260,
"jsHeapTotalBytes": -557056,
"scriptDurationMs": 380.05300000000005,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2131.4080000000217,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.489,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1025.373,
"heapDeltaBytes": -431896,
"heapUsedBytes": 60480048,
"domNodes": -263,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 380.98699999999997,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3120.2039999999442,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.934,
"layouts": 60,
"layoutDurationMs": 6.566000000000001,
"taskDurationMs": 1227.428,
"heapDeltaBytes": 8136672,
"heapUsedBytes": 69261536,
"domNodes": -263,
"jsHeapTotalBytes": 5005312,
"scriptDurationMs": 463.853,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3162.474999999972,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.459,
"layouts": 60,
"layoutDurationMs": 6.8389999999999995,
"taskDurationMs": 1283.543,
"heapDeltaBytes": 38241288,
"heapUsedBytes": 107079600,
"domNodes": 12,
"jsHeapTotalBytes": 59125760,
"scriptDurationMs": 466.5590000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.5979999999927,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.277,
"heapDeltaBytes": -2089804,
"heapUsedBytes": 56455408,
"domNodes": -262,
"jsHeapTotalBytes": 4743168,
"scriptDurationMs": 86.57100000000001,
"eventListeners": -159,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.2689999999607,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.094000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.03000000000003,
"heapDeltaBytes": -13174272,
"heapUsedBytes": 55177076,
"domNodes": 18,
"jsHeapTotalBytes": 10629120,
"scriptDurationMs": 81.998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.3819999999964,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.442,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.36899999999997,
"heapDeltaBytes": -3928336,
"heapUsedBytes": 62285384,
"domNodes": 22,
"jsHeapTotalBytes": 22896640,
"scriptDurationMs": 134.967,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 528.7420000000225,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.392999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.78299999999996,
"heapDeltaBytes": -12711576,
"heapUsedBytes": 53500628,
"domNodes": 20,
"jsHeapTotalBytes": 20799488,
"scriptDurationMs": 121.82800000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2000.2289999999903,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.449000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.577,
"heapDeltaBytes": 22980756,
"heapUsedBytes": 72018004,
"domNodes": 16,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 11.868,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.1839999999856,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.412000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.358,
"heapDeltaBytes": 22702592,
"heapUsedBytes": 71308172,
"domNodes": 18,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 12.189000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1671.0840000000076,
"styleRecalcs": 75,
"styleRecalcDurationMs": 32.723,
"layouts": 16,
"layoutDurationMs": 4.195000000000001,
"taskDurationMs": 606.062,
"heapDeltaBytes": 14483508,
"heapUsedBytes": 67503228,
"domNodes": 61,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 83.73899999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.7389999999846,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.35,
"layouts": 16,
"layoutDurationMs": 4.101999999999999,
"taskDurationMs": 660.479,
"heapDeltaBytes": -3601028,
"heapUsedBytes": 44919332,
"domNodes": -260,
"jsHeapTotalBytes": 15593472,
"scriptDurationMs": 84.633,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1049.6850000000109,
"styleRecalcs": 15,
"styleRecalcDurationMs": 26.422999999999995,
"layouts": 4,
"layoutDurationMs": 13.71,
"taskDurationMs": 863.4199999999998,
"heapDeltaBytes": -24259276,
"heapUsedBytes": 118544496,
"domNodes": 12627,
"jsHeapTotalBytes": -29360128,
"scriptDurationMs": 29.204999999999995,
"eventListeners": 1639,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8364.125000000002,
"styleRecalcs": 248,
"styleRecalcDurationMs": 47.288000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3800.63,
"heapDeltaBytes": 75331988,
"heapUsedBytes": 134420264,
"domNodes": -263,
"jsHeapTotalBytes": 72318976,
"scriptDurationMs": 1218.431,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8135.378000000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 47.589,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3398.594,
"heapDeltaBytes": 8372308,
"heapUsedBytes": 68115764,
"domNodes": -261,
"jsHeapTotalBytes": 6025216,
"scriptDurationMs": 1172.51,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11479.808999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11452.259999999998,
"heapDeltaBytes": -34136452,
"heapUsedBytes": 175845700,
"domNodes": -8331,
"jsHeapTotalBytes": -19861504,
"scriptDurationMs": 586.876,
"eventListeners": -16490,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11247.892000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11239.491,
"heapDeltaBytes": -36459332,
"heapUsedBytes": 174247944,
"domNodes": -8360,
"jsHeapTotalBytes": 24702976,
"scriptDurationMs": 532.359,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14422.113000000025,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.504000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14386.333,
"heapDeltaBytes": -23222984,
"heapUsedBytes": 166336664,
"domNodes": -3308,
"jsHeapTotalBytes": 19107840,
"scriptDurationMs": 866.1320000000001,
"eventListeners": -16468,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13799.932000000012,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.027000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13779.194999999998,
"heapDeltaBytes": -10869620,
"heapUsedBytes": 193533124,
"domNodes": -8331,
"jsHeapTotalBytes": 26742784,
"scriptDurationMs": 817.163,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 462.6140000000305,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.871,
"layouts": 5,
"layoutDurationMs": 1.4799999999999998,
"taskDurationMs": 129.43200000000002,
"heapDeltaBytes": 5428364,
"heapUsedBytes": 56784348,
"domNodes": 170,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 29.171000000000003,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 477.87799999991876,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.724,
"layouts": 5,
"layoutDurationMs": 1.324,
"taskDurationMs": 134.513,
"heapDeltaBytes": -14914948,
"heapUsedBytes": 52352272,
"domNodes": 159,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 26.111,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1686 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 7.52 MB gzip 🔴 +11 BDetailsSummary
Category Glance App Entry Points — 46.8 kB (baseline 46.8 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.25 MB (baseline 1.25 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 95.2 kB (baseline 95.2 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 3 unchanged Panels & Settings — 526 kB (baseline 526 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 19.9 kB (baseline 19.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 3 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed / 1 unchanged UI Components — 57.2 kB (baseline 57.2 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 271 kB (baseline 271 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 3.34 MB (baseline 3.34 MB) • 🔴 +136 BHelpers, composables, and utility bundles
Status: 15 added / 15 removed / 17 unchanged Vendor & Third-Party — 15.3 MB (baseline 15.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 64 added / 64 removed / 94 unchanged ⚡ Performance Report
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-06-24T23:06:31.613Z",
"gitSha": "2c33c35eb7170c395bda27257f2cb35abe4ffb90",
"branch": "litegraph/prune-lgraph-misc-hooks",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.8619999999942,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.017999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.52900000000005,
"heapDeltaBytes": 24429904,
"heapUsedBytes": 76908512,
"domNodes": 18,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 23.517000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2015.8579999999802,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.056,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.5199999999999,
"heapDeltaBytes": -2089592,
"heapUsedBytes": 56571828,
"domNodes": 14,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 21.34,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2014.0010000000075,
"styleRecalcs": 78,
"styleRecalcDurationMs": 44.593,
"layouts": 12,
"layoutDurationMs": 3.8459999999999996,
"taskDurationMs": 882.246,
"heapDeltaBytes": -6672408,
"heapUsedBytes": 51935376,
"domNodes": 61,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 135.70700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1789.7850000000517,
"styleRecalcs": 74,
"styleRecalcDurationMs": 38.443,
"layouts": 12,
"layoutDurationMs": 3.643,
"taskDurationMs": 769.3190000000001,
"heapDeltaBytes": -7032984,
"heapUsedBytes": 51620584,
"domNodes": 56,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 124.197,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.672999999982,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.527,
"layouts": 6,
"layoutDurationMs": 0.5920000000000001,
"taskDurationMs": 364.03000000000003,
"heapDeltaBytes": 2251084,
"heapUsedBytes": 61114280,
"domNodes": 77,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 25.762,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.203000000036,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.554000000000002,
"layouts": 6,
"layoutDurationMs": 0.6209999999999998,
"taskDurationMs": 345.248,
"heapDeltaBytes": 1870704,
"heapUsedBytes": 60543324,
"domNodes": 78,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 24.172000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 594.7639999999978,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.825000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.436,
"heapDeltaBytes": 7406052,
"heapUsedBytes": 66224988,
"domNodes": 20,
"jsHeapTotalBytes": 19398656,
"scriptDurationMs": 58.291000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 567.7749999999833,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.816999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.71999999999997,
"heapDeltaBytes": 7257072,
"heapUsedBytes": 65937800,
"domNodes": 14,
"jsHeapTotalBytes": 17563648,
"scriptDurationMs": 57.830000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2019.713999999965,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.34,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.406,
"heapDeltaBytes": -8840080,
"heapUsedBytes": 63115308,
"domNodes": 20,
"jsHeapTotalBytes": 9318400,
"scriptDurationMs": 105.83200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2023.0299999999488,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.149000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.924,
"heapDeltaBytes": -9025984,
"heapUsedBytes": 63111836,
"domNodes": 20,
"jsHeapTotalBytes": 9318400,
"scriptDurationMs": 103.71100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2130.9140000000184,
"styleRecalcs": 69,
"styleRecalcDurationMs": 20.493000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1129.704,
"heapDeltaBytes": -15062448,
"heapUsedBytes": 58339960,
"domNodes": 18,
"jsHeapTotalBytes": 10366976,
"scriptDurationMs": 423.977,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2076.663000000053,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.019000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1030.38,
"heapDeltaBytes": 27898732,
"heapUsedBytes": 82487052,
"domNodes": 14,
"jsHeapTotalBytes": 466944,
"scriptDurationMs": 373.975,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3100.8030000000417,
"styleRecalcs": 64,
"styleRecalcDurationMs": 18.403000000000002,
"layouts": 60,
"layoutDurationMs": 7.547,
"taskDurationMs": 1315.676,
"heapDeltaBytes": 13242988,
"heapUsedBytes": 68755568,
"domNodes": 10,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 489.07899999999995,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3165.4140000000552,
"styleRecalcs": 65,
"styleRecalcDurationMs": 19.449,
"layouts": 60,
"layoutDurationMs": 7.428,
"taskDurationMs": 1335.748,
"heapDeltaBytes": 13144112,
"heapUsedBytes": 68676044,
"domNodes": 12,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 494.328,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.0160000000274,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.266,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.9419999999999,
"heapDeltaBytes": 10768568,
"heapUsedBytes": 65403092,
"domNodes": 18,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 107.92600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.2700000000195,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.159999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.705,
"heapDeltaBytes": 10218520,
"heapUsedBytes": 64888812,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 99.99000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 566.8570000000273,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.731,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.834,
"heapDeltaBytes": 8422864,
"heapUsedBytes": 67062676,
"domNodes": 22,
"jsHeapTotalBytes": 19660800,
"scriptDurationMs": 121.002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.7690000000839,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.314,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.756,
"heapDeltaBytes": 8070480,
"heapUsedBytes": 66794460,
"domNodes": 22,
"jsHeapTotalBytes": 19660800,
"scriptDurationMs": 120.796,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.3930000000032,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.950999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.492,
"heapDeltaBytes": -2220760,
"heapUsedBytes": 56508540,
"domNodes": 24,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 17.976,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1994.7570000000496,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.847999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.808,
"heapDeltaBytes": -2334864,
"heapUsedBytes": 56363172,
"domNodes": 22,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 19.235,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1715.3409999999667,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.192,
"layouts": 16,
"layoutDurationMs": 3.8469999999999995,
"taskDurationMs": 711.5409999999999,
"heapDeltaBytes": -10544140,
"heapUsedBytes": 48381716,
"domNodes": 66,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 96.37799999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1682.205999999951,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.047,
"layouts": 16,
"layoutDurationMs": 3.8780000000000006,
"taskDurationMs": 693.399,
"heapDeltaBytes": -10532348,
"heapUsedBytes": 48389348,
"domNodes": 63,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 92.735,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 947.3679999999831,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.365000000000002,
"layouts": 4,
"layoutDurationMs": 14.217999999999998,
"taskDurationMs": 737.8979999999999,
"heapDeltaBytes": 4507568,
"heapUsedBytes": 80976076,
"domNodes": 13833,
"jsHeapTotalBytes": 17825792,
"scriptDurationMs": 27.766,
"eventListeners": 2531,
"totalBlockingTimeMs": 167,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8156.949999999995,
"styleRecalcs": 251,
"styleRecalcDurationMs": 55.126000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3823.8280000000004,
"heapDeltaBytes": -3890424,
"heapUsedBytes": 68145496,
"domNodes": 20,
"jsHeapTotalBytes": 18669568,
"scriptDurationMs": 1239.399,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8125.583000000006,
"styleRecalcs": 251,
"styleRecalcDurationMs": 55.10799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3877.657,
"heapDeltaBytes": -4384064,
"heapUsedBytes": 67477932,
"domNodes": 20,
"jsHeapTotalBytes": 16572416,
"scriptDurationMs": 1265.141,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12807.193999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12790.701000000001,
"heapDeltaBytes": -35390392,
"heapUsedBytes": 169261292,
"domNodes": -3302,
"jsHeapTotalBytes": 19107840,
"scriptDurationMs": 590.173,
"eventListeners": -16473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12852.81299999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12836.897,
"heapDeltaBytes": -20479652,
"heapUsedBytes": 166776468,
"domNodes": -3302,
"jsHeapTotalBytes": 15437824,
"scriptDurationMs": 623.5269999999999,
"eventListeners": -16474,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.22666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14549.455000000024,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.58499999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14525.194000000001,
"heapDeltaBytes": -38920892,
"heapUsedBytes": 158385500,
"domNodes": -3302,
"jsHeapTotalBytes": 20156416,
"scriptDurationMs": 887.814,
"eventListeners": -16472,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14587.008999999965,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.364999999999966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14566.399000000001,
"heapDeltaBytes": -17899248,
"heapUsedBytes": 180691680,
"domNodes": -3302,
"jsHeapTotalBytes": 20332544,
"scriptDurationMs": 885.0499999999998,
"eventListeners": -16470,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 449.32199999993827,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.874,
"layouts": 4,
"layoutDurationMs": 1.1699999999999997,
"taskDurationMs": 119.676,
"heapDeltaBytes": 5348740,
"heapUsedBytes": 65148160,
"domNodes": 168,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 17.860999999999997,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 124.94499999991149,
"styleRecalcs": 12,
"styleRecalcDurationMs": 16.660999999999998,
"layouts": 4,
"layoutDurationMs": 1.0359999999999998,
"taskDurationMs": 97.956,
"heapDeltaBytes": -16301016,
"heapUsedBytes": 57629116,
"domNodes": 165,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.534000000000002,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #12230 +/- ##
==========================================
- Coverage 76.75% 76.05% -0.71%
==========================================
Files 1606 1605 -1
Lines 110541 107033 -3508
Branches 36147 33467 -2680
==========================================
- Hits 84851 81403 -3448
+ Misses 24815 24748 -67
- Partials 875 882 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 161 files with indirect coverage changes 🚀 New features to boost your workflow:
|
9d2cd7b to
dad1ead
Compare
Custom node ecosystem search — breaking change validationSearched the ComfyUI custom node ecosystem (GitHub code search + comfy codesearch index) for the 2 deleted
ConclusionNot a breaking change for custom nodes. Neither hook has any real consumer in the ecosystem. The canvas-side — evidence gathered via GitHub code search ( |
dfeeb7b
Re-analyzing the actual needs (replacement API brainstorm)Based on the re-audit findings in the PR description:
|
| Hook | Real consumers | Replacement needed? |
|---|---|---|
LGraph.onBeforeChange |
2 (bmad, BennyKok) | Yes — need graph.on('beforeChange') event or deprecation shim |
LGraph.onGetNodeMenuOptions |
0 | No — safe to delete |
Recommendation:
- The PR description already notes that
LGraphCanvas.onBeforeChangeis preserved, but the listener-assignment pattern (graph.onBeforeChange = fn) will break - Before merging, either:
- Add deprecation shims that emit warnings and forward to the new pattern
- Or ensure
graph.on('beforeChange', handler)API exists as replacement - Or open issues against bmad4ever/ComfyUI-Bmad-DirtyUndoRedo and BennyKok/comfyui-deploy with migration guidance
|
Investigation (W15.F): PR is APPROVED (DrJKL on HEAD |
|
@Comfy-Org/comfy_frontend_devs gentle ping — this PR is APPROVED (DrJKL, on current HEAD), all 3 required checks ( Per repo ruleset 991238 it requires a CODEOWNERS team member ( Investigation context: |
…reChange Delete two remaining LGraph instance hook fields confirmed dead by AUDIT-LG.9: - LGraph.onGetNodeMenuOptions field + dispatcher in LGraphCanvas.ts (context-menu construction). - LGraph.onBeforeChange field + dispatcher in LGraph.ts:1374. LGraphCanvas.onBeforeChange is a SEPARATE field and is preserved. Stacks on #12228. Closes the LGraph-side portion of #12224.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Ecosystem re-audit (W2F-1) found bmad4ever/ComfyUI-Bmad-DirtyUndoRedo assigns app.graph.onBeforeChange via the listener-assignment pattern. Deleting the field outright silently no-ops those handlers. Keep the hook as a deprecated shim: the dispatch in beforeChange() is restored and emits a one-time deprecation warning via warnDeprecated, nudging migration to LGraphCanvas.onBeforeChange. onGetNodeMenuOptions stays deleted (zero ecosystem consumers).
d57f5f7
07a5fbe to
d57f5f7
Compare
|
✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged. |
There was a problem hiding this comment.
Not sure if I interpret this correctly, it aligns with the commit title well but this commit deletes this.onBeforeChange?.(this, info) and restores/refactor it in subsequent commits. IMO it's better to keep it and do it in one commit to be atomic and recoverable
There was a problem hiding this comment.
It’s helpful to have all squashed commits in one clear history. I’m curious about your thoughts on organizing commits to address one concern at a time, avoiding undo or redo in later commits when possible, which makes review easier?
|
I have read and agree to the Contributor License Agreement |
Stacks on #12228. Part of the LGraph dead-hook cleanup per AUDIT-LG.9.
What
LGraph.onGetNodeMenuOptions— deleted (field + dispatcher inLGraphCanvas.getNodeMenuOptions). Zero ecosystem consumers.LGraph.onBeforeChange— deprecated, not deleted. The field and the dispatch inLGraph.beforeChange()are kept, but assigning a handler now emits a one-timewarnDeprecatednudging migration toLGraphCanvas.onBeforeChange.Why onBeforeChange is preserved
The W2F-1 re-audit found
bmad4ever/ComfyUI-Bmad-DirtyUndoRedoassignsapp.graph.onBeforeChange = fn(the listener-assignment pattern). Deleting the field outright would silently turn those handlers into no-ops. Keeping it as a deprecated shim preserves backward compatibility during a grace period while signaling the intended replacement.onAfterChangeis untouched (soBennyKok/comfyui-deploy'sonAfterChangewrapper keeps working).LGraphCanvas.onBeforeChangeremains a separate field, and the canvas dispatch chainthis.canvasAction((c) => c.onBeforeChange?.(this))is unchanged.Tests
LGraph.test.tscovers the shim: the assigned listener is still invoked, the deprecation warning fires when used, and no warning fires when no listener is assigned.Sequencing