Repository navigation
refactor(litegraph): delete LiteGraph trigger/action subsystem (closes #12223) - #12234
christian-byrne wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis PR removes the LiteGraph trigger/action subsystem across multiple core classes. The changes delete deprecated ON_TRIGGER mode, onAction callbacks, execution/action tracking fields, and timestamp-based rendering logic that were confirmed as unused by prior audit. ChangesTrigger/Action Subsystem Deletion
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
📦 Bundle: 5.35 MB gzip 🟢 -1.68 kBDetailsSummary
Category Glance App Entry Points — 31.8 kB (baseline 31.8 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 82.6 kB (baseline 82.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 526 kB (baseline 526 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 14 unchanged User & Accounts — 17.7 kB (baseline 17.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 57.9 kB (baseline 57.9 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3.15 MB (baseline 3.16 MB) • 🟢 -7.66 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 369 kB (baseline 369 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 19 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 9.13 MB (baseline 9.13 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 85 unchanged ⚡ Performance Report
No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-13T23:41:59.843Z",
"gitSha": "6387df40051e1ec50420d653324d942b83492a05",
"branch": "litegraph/prune-trigger-cluster",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.741999999956,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.299,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.279,
"heapDeltaBytes": 23091320,
"heapUsedBytes": 71920096,
"domNodes": 18,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 19.062999999999995,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2016.1190000000033,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.588,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.37999999999994,
"heapDeltaBytes": 20353080,
"heapUsedBytes": 69757108,
"domNodes": -263,
"jsHeapTotalBytes": 19001344,
"scriptDurationMs": 20.663,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.6189999999629,
"styleRecalcs": 70,
"styleRecalcDurationMs": 31.716,
"layouts": 12,
"layoutDurationMs": 3.6450000000000005,
"taskDurationMs": 791.7749999999999,
"heapDeltaBytes": 23314284,
"heapUsedBytes": 71942000,
"domNodes": -265,
"jsHeapTotalBytes": 17166336,
"scriptDurationMs": 106.32,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1772.677999999928,
"styleRecalcs": 72,
"styleRecalcDurationMs": 33.065999999999995,
"layouts": 12,
"layoutDurationMs": 3.7720000000000002,
"taskDurationMs": 724.605,
"heapDeltaBytes": -1758372,
"heapUsedBytes": 46502476,
"domNodes": -262,
"jsHeapTotalBytes": 14807040,
"scriptDurationMs": 100.21,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.8430000000408,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.468999999999998,
"layouts": 6,
"layoutDurationMs": 0.7589999999999999,
"taskDurationMs": 296.16,
"heapDeltaBytes": 6116788,
"heapUsedBytes": 72180752,
"domNodes": 78,
"jsHeapTotalBytes": 19750912,
"scriptDurationMs": 22.358,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.1490000000822,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.205,
"layouts": 6,
"layoutDurationMs": 0.6300000000000001,
"taskDurationMs": 275.08299999999997,
"heapDeltaBytes": 527212,
"heapUsedBytes": 49215924,
"domNodes": 78,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 17.163999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 522.9929999999854,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.704000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.843,
"heapDeltaBytes": 1185372,
"heapUsedBytes": 50087192,
"domNodes": -263,
"jsHeapTotalBytes": 16379904,
"scriptDurationMs": 47.836000000000006,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 479.1739999999436,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.0729999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.035,
"heapDeltaBytes": 9132548,
"heapUsedBytes": 57536732,
"domNodes": 19,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 47.54899999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2012.6640000000293,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.040000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.958,
"heapDeltaBytes": 2078236,
"heapUsedBytes": 60752048,
"domNodes": -260,
"jsHeapTotalBytes": 5529600,
"scriptDurationMs": 80.90400000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.9029999999184,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.6499999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.9630000000001,
"heapDeltaBytes": 42207348,
"heapUsedBytes": 101227684,
"domNodes": -264,
"jsHeapTotalBytes": 33841152,
"scriptDurationMs": 86.73400000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2119.583999999975,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.084,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1099.4650000000001,
"heapDeltaBytes": 60148844,
"heapUsedBytes": 120383972,
"domNodes": -260,
"jsHeapTotalBytes": 36667392,
"scriptDurationMs": 363.611,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2130.141999999978,
"styleRecalcs": 69,
"styleRecalcDurationMs": 20.43,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1095.1789999999999,
"heapDeltaBytes": 47768804,
"heapUsedBytes": 107719464,
"domNodes": -259,
"jsHeapTotalBytes": 39813120,
"scriptDurationMs": 352.92799999999994,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3100.8749999999736,
"styleRecalcs": 65,
"styleRecalcDurationMs": 17.493999999999996,
"layouts": 60,
"layoutDurationMs": 7.047,
"taskDurationMs": 1235.54,
"heapDeltaBytes": 54690636,
"heapUsedBytes": 116668244,
"domNodes": -269,
"jsHeapTotalBytes": 36986880,
"scriptDurationMs": 421.174,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3181.75999999994,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.856,
"layouts": 60,
"layoutDurationMs": 7.071000000000001,
"taskDurationMs": 1263.556,
"heapDeltaBytes": 44716308,
"heapUsedBytes": 106068188,
"domNodes": -265,
"jsHeapTotalBytes": 44064768,
"scriptDurationMs": 424.21,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.5939999999791,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.341,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.426,
"heapDeltaBytes": 3562908,
"heapUsedBytes": 63366792,
"domNodes": -264,
"jsHeapTotalBytes": -237568,
"scriptDurationMs": 69.937,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2046.7710000000352,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.849000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.4520000000001,
"heapDeltaBytes": 43862312,
"heapUsedBytes": 103668368,
"domNodes": -260,
"jsHeapTotalBytes": 27549696,
"scriptDurationMs": 86.127,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 494.75400000000036,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.58,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.502,
"heapDeltaBytes": 15236552,
"heapUsedBytes": 64690820,
"domNodes": 21,
"jsHeapTotalBytes": 17301504,
"scriptDurationMs": 106.12000000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 501.213000000007,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.354999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.83299999999997,
"heapDeltaBytes": 9500240,
"heapUsedBytes": 58076308,
"domNodes": 18,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 105.795,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2002.6739999999563,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.891999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.55999999999995,
"heapDeltaBytes": 23134476,
"heapUsedBytes": 72977732,
"domNodes": 18,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 17.583000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1999.3009999999458,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.162000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.91900000000004,
"heapDeltaBytes": 23065064,
"heapUsedBytes": 71953268,
"domNodes": 20,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 17.078999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1699.7899999999504,
"styleRecalcs": 74,
"styleRecalcDurationMs": 31.264,
"layouts": 16,
"layoutDurationMs": 4.2589999999999995,
"taskDurationMs": 646.5110000000001,
"heapDeltaBytes": -2219408,
"heapUsedBytes": 46934044,
"domNodes": -264,
"jsHeapTotalBytes": 14544896,
"scriptDurationMs": 73.7,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.9959999999983,
"styleRecalcs": 74,
"styleRecalcDurationMs": 32.580000000000005,
"layouts": 16,
"layoutDurationMs": 3.999,
"taskDurationMs": 619.3949999999999,
"heapDeltaBytes": -6799260,
"heapUsedBytes": 62859584,
"domNodes": 60,
"jsHeapTotalBytes": 17129472,
"scriptDurationMs": 75.535,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 982.6689999999871,
"styleRecalcs": 16,
"styleRecalcDurationMs": 23.360999999999994,
"layouts": 5,
"layoutDurationMs": 9.932,
"taskDurationMs": 746.0250000000002,
"heapDeltaBytes": 81986900,
"heapUsedBytes": 222756020,
"domNodes": 13513,
"jsHeapTotalBytes": 80216064,
"scriptDurationMs": 28.303999999999995,
"eventListeners": 2527,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8295.987000000025,
"styleRecalcs": 249,
"styleRecalcDurationMs": 49.711,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3627.7299999999996,
"heapDeltaBytes": 86974628,
"heapUsedBytes": 147210636,
"domNodes": -261,
"jsHeapTotalBytes": 64221184,
"scriptDurationMs": 1082.519,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8338.569000000007,
"styleRecalcs": 249,
"styleRecalcDurationMs": 48.902,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3669.843,
"heapDeltaBytes": 85415544,
"heapUsedBytes": 142939620,
"domNodes": -263,
"jsHeapTotalBytes": 68386816,
"scriptDurationMs": 1115.706,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12766.267000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12750.204,
"heapDeltaBytes": -20729832,
"heapUsedBytes": 230244512,
"domNodes": -8331,
"jsHeapTotalBytes": 4255744,
"scriptDurationMs": 576.5369999999999,
"eventListeners": -16488,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13906.176999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13889.439,
"heapDeltaBytes": 218392124,
"heapUsedBytes": 460885300,
"domNodes": -3310,
"jsHeapTotalBytes": 223055872,
"scriptDurationMs": 587.3820000000001,
"eventListeners": -16475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 11886.54200000002,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.672999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11873.764,
"heapDeltaBytes": -6126536,
"heapUsedBytes": 190371476,
"domNodes": -8331,
"jsHeapTotalBytes": 25403392,
"scriptDurationMs": 773.055,
"eventListeners": -16466,
"totalBlockingTimeMs": 104,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14850.887000000057,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.738000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14827.848000000002,
"heapDeltaBytes": 2709660,
"heapUsedBytes": 269730808,
"domNodes": -8331,
"jsHeapTotalBytes": 8626176,
"scriptDurationMs": 890.904,
"eventListeners": -16490,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 469.9869999999464,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.423,
"layouts": 5,
"layoutDurationMs": 1.495,
"taskDurationMs": 131.166,
"heapDeltaBytes": 5432260,
"heapUsedBytes": 55412912,
"domNodes": 168,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.336,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 457.48200000002726,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.701999999999998,
"layouts": 4,
"layoutDurationMs": 1.032,
"taskDurationMs": 112.231,
"heapDeltaBytes": 5073372,
"heapUsedBytes": 55556116,
"domNodes": 155,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 22.054,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🎨 Storybook: ❌ FailedDetails⏰ Completed at: 09/02/2026, 05:37:10 PM UTC Links
🎭 Playwright: 🕵🏻 0 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance
🔬 E2E Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #12234 +/- ##
==========================================
+ Coverage 80.76% 82.45% +1.68%
==========================================
Files 2440 2032 -408
Lines 124596 117524 -7072
Branches 31154 29521 -1633
==========================================
- Hits 100629 96903 -3726
+ Misses 23465 20443 -3022
+ Partials 502 178 -324
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 423 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Custom node ecosystem search — breaking change validation
This PR removes the LiteGraph trigger/action subsystem (~25 symbols on Symbols searched
Hit triage
Confirmed real consumers
ConclusionThe trigger/action cluster has almost no organic ecosystem usage — the AUDIT-LG.9 attribution was correct that this is dead infrastructure. The only real exposure overlaps with #12233:
Recommend the same approach as #12233: a one-line heads-up in the release notes plus an issue/PR against those two repos. Otherwise this is a clean prune. — evidence via |
Supplemental validation — ComfyUI custom node ecosystem searchThe earlier comment said the trigger/action cluster has "almost no ecosystem usage". After re-running this against the ComfyUI custom node ecosystem search (
|
| Repo | File | Usage |
|---|---|---|
SKBv0/ComfyUI_SKBundle |
js/MultiFloat.js#L111 |
this.node.triggerSlot(i, roundedValue) |
filliptm/ComfyUI_Fill-Nodes |
web/nodes/wip/fl_wf_agent.js#L1102-1103 |
node.triggerSlot(0) |
filliptm/ComfyUI_Fill-Nodes |
web/nodes/image/FL_ImageAdjuster.js#L77 |
node.triggerSlot(0) |
sofakid/dandy |
web/chains.js#L460, #L469 |
node.triggerSlot(out_slot) |
Removing the trigger subsystem will break these packs' runtime behavior, not just type signatures.
Other terms
node.actionDo/nodes_actioning/nodes_executedAction— comfy codesearch only returned vendored frontend copies, no real custom-node runtime consumers. Earlier conclusion stands for these.sendEventToAllNodesanddoExecute— comfy codesearch backend was unstable for these terms; earlier GH-search hits (sfinktah/comfy-ovum,diodiogod/TTS-Audio-Suite) remain the best evidence.
Caveat: the comfy codesearch backend was intermittent during this run.
Re-analyzing the actual needs (replacement API brainstorm)Looking at what exists: Existing
Existing
1.
|
| Pattern | What they think they need | What they actually need |
|---|---|---|
triggerSlot |
Push value to downstream | node:output:changed event + receiving node handler |
sendEventToAllNodes |
Broadcast custom event | graph.broadcast(customEvent, payload) |
doExecute |
Execute node client-side | Just invoke a callback — probably node.onSomethingChanged?.() |
These are awkward inter-node communication patterns. The core want is: typed pub/sub for custom events on the graph. The existing graph.trigger() system could be extended to allow custom event types.
Recommendation: Before merging this PR, we should:
- Design replacement APIs for the 3 patterns above
- Add deprecation warnings pointing to the new APIs
- Open issues against the 4-5 affected repos (SKBv0/ComfyUI_SKBundle, filliptm/ComfyUI_Fill-Nodes, sofakid/dandy, sfinktah/comfy-ovum, diodiogod/TTS-Audio-Suite)
- Set a deprecation timeline (2-3 releases)
Delete the in-browser trigger/action event subsystem (~22 symbols) confirmed dead by AUDIT-LG.5 + AUDIT-LG.9. ComfyUI's graph mutation event bus on LGraph.onTrigger / LGraph.trigger(action,param) is preserved — those are the production event hooks used by useGraphNodeManager, useErrorClearingHooks, and useMinimapGraph. LGraphNode: triggerSlot, actionDo, trigger, doExecute, addOnTriggerInput, addOnExecutedOutput, clearTriggeredSlot, onAfterExecuteNode, onAction, connect()'s LiteGraph.EVENT branch, findConnectByTypeSlot's createEventInCase block, ON_TRIGGER case in changeMode(), and the now-dead-on-arrival readers/writers for execute_triggered, action_triggered, exec_version, action_call. LGraph: triggerInput, setCallback, clearTriggeredSlots, _last_trigger_time, nodes_executing, nodes_actioning, nodes_executedAction, doExecute call site in runStep(). PRESERVES onTrigger field, trigger() dispatcher, and LGraphTrigger* types. globalEnums: LGraphEventMode.ON_TRIGGER. LiteGraphGlobal: LiteGraph.ON_TRIGGER, LiteGraph.do_add_triggers_slots, 'On Trigger' entry in NODE_MODES. LLink: _last_time field + LGraphCanvas fade-out reader (dead-on-arrival per AUDIT-LG.5). LGraphCanvas: do_add_triggers_slots menu block, _last_trigger_time dirty-bg-canvas reader, _last_time link fade-out reader, execute_triggered/action_triggered decrement counters; unused 'now' locals/params in _renderAllLinkSegments and _renderFloatingLinks removed in cascade. CARVE-OUT: LiteGraph.EVENT = -1 and LiteGraph.ACTION = -1 are NOT deleted. The user's instructions described these as living in '3 vendored canvas bundles' but in this layout they are referenced by 12 live TypeScript callers in LGraphCanvas.ts and linkColors.ts (slot-type filtering, link colors, type-filter menu options) which the user explicitly directed not to touch. Removing the constants would break TS compilation. The constants now point to slot types that no LGraphNode method can produce — the canvas branches are dead-on-arrival per AUDIT-LG.9. Closes #12223.
5ce1ce9 to
f5aef4b
Compare
|
Rebased onto current EvidenceConflicts resolved in Two test files landed on
Commands run post-rebase:
|
Deletes the entire in-browser trigger/action event subsystem (~22 symbols) per AUDIT-LG.5 + AUDIT-LG.9.
Deleted
triggerSlot,actionDo,trigger,doExecute,addOnTriggerInput,addOnExecutedOutput,clearTriggeredSlot,onAfterExecuteNode,onAction, theconnect()LiteGraph.EVENTbranch, thefindConnectByTypeSlotcreateEventInCaseblock, theON_TRIGGERcase inchangeMode(), the now-dead-on-arrival readers/writers forexecute_triggered,action_triggered,exec_version,action_call(field declarations +renderingBoxColorflash branch).triggerInput,setCallback,clearTriggeredSlots,_last_trigger_time,nodes_executing,nodes_actioning,nodes_executedAction,doExecutecall site inrunStep().LGraphEventMode.ON_TRIGGER.LiteGraphGlobal: Delete all of
LiteGraph.ON_TRIGGER,LiteGraph.do_add_triggers_slots,'On Trigger'entry inNODE_MODES._last_time+LGraphCanvasfade-out reader.do_add_triggers_slotsmenu block,_last_trigger_timedirty-bg-canvas reader,_last_timelink fade-out reader,execute_triggered/action_triggereddecrement counters; unusednowlocals/params in_renderAllLinkSegmentsand_renderFloatingLinksremoved in cascade.Preserved
LGraph.onTriggerfieldLGraph.trigger(action, param)dispatcherLGraphTrigger*typesThese form the typed graph-mutation event bus with 6 production callers in
useGraphNodeManager.ts,useErrorClearingHooks.ts, anduseMinimapGraph.ts.Carve-out (deviation from scoping doc)
The scoping ticket asked for
LiteGraph.EVENT = -1andLiteGraph.ACTION = -1to be deleted, with the note that '6 LiteGraph.EVENT references in 3 vendored canvas bundles' would be acceptable to leave intact per AUDIT-LG.9. In this layout there are no separate vendored bundles — the references live in live TypeScript source:LGraphCanvas.ts(8EVENT+ 3ACTIONrefs in slot-type filtering / type-filter menu paths) andutils/linkColors.ts(1EVENTref in link color resolution). Deleting the constants would break TS compilation across the canvas, so they are kept defined.The constants now point to slot types that no
LGraphNodemethod can produce — the canvas branches that compare against them are dead-on-arrival per AUDIT-LG.9. They can be cleaned up in a follow-up that retires the canvas type-filter logic.Verification
pnpm lint→ 0 errors (3 pre-existing warnings)pnpm format:check→ cleanpnpm typecheck→ cleanpnpm knip→ clean (no new dead code surfaced)pnpm vitest run src/lib/litegraph/→ 932 / 932 pass (snapshot regenerated to dropdo_add_triggers_slots,ON_TRIGGER, and'On Trigger'entries)Sequencing
main; independent of refactor(litegraph): prune dead surfaces (AUDIT-LG implementation, draft) #12228 stack.Closes #12223.
┆Issue is synchronized with this Notion page by Unito
Re-audit context (W2F-1, 2026-05-13)
Re-audit context: no listener-variant consumer impact found in W2F-1 sweep across 138 indexed extension repos. The W2F-1 sweep targeted the 21 EXTENSION-CONSUMER surfaces enumerated in
research/touch-points/database.yaml(S2.N*, S3.C1, S6.A1, S11.G3); the symbols deleted in this PR are LITEGRAPH-INTERNAL and not in that surfaced set. Seeresearch/meta/sourcegraph-mcp-coverage-investigation.md§Step E (AUDIT-LG.10 verdict-table impact: zero flips required).