Repository navigation
Conversation
5faa219 to
1bd0189
Compare
|
ack |
|
ACK 1bd0189 I updated stratum-mining/sv2-tp#108 to match. How do you want to go about deploying this? It's probably safest if you first update SRI to optionally handle this extra field. I could then release a new sv2-tp version that sets the field, and note in its release notes the minimum expected SRI release. Or we could do something more graceful like bumping a protocol number? |
|
Ack |
7a54b79 to
dc6c26d
Compare
|
ack |
|
@plebhash do you have a branch that implements this spec change? Then I can test stratum-mining/sv2-tp#108 CI against that. I'll update it to use |
dc6c26d to
d9b06ac
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
- add `NewTemplate.coinbase_witness` to TDP as `OPTION[U256]` - define conditional encoding: - empty when witness commitment output is omitted - exactly 32 bytes when witness commitment output is present - codify BIP141 empty-block behavior (witness commitment optional) - require clients to preserve TP-provided output ordering as `<client-added-outputs> || <NewTemplate.coinbase_tx_outputs>` - clarify field purpose: serialize coinbase witness coherently with TP commitment output; no witness-commitment recomputation required - update Protocol Overview BIP141 text to match the new rules
d9b06ac to
0c274cf
Compare
|
Thanks, it would be good to test sv2-tp against a proposed SRI change, and figure out the right deployment sequence. I suspect we'll need a protocol version bump for this. If so, we should also settle on #216. |
close #166
as discussed in #156 (TLDR: future-proofing Sv2 TDP wrt future/potential BIP141-related consensus changes)
note: this PR is similar to #15, which was opened in 2022 and closed in 2023 with pending review comments and no merging
so I'm trying to preemptively address some confusion points that were left as pending review comments on #15