Repository navigation
Conversation
The proposed NewTemplate.coinbase_witness field in stratum-mining#198 is intended to provide this information explicitly. The current SRI template provider in sv2-apps already sends empty excess_data. sv2-tp sends the coinbase witness instead, which causes problems discussed in stratum-mining/sv2-tp#138. Explicitly exclude the coinbase witness from excess_data and require the field to be empty for now. Keep the field and require Job Declarators to forward it unchanged.
Contributor
Author
|
cc @plebhash and @TheBlueMatt |
Member
Sjors
added a commit
to Sjors/sv2-tp
that referenced
this pull request
Oct 29, 2026
No excess data is currently defined, and the coinbase witness does not belong in this field. Always send empty excess_data, as proposed in: stratum-mining/sv2-spec#241 This also avoids reading the coinbase after a submitted solution has replaced it with a transaction that may have no inputs, fixing the crash described in stratum-mining#138.
Sjors
added a commit
to stratum-mining/sv2-tp
that referenced
this pull request
Nov 11, 2026
a32129b test: cover transaction requests after an inputless coinbase (Sjors Provoost) 6fa70e6 sv2: leave transaction response excess_data empty (Sjors Provoost) 4d6920d test: retain submitted coinbases in the mining mock (Sjors Provoost) Pull request description: Depends on: - stratum-mining/sv2-spec#241 The SRI version already does this. Alternative to #138. ACKs for top commit: xyephy: tACK a32129b Tree-SHA512: 1b788dda5e490f4d9a75ff341395ff6b45013f87aa5a0600fb2dbef1e0bb35af9dfdd0c6872e57d0f3ea374c38db3e519e0c3b84843e49062a42a56786444052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed
NewTemplate.coinbase_witnessfield in #198 is intended to provide this information explicitly.The current SRI template provider in sv2-apps already sends empty
excess_data.sv2-tp sends the coinbase witness instead, which causes problems, stratum-mining/sv2-tp#138.
Explicitly exclude the coinbase witness from
excess_dataand require the field to be empty for now. Keep the field and require Job Declarators to forward it unchanged.