Repository navigation
Conversation
This was referenced Jun 16, 2026
Sjors
force-pushed
the
2026/06/witness_reserved_value
branch
from
September 3, 2026 11:29
6e9cb7f to
a4bda69
Compare
Adding coinbase_witness to the Sv2NewTemplate message so that it is automatically propagated to other roles in the Stratum v2 ecosystem, rather than assumed to be 0x00...00. This ensures that if this value ever gets consensus meaning, miners only need to upgrade their node software, not the rest of the mining stack. This is a breaking change requiring an updated Stratum v2 spec as well as support on the SRI side.
Sjors
force-pushed
the
2026/06/witness_reserved_value
branch
from
November 10, 2026 14:17
a4bda69 to
c5b147f
Compare
Collaborator
Author
|
@plebhash this PR now assume a protocol bump from 2 to 3, only setting the new field for the latter. So you should be able to test it against an SRI branch that implements the new field. I won't merge this until we have agreement on the spec of course. |
Assume Stratum V2 spec version 3 introduces NewTemplate.coinbase_witness. Support versions 2 and 3 and pass the negotiated version to NewTemplate. Omit the entire witness field, including its option count, for version 2 clients so existing SRI can parse NewTemplate. Version 3 clients receive the witness value. Let the template-provider test harness specify a maximum version and check the selected version and template layout for each connection. Disconnect legacy clients if the node supplies a nonzero witness that their implicit zero-value assumption cannot represent.
Sjors
force-pushed
the
2026/06/witness_reserved_value
branch
from
November 10, 2026 14:39
c5b147f to
f715ee3
Compare
Sjors
added a commit
that referenced
this pull request
Nov 10, 2026
c75e2ba refactor: prepare SV2 protocol version negotiation (Sjors Provoost) Pull request description: Select the highest common version from an explicit supported range and store it on each client. Keep both ends of the supported range at version 2, preserving the existing handshake behavior and message serialization. Preparation for #108 or anything else that requires a stratum protocol version bump. Top commit has no ACKs. Tree-SHA512: 1cc1470fd60cc9bc4c530ba012e79f9e14f613b45c75dcc0a3f97ff8b876efbdd76f2eadbbf2f0cde46d75921597b3fa155d5670292878187820be65d94ca70e
Sjors
force-pushed
the
2026/06/witness_reserved_value
branch
from
November 10, 2026 16:18
f715ee3 to
4f04944
Compare
Collaborator
Author
|
Rebased after #157. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
coinbase_witnessto theSv2NewTemplatemessage so that it is automatically propagated to other roles in the Stratum v2 ecosystem, rather than assumed to be0x00...00.This ensures that if this value ever gets consensus meaning, miners only need to upgrade their node software, not the rest of the mining stack.
This is a breaking change requiring an updated Stratum v2 spec as well as support on the SRI side.
coinbase_witnessfield toNewTemplatesv2-spec#198Supersedes #10.
TODO: