Repository navigation
Refs #API-33: Drop Ruby 2.7 support - #26
Open
franco-mariani wants to merge 1 commit into
Open
franco-mariani wants to merge 1 commit into
franco-mariani wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The three configuration changes consistently implement the intended support boundary, with no blocking code issues identified.
No open issues 🎉
What changed in this PR
Drops Ruby 2.7 support and aligns the gem’s minimum Ruby requirement, CI matrix, and lint configuration around Ruby 3.0.
Changes:
- Raises the gem’s minimum Ruby version from 2.6 to 3.0.
- Removes Ruby 2.7 from CI, retaining Ruby 3.0 and 3.1.
- Sets RuboCop’s target Ruby version to 3.0.
Before merging, an administrator must remove specs (2.7) from the required checks on main.
| File | Description |
|---|---|
| graphql_to_rest.gemspec | Requires Ruby 3.0 or newer for installation. |
| .rubocop.yml | Targets Ruby 3.0 for linting. |
| .github/workflows/main.yml | Removes Ruby 2.7 from the test matrix. |
Review effort: Balanced
This was referenced Oct 22, 2026
franco-mariani
requested review from
a team,
edvardas-samesystem and
povilasjurcys
October 22, 2026 10:46
franco-mariani
marked this pull request as ready for review
October 22, 2026 10:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 2.7 can no longer install this gem's development dependencies:
Gemfile.lockhas pinnednokogiri 1.17.2(Ruby >= 3.0) since Dec 2024, so thespecs (2.7)job fails atbundle install(nokogiri-1.17.2-x86_64-linux requires ruby version < 3.4.dev, >= 3.0) on every PR. Ruby 2.7 has also been end-of-life since March 2023.This PR:
required_ruby_versionfrom>= 2.6.0to>= 3.0.0, so the gemspec only claims versions CI actually tests. Apps on Ruby < 3.0 will no longer be able to install new versions of the gem; the only known consumer (samesystem) runs Ruby 4.0.6.TargetRubyVersionto 3.0.Before merging, an admin needs to remove
specs (2.7)from the required checks onmain.Note: the
specs (3.0)/specs (3.1)jobs may still go red here after the specs pass, because the oldcodecovgem's upload gets rate-limited and exits 1 (same as #22 and #24). That's fixed separately in the Codecov replacement PR, which builds on this one.