Skip to content

Refs #API-33: Drop Ruby 2.7 support - #26

Open
franco-mariani wants to merge 1 commit into
mainfrom
fix/API-33-drop-ruby-2-7
Open

franco-mariani wants to merge 1 commit into
mainfrom
fix/API-33-drop-ruby-2-7

Conversation

@franco-mariani

Copy link
Copy Markdown

Ruby 2.7 can no longer install this gem's development dependencies: Gemfile.lock has pinned nokogiri 1.17.2 (Ruby >= 3.0) since Dec 2024, so the specs (2.7) job fails at bundle install (nokogiri-1.17.2-x86_64-linux requires ruby version < 3.4.dev, >= 3.0) on every PR. Ruby 2.7 has also been end-of-life since March 2023.

This PR:

  • Drops Ruby 2.7 from the CI matrix (now 3.0 and 3.1).
  • Raises required_ruby_version from >= 2.6.0 to >= 3.0.0, so the gemspec only claims versions CI actually tests. Apps on Ruby < 3.0 will no longer be able to install new versions of the gem; the only known consumer (samesystem) runs Ruby 4.0.6.
  • Sets RuboCop's TargetRubyVersion to 3.0.

Before merging, an admin needs to remove specs (2.7) from the required checks on main.

Note: the specs (3.0) / specs (3.1) jobs may still go red here after the specs pass, because the old codecov gem's upload gets rate-limited and exits 1 (same as #22 and #24). That's fixed separately in the Codecov replacement PR, which builds on this one.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The three configuration changes consistently implement the intended support boundary, with no blocking code issues identified.

No open issues 🎉

What changed in this PR

Drops Ruby 2.7 support and aligns the gem’s minimum Ruby requirement, CI matrix, and lint configuration around Ruby 3.0.

Changes:

  • Raises the gem’s minimum Ruby version from 2.6 to 3.0.
  • Removes Ruby 2.7 from CI, retaining Ruby 3.0 and 3.1.
  • Sets RuboCop’s target Ruby version to 3.0.

Before merging, an administrator must remove specs (2.7) from the required checks on main.

File Description
graphql_to_rest.gemspec Requires Ruby 3.0 or newer for installation.
.rubocop.yml Targets Ruby 3.0 for linting.
.github/​workflows/​main.yml Removes Ruby 2.7 from the test matrix.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants