Repository navigation
Refs #API-33: Replace Codecov with a SimpleCov coverage threshold and drop Ruby 2.7 - #25
Closed
franco-mariani wants to merge 7 commits into
Closed
franco-mariani wants to merge 7 commits into
franco-mariani wants to merge 7 commits into
Conversation
franco-mariani
marked this pull request as draft
October 16, 2026 11:27
There was a problem hiding this comment.
🟡 Changes recommended
The gemspec introduces a consumer-facing Ruby compatibility restriction that the PR description explicitly excludes.
1 open issue
What changed in this PR
This PR separates coverage uploads from test execution so Codecov upload failures no longer fail otherwise passing specs.
Changes:
- Replace the Codecov gem integration with SimpleCov JSON output.
- Upgrade the workflow to Codecov Action v5 with an explicit token and coverage file.
- Remove Ruby 2.7 from CI and raise the lint target and gem minimum to Ruby 3.0.
| File | Description |
|---|---|
| spec/spec_helper.rb | Generate JSON coverage in CI instead of uploading from SimpleCov. |
| graphql_to_rest.gemspec | Raise the minimum supported Ruby version to 3.0. |
| Gemfile.lock | Remove the locked Codecov dependency. |
| Gemfile | Remove the Codecov test dependency. |
| .rubocop.yml | Set the Ruby lint target to 3.0. |
| .github/workflows/main.yml | Drop Ruby 2.7 and configure Codecov Action v5 uploads. |
Review effort: Balanced
franco-mariani
requested review from
edvardas-samesystem and
povilasjurcys
and
a balanced review from Copilot
October 22, 2026 08:35
franco-mariani
marked this pull request as ready for review
October 22, 2026 08:36
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Every specs job is red even when all specs pass: the old
codecovgem uploads from SimpleCov's at_exit insidebundle exec rake, Codecov rejects the tokenless upload (Rate limit reached…), and the process exits 1. Codecov hasn't received an upload since 2023-08-18 (#20), and thecodecovgem is deprecated (its repo is archived, last release0.6.0in Aug 2021).codecovgem and the Codecov workflow step.minimum_coverage 98in CI (currently 98.73%), so a PR that drops coverage fails the specs job.nokogiri 1.17.2(Ruby >= 3.0) since Dec 2024, so 2.7 fails at bundle install. RuboCop's TargetRubyVersion moves to 3.0.Before merging, an admin needs to remove specs (2.7) from the required checks on main.
Follow-ups (separate PRs): Pronto + RuboCop on PRs, Brakeman, dependency and Ruby upgrade maybe? (refresh the lockfile, test 3.3/3.4/4.0, raise required_ruby_version)