Repository navigation
Refs #API-33: Replace Codecov with a SimpleCov coverage threshold - #27
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The dependency removal, coverage threshold, and reporting changes are consistent, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Replaces Codecov uploads with a CI-enforced SimpleCov coverage threshold and GitHub Actions reports, removing the failing external upload dependency. This PR builds on #26’s Ruby 2.7 removal.
Changes:
- Removes the Codecov dependency, workflow step, and token configuration.
- Enforces a 98% minimum coverage threshold in CI.
- Adds line coverage to job summaries and uploads HTML reports per Ruby version.
| File | Description |
|---|---|
spec/spec_helper.rb |
Replaces the Codecov formatter with a CI-only coverage threshold. |
Gemfile.lock |
Removes Codecov from the locked dependencies. |
Gemfile |
Removes the Codecov test dependency. |
.github/workflows/main.yml |
Replaces Codecov uploads with coverage summaries and report artifacts. |
Review effort: Balanced
franco-mariani
requested review from
a team,
edvardas-samesystem and
povilasjurcys
October 22, 2026 10:48
franco-mariani
marked this pull request as ready for review
October 22, 2026 10:48
povilasjurcys
approved these changes
Oct 26, 2026
edvardas-samesystem
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #26 (Drop Ruby 2.7 support), which should merge first. GitHub will retarget this PR to
mainwhen #26's branch is deleted.Every specs job is red even when all specs pass: the old
codecovgem uploads from SimpleCov'sat_exitinsidebundle exec rake, Codecov rejects the tokenless upload (Rate limit reached…), and the process exits 1. Codecov hasn't received an upload since 2023-08-18 (#20), and thecodecovgem is deprecated (its repo is archived, last release 0.6.0 in Aug 2021).This PR drops Codecov instead of reviving it:
codecovgem and the Codecov workflow step (and the unusedCODECOV_TOKENenv).minimum_coverage 98in CI (currently 98.73%), so a PR that drops coverage fails the specs job.coverage-ruby-<version>artifact.Supersedes #25, which combined this with the Ruby 2.7 removal.
Follow-ups (separate PRs): Pronto + RuboCop on PRs; dependency and Ruby upgrade (refresh the lockfile, test 3.3/3.4/4.0).