Skip to content

Handle vaultless deployment operations#2773

Open
findolor wants to merge 1 commit into
rai-1063-js-builder-vaultless-statefrom
rai-1063-vaultless-deployment-ops
Open

Handle vaultless deployment operations#2773
findolor wants to merge 1 commit into
rai-1063-js-builder-vaultless-statefrom
rai-1063-vaultless-deployment-ops

Conversation

@findolor

@findolor findolor commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Treat builder deposit amounts for vaultless output tokens as wallet allowance targets, not orderbook deposits.
  • Generate approvals for configured output deposits when allowance differs, including vaultless outputs.
  • Generate deposit calldata only for vault-backed outputs; input-only deposits produce no approval/deposit.
  • Decode-test deployment multicall shape so it contains addOrder plus only vault-backed deposit4 calls.

Validation

  • cargo test -p raindex_common generate_deposit_calldatas
  • cargo test -p raindex_common output_deposits_by_token
  • cargo check -p raindex_common
  • npm run build && npm test -- test/js_api/builder.test.ts in packages/raindex
  • Final stack: rainix-rs-static
  • Final stack: wasm target cargo test for raindex_quote, raindex_bindings, raindex_js_api, raindex_common
  • Final stack: npm run build && npm test in packages/raindex

Review

  • Staged local review completed. A duplicate approval finding for repeated output tokens was fixed by deduping approval candidates by token address; follow-up review was clean.

Refs RAI-1063.

@linear

linear Bot commented Jun 16, 2026

Copy link
Copy Markdown

RAI-1063

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label Raindex-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fb117632-7c4f-4b44-a93a-1f69dad80d8d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rai-1063-vaultless-deployment-ops

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@findolor findolor force-pushed the rai-1063-vaultless-deployment-ops branch from 3ba5c17 to 08d98bc Compare June 17, 2026 07:41
@findolor findolor self-assigned this Jun 17, 2026
@findolor findolor requested review from 0xgleb and JuaniRios June 17, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants