Skip to content

Add builder vaultless state APIs#2772

Open
findolor wants to merge 1 commit into
rai-1063-vault-operation-guardsfrom
rai-1063-js-builder-vaultless-state
Open

Add builder vaultless state APIs#2772
findolor wants to merge 1 commit into
rai-1063-vault-operation-guardsfrom
rai-1063-js-builder-vaultless-state

Conversation

@findolor

@findolor findolor commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add explicit builder APIs setVaultless and getVaultless for JS/WASM consumers.
  • Keep setVaultId mutually exclusive with vaultless and reject zero through settings validation.
  • Round-trip vaultless flags through generated dotrain and serialized builder state, including a legacy state fallback.

Validation

  • cargo test -p raindex_common test_set_and_get_vaultless
  • cargo test -p raindex_common raindex_order_builder::state_management::tests
  • cargo check -p raindex_js_api
  • npm run build && npm test -- test/js_api/builder.test.ts in packages/raindex
  • Final stack: rainix-rs-static
  • Final stack: wasm target cargo test for raindex_quote, raindex_bindings, raindex_js_api, raindex_common
  • Final stack: npm run build && npm test in packages/raindex

Review

  • Staged local review completed. During self-review, serialized-state backward compatibility was fixed before final review; both reviewers were clean.

Refs RAI-1063.

@linear

linear Bot commented Jun 16, 2026

Copy link
Copy Markdown

RAI-1063

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 923daf64-aa1f-4f3d-9db3-db35c1d7457b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rai-1063-js-builder-vaultless-state

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

findolor commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label Raindex-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants