Skip to content

Reject zero vault operations#2771

Open
findolor wants to merge 1 commit into
rai-1063-add-order-vaultlessfrom
rai-1063-vault-operation-guards
Open

Reject zero vault operations#2771
findolor wants to merge 1 commit into
rai-1063-add-order-vaultlessfrom
rai-1063-vault-operation-guards

Conversation

@findolor

@findolor findolor commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Reject zero vault IDs in SDK deposit and withdraw calldata/execution paths before building contract calls.
  • Exclude zero vaults from normal withdrawable vault convenience flows.
  • Preserve raw read/query support for on-chain zero-vault orders.

Validation

  • cargo test -p raindex_common zero_vault
  • Focused deposit, withdraw, and withdrawable-vault tests
  • cargo check -p raindex_common
  • Final stack: rainix-rs-static
  • Final stack: wasm target cargo test for raindex_quote, raindex_bindings, raindex_js_api, raindex_common
  • Final stack: npm run build && npm test in packages/raindex

Review

  • Staged local review completed. A review finding about validating before allowance/ledger setup was fixed; follow-up review was clean.

Refs RAI-1063.

@linear

linear Bot commented Jun 16, 2026

Copy link
Copy Markdown

RAI-1063

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e3b7547a-ae75-47a3-a0ff-5b7ed9bbe174

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rai-1063-vault-operation-guards

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

findolor commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label Raindex-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants