Repository navigation
Cloudflare Worker: drop the migration notes, fix the step numbering - #118
Merged
Merged
Conversation
Three tidy-ups to the guide, two of them mine from yesterday. - Removed the "earlier releases had SITE_KEY / took ORIGIN_URL, both are gone" asides. A customer reading the install guide has no use for what the worker used to do; they only need what to configure now. - Part 2 ran 2a, 2c, 2d. Deleting the auto-inject section and promoting the manual one to 2a left a hole. It is 2a, 2b, 2c now. - "How the worker reaches your origin" was an unnumbered h3 sitting between 1c and 1d, so it read as a step without being one and broke the lettered run. It is 1d now, and Verify is 1e. Also fixes a link on the troubleshooting page that pointed at #step-1-add-the-protect-js-bundle-to-every-html-page, a heading that does not exist on the page. It now points at 2a. Checked every anchor any page aims at the worker guide: all resolve. astro build passes, 417 pages. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for peaceful-pothos-9e62ce ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Three tidy-ups to the Cloudflare Worker guide. Two of the problems are mine, introduced in #116 yesterday.
1. Removed the "what it used to do" asides. The page carried two: that earlier releases had a
SITE_KEYvar which rewrote your HTML, and that they took anORIGIN_URLplus a second grey-cloudedorigin.<your-domain>record, "both are gone". A customer following an install guide has no use for what the product used to do — they need to know what to configure now. Both sentences are gone; the surrounding guidance that matters is kept.2. Part 2 was numbered 2a, 2c, 2d. Deleting the auto-inject section and promoting the manual one to 2a left a hole in the sequence. Now 2a, 2b, 2c.
3. "How the worker reaches your origin" was an unnumbered
###between 1c and 1d. It read like a step without being one, and interrupted the lettered run. It's 1d now, and Verify is 1e.Also: a link on the troubleshooting page pointed at
#step-1-add-the-protect-js-bundle-to-every-html-page, a heading that doesn't exist on the worker page. It now points at#2a-add-the-snippet.Test coverage
astro buildpasses, 417 pages.Checked against the rendered HTML rather than the source: no "Earlier releases", "both are gone" or "has been removed" text survives, and the new headings render with the expected anchors. I also walked every
cloudflare-worker#…anchor used by any page in the site and confirmed all of them resolve to anidthat exists on the built page — that's what caught the broken troubleshooting link, which predates my changes.Relationship to #115
goastler's #115 covers the same SITE_KEY/auto-inject removal that merged as #116, so that part is already on main. The one thing #115 has that #116 didn't is the troubleshooting link fix — which this PR now does. Worth closing #115 as superseded unless it carries something else.
🤖 Generated with Claude Code