Skip to content

Warn not to enable Workers Cache on the Protect worker - #114

Merged
forgetso merged 1 commit into
mainfrom
docs-warn-workers-cache
Oct 20, 2026
Merged

forgetso merged 1 commit into
mainfrom
docs-warn-workers-cache

Conversation

@goastler

Copy link
Copy Markdown
Member

What changed: The Cloudflare Worker setup page now has a warning not to turn on Workers Cache, and the troubleshooting page has a new entry for it.

Why: If Workers Cache is on, Cloudflare answers from its cache before our worker runs. Those requests skip Protect completely, and one cached page can be served to every visitor, bots included. Source: https://developers.cloudflare.com/workers/cache/ ("Cloudflare checks the cache before running your Worker").

Tests: Docs only, no code. Checked that the warning shows on both pages.

Issue: https://github.com/prosopo/captcha-private/issues/5295

@goastler goastler self-assigned this Oct 16, 2026
@netlify

netlify Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for peaceful-pothos-9e62ce ready!

Name Link
🔨 Latest commit 3b2264a
🔍 Latest deploy log https://app.netlify.com/projects/peaceful-pothos-9e62ce/deploys/6ad75b7f3a99fecce0728c01
😎 Deploy Preview https://deploy-preview-114--peaceful-pothos-9e62ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

With Workers Cache on, Cloudflare serves cached responses before the
worker runs, so those requests never reach Protect.
@forgetso
forgetso force-pushed the docs-warn-workers-cache branch from a7a9551 to 3b2264a Compare October 20, 2026 12:15
@forgetso

Copy link
Copy Markdown
Member

Rebased onto current main for you — it conflicted with #116/#118, which renumbered the install steps (1d. Verify is 1e now and Part 2 runs 2a–2c). The caution still lands in 1c. Deploy the worker, right after the route block, which reads well.

astro build passes and both the caution and the troubleshooting entry render.

Left as a draft since it's yours to mark ready — this is a real gap worth landing, and a security-relevant one: a cached response served before the worker runs means those requests never reach Protect at all. Happy to mark it ready and let auto-merge take it if you'd rather I just did.

@forgetso
forgetso marked this pull request as ready for review October 20, 2026 13:53
@forgetso
forgetso merged commit f5e6e36 into main Oct 20, 2026
8 checks passed
@forgetso
forgetso deleted the docs-warn-workers-cache branch October 20, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants