Repository navigation
Cloudflare Worker: drop the "why the worker doesn't add the script" section - #120
Merged
Merged
Conversation
…ection Reverts the section added in #119. It explained an absence, which is not something a customer following an install guide needs: they need to know to add the script, which the install step tells them. Nothing linked to its anchor, so it comes out cleanly. astro build passes, 417 pages. The heading and its id are gone from the rendered page and every cloudflare-worker# anchor used anywhere in the site still resolves. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for peaceful-pothos-9e62ce ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the section added in #119, which I shouldn't have added.
It explained an absence — why the worker doesn't edit your HTML. A customer following an install guide doesn't need that; they need to know to add the script, which
2a. Add the Protect script to your pagesalready tells them. Same category as the "earlier releases hadSITE_KEY" asides removed in #118, and I missed that when porting it.The paragraph above it still says the client-side part is two
<script>tags you add to your pages, so nothing load-bearing is lost.Test coverage
astro buildpasses, 417 pages. The heading and itsidare gone from the rendered page, and everycloudflare-worker#…anchor used by any page in the site still resolves — nothing linked to the removed section's anchor, which is why it comes out cleanly.🤖 Generated with Claude Code