feat: add SupportContactContextRequested filter - #390
Merged
Conversation
This was referenced Sep 3, 2026
Open
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 8, 2026 12:37
407df09 to
7e96a3c
Compare
brobro10000
changed the title
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 8, 2026 14:01
7e96a3c to
19dc1e8
Compare
pwnage101
reviewed
Sep 8, 2026
pwnage101
reviewed
Sep 8, 2026
pwnage101
reviewed
Sep 8, 2026
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 8, 2026 16:38
19dc1e8 to
353279b
Compare
brobro10000
added a commit
to brobro10000/openedx-filters
that referenced
this pull request
Sep 8, 2026
ENT-11574 Adds a filter that lets pipeline steps inject enterprise enrollment data into the support enrollment lookup view. run_filter returns a tuple of all its inputs (enrollment_data, user), matching the convention used by every other filter in this module (per pwnage101's review feedback on the sibling SupportContactContextRequested filter in PR openedx#390). Includes unit tests.
pwnage101
reviewed
Sep 8, 2026
pwnage101
approved these changes
Sep 8, 2026
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 9, 2026 16:07
353279b to
e158b17
Compare
brobro10000
marked this pull request as ready for review
September 9, 2026 16:27
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Adds a filter that lets pipeline steps enrich the support-contact tags list. run_filter returns a tuple of all its inputs (tags, user), matching the convention used by every other filter in this module — pipeline steps that need the current request can pull it from crum themselves rather than having it threaded through the filter signature. Includes unit tests. ENT-11574
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 9, 2026 16:35
e158b17 to
84cf8c7
Compare
brobro10000
added a commit
to brobro10000/openedx-filters
that referenced
this pull request
Sep 9, 2026
Adds a filter that lets pipeline steps inject enterprise enrollment data into the support enrollment lookup view. run_filter returns a tuple of all its inputs (enrollment_data, user), matching the convention used by every other filter in this module (per pwnage101's review feedback on the sibling SupportContactContextRequested filter in PR openedx#390). Includes unit tests. ENT-11574
brobro10000
added a commit
to brobro10000/openedx-filters
that referenced
this pull request
Sep 9, 2026
Adds a filter that lets pipeline steps inject enterprise enrollment data into the support enrollment lookup view. run_filter returns a tuple of all its inputs (enrollment_data, user), matching the convention used by every other filter in this module (per pwnage101's review feedback on the sibling SupportContactContextRequested filter in PR openedx#390). Includes unit tests. ENT-11574
brobro10000
added a commit
to brobro10000/openedx-filters
that referenced
this pull request
Sep 10, 2026
Adds a filter that lets pipeline steps inject enterprise enrollment data into the support enrollment lookup view. run_filter returns a tuple of all its inputs (enrollment_data, user), matching the convention used by every other filter in this module (per pwnage101's review feedback on the sibling SupportContactContextRequested filter in PR openedx#390). Includes unit tests. ENT-11574
brobro10000
added a commit
to brobro10000/openedx-filters
that referenced
this pull request
Sep 10, 2026
Adds a filter that lets pipeline steps inject enterprise enrollment data into the support enrollment lookup view. run_filter returns a tuple of all its inputs (enrollment_data, user), matching the convention used by every other filter in this module (per pwnage101's review feedback on the sibling SupportContactContextRequested filter in PR openedx#390). Includes unit tests. ENT-11574
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENT-11574
Adds a filter that lets pipeline steps enrich the support-contact tags list:
SupportContactContextRequested(org.openedx.learning.support.contact.context.requested.v1).Related PRs
Testing
New: unit tests for the filter class in
openedx_filters/learning/tests/test_filters.py,matching the existing per-filter-class test pattern (asserts
run_filterinvokes the pipelineand returns the expected value).
Locally verified:
pytest openedx_filters/learning/tests/test_filters.py— 75 passed, 99% linecoverage on
filters.py.mypyclean.isort --check-onlyclean.Changelog / version
Bumped
__version__to3.10.0and added aCHANGELOG.rstentry, matching current practice(see #391). Note: #391 is also unmerged and claims 3.10.0 — whichever of us merges second will
need a quick rebase to the next version slot; that's expected/normal, not a blocker.