feat: replace enterprise support contact-tag import with filter call - #39076
Open
brobro10000 wants to merge 1 commit into
Open
feat: replace enterprise support contact-tag import with filter call#39076brobro10000 wants to merge 1 commit into
brobro10000 wants to merge 1 commit into
Conversation
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 8, 2026 12:37
415814a to
66e2c12
Compare
brobro10000
changed the title
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
6 times, most recently
from
September 9, 2026 19:29
bd3abe7 to
2b95d3a
Compare
brobro10000
marked this pull request as ready for review
September 9, 2026 19:31
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 10, 2026 16:15
2b95d3a to
c080547
Compare
Swaps the direct openedx.features.enterprise_support import in the support contact-us view for a call to the SupportContactContextRequested openedx-filter. Per pwnage101's review feedback, the filter call is made after context['tags'] = tags and operates on the whole page context dict rather than a bare tags list, since it's the context (not just the tags) that's conceptually being requested; the unused user argument is dropped entirely since pipeline steps that need it fetch it via crum internally. No settings changes here: OPEN_EDX_FILTERS_CONFIG registration for the pipeline step lives in edx-enterprise's own plugin_settings() (enterprise/settings/common.py), per the ENT-11830 ownership handoff. The test now mocks the filter call at the view layer; the enterprise-specific pipeline step behavior is covered by edx-enterprise's own test suite. Also bumps openedx-filters (3.10.0 -> 3.11.0, carrying the context-shape change above) and edx-enterprise (8.10.0 -> 8.11.0, carrying the matching SupportContactEnterpriseTagStep update) in pyproject.toml's uv_constraints and uv.lock / the compiled requirements files, now that both releases are published on PyPI. Verified locally against the real released packages (not just the mocked unit test) that SupportContactContextRequested.run_filter accepts and returns a bare context dict as expected. ENT-11574
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 10, 2026 18:54
c080547 to
50bd935
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENT-11574
Swaps the direct
openedx.features.enterprise_supportimport in the support contact-us viewfor a call to the
SupportContactContextRequestedopenedx-filter. No settings changes inthis PR:
OPEN_EDX_FILTERS_CONFIGregistration for the pipeline step lives entirely inedx-enterprise's own
plugin_settings()(enterprise/settings/common.py), per theENT-11830ownership handoff — already merged in this repo (#38634) well before this branch existed.
(An earlier version of this PR incorrectly re-added
OPEN_EDX_FILTERS_CONFIGtolms/envs/common.py/production.py; that's been reverted.)lms/djangoapps/support/views/enrollments.pyis untouched — this PR is scoped to thecontact-tag filter only.
Update: filter shape corrected per review feedback
Per pwnage101's review feedback
on the sibling edx-platform PR, the filter's original shape was wrong — it claimed to request
the whole page "context" but only ever passed/returned a bare
tagslist.SupportContactContextRequested.run_filternow accepts/returns the entirecontextdict (thecall is made after
context['tags'] = tags), and the unuseduserargument was droppedentirely (pipeline steps fetch it via
cruminternally, matching the convention used elsewhere).Since the original shape (#390 / #2688 below) had already merged and released, this required new
PRs in openedx-filters and edx-enterprise rather than amendments — both are now merged and
released (3.11.0 / 8.11.0), and this PR's call site and requirements pins are updated to match,
verified locally against the real released packages.
Related PRs
user): fix: change SupportContactContextRequested to accept/return full context openedx-filters#394Merge order (per the enterprise plugin ticket runbook)
This PR merges LAST, only after:
confirmed working.
Do not merge before that sequence completes.
CI note
Previously CI here was expected to be red until openedx-filters/edx-enterprise released — that
dependency chain has since resolved. Both packages are now released (openedx-filters 3.11.0,
edx-enterprise 8.11.0, carrying the shape-fix above) and this PR's requirements pins are bumped
to match. CI is green.
Testing
New:
ContactUsViewTestsinlms/djangoapps/support/tests/test_views.pymocksSupportContactContextRequested.run_filterat the call site — the pipeline-step behavioritself is covered by edx-enterprise's own test suite.
Local devstack integration testing (with the openedx-filters, edx-enterprise, and edx-platform
branches checked out together) is required before any of these PRs merge — see the handoff
prompt below for exact steps.