fix: change SupportContactContextRequested to accept/return full context - #394
Merged
pwnage101 merged 1 commit intoSep 10, 2026
Merged
Conversation
Per pwnage101's review feedback on edx-platform PR #455, the filter's original shape was wrong: it claimed to request "context" but only ever passed/returned a bare tags list, and accepted a user argument that no pipeline step actually needs (it's available via crum internally, matching the convention used elsewhere). run_filter now takes a single context dict and returns the (possibly modified) context dict directly, with no tuple — matching the existing single-input/output pattern used by filters like StudentRegistrationRequested. Callers are expected to call this after populating context['tags'], not before, so pipeline steps can read and modify the tags in place via context['tags']. ENT-11574
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
pwnage101
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses pwnage101's review feedback on the sibling edx-platform PR #455:
SupportContactContextRequested's original shape was wrong. It claimed to request the support-contact "context" but only ever passed/returned a baretagslist, and accepted auserargument that no pipeline step actually needs (it's available viacruminternally, matching the convention used elsewhere in this codebase).run_filternow takes a singlecontext: dictand returns the (possibly modified) context dict directly — no tuple, matching the existing single-input/output pattern already used by filters likeStudentRegistrationRequested.Callers are expected to call this after populating
context['tags'], so pipeline steps can read/modify the tags viacontext['tags']in place.Since the original shape (#390) already merged and released as 3.10.0, this is a new PR rather than an amendment.
Companion PRs
ENT-11574