Skip to content

rust: Port null audio-monitoring backend to obs-audio-monitoring #5269

Closed

Description

@zackees

Characterization prerequisite: #5262, delivered by PR #5268. Wait for that PR to merge before starting this Rust swap.

Phase 6 prerequisite: #5262 characterizes the already isolated libobs/audio-monitoring/null/null-audio-monitoring.c.h, selected through group libobs/build/libobs.null-audio+.h.c. Wait until its characterization PR merges before starting the swap.

Replace the whole null backend with safe Rust in obs-audio-monitoring, preserving its exact six-function behavior and canonical symbol ownership. Linux/FreeBSD select the fallback only when ENABLE_PULSEAUDIO is OFF; Windows/macOS and PulseAudio-on builds define the same canonical names elsewhere. The Cargo-native Linux selector independently selects the group. Use backend-gated ABI definitions or uniquely named hidden Rust functions behind selected thin native forwarders. Keep platform selection at the platform/FFI boundary; never unconditionally export the fallback names from the always-linked Rust archive.

Port all C characterization assertions 1:1 to Tier 1; add Tier 3 differential tests using the original C oracle and a mutation check. Keep the existing C characterization unchanged. Its two public calls exercise the selected real C-reference/hybrid libobs; its renamed whole-source assertions cover all six C functions, including four hidden functions, and therefore need equivalent coverage linked to the Rust implementation in the swap. Preserve false availability, zero callbacks (including NULL), NULL creation, no-op reset/destroy, false matching for all pointers/byte strings, unchanged caller storage, ownership, log and allocation balance.

Validate selected fallback OFF/ON Linux Tier 2, symbol parity, every configured *_rust target, full native_build module, Windows and Darwin links proving no duplicate canonical symbols in other backends, and lint. No public header, existing C test or OBS WebSocket changes.

Activity

  1. added
    portPort a C unit to Rust (four-tier policy)
    readyMeets the definition of Ready; claimable
    P2Normal priority
    on Nov 19, 2026
  2. rdoupe commented on Nov 19, 2026

    @rdoupe
    Collaborator

    Claiming: null audio-monitoring backend Rust swap (#5269); the characterization (#5268) is on master.

    Plan: RED Tier 1 cases mirroring every assertion of the characterization in the existing obs-audio-monitoring test binary, then the safe core and a backend-gated FFI (the null fallback symbols exported only where the null group is selected), Tier 3 differential against the C oracle with a mutation check, unchanged Tier 2 on hybrid and C reference, symbol parity.

  3. rdoupe commented on Nov 19, 2026

    @rdoupe
    Collaborator

    Done by #5278 (merged as 717ea6c): the null audio-monitoring backend is safe Rust in obs-audio-monitoring, with Tier 1, Tier 3 differential and Tier 2 coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Normal priorityportPort a C unit to Rust (four-tier policy)readyMeets the definition of Ready; claimablesize:SHours

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions