Repository navigation
libobs: characterize and extract output encoder-demand/start predicates (Refs #5229) - #5232
Merged
Merged
Conversation
…5229) Ci-Attestation: {"at":1795089311,"gate":"data/all/compatibility","host":"linux-x86_64","key":"","lane":"client-checks","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":133,"stamp":"ec89e81ab761050c121400be6f9897c9","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089311,"gate":"data/all/flatpak-manifest","host":"linux-x86_64","key":"","lane":"client-checks","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":133,"stamp":"fdf2e504cee55aaa9289bcc409a5c40c","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089311,"gate":"data/all/qt-xml","host":"linux-x86_64","key":"","lane":"client-checks","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":133,"stamp":"4577ac7d883ec346a286280c5e48f51e","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089311,"gate":"data/all/services-schema","host":"linux-x86_64","key":"","lane":"client-checks","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":133,"stamp":"439879a17669ff38d4ceb6bc8a05e9d9","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089175,"gate":"general/all/client-lint","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"b2e3ab68a786d9dece6f5d697771f4ce","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089311,"gate":"python/all/self-test","host":"linux-x86_64","key":"","lane":"client-checks","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":133,"stamp":"1359a733082c07c2b98980765eabf92c","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089176,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"b4f7af564c5ad0c27db19ac3c85d40d4","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089176,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"017e8078db3018f2cd4f578300cbd7e2","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089176,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"c3943d4ef82c94ebe7be1c14cce0e156","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089176,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"207c1ca14bdec3706ac79d9449154b11","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089175,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"0b392207415f743c149a2d409bf7aa00","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089175,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"2a00acdd0fd895c9eabdcf12fcb3ed79","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089176,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"806ea82c92fe52826709319a5e6b9c5a","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089176,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"7657dfbd92f6679a3fcc78dbe1c579c7","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089175,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"fb0011220e32172d7edb6c55bfa6efe7","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089175,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"bb25b4dce39f0baaf82c69d30fd77421","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089175,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"9c5271380d5d8047ca33d3080f27e5f1","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795089175,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"d2ea0b6cad108788b7aca20db141423e2fd0a4b42c7a2821453d197456c34f9b","lane":"client-lint","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":150,"stamp":"e106e34872e53cbc624274ffa90cef2e","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Ci-Attestation: {"at":1795090027,"gate":"rust/x86_64-unknown-linux-gnu/client-test","host":"linux-x86_64","key":"8db27221917c322b41b11e6ad36abac0979aaa21d08d1088a514bf32a76ff8f8","lane":"client-test-x86_64-unknown-linux-gnu","parents":["a5cefc983d178b2a01ebe71196a2d9d78250c8b1"],"secs":714,"stamp":"4a78384ddbbaedea3d890a17459c4856","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d","v":1,"via":"run"} Client-Checks: {"checks":{"base":"7ff57244c874a81d1812a3d57d5253ee7d8c5e1d","coverage":"all-tracked-applicable-files","diff":["libobs/build/libobs.core+.h.c","libobs/build/libobs.core-output+.h.c","libobs/build/libobs.ported-type-catalog-enum+.h.c","libobs/build/ported-source-sets/type-catalog-enum.json","libobs/cmake/rust-exports.d/obs-core-type_catalog_enum.txt","libobs/obs-output-starting-queries.c.h","libobs/obs-output.c.h","libobs/obs-type-catalog-enum-fields.c.h","rust/README.md","rust/obs-build/tests/native.rs","rust/obs-build/tests/native/registration/canonical_type_catalog_enum_swap_is_registered.rs","rust/obs-c-oracle/oracle/type_catalog_enum.c","rust/obs-core/src/ffi/mod.rs","rust/obs-core/src/ffi/type_catalog_enum.rs","rust/obs-core/src/lib.rs","rust/obs-core/src/type_catalog_enum.rs","rust/obs-core/tests/obs_core/main.rs","rust/obs-core/tests/obs_core/type_catalog_enum.rs","rust/obs-core/tests/obs_core/type_catalog_enum_parity.rs","test/cmocka/build/test-graph.json","test/cmocka/test_output_starting_queries.c","test/cmocka/tests.d/test_output_starting_queries.cmake","test/cmocka/video-info-query-link-support.c"],"head":"d859b4b9317999200f3e7dac8b4c15a6cc7bcfcf","tools":{"orchestrator-python":"3.13.15 (main, Aug 14 2026, 15:34:59) [Clang 22.1.3 ]","schema-dependencies":"3.13.15 (main, Aug 14 2026, 15:34:59) [Clang 22.1.3 ]\n{'jsonschema': '4.26.0', 'json_source_map': '1.0.5'}","uv":"uv 0.13.5 (x86_64-unknown-linux-gnu)","xmllint":"xmllint: using libxml version 21504\n compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 DTDValid HTML C14N Catalog XPath XPointer XInclude Iconv ISO8859X Regexps Automata RelaxNG Schemas Modules Debug"},"tracked-digest":"d5309cdc3a2119c58bdee7379ab1e525f4012660e6d4560b0fb2fc6a53f0d52d","tree":"514fd2b9caeb134aefb6b0fbbc903936bc6a797d"}}
zackees
enabled auto-merge
November 19, 2026 12:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #5229
Add a deterministic C-source characterization for the private obs_output_needs_encoders and obs_output_starting predicates using the real output layout. It covers all 16 flag states, exact atomic-load addresses/order, short-circuit skips, exclusion of active from starting, unrelated true flags, and unchanged output storage. The fixture needs no OBS startup, hardware, platform defaults or own threads. Its OUTPUT_STARTING_QUERIES_EXTERNAL option lets a later swap link the predicates and real atomic recorder separately with unchanged assertions; both default and separately linked modes passed against both libraries. Existing failed-start, encoder-bind and video-reset C tests stay unchanged and exercise the library callers.
Extract both original bodies and comments verbatim into libobs/obs-output-starting-queries.c.h in the sorted core-output unity group. Exact same-group static-inline declarations preserve the existing C atomic helpers. Needs-encoders still reads active, starting, reconnecting and delay-active only until true; starting still omits active. Both symbols remain hidden, with their original live non-NULL owner precondition. Add the tests.d pointer and sorted canonical graph registration; no Rust, public-header, existing-C-test, WebSocket or workflow changes.
Original-C baseline characterization passed against both C-reference and hybrid libobs, with every configured standalone Rust fixture built and identical 1,769-symbol exports. RED a5cefc9 requires the extracted unit missing from that committed tree; the local incomplete extraction also failed native compilation for undeclared helpers and duplicate definitions. GREEN supplies the byte-identical unit, removes the original definitions and provides the helper declarations. All 12 build-group/module/graph-sort checks and the whole native_build:: module pass (318 tests, zero failures/ignored, 46.27 seconds of test execution).
After extraction, Linux Tier 2 built the new target plus EVERY one of the 64 configured *_rust targets with keep-going enabled. The new fixture and unchanged failed-start/bind/video-reset tests each passed three repetitions in both library modes. Export parity remains 1,769 symbols; neither private predicate appears in the dynamic exports.
The single-agent clud-review found no issues. Forced fetched PR-head footprint and merge-tree checks cover the output group, obs-output.c.h and canonical graph, including #5226. Actual queued overlaps combine cleanly; DIRTY, unqueued conflicts do not block this unit. Temporary refs were deleted. A separate obs-output Rust-swap issue will require lazy safe-core mirrors, unchanged C assertions, original-C differential/mutation coverage, hidden ABI symbols and real atomic adapters linked into every standalone Rust-static consumer.
Native Windows/macOS execution and hosted PR/merge-group results are not claimed. This is a C-only prerequisite; new Rust Tier 1/Tier 3 implementation tests belong to its later swap, and network Tier 4 does not apply.
ci/windows_link_check.py passed: all eight Windows MSVC Rust test-category binaries linked, followed by hybrid libobs and all 55 configured Rust fixtures on Windows MSVC x86_64 and Darwin arm64 (266.61 and 285.40 seconds for the native fixture legs). The new non-Rust C characterization was explicitly compiled and linked on both cross targets as well. These are link checks, not native Windows/macOS runtime claims.
The single full SOLDR_PORCELAIN=0 ./lint run passed in 147.9 seconds, including formatting, repository validators/self-tests and configured analysis. Unchanged Rust inputs reused soldr passing verdicts where reported. No source files changed after these checks.
The ./push client proof also passed six-target Clippy/Dylint (149.9 seconds), repository validators/self-tests, all 9,170 host tests with six additional skips, all 920 feature-set tests, documentation checks and Windows GNU workspace linking (client-test 714.5 seconds). Optional Swift proof was unavailable because swift-format is absent; no Swift files changed. Published signed head: eefff9c, with GitHub verification valid and the validated tree/parents preserved.