You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: Extract and characterize output encoder-demand/start predicates before Rust swap #5229
C-only prerequisite for Phase 6 output encoder-demand/start queries, later targeting obs-output.
Characterize obs_output_needs_encoders and obs_output_starting from libobs/obs-output.c.h (currently lines 1959–1971), then extract their bodies verbatim into libobs/obs-output-starting-queries.c.h in the existing sorted libobs/build/libobs.core-output+.h.c unity group. Preserve the C-owned atomic loads and their exact short-circuit order: active, starting, reconnecting, delay-active for needs-encoders; starting, reconnecting, delay-active for starting. Do not eagerly snapshot fields. Both symbols remain internal/hidden, with unchanged non-NULL owner preconditions.
Acceptance: add a portable C-source recorder characterization using real private layouts, covering all 16 flag combinations, skipped loads, exact load addresses/order and unchanged storage. Add its tests.d pointer and sorted canonical test-graph entry, keeping all native/CMake/source-set inventories consistent. Characterize original C first, then commit extraction-contract RED and behavior-neutral GREEN. Run the whole native_build:: module, focused Linux Tier 2 new and unchanged encoder failed-start/bind/reset tests against C-reference/hybrid with symbol parity, EVERY configured *_rust target, ci/windows_link_check.py (and separate Darwin link gate if Windows fails), explicit links of the new C fixture on both cross targets, and ./lint once.
No Rust, existing-C-test or public-header edits, no WebSocket changes or new workflows. Refresh forced fetched PR heads and merge-tree overlaps for the O group, output implementation and canonical graph; serialize actual queued conflicts. Follow merged #5207 and #5215. File the separate Rust-swap follow-up after publication.
Decisions: ready / P2 / port / size:S; no functional dependency. This prerequisite changes no behavior.
Claiming: output encoder-demand/start prerequisite in pool slot fix5159. 1. Characterize original C with all flag states and an ordered atomic-load recorder. 2. Commit extraction RED then verbatim C-only GREEN with sorted graph/unity registration. 3. Run native_build, Linux Tier 2 including every *_rust target, Windows/Darwin links and lint; screen queued conflicts and publish under backpressure. First PR expected this session; branch test/5229-output-starting-queries.
Activity
zackees commentedon Nov 19, 2026
Claiming: output encoder-demand/start prerequisite in pool slot fix5159. 1. Characterize original C with all flag states and an ordered atomic-load recorder. 2. Commit extraction RED then verbatim C-only GREEN with sorted graph/unity registration. 3. Run native_build, Linux Tier 2 including every *_rust target, Windows/Darwin links and lint; screen queued conflicts and publish under backpressure. First PR expected this session; branch test/5229-output-starting-queries.
zackees commentedon Nov 19, 2026
Landed on master in #5232 (2471a31): the output encoder-demand/start predicates are extracted and characterized. The Rust swap is #5233.