Skip to content

ci: pre-queue Windows and Darwin cmocka Rust links (Refs #5189) - #5195

Merged
zackees merged 6 commits into
masterfrom
fix/5189-cmocka-cross-link
Nov 19, 2026
Merged

zackees merged 6 commits into
masterfrom
fix/5189-cmocka-cross-link

Conversation

@zackees

@zackees zackees commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

PRs touching libobs, linked Rust crates, obs-build registration/support, or cmocka now link the Windows MSVC x86_64 and Darwin arm64 Tier 2 Rust fixtures before entering the merge queue, including fully attested member PRs. The existing Linux-hosted Windows Link Check keeps its eight category links and adds both CMake passes when LANES["cmocka_link"] selects them. Its existing heavy-pool route and 30-minute deadline remain in use.

The checker uses soldr's LLVM and target SDKs, builds real cmocka and hybrid libobs, and discovers executable targets through CMake's file API after the unchanged registrations, host guards and deferred support hooks run. Windows uses clang-cl so CMake evaluates MSVC guards correctly. Darwin uses production's hidden-symbol list, target-only library discovery and the Rust crate's existing framework imports. Every run refreshes the Rust archive before configuring. The independent PR gate requires selected cmocka execution even when older category/client proofs are complete.

RED: commit 9cda73789 adds the missing selection/discovery tests. The old selector also fails the new selection cases. Replaying the final checker over pinned #5155 head f47e0ddbc1bc051ef198646dfd3ae712e9ab81c9, with only checker files overlaid, fails twelve fixtures, including the graphics FFmpeg WIC/PQ fixtures: LLD reports duplicate error_data_add definitions in libobs_rust.lib and obs.lib(obs.dll). This is the same static-versus-import-library collision class as merge-group run 44444101724's MSVC LNK2005 errors; the first symbol differs between the Linux/Windows compiler builds. Separate real COFF probes reject undefined gs_image_max_texture_size and an import/static bmalloc collision, establishing the LNK2019/LNK2005 failure classes.

GREEN: both platforms link 54 Rust cmocka executables plus hybrid libobs on master, and all eight original Windows Rust category binaries link. PE/Mach-O headers confirm the intended target architectures and executable/shared-library types. Selection, discovery, dispatch, allocation and missing/skipped-execution self-tests pass; the single pre-push reviewer reports clean. Full SOLDR_PORCELAIN=0 ./lint passes in 388.0 s. Publication through ./push passes complete client lint (all six Clippy/Dylint targets), CI self-tests/data validators, 9,118 workspace tests with six skips, 920 feature tests, applicable doctests and all eight Windows GNU category links. The final signed head verifies.

Target Fresh CMake/Corrosion tree Warm tree
Windows MSVC x86_64 367.80 s 82.49 s
Darwin arm64 418.54 s 73.69 s

Measured on the shared Linux worker with four Ninja jobs. SDKs, prebuilt target dependencies and the Cargo registry were installed already; first-host downloads are excluded. The eight category binaries took 128.53 s with partial Cargo reuse. These are local timings, not a hosted critical-path guarantee.

These checks link target programs without running them. They do not prove runtime recording/allocator behavior or every archive-order binding problem where a link succeeds. #5155 remains on hold. Existing runtime test tiers continue to run under the repository's policy; this CI change adds no Rust test executables and changes no C tests or public headers.

Refs #5189

Ci-Attestation: {"at":1795062846,"gate":"data/all/compatibility","host":"linux-x86_64","key":"","lane":"client-checks","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":378,"stamp":"e6b25681a5ad01c31a538ca3e121a805","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062846,"gate":"data/all/flatpak-manifest","host":"linux-x86_64","key":"","lane":"client-checks","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":378,"stamp":"71e4853c4b0d22c4447df280a1ee5394","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062846,"gate":"data/all/qt-xml","host":"linux-x86_64","key":"","lane":"client-checks","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":378,"stamp":"b3c219a0b163d30157aa5b0561637823","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062846,"gate":"data/all/services-schema","host":"linux-x86_64","key":"","lane":"client-checks","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":378,"stamp":"aaa854bffbe74cf41f0fd27ae284207b","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062465,"gate":"general/all/client-lint","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"94f48c99c8a60f210d0a21a8071c448e","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062846,"gate":"python/all/self-test","host":"linux-x86_64","key":"","lane":"client-checks","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":378,"stamp":"8daa7a9e30e399cc2b76101246f9b109","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062466,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"3c6a47c9f84169df817277499c24ac9a","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062466,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"99031f75737a420b48a6831b2c63d2a3","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062466,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"302398de82685207827a16c80ae0c091","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062466,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"7377411353ff510012a8c3378fe4dd67","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062466,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"62495e689e0ea7e6fbca43740c3bb4d7","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062466,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"a80d1e3b90fbe5cffbf328adbfe78397","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062466,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"5dbc085e9142152f1c15b5671588526c","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062466,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"f5cd10a8523eb05430c47f8f5d7f8761","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062466,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"b6500fa762f946ed85e3990b4aa87ec3","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062466,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"5a1d1be5d5ad3318200825ed2809bf65","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062465,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"17ff3d710254d08dd894e55011d7a032","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795062466,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"f7cf01941a84bda180285306e56177474c61a1bc89295c4aabc803a51ebdba53","lane":"client-lint","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":27,"stamp":"eaef7a48bdfc947d11a945aa0bc91215","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}
Ci-Attestation: {"at":1795063251,"gate":"rust/x86_64-unknown-linux-gnu/client-test","host":"linux-x86_64","key":"cfeba7b1f14bc5281f6bf121ec845576291d49f3918fba8dd3cd8e9d2d47e0b4","lane":"client-test-x86_64-unknown-linux-gnu","parents":["28fea60187c6d9531533242533151dd4da9417f8"],"secs":404,"stamp":"81cec057199fcbd0a7d197202b84429d","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933","v":1,"via":"run"}

Client-Checks: {"checks":{"base":"ccda70968d7c93b7fec351111f641e70873bfdc9","coverage":"all-tracked-applicable-files","diff":[".github/workflows/build-project.yaml","CMakeLists.txt","ci/ci_scope.py","ci/cmocka_link_check.py","ci/gate_jobs.py","ci/test_ci_scope.py","ci/test_cmocka_link_check.py","ci/test_gate_jobs.py","ci/test_pr_attestation.py","ci/test_windows_link_check.py","ci/windows_link_check.py","cmake/cross/CMakeLists.txt","cmake/cross/cmocka/CMockaConfig.cmake","cmake/cross/cmocka/CMockaConfigVersion.cmake","cmake/cross/tier2.cmake","docs/ci-tooling.md"],"head":"d1ffcfdb78877a24ca18dc76aafde27919cfc740","tools":{"orchestrator-python":"3.13.15 (main, Aug 14 2026, 15:34:59) [Clang 22.1.3 ]","schema-dependencies":"3.13.15 (main, Aug 14 2026, 15:34:59) [Clang 22.1.3 ]\n{'jsonschema': '4.26.0', 'json_source_map': '1.0.5'}","uv":"uv 0.13.5 (x86_64-unknown-linux-gnu)","xmllint":"xmllint: using libxml version 21504\n   compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 DTDValid HTML C14N Catalog XPath XPointer XInclude Iconv ISO8859X Regexps Automata RelaxNG Schemas Modules Debug"},"tracked-digest":"dd448f1211b23a18ffde32b3f2333cec15bfcf13ef0cdf1d98ce8a99388ba787","tree":"25fab3752a5649078d47eb54d8e9b1b7e359b933"}}
@zackees zackees added the pool-active Pool worker owns this PR; automated rebases must skip it label Nov 19, 2026
@zackees zackees changed the title docs: record cold and warm pre-queue link costs ci: pre-queue Windows and Darwin cmocka Rust links (Refs #5189) Nov 19, 2026
@zackees zackees removed the pool-active Pool worker owns this PR; automated rebases must skip it label Nov 19, 2026
@zackees
zackees enabled auto-merge November 19, 2026 04:42
@zackees zackees added pool-active Pool worker owns this PR; automated rebases must skip it and removed pool-active Pool worker owns this PR; automated rebases must skip it labels Nov 19, 2026
@zackees
zackees added this pull request to the merge queue Nov 19, 2026
Merged via the queue into master with commit df7b884 Nov 19, 2026
44 checks passed
@zackees
zackees deleted the fix/5189-cmocka-cross-link branch November 19, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant