Skip to content

ci: pre-queue link check for the Tier 2 cmocka *_rust targets on Windows and macOS #5189

Closed

Description

@zackees

Refs #5145. PR CI runs Tier 2 only on Linux for libobs changes, plus ci/windows_link_check.py, which links the eight Rust category test executables but not the Tier 2 cmocka *_rust targets. Linkage changes to libobs_rust's static support (new C adapters, private host imports, allocator objects) are therefore only exercised on Windows and macOS inside the merge queue, where one failure ejects every grouped PR.

#5155 shows the cost: four failed merge-group runs, 44423636668, 44427880156, 44436994657 and 44444101724.

  • Windows: LNK2019 gs_image_max_texture_size, __imp_timeBeginPeriod/timeEndPeriod, then LNK2005 duplicate bmalloc/brealloc/bfree/cf_pass_pair between libobs_rust.lib and obs.lib.
  • macOS: archive-order-dependent test failures.
  • Linux: *_rust link failures.

Proposal: extend the Linux-hosted MSVC link check, using the soldr clang-cl/lld-link toolchain that already links the Rust executables, to configure and link (not run) the Tier 2 cmocka *_rust targets for x86_64-pc-windows-msvc. Add the equivalent Linux-hosted Darwin cross-link (soldr's Apple SDK, as the macOS run-only producer already uses), and run both in PR CI whenever libobs, rust/libobs-rust or the registration/support files change. A link-only check needs no Windows or macOS runner.

Activity

  1. added
    readyMeets the definition of Ready; claimable
    ciContinuous integration
    on Nov 19, 2026
  2. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Claiming: Tier 2 cross-link coverage in pool slot obs-studio6. 1. Extend the existing Linux-hosted MSVC lane to link the real hybrid libobs and cmocka Rust fixtures. 2. Reproduce #5155 and validate master; investigate the Darwin equivalent. 3. Add RED/GREEN CI self-tests, run lint, publish subject to backpressure. First PR expected this session.

  3. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Landed on master in #5195 (df7b884). The Linux-hosted Windows link lane now also links all 54 host-selected *_rust cmocka targets for Windows MSVC and Darwin arm64. Replayed over #5155's head, it fails the same real COFF links that ejected that PR's queue groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ciContinuous integrationreadyMeets the definition of Ready; claimable

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions