Skip to content

ci: Windows Link Check grew from 269 s to 1234 s after #5195 and is now the merge-group critical path #5224

Closed

Description

@zackees

#5195 (Refs #5189) added a Tier 2 pass that links every *_rust cmocka target for Windows MSVC and then for Darwin arm64, inside the existing "Windows Link Check 🔗 (x86_64-pc-windows-msvc)" job. The pass runs serially after the Rust category links. That job is now the longest in the merge group.

Run Runner Windows Link Check job
44461970565 (before #5195) hosted 269 s
44463439467 (before #5195) Dell 947 s
44495240642 (after) hosted 1234 s, the run's critical path (run 21.9 min)
44500429449 (after) Dell 1021 s
44501805583 (after) Dell about 960 s

On hosted runners the job grew 4.6 times and now sets the merge-group wall time. It also runs on every non-docs PR.

Proposed:

  1. Run the Windows MSVC pass and the Darwin arm64 pass as two parallel jobs (a matrix over the alias). Keep both in the CI Gate ✅ dependency set, so neither weakens the check that caught graphics: port legacy image-file data orchestration to Rust (Refs #5145) #5155 and obs-core: swap core video-info query to safe Rust (Refs #5179) #5190.
  2. Inside each pass, check that the cmocka targets link in parallel at the job's real CPU budget, not serially.
  3. Check whether the hybrid libobs configure/build is shared or duplicated between the Rust-category and cmocka phases, and between the two aliases. Reuse it if it's duplicated.
  4. Separately, the Dell takes 947-1021 s against 269 s hosted for the same job even before ci: pre-queue Windows and Darwin cmocka Rust links (Refs #5189) #5195. Find out why (CPU contention with concurrent jobs, or a cache that isn't warm on the self-hosted path).

Acceptance: the job's (or jobs') critical path on hosted is back under about 6 min, with the same set of targets linked, shown on a PR run.

Activity

  1. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Claiming: CI link-check performance work in obs-studio2, as assigned by the maintainer.

    1. Measure hosted run 44495240642 and Dell run 44500429449 by phase and alias.
    2. Make the smallest change that restores concurrency while preserving every target and both required gate passes.
    3. Commit local RED then GREEN coverage, run both real cross-link scripts and lint, and publish subject to backpressure. First PR expected this worker session.
  2. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Landed on master in #5231 (1c936eb): the Tier 2 cmocka cross-link checks now run as a parallel win-x64/mac-arm64 matrix, and both legs stay gate-required. Before it, Link Check took 887 s hosted and 996 s on the Dell. The next E640 check will measure the new timing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ciContinuous integrationreadyMeets the definition of Ready; claimable

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions