Repository navigation
[stable35] fix(viewer): skip duplicate handlers on init - #3457
Merged
skjnldsv merged 2 commits intoOct 21, 2026
Merged
Conversation
The viewer initializes the service, which registers the built-in handlers, and then replays the handlers queued before it loaded. That replay did not check whether a handler was already registered, so built-ins queued by other apps were registered twice and logged "already registered" errors. Skip handlers already in availableHandlers. Viewer.vue already does this when it mounts; this covers the earlier synchronous init path. Assisted-by: opencode:DeepSeek-V4.1-Flash-Free Signed-off-by: Braux Martinez <martinezjb@hitss.com>
Signed-off-by: Braux Martinez <martinezjb@hitss.com>
bulungasdeveloper
changed the title
skjnldsv
approved these changes
Oct 21, 2026
Member
|
/backport to stable34 |
Member
|
/backport to stable33 |
This was referenced Oct 21, 2026
backportbot
Bot
removed
the
backport-request
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The viewer initializes the service, which registers the built-in handlers, and then replays the handlers queued before it loaded. That replay did not check whether a handler was already registered, so built-ins queued by other apps were registered twice and logged
"already registered"errors.Skip handlers that are already in
availableHandlers.Viewer.vuealready does this when it mounts; this change covers the earlier synchronous init path insrc/init.ts.Testing
"already registered"errors in the browser console; images and videos open normally.馃 AI (if applicable)