Repository navigation
[stable33] fix(viewer): skip duplicate handlers on init - #3458
Conversation
The viewer initializes the service, which registers the built-in handlers, and then replays the handlers queued before it loaded. That replay did not check whether a handler was already registered, so built-ins queued by other apps were registered twice and logged "already registered" errors. Skip handlers already in availableHandlers. Viewer.vue already does this when it mounts; this covers the earlier synchronous init path. Assisted-by: opencode:DeepSeek-V4.1-Flash-Free Signed-off-by: Braux Martinez <martinezjb@hitss.com>
Signed-off-by: Braux Martinez <martinezjb@hitss.com>
backportbot
Bot
added
bug
github-actions
Bot
changed the title
Signed-off-by: Braux Martinez <martinezjb@hitss.com>
|
All checks on this PR are green, including Playwright. However, the Could a maintainer align the ruleset with the check name emitted on these |
bulungasdeveloper
left a comment
bulungasdeveloper
left a comment
There was a problem hiding this comment.
All checks on this PR are green, including Playwright. However, the
33 and up ruleset requires the status check playwright-summary, while
the stable33 / stable34 workflows emit playwright-test-summary.
That required check is never reported, so the PR stays blocked even with
an approval.
Could a maintainer align the ruleset with the check name emitted on these
branches, or backport the workflow rename from stable35? Thanks.
|
Re-running the workflow will not help here: Could a maintainer align the ruleset to |
Backport of #3457
Warning, This backport's changes differ from the original and might be incomplete鈿狅笍
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.