Repository navigation
[stable35] fix(viewer): handle public shares on delete - #3460
Open
bulungasdeveloper wants to merge 4 commits into
Open
bulungasdeveloper wants to merge 4 commits into
bulungasdeveloper wants to merge 4 commits into
Conversation
Author
|
Playwright is intentionally disabled on fork PRs, so |
Assisted-by: opencode:opencode Signed-off-by: Braux Martinez <martinezjb@hitss.com>
bulungasdeveloper
force-pushed
the
fix-viewer-public-delete-stable35
branch
from
October 25, 2026 06:37
df69773 to
56282c6
Compare
Add engine-strict=false to allow npm to run on newer Node versions used by GitHub Actions runners. This does not change code. Assisted-by: opencode:opencode Signed-off-by: Braux Martinez <martinezjb@hitss.com>
Build assets in Docker node:24 so CI git status check passes. Assisted-by: opencode:opencode Signed-off-by: Braux Martinez <martinezjb@hitss.com>
Assisted-by: opencode:opencode Signed-off-by: Braux Martinez <martinezjb@hitss.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deleting a file from the viewer in a public link share with delete permission
failed with
Missing mandatory rootin the browser console. The file was notremoved: the exception is thrown while building the temporary
NcFilenode,before the DELETE request is sent.
onDeleteonly treatedremote.php/davURLs as DAV resources. Files openedfrom a public share are served over
public.php/dav(web UI) orpublic.php/webdav(legacy clients), so the node was created withroot: undefined.Recognise
(remote|public).php/(web)?davas DAV endpoints. Public shares nowget
root = getRootPath()(/files/<token>) and the same decoded source thestore uses. Behaviour for authenticated users is unchanged.
Testing
playwright/e2e/sharing/delete-share.spec.ts: publiclink share with delete permission → open image in viewer → Delete → viewer
closes and the file disappears from the list.
npm ci && npm run build(Node 24, Linux): OK. The five generated assets arein a separate
chore(assets)commit because the build workflow checks for aclean tree.
npm run stylelint: 0 errors (11 pre-existing warnings).npx eslint src: 0 errors (24 pre-existing warnings).No unit tests exist in this app; the Playwright suite is the relevant coverage.
Notes
READ | UPDATE | CREATE | DELETEpermissions; the viewer only offers Deletewhen the file carries the
Dpermission.files store; the DELETE request still uses the encoded URL.
stable35.mainno longer ships the app.🤖 AI (if applicable)