Repository navigation
feat(contexts): carry the menu through export and import - #3138
Open
rubenvdlinde wants to merge 2 commits into
Open
rubenvdlinde wants to merge 2 commits into
rubenvdlinde wants to merge 2 commits into
Conversation
3 of 5 tasks
rubenvdlinde
force-pushed
the
feat/noid/app-menu-export-import
branch
from
October 22, 2026 13:25
dca4eb5 to
bc762f6
Compare
This was referenced Oct 22, 2026
rubenvdlinde
force-pushed
the
feat/noid/app-menu-export-import
branch
from
October 23, 2026 08:05
bc762f6 to
04aafd2
Compare
rubenvdlinde
force-pushed
the
feat/noid/app-menu-export-import
branch
from
October 24, 2026 08:09
04aafd2 to
455a391
Compare
rubenvdlinde
force-pushed
the
feat/noid/app-menu-export-import
branch
from
October 26, 2026 08:51
455a391 to
8ac7add
Compare
Menus travel with the application's scheme and with a user's data, with targets referenced by UUID or technical name. TableMapper and ViewMapper findByUuid now return null when nothing matches, as their signatures already said. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ruben van der Linde <ruben@conduction.nl>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ruben van der Linde <ruben@conduction.nl>
rubenvdlinde
force-pushed
the
feat/noid/app-menu-export-import
branch
from
October 26, 2026 09:24
8ac7add to
bfdf4e9
Compare
rubenvdlinde
marked this pull request as ready for review
October 26, 2026 09:26
samin-z
self-requested a review
October 26, 2026 17:03
samin-z
requested changes
Oct 26, 2026
Contributor
There was a problem hiding this comment.
thank you @rubenvdlinde
i tested the pr manually for now, what i found is the API part works fine, the exported file contains 'menuItems' and the import saves them when they are in the body. however the import screen does not send them.
from what i see, ImportContextSchemePreview.vue builds the import body in emitPayload() from the name, icon,description, tables and nodes. 'menuItems' is left out, so the application keeps the menu it already has. the preview response already returns the menu under 'menuItem' and it needs to be included in the import request, otherwise a user of the screen never gets the menu from the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3099, on top of #3137 (menu nesting). A menu now travels with its application when the application's scheme is exported and imported, and when a user's data is moved to another instance.
Size: 868 lines: 390 code, 453 tests and 25 generated OpenAPI.
What changes
item_7included, so nesting survives the round trip.TablesMigrator) carries the menu's links and the items for the moved table and pages. View items are skipped for now, because that import has no mapping from old view ids to new ones.ViewMapper::findByUuidandTableMapper::findByUuidwere already declared to return nothing when the UUID is unknown, but threw an exception instead. They now return null, which the import relies on.How it was tested
On Nextcloud 34 with PostgreSQL:
FindByUuidTest: both mappers return null for an unknown UUIDimportContext()and through a scheme, including a child under an automatically named parentcomposer cs:check, psalm and rector, all clean🖼️ Screenshots
Backend only, no UI changes.
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)