Repository navigation
feat(contexts): give applications a menu - #3135
Open
rubenvdlinde wants to merge 2 commits into
Open
rubenvdlinde wants to merge 2 commits into
rubenvdlinde wants to merge 2 commits into
Conversation
This was referenced Oct 22, 2026
rubenvdlinde
force-pushed
the
feat/noid/app-menu-model
branch
from
October 22, 2026 13:25
9847aa9 to
5825db2
Compare
rubenvdlinde
force-pushed
the
feat/noid/app-menu-model
branch
from
October 23, 2026 08:05
5825db2 to
9e81a78
Compare
rubenvdlinde
force-pushed
the
feat/noid/app-menu-model
branch
from
October 24, 2026 08:09
9e81a78 to
7e236cc
Compare
A menu item has a label, an optional icon and description, and opens a table, a view, a page of the same application or a link. Items have a technical name unique within the application (item_<id> by default) and may sit under another item. An item whose target is gone is read as broken. Applications carry their menu in their responses, loaded for all applications of a response in one query. Deleting an application deletes its menu, and deletes the application row first inside a retried transaction. Co-authored-by: remko48 <remko@conduction.nl> Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ruben van der Linde <ruben@conduction.nl>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ruben van der Linde <ruben@conduction.nl>
rubenvdlinde
force-pushed
the
feat/noid/app-menu-model
branch
from
October 26, 2026 09:24
7e236cc to
c7a6e95
Compare
rubenvdlinde
marked this pull request as ready for review
October 26, 2026 09:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3099, on top of #3133. #3099 gives every application a menu: inside Tables it's what the page bar designs, and when the application is opened on its own, it's the navigation. This pull request adds the menu to the data model and to the application's responses. Saving a menu follows in the next pull request.
This replaces #3086 by @remko48, rebuilt on the page model from #3100. He's co-author of the commits that reuse his code.
Size: 1033 lines: 457 code, 478 tests and 98 generated OpenAPI.
What changes
item_<id>, the same way pages, views and columns get theirs.item_<number>is reserved for those automatic names.How it was tested
On Nextcloud 34 with PostgreSQL:
MenuItemTestandMenuItemMapperTest(database: broken targets, one query for all menus, the unique technical name)ContextServiceTest, including that deleting an application removes the application row firstfindAllContainingNodecompares application ids as numbers and doesn't load menus it doesn't needcomposer cs:check, psalm and rector, all clean🖼️ Screenshots
Backend only, no UI changes.
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)