Skip to content

feat(contexts): nest menu items one level deep - #3137

Open
rubenvdlinde wants to merge 2 commits into
feat/noid/app-menu-savingfrom
feat/noid/app-menu-nesting
Open

rubenvdlinde wants to merge 2 commits into
feat/noid/app-menu-savingfrom
feat/noid/app-menu-nesting

Conversation

@rubenvdlinde

@rubenvdlinde rubenvdlinde commented Oct 22, 2026 •

Copy link
Copy Markdown

Part of #3099, on top of #3136 (menu saving). A menu item can sit under another item, one level deep, for example a few views under the table they belong to. This replaces #3088 by @remko48.

Size: 248 lines: 100 code, 128 tests and 20 generated OpenAPI.

What changes

  • When saving a menu, an item can name its parent by its position in the list (parentIndex). Nesting goes one level deep: a parent can't have a parent of its own.
  • The response gives each item its parentId.

How it was tested

On Nextcloud 34 with PostgreSQL:

🖼️ Screenshots

Backend only, no UI changes.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stableX.X
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

rubenvdlinde and others added 2 commits October 26, 2026 10:24
Co-authored-by: remko48 <remko@conduction.nl>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Ruben van der Linde <ruben@conduction.nl>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Ruben van der Linde <ruben@conduction.nl>
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-nesting branch from 70eda55 to 065c9b9 Compare October 26, 2026 09:24
@rubenvdlinde
rubenvdlinde marked this pull request as ready for review October 26, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants