Repository navigation
Fix Vulkan scene replacement and Wayland swapchain resizing - #255
Merged
Merged
Conversation
maxvdec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a scene from the editor replaces render targets while the preceding Vulkan frame may still be in flight. Wait for the submitted frame before clearing scene resources, preventing the buffer and image destruction errors reproduced during project startup.
Update canonical neutralsoftware/opal to handle application-controlled Vulkan surface extents: Wayland swapchains now resize to the embedded viewport drawable instead of keeping their startup dimensions. Dependency: neutralsoftware/opal#4.
Validation: traced the packaged Linux editor with Vulkan validation enabled; both destruction errors originate in Context::loadScene through render-target destruction. git diff --check passes. No local project build was run. In a controlled packaged-editor test, forcing the existing swapchain rebuild at the actual 1118 x 397 viewport size restored scene output under Wayland. Runtime verification of the final patch awaits the updated CI package.
Related to #238 and #239.