Repository navigation
Resize application-controlled Vulkan swapchains - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wayland reports UINT32_MAX as the surface extent, leaving the swapchain size under application control. The default framebuffer pass skipped its resize check for such surfaces, keeping the startup swapchain dimensions when an embedded viewport changed size.
Use the SDL drawable size, clamped to the surface capabilities, for this case and rebuild the swapchain when it changes. Fixed-extent surfaces retain their existing behavior.
Validation: git diff --check passes; inspected the rebuild path and zero-sized drawable handling. No local build was run. Atlas CI package verification will follow through neutralsoftware/atlas#255.