Repository navigation
Accept custom rsl-rl log writers in the runner config. - #1257
Merged
Merged
Conversation
`RslRlBaseRunnerCfg.logger` only accepted `"wandb"` or `"tensorboard"`, so projects couldn't plug in their own rsl-rl `LogWriter` even though rsl-rl already supports it. This lets `logger` take a writer import path like `my_pkg.writers:MyLogWriter`, which the runner passes to rsl-rl in its dict form (also silencing rsl-rl's deprecation warning for the plain `"wandb"` string). W&B tags are now only applied with the W&B logger.
kevinzakka
reviewed
Nov 1, 2026
kevinzakka
left a comment
kevinzakka
left a comment
Collaborator
There was a problem hiding this comment.
Nice, thanks Louis! Any reason not to type it as Literal["wandb", "tensorboard"] | dict and pass the dict straight to rsl-rl, so custom writers can take kwargs and the built-ins keep CLI validation?
kevinzakka
approved these changes
Nov 1, 2026
kevinzakka
left a comment
kevinzakka
left a comment
Collaborator
There was a problem hiding this comment.
Never mind, a dict union breaks tyro's CLI parsing.
Collaborator
Author
|
Thanks! Appreciate it :) |
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RslRlBaseRunnerCfg.loggeronly accepted"wandb"or"tensorboard", so projects couldn't plug in their own rsl-rlLogWritereven though rsl-rl already supports it. This letsloggertake a writer import path likemy_pkg.writers:MyLogWriter, which the runner passes to rsl-rl in its dict form (also silencing rsl-rl's deprecation warning for the plain"wandb"string). W&B tags are now only applied with the W&B logger.