Skip to content

feat(web-transport-moq)!: implement web-transport-trait 0.5 - #13

Merged
kixelated merged 5 commits into
mainfrom
chore/web-transport-trait-0.5
Sep 27, 2026
Merged

kixelated merged 5 commits into
mainfrom
chore/web-transport-trait-0.5

Conversation

@kixelated

@kixelated kixelated commented Sep 26, 2026 •

Copy link
Copy Markdown

Moves web-transport-moq onto web-transport-trait 0.5, whose SendStream::set_priority takes an i32 (moq-dev/web-transport#390). The impl now passes the order straight to noq's i32 scheduler. Cargo.lock now pins web-transport-trait 0.5.0 from crates.io.

Also stops re-exporting web_transport_trait as generic: callers depend on web-transport-trait directly, so its version is theirs to pick. moq does not use the re-export.

Public API: breaking (trait 0.5, generic removed). Only moq consumes moq-noq*, so this ships as 1.3.2 per the maintainer.

Wire: none. Upstream: none, web-transport-moq is fork-only.

(Written by Opus 5.5)

🤖 Generated with Claude Code

The trait's set_priority takes the i32 send order directly, matching
noq's own scheduler, so the u8 widening goes away.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…neric

Callers depend on web-transport-trait directly, so the trait version is
theirs to pick rather than tied to this crate's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review September 27, 2026 23:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-27T23:36:05.040724Z 7c3ca24 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d42b0148-5ee5-42de-9d13-18e0d0aa8c61

📥 Commits

Reviewing files that changed from the base of the PR and between c7b5665 and 7c3ca24.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • web-transport-moq/Cargo.toml
  • web-transport-moq/src/lib.rs
  • web-transport-moq/src/send.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Author

Merging. Updated onto main after #11 and #12, locked web-transport-trait 0.5.0 from crates.io, and marked ready. CI green; Codex found nothing.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit c5583a1 into main Sep 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant