feat(web-transport-moq)!: implement web-transport-trait 0.5 - #13
Conversation
The trait's set_priority takes the i32 send order directly, matching noq's own scheduler, so the u8 widening goes away. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…neric Callers depend on web-transport-trait directly, so the trait version is theirs to pick rather than tied to this crate's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedNext included review available in 45 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Moves
web-transport-moqontoweb-transport-trait0.5, whoseSendStream::set_prioritytakes ani32(moq-dev/web-transport#390). The impl now passes the order straight to noq'si32scheduler.Cargo.locknow pinsweb-transport-trait0.5.0 from crates.io.Also stops re-exporting
web_transport_traitasgeneric: callers depend onweb-transport-traitdirectly, so its version is theirs to pick. moq does not use the re-export.Public API: breaking (trait 0.5,
genericremoved). Only moq consumesmoq-noq*, so this ships as 1.3.2 per the maintainer.Wire: none. Upstream: none,
web-transport-moqis fork-only.(Written by Opus 5.5)
🤖 Generated with Claude Code