chore: release 1.3.2 - #14
Conversation
|
Warning Review limit reachedNext included review available in 24 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdd00c7c4c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| [workspace.package] | ||
| version = "1.3.1" | ||
| version = "1.3.2" |
There was a problem hiding this comment.
Do not publish the breaking API change as 1.3.2
When an existing consumer specifies web-transport-moq = "1.3.1", Cargo may automatically select this release, yet the accompanying changelog explicitly says that web_transport_moq::generic was removed and the implemented trait was replaced with the incompatible 0.5 version. Such consumers can therefore stop compiling after an ordinary dependency resolution despite requesting a semver-compatible update; preserve the 1.x API or publish this as a major version.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed, and the plan changed. Published moq-tokio 0.19.19 and moq-uring 0.0.9 depend on web-transport-moq ^1.3 with web-transport-trait 0.4, so shipping #13 as 1.3.2 would break them. Final plan:
- 1.3.2 ships only fix(web-transport-moq): report a raw QUIC peer's close code #11 and fix(proto): make BBR respond to classic ECN #12 from
release/1.3(branched before feat(web-transport-moq)!: implement web-transport-trait 0.5 #13), via chore: release 1.3.2 #15, taggedv1.3.2there. - feat(web-transport-moq)!: implement web-transport-trait 0.5 #13's trait 0.5 move ships from main as 2.0.0 via chore!: release 2.0.0 #16, tagged
v2.0.0. This PR's 1.3.2 version on main is superseded by that bump.
(Written by Claude Opus 5.5)
|
Merging. Version bump and changelog only; CI and the publish dry run pass. The Codex semver note is answered inline (maintainer decision). Tagging (Written by Claude Opus 5.5) |
Bumps
workspace.package.versionand the internal path-dep pins (moq-noqonmoq-noq-proto/moq-noq-udp,web-transport-moqonmoq-noq) to 1.3.2, and adds the 1.3.2 entry toCHANGELOG-MOQ.md.Ships #11 (raw QUIC close code), #12 (BBR classic ECN), and #13 (web-transport-trait 0.5,
genericre-export removed). Taggingv1.3.2on the merge publishes all four crates.Public API:
web-transport-moqmoves to web-transport-trait 0.5 and dropsgeneric(from #13). Wire: none. Parent unchanged.cargo publish --workspace --locked --dry-runpasses locally.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code