chore!: bump web-transport-trait to 0.5 and its implementors - #401
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3caf347fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tokio = { version = "1", features = ["sync"] } | ||
| url = "2" | ||
| web-transport-quinn = { path = "../web-transport-quinn", version = "0.12" } | ||
| web-transport-quinn = { path = "../web-transport-quinn", version = "0.13" } |
There was a problem hiding this comment.
When this reaches main, .github/workflows/release-js.yml will build new native modules because rs/web-transport-node/** changed, but js/web-transport/scripts/release.ts exits before publishing when the main npm version is already published. Since js/web-transport/package.json and its platform manifests remain at 0.1.4, the newly built 0.13-based binaries will be discarded and npm users will remain on the old native code; bump the main and platform npm versions and their optional-dependency pins together with this dependency change.
AGENTS.md reference: AGENTS.md:L40-L42
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed. The native module has picked up fixes since 0.1.4 shipped in July, so without a bump release-js would rebuild and then drop the binaries. I bumped @moq/web-transport, its five platform packages, and the optional-dependency pins to 0.1.5. As in #320, the platform lockfile entries are removed until 0.1.5 is on npm.
(Written by Opus 5.5)
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Caution Review failedAn error occurred during the review process. Please try again later. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughThe workspace dependency requirements for Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The Rust dependency and crate versions align, and the JavaScript wrapper and platform package versions are consistent. No actionable merge-blocking risk was identified in these release metadata changes. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 3 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
#390 changed SendStream::set_priority from u8 to i32 without bumping the trait. Bump it to 0.5.0 and give every crate whose public API implements or re-exports it a breaking bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The node crate changed, so release-js rebuilds the native modules on merge, but it skips publishing when the npm version is already released. Bump the main and platform packages so the new binaries ship. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5872de3 to
49873d9
Compare
|
Merge summary:
#363 needs regenerating after this lands. (Written by Opus 5.5) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49873d9cbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| license = "MIT OR Apache-2.0" | ||
|
|
||
| version = "0.4.0" | ||
| version = "0.5.0" |
There was a problem hiding this comment.
When 0.5.0 is published, rs/web-transport-trait/CHANGELOG.md will still jump from an empty Unreleased section to 0.4.0, so users have no release note explaining that SendStream::set_priority changed from u8 to i32; the corresponding implementor changelogs likewise omit their newly assigned versions. Add release entries for these version bumps and the breaking migration before publishing them.
AGENTS.md reference: AGENTS.md:L52-L53
Useful? React with 👍 / 👎.
1 participant
#390 changed
SendStream::set_priority(both the async andpolltraits) fromu8toi32but leftweb-transport-traitat 0.4.0, so it can't be released as is. The open release-plz PR (#363) proposes 0.4.1. This bumps the trait to 0.5.0 and gives a breaking bump to every crate whose public API implements or re-exports it:set_prioritysignatureweb_transport_quinntypesweb-transport-protois unchanged. Internal dependency requirements and the qmux README follow.cargo check --workspace --all-targetspasses.Downstream: moq-dev/noq#13 moves
web-transport-moqto trait 0.5. moq-dev/moq#4262 moves moq to it (ondev, since moq-net re-exports the trait).#363 will need regenerating after this merges.
(Written by Opus 5.5)
🤖 Generated with Claude Code