Skip to content

fix(net): backport FETCH requester FIN semantics - #5230

Merged
kixelated merged 2 commits into
releasefrom
quest/m1/release-backports/fetch-fin
Oct 11, 2026
Merged

kixelated merged 2 commits into
releasefrom
quest/m1/release-backports/fetch-fin

Conversation

@kixelated

@kixelated kixelated commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Release's FETCH serving paths still treat a clean requester FIN as cancellation on draft 19, discarding standalone and joining fetch responses. Reuse the existing version-aware request-stream cancellation helper while waiting for a joining subscription and while buffering its response: pre-19 FIN still cancels; modern FIN only ends requester updates; resets and response STOP_SENDING still cancel.

Validation: the release draft-19 regression fails before the fix. The final matrix covers standalone/joining requests, FIN/reset, and every draft whose FETCH this release serves; it passes. Scoped just check passes.

Public API: none. Wire: existing draft cancellation semantics, no framing or version change. No package version bump or release. Main quest cleanup is tracked in #5231.

Combined release validation: a private tree applying all six implementation commits passes 1,469 moq-net library tests (four existing ignored tests), 252 JS decoder/publisher tests, and just test interop --all across Rust, Python, Go, JS/browser/native Node/native Bun, C, and GStreamer. The interop harness negotiates Lite; the IETF behavior is covered by the version-specific regressions.

(Written by GPT-6)

kixelated and others added 2 commits October 10, 2026 09:24
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 10, 2026 22:40
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T22:43:05.794929Z a1cfe89 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Approved to merge a1cfe89cc37da422179554062c3bc9489d728131 into release with a merge commit. CI is green, Codex gave a thumbs up, and no review threads remain.

This backports the existing FETCH requester FIN semantics: modern drafts continue serving after clean FIN while resets and response cancellation still cancel. Public API and wire framing are unchanged. Existing focused and combined-release validation covers the behavior. No additional changes or unresolved decisions.

(Written by GPT-6)

@kixelated
kixelated merged commit 1454c7b into release Oct 11, 2026
7 checks passed
@kixelated
kixelated deleted the quest/m1/release-backports/fetch-fin branch October 11, 2026 01:17
@moq-bot moq-bot Bot mentioned this pull request Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant