Repository navigation
chore: release - #4944
chore: release#4944moq-bot[bot] wants to merge 1 commit into
Conversation
|
Automated review of #4944 (release-plz), head This is the same follow-up-PR pattern as #4867's first head. The PR doesn't actually bump anything. All 9 version bumps listed in the body (moq-tokio 0.19.23, moq-relay 0.17.2, moq-stats 0.2.12, and the rest) already landed on Blocking
Non-blocking
Verdict: ITERATE. Drop the duplicate changelog section or close this PR. Separately, reorder This is an automated review, not the maintainer's decision |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 7a54baf
[P2] Remove the duplicate release entry before landing. rs/moq-tokio/CHANGELOG.md:20–24 adds a second 0.19.23 section, repeating the existing heading/fix at lines 10–14. This PR has no crate-version changes: its actual diff is a transitive Cargo.lock refresh plus the duplicated changelog, although the body advertises nine new releases. Regenerate after publishing the existing release, or retain only the intended dependency update with an accurate description.
This independently confirms the existing finding in #4944 (comment); no duplicate inline thread added. Direction: a dependency refresh can stand alone, but this should not be treated as a fresh nine-crate release.
Verification: inspected both changed files, the pinned moq-tokio manifest/changelog, release recipe and prior discussion. No build or publishing command run. Exact-head Check, Test and the returned platform checks passed; those checks do not resolve the duplicated release metadata.
34f1b62 to
0d1e051
Compare
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 0d1e051
No new actionable findings in the 52-file release delta.
Fixed since the previous review: rs/moq-tokio/CHANGELOG.md:10–20 now contains a genuine 0.19.24 entry and a single 0.19.23 entry. The advertised 25 crate-version bumps agree with the manifest changes, applicable workspace dependency versions, Cargo.lock entries and changelog headings.
Direction: this is now a coherent patch-release update. I separated changes already on the release branch from this PR's metadata/dependency changes; the PR itself introduces no source/API/wire-format edits. The previously discussed release-pr-before-release ordering in rs/justfile:262–265 remains unchanged and outside this diff.
Verification: inspected every changed-file patch, pinned workspace manifest/lockfile, the complete moq-tokio changelog, release recipe and prior reviews. No build, runtime test or publishing command run; registry availability was not independently checked. At the final state check, Android and WASM passed, Check was queued, and Swift/OBS/Platform were running. Require completed current CI before landing.
d739912 to
a5b1604
Compare
9905f9b to
9597646
Compare
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 9597646
No new actionable findings in the cumulative release delta since 0d1e051.
Cargo.lock:9495–9498 now updates uuid 1.27.0 → 1.28.0, within the unchanged Cargo.toml:233 requirement; the remaining lockfile patch is unchanged. All 25 advertised crate bumps still agree across manifest patches, applicable workspace dependencies, lock entries and changelog headings. The duplicate moq-tokio release entry remains fixed.
Direction: coherent patch-release metadata. Accounting for intervening release-branch changes, this PR introduces no source/API/wire-format edits; the expanded changelogs describe the refreshed base.
Verification: compared all 52 release-file patches with the last reviewed commit and checked pinned workspace metadata, the uuid lock entry, moq-tokio changelog and prior reviews. No build, runtime or publishing commands run; registry availability/checksums were not independently verified. Current-head CI remains queued/running; require completed checks before landing.
0af5f61 to
9905e42
Compare
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 9905e42
No new actionable findings in the release metadata/dependency delta.
Since the last review at 9597646, Cargo.lock adds cc 1.6.0 → 1.7.0 (lines 1017–1020), smallvec 1.16.2 → 1.16.3 (8053–8056), and syn 3.0.6 → 3.0.7 (8487–8490). All version-qualified syn references were updated consistently. The 25 advertised crate bumps still agree across manifests, applicable workspace dependencies, lock entries and changelog headings.
Direction: coherent patch-release metadata. I separated changes already on the refreshed release base from this PR; its own 52-file delta contains no source/API/wire-format edits.
Verification: compared every release-file patch against the previous review and inspected the pinned workspace manifest and complete lockfile. No build/runtime/publishing commands run; upstream dependency behavior, registry availability and checksums were not independently verified. Current-head CI remains pending; require completed checks before landing.
9905e42 to
ee7094d
Compare
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: ee7094d
No new actionable findings in this release refresh.
Since review 5477239479, Cargo.lock:4538–4594 and 9850–9853 update moq-noq, moq-noq-proto, moq-noq-udp and web-transport-moq together from 1.3.4 to 1.3.5. The unchanged workspace requirements allow these patch versions; the fork's dependency references remain consistent and separate from upstream noq. All 25 advertised crate bumps still match their manifests, workspace references, lock entries and changelog headings.
Direction: coherent patch-release metadata. Fifty of 52 file patches are identical to the previous review; the other change is a moq-net changelog entry for a fix already on the refreshed release base. The PR itself adds no source/API/wire-format edits.
Verification: compared all release patches, inspected the complete pinned lockfile and workspace/moq-tokio/moq-uring manifests. No build/runtime/publishing commands run; upstream dependency behavior, registry availability and checksums were not independently verified. Current-head CI is queued/running; require completed checks before landing.
ef1565c to
ce76937
Compare
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: ce76937
No new actionable findings in the release refresh.
Since ee7094d, Cargo.lock:7779–7782 updates serde_json 1.0.151 → 1.0.152, within Cargo.toml:213's unchanged requirement. Every other lockfile package block is identical. All 25 crate bumps still match their manifest patches, applicable workspace references, lock entries and changelog headings; the duplicate moq-tokio release entry remains fixed.
Direction: coherent patch-release metadata. Accounting for the refreshed release base, this PR's 52-file diff contains no source/API/wire-format edits. The remaining changes refresh generated changelogs.
Verification: compared both release commits' file patches and complete lockfiles, and inspected pinned workspace metadata and the moq-tokio changelog. No build/runtime/publishing commands run; upstream dependency behavior, registry availability and checksums were not independently verified. Current-head CI is running; require completed checks before landing.
(Written by OpenAI)
ce76937 to
674290e
Compare
674290e to
ffe536a
Compare
🤖 New release
moq-net: 0.3.10 -> 0.3.11 (✓ API compatible changes)hang: 0.21.11 -> 0.21.12 (✓ API compatible changes)moq-mux: 0.10.11 -> 0.10.12 (✓ API compatible changes)moq-tokio: 0.19.23 -> 0.19.24 (✓ API compatible changes)moq-uring: 0.0.12 -> 0.0.13 (✓ API compatible changes)moq-boy: 0.5.12 -> 0.5.13moq-hls: 0.5.11 -> 0.5.12 (✓ API compatible changes)moq-relay: 0.17.2 -> 0.17.3 (✓ API compatible changes)moq-rtmp: 0.3.11 -> 0.3.12 (✓ API compatible changes)moq-transcode: 0.1.10 -> 0.1.11 (✓ API compatible changes)moq-cli: 0.14.2 -> 0.14.3moq-gst: 0.4.12 -> 0.4.13 (✓ API compatible changes)moq-json: 0.5.8 -> 0.5.9moq-binary: 0.1.10 -> 0.1.11moq-loc: 0.2.19 -> 0.2.20moq-audio: 0.1.10 -> 0.1.11moq-video: 0.1.10 -> 0.1.11libmoq: 0.6.12 -> 0.6.13moq-archive: 0.0.11 -> 0.0.12moq-stats: 0.2.12 -> 0.2.13moq-rtc: 0.3.12 -> 0.3.13moq-srt: 0.3.11 -> 0.3.12moq-e2ee: 0.0.11 -> 0.0.12moq-ffi: 0.4.12 -> 0.4.13moq-room: 0.2.11 -> 0.2.12Changelog
moq-nethangmoq-muxmoq-tokiomoq-uringmoq-boymoq-hlsmoq-relaymoq-rtmpmoq-transcodemoq-climoq-gstmoq-jsonmoq-binarymoq-locmoq-audiomoq-videolibmoqmoq-archivemoq-statsmoq-rtcmoq-srtmoq-e2eemoq-ffimoq-roomThis PR was generated with release-plz.