Skip to content

fix(net): backport quiet catalog floor clearing - #5228

Merged
kixelated merged 2 commits into
releasefrom
quest/m1/release-backports/catalog-floor
Oct 11, 2026
Merged

kixelated merged 2 commits into
releasefrom
quest/m1/release-backports/catalog-floor

Conversation

@kixelated

@kixelated kixelated commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

A finished catalog below a relay's resume floor stays unread after SUBSCRIBE_UPDATE clears that floor. Preserve the old requested floor before replacing subscription preferences, then lower the local cursor to zero only when Lite-06+ removes a nonzero floor. An already-unfloored cursor keeps its progress and never replays served groups.

The release model already supports downward start_at, so this ports only the missing publisher behavior from #4940. The release fixture explicitly resolves the source start to isolate this bug from the separate handshake gate.

Validation: the final release regression fails with the original update method and passes with this fix; both cleared-floor/no-replay tests and the full Lite serving suite pass with paused test time.

Public API: none. Wire: existing SUBSCRIBE_UPDATE semantics, no framing or version change. No package version bump or release. Main quest cleanup is tracked in #5231.

Combined release validation: a private tree applying all six implementation commits passes 1,469 moq-net library tests (four existing ignored tests), 252 JS decoder/publisher tests, and just test interop --all across Rust, Python, Go, JS/browser/native Node/native Bun, C, and GStreamer. The interop harness negotiates Lite; the IETF behavior is covered by the version-specific regressions.

(Written by GPT-6)

kixelated and others added 2 commits October 10, 2026 09:37
Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 10, 2026 22:40
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T22:43:00.196600Z a465298 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Approved to merge a465298033c2657f323a3583619b462f37ce6052 into release with a merge commit. CI is green, Codex gave a thumbs up, and no review threads remain.

This backports quiet catalog delivery when Lite-06+ clears a nonzero resume floor, preserving cursor progress when no floor was set. Public API and wire framing are unchanged. Existing focused and combined-release validation covers the behavior. No additional changes or unresolved decisions.

(Written by GPT-6)

@kixelated
kixelated merged commit 2068612 into release Oct 11, 2026
7 checks passed
@kixelated
kixelated deleted the quest/m1/release-backports/catalog-floor branch October 11, 2026 01:18
@moq-bot moq-bot Bot mentioned this pull request Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant