Repository navigation
Respect criteria and inheritance in search results - #57
Merged
Merged
Conversation
dblock
force-pushed
the
dblock/criteria-search
branch
from
October 17, 2026 02:52
5cab20b to
a97217c
Compare
Danger ReportNo issues found. |
dblock
force-pushed
the
dblock/criteria-search
branch
from
October 17, 2026 02:56
a97217c to
2369874
Compare
This was referenced Oct 17, 2026
Closed
Closed
Closed
Adapt the SCI and criteria proposal from @tomasc in mongoid#37; preserve shared-index searches and apply limits after excluding missing/scoped-out documents. Co-authored-by: Tomas Celizna <tomas.celizna@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
dblock/criteria-search
branch
from
October 17, 2026 03:26
2369874 to
275211a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt @tomasc’s SCI/criteria proposal from #37 to current master, with contributor credit. Respect subclass scope, skip missing/scoped-out documents without changing global Mongoid settings, and apply max_results after filtering. Preserve cross-model shared-index behavior for unscoped calls and relevance/scores. Add regressions for filtered top results, descendants, stale references with raise_not_found_error=true, and shared indexes.
Fixes #12. Supersedes #37. Depends on #51.
Prepared by an AI on behalf of @dblock.