Repository navigation
Conversation
Closed
This reverts commit b172e64.
dblock
added a commit
to dblock/mongoid_fulltext
that referenced
this pull request
Oct 17, 2026
Adapt the localized-fields proposal from @tomasc in mongoid#38. Keep locale suffixes stable, evaluate readers and filters within each locale, and update creation/removal/reindexing consistently. Co-authored-by: Tomas Celizna <tomas.celizna@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
added a commit
to dblock/mongoid_fulltext
that referenced
this pull request
Oct 17, 2026
Adapt the localized-fields proposal from @tomasc in mongoid#38. Keep locale suffixes stable, evaluate readers and filters within each locale, and update creation/removal/reindexing consistently. Co-authored-by: Tomas Celizna <tomas.celizna@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
AI posting on behalf of @dblock: adapted the localized-field proposal into #58, separately from the inherited criteria changes now in #57. @tomasc is credited in the changelog, PR description, and commit coauthor. The replacement keeps locale suffixes stable even with one configured locale, only localizes indexes that explicitly include a localized field, evaluates computed readers/filters/update_if in locale context, restores the caller locale on failures, and continues after empty translations. It also covers index creation/removal/rebuilding and includes migration instructions. Its full Mongoid 3–9 matrix is green: https://github.com/dblock/mongoid_fulltext/actions/runs/38996889008. Closing this older PR in favor of #58; thank you for the original implementation. |
dblock
added a commit
to dblock/mongoid_fulltext
that referenced
this pull request
Oct 17, 2026
Adapt the localized-fields proposal from @tomasc in mongoid#38. Keep locale suffixes stable, evaluate readers and filters within each locale, and update creation/removal/reindexing consistently. Co-authored-by: Tomas Celizna <tomas.celizna@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
added a commit
to dblock/mongoid_fulltext
that referenced
this pull request
Oct 17, 2026
Adapt the localized-fields proposal from @tomasc in mongoid#38. Keep locale suffixes stable, evaluate readers and filters within each locale, and update creation/removal/reindexing consistently. Co-authored-by: Tomas Celizna <tomas.celizna@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
added a commit
to dblock/mongoid_fulltext
that referenced
this pull request
Oct 17, 2026
Adapt the localized-fields proposal from @tomasc in mongoid#38. Keep locale suffixes stable, evaluate readers and filters within each locale, and update creation/removal/reindexing consistently. Co-authored-by: Tomas Celizna <tomas.celizna@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
added a commit
to dblock/mongoid_fulltext
that referenced
this pull request
Oct 17, 2026
Adapt the localized-fields proposal from @tomasc in mongoid#38. Keep locale suffixes stable, evaluate readers and filters within each locale, and update creation/removal/reindexing consistently. Co-authored-by: Tomas Celizna <tomas.celizna@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
added a commit
that referenced
this pull request
Oct 17, 2026
Adapt the localized-fields proposal from @tomasc in #38. Keep locale suffixes stable, evaluate readers and filters within each locale, and update creation/removal/reindexing consistently. Co-authored-by: Tomas Celizna <tomas.celizna@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here a PR with support for localized fields.
Basically, if there are multiple locales, and the document has any localized fields, an index is created per each locale, and then used when searching.
Built upon #37 , will rebase once merged.