Repository navigation
Support localized fields with locale-tagged ngrams - #58
Merged
Merged
Conversation
dblock
force-pushed
the
dblock/localized-fields
branch
from
October 17, 2026 02:54
ce6f51b to
7e0eb44
Compare
Danger ReportNo issues found. |
dblock
force-pushed
the
dblock/localized-fields
branch
from
October 17, 2026 02:56
7e0eb44 to
7e8e984
Compare
This was referenced Oct 17, 2026
Closed
Closed
dblock
force-pushed
the
dblock/localized-fields
branch
2 times, most recently
from
October 17, 2026 03:08
b8cf74c to
c896115
Compare
dblock
changed the title
dblock
force-pushed
the
dblock/localized-fields
branch
from
October 17, 2026 03:12
c896115 to
a4bff2a
Compare
Adapt the localized-fields proposal from @tomasc in mongoid#38. Keep locale suffixes stable, evaluate readers and filters within each locale, and update creation/removal/reindexing consistently. Co-authored-by: Tomas Celizna <tomas.celizna@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
dblock/localized-fields
branch
from
October 17, 2026 03:23
a4bff2a to
da7e085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt @tomasc’s localized-field proposal from #38, with contributor credit, using one original index collection rather than locale-suffixed collections. Each localized ngram record stores a string locale field; searches filter by I18n.locale and the compound search index begins with locale, ngram, score. Nonlocalized records retain their existing shape.
Evaluate readers, computed methods, filters, and update_if within each configured locale. Replace records per document/locale; remove and destroy across all locales, including locales no longer configured. Cover storage shape, locale isolation and scores, compound-index upgrades, replacement, empty translations, filters, conditions, and locale restoration. UPGRADING.md documents clearing old untagged records and rebuilding. Bump to 0.9.0.
Fixes #33. Supersedes #38. #52 should also land for older-driver empty-collection index creation. Criteria support is separate in #57.
Prepared by an AI on behalf of @dblock.